AccessTokenTrait - Code Metrics - Inspection of "Merge branch 'V5-WIP'" - thephpleague/oauth2-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1de13c...bf55ce )

by Alex

created 2016-04-17 12:22 UTC

AccessTokenTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	1
c	1
b	0
f	1
lcom	0
cbo	4
dl	0
loc	23
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	convertToJWT()	0	13	1

<?php
/**
 * @author      Alex Bilbie <[email protected]>
 * @copyright   Copyright (c) Alex Bilbie
 * @license     http://mit-license.org/
 *
 * @link        https://github.com/thephpleague/oauth2-server
 */

namespace League\OAuth2\Server\Entities\Traits;

use Lcobucci\JWT\Builder;
use Lcobucci\JWT\Signer\Key;
use Lcobucci\JWT\Signer\Rsa\Sha256;
use League\OAuth2\Server\CryptKey;

trait AccessTokenTrait
{
    /**
     * Generate a JWT from the access token
     *
     * @param \League\OAuth2\Server\CryptKey $privateKey
     *
     * @return string
     */
    public function convertToJWT(CryptKey $privateKey)
    {
        return (new Builder())
            ->setAudience($this->getClient()->getIdentifier())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setId($this->getIdentifier(), true)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setIssuedAt(time())
            ->setNotBefore(time())
            ->setExpiration($this->getExpiryDateTime()->getTimestamp())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setSubject($this->getUserIdentifier())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->set('scopes', $this->getScopes())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->sign(new Sha256(), new Key($privateKey->getKeyPath(), $privateKey->getPassPhrase()))
            ->getToken();
    }
}


1			<?php
2			/**
3			* @author Alex Bilbie <[email protected]>
4			* @copyright Copyright (c) Alex Bilbie
5			* @license http://mit-license.org/
6			*
7			* @link https://github.com/thephpleague/oauth2-server
8			*/
9
10			namespace League\OAuth2\Server\Entities\Traits;
11
12			use Lcobucci\JWT\Builder;
13			use Lcobucci\JWT\Signer\Key;
14			use Lcobucci\JWT\Signer\Rsa\Sha256;
15			use League\OAuth2\Server\CryptKey;
16
17			trait AccessTokenTrait
18			{
19			/**
20			* Generate a JWT from the access token
21			*
22			* @param \League\OAuth2\Server\CryptKey $privateKey
23			*
24			* @return string
25			*/
26			public function convertToJWT(CryptKey $privateKey)
27			{
28			return (new Builder())
29			->setAudience($this->getClient()->getIdentifier())
			0 ignored issues – show Bug introduced 2016-04-17 12:55 UTC by Report Bug Copy Issue Report It seems like `getClient()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30			->setId($this->getIdentifier(), true)
			0 ignored issues – show Bug introduced 2016-04-17 12:55 UTC by Report Bug Copy Issue Report It seems like `getIdentifier()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			->setIssuedAt(time())
32			->setNotBefore(time())
33			->setExpiration($this->getExpiryDateTime()->getTimestamp())
			0 ignored issues – show Bug introduced 2016-04-17 12:55 UTC by Report Bug Copy Issue Report It seems like `getExpiryDateTime()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			->setSubject($this->getUserIdentifier())
			0 ignored issues – show Bug introduced 2016-04-17 12:55 UTC by Report Bug Copy Issue Report It seems like `getUserIdentifier()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35			->set('scopes', $this->getScopes())
			0 ignored issues – show Bug introduced 2016-04-17 12:55 UTC by Report Bug Copy Issue Report It seems like `getScopes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36			->sign(new Sha256(), new Key($privateKey->getKeyPath(), $privateKey->getPassPhrase()))
37			->getToken();
38			}
39			}
40

thephpleague / oauth2-server

Push — master ( 1de13c...bf55ce )

AccessTokenTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like