Completed
Push — master ( e24964...6723aa )
by
unknown
02:17
created

AuthCodeGrant::enableCodeExchangeProof()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 3
CRAP Score 1

Importance

Changes 0
Metric Value
c 0
b 0
f 0
dl 0
loc 4
ccs 3
cts 3
cp 1
rs 10
cc 1
eloc 2
nc 1
nop 0
crap 1
1
<?php
2
/**
3
 * @author      Alex Bilbie <[email protected]>
4
 * @copyright   Copyright (c) Alex Bilbie
5
 * @license     http://mit-license.org/
6
 *
7
 * @link        https://github.com/thephpleague/oauth2-server
8
 */
9
10
namespace League\OAuth2\Server\Grant;
11
12
use League\OAuth2\Server\Entities\ClientEntityInterface;
13
use League\OAuth2\Server\Entities\ScopeEntityInterface;
14
use League\OAuth2\Server\Entities\UserEntityInterface;
15
use League\OAuth2\Server\Exception\OAuthServerException;
16
use League\OAuth2\Server\Repositories\AuthCodeRepositoryInterface;
17
use League\OAuth2\Server\Repositories\RefreshTokenRepositoryInterface;
18
use League\OAuth2\Server\RequestEvent;
19
use League\OAuth2\Server\RequestTypes\AuthorizationRequest;
20
use League\OAuth2\Server\ResponseTypes\RedirectResponse;
21
use League\OAuth2\Server\ResponseTypes\ResponseTypeInterface;
22
use Psr\Http\Message\ServerRequestInterface;
23
24
class AuthCodeGrant extends AbstractAuthorizeGrant
25
{
26
    /**
27
     * @var \DateInterval
28
     */
29
    private $authCodeTTL;
30
31
    /**
32
     * @var bool
33
     */
34
    private $enableCodeExchangeProof = false;
35
36
    /**
37
     * @param AuthCodeRepositoryInterface     $authCodeRepository
38
     * @param RefreshTokenRepositoryInterface $refreshTokenRepository
39
     * @param \DateInterval                   $authCodeTTL
40
     */
41 41
    public function __construct(
42
        AuthCodeRepositoryInterface $authCodeRepository,
43
        RefreshTokenRepositoryInterface $refreshTokenRepository,
44
        \DateInterval $authCodeTTL
45
    ) {
46 41
        $this->setAuthCodeRepository($authCodeRepository);
47 41
        $this->setRefreshTokenRepository($refreshTokenRepository);
48 41
        $this->authCodeTTL = $authCodeTTL;
49 41
        $this->refreshTokenTTL = new \DateInterval('P1M');
50 41
    }
51
52 13
    public function enableCodeExchangeProof()
53
    {
54 13
        $this->enableCodeExchangeProof = true;
55 13
    }
56
57
    /**
58
     * Respond to an access token request.
59
     *
60
     * @param ServerRequestInterface $request
61
     * @param ResponseTypeInterface  $responseType
62
     * @param \DateInterval          $accessTokenTTL
63
     *
64
     * @throws OAuthServerException
65
     *
66
     * @return ResponseTypeInterface
67
     */
68 18
    public function respondToAccessTokenRequest(
69
        ServerRequestInterface $request,
70
        ResponseTypeInterface $responseType,
71
        \DateInterval $accessTokenTTL
72
    ) {
73
        // Validate request
74 18
        $client = $this->validateClient($request);
75 18
        $encryptedAuthCode = $this->getRequestParameter('code', $request, null);
76
77 18
        if ($encryptedAuthCode === null) {
78 1
            throw OAuthServerException::invalidRequest('code');
79
        }
80
81
        // Validate the authorization code
82
        try {
83 17
            $authCodePayload = json_decode($this->decrypt($encryptedAuthCode));
84 16
            if (time() > $authCodePayload->expire_time) {
85 1
                throw OAuthServerException::invalidRequest('code', 'Authorization code has expired');
86
            }
87
88 15
            if ($this->authCodeRepository->isAuthCodeRevoked($authCodePayload->auth_code_id) === true) {
89 1
                throw OAuthServerException::invalidRequest('code', 'Authorization code has been revoked');
90
            }
91
92 14
            if ($authCodePayload->client_id !== $client->getIdentifier()) {
93 1
                throw OAuthServerException::invalidRequest('code', 'Authorization code was not issued to this client');
94
            }
95
96
            // The redirect URI is required in this request
97 13
            $redirectUri = $this->getRequestParameter('redirect_uri', $request, null);
98 13
            if (empty($authCodePayload->redirect_uri) === false && $redirectUri === null) {
99 1
                throw OAuthServerException::invalidRequest('redirect_uri');
100
            }
101
102 12
            if ($authCodePayload->redirect_uri !== $redirectUri) {
103 1
                throw OAuthServerException::invalidRequest('redirect_uri', 'Invalid redirect URI');
104
            }
105
106 11
            $scopes = [];
107 11
            foreach ($authCodePayload->scopes as $scopeId) {
108 11
                $scope = $this->scopeRepository->getScopeEntityByIdentifier($scopeId);
109
110 11
                if ($scope instanceof ScopeEntityInterface === false) {
111
                    // @codeCoverageIgnoreStart
112
                    throw OAuthServerException::invalidScope($scopeId);
113
                    // @codeCoverageIgnoreEnd
114
                }
115
116 11
                $scopes[] = $scope;
117
            }
118
119
            // Finalize the requested scopes
120 11
            $scopes = $this->scopeRepository->finalizeScopes(
121 11
                $scopes,
122 11
                $this->getIdentifier(),
123 11
                $client,
124 11
                $authCodePayload->user_id
125
            );
126 6
        } catch (\LogicException  $e) {
127 1
            throw OAuthServerException::invalidRequest('code', 'Cannot decrypt the authorization code');
128
        }
129
130
        // Validate code challenge
131 11
        if ($this->enableCodeExchangeProof === true) {
132 7
            $codeVerifier = $this->getRequestParameter('code_verifier', $request, null);
133 7
            if ($codeVerifier === null) {
134 1
                throw OAuthServerException::invalidRequest('code_verifier');
135
            }
136
137
            // Validate code_verifier according to RFC-7636
138
            // @see: https://tools.ietf.org/html/rfc7636#section-4.1
139 6
            if (preg_match('/^[A-Za-z0-9-._~]{43,128}$/', $codeVerifier) !== 1) {
140 3
                throw OAuthServerException::invalidRequest(
141 3
                    'code_verifier',
142 3
                    'Code Verifier must follow the specifications of RFC-7636.'
143
                );
144
            }
145
146 3
            switch ($authCodePayload->code_challenge_method) {
147 3
                case 'plain':
148 2
                    if (hash_equals($codeVerifier, $authCodePayload->code_challenge) === false) {
149 1
                        throw OAuthServerException::invalidGrant('Failed to verify `code_verifier`.');
150
                    }
151
152 1
                    break;
153 1
                case 'S256':
154
                    if (
155 1
                        hash_equals(
156 1
                            strtr(rtrim(base64_encode(hash('sha256', $codeVerifier, true)), '='), '+/', '-_'),
157 1
                            $authCodePayload->code_challenge
158 1
                        ) === false
159
                    ) {
160
                        throw OAuthServerException::invalidGrant('Failed to verify `code_verifier`.');
161
                    }
162
                    // @codeCoverageIgnoreStart
163
                    break;
164
                default:
165
                    throw OAuthServerException::serverError(
166
                        sprintf(
167
                            'Unsupported code challenge method `%s`',
168
                            $authCodePayload->code_challenge_method
169
                        )
170
                    );
171
                // @codeCoverageIgnoreEnd
172
            }
173
        }
174
175
        // Issue and persist access + refresh tokens
176 6
        $accessToken = $this->issueAccessToken($accessTokenTTL, $client, $authCodePayload->user_id, $scopes);
177 6
        $refreshToken = $this->issueRefreshToken($accessToken);
178
179
        // Inject tokens into response type
180 4
        $responseType->setAccessToken($accessToken);
0 ignored issues
show
Bug introduced by
It seems like $accessToken defined by $this->issueAccessToken(...load->user_id, $scopes) on line 176 can be null; however, League\OAuth2\Server\Res...rface::setAccessToken() does not accept null, maybe add an additional type check?

Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code:

/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
Loading history...
181 4
        $responseType->setRefreshToken($refreshToken);
0 ignored issues
show
Bug introduced by
It seems like $refreshToken defined by $this->issueRefreshToken($accessToken) on line 177 can be null; however, League\OAuth2\Server\Res...face::setRefreshToken() does not accept null, maybe add an additional type check?

Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code:

/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
Loading history...
182
183
        // Revoke used auth code
184 4
        $this->authCodeRepository->revokeAuthCode($authCodePayload->auth_code_id);
185
186 4
        return $responseType;
187
    }
188
189
    /**
190
     * Return the grant identifier that can be used in matching up requests.
191
     *
192
     * @return string
193
     */
194 33
    public function getIdentifier()
195
    {
196 33
        return 'authorization_code';
197
    }
198
199
    /**
200
     * Fetch the client_id parameter from the query string.
201
     *
202
     * @return string
203
     * @throws OAuthServerException
204
     */
205 15
    protected function getClientIdFromRequest($request)
206
    {
207 15
        $clientId = $this->getQueryStringParameter(
208 15
            'client_id',
209 15
            $request,
210 15
            $this->getServerParameter('PHP_AUTH_USER', $request)
211
        );
212
213 15
        if (is_null($clientId)) {
214 1
            throw OAuthServerException::invalidRequest('client_id');
215
        }
216
217 14
        return $clientId;
218
    }
219
220
    /**
221
     * {@inheritdoc}
222
     */
223 4
    public function canRespondToAuthorizationRequest(ServerRequestInterface $request)
224
    {
225
        return (
226 4
            array_key_exists('response_type', $request->getQueryParams())
227 4
            && $request->getQueryParams()['response_type'] === 'code'
228 4
            && null !== $this->getClientIdFromRequest($request)
229
        );
230
    }
231
232
    /**
233
     * {@inheritdoc}
234
     */
235 13
    public function validateAuthorizationRequest(ServerRequestInterface $request)
236
    {
237 13
        $clientId = $this->getClientIdFromRequest($request);
238
239 13
        $client = $this->clientRepository->getClientEntity(
240 13
            $clientId,
241 13
            $this->getIdentifier(),
242 13
            null,
243 13
            false
244
        );
245
246 13
        if ($client instanceof ClientEntityInterface === false) {
247 1
            $this->getEmitter()->emit(new RequestEvent(RequestEvent::CLIENT_AUTHENTICATION_FAILED, $request));
248 1
            throw OAuthServerException::invalidClient();
249
        }
250
251 12
        $redirectUri = $this->getQueryStringParameter('redirect_uri', $request);
252 12
        if ($redirectUri !== null) {
253
            if (
254 10
                is_string($client->getRedirectUri())
255 10
                && (strcmp($client->getRedirectUri(), $redirectUri) !== 0)
256
            ) {
257 1
                $this->getEmitter()->emit(new RequestEvent(RequestEvent::CLIENT_AUTHENTICATION_FAILED, $request));
258 1
                throw OAuthServerException::invalidClient();
259
            } elseif (
260 9
                is_array($client->getRedirectUri())
261 9
                && in_array($redirectUri, $client->getRedirectUri(), true) === false
262
            ) {
263 1
                $this->getEmitter()->emit(new RequestEvent(RequestEvent::CLIENT_AUTHENTICATION_FAILED, $request));
264 9
                throw OAuthServerException::invalidClient();
265
            }
266 2
        } elseif (is_array($client->getRedirectUri()) && count($client->getRedirectUri()) !== 1
267 2
            || empty($client->getRedirectUri())) {
268 1
            $this->getEmitter()->emit(new RequestEvent(RequestEvent::CLIENT_AUTHENTICATION_FAILED, $request));
269 1
            throw OAuthServerException::invalidClient();
270
        } else {
271 1
            $redirectUri = is_array($client->getRedirectUri())
272
                ? $client->getRedirectUri()[0]
273 1
                : $client->getRedirectUri();
274
        }
275
276 9
        $scopes = $this->validateScopes(
277 9
            $this->getQueryStringParameter('scope', $request, $this->defaultScope),
278 9
            $redirectUri
279
        );
280
281 9
        $stateParameter = $this->getQueryStringParameter('state', $request);
282
283 9
        $authorizationRequest = new AuthorizationRequest();
284 9
        $authorizationRequest->setGrantTypeId($this->getIdentifier());
285 9
        $authorizationRequest->setClient($client);
286 9
        $authorizationRequest->setRedirectUri($redirectUri);
287 9
        $authorizationRequest->setState($stateParameter);
288 9
        $authorizationRequest->setScopes($scopes);
289
290 9
        if ($this->enableCodeExchangeProof === true) {
291 6
            $codeChallenge = $this->getQueryStringParameter('code_challenge', $request);
292 6
            if ($codeChallenge === null) {
293 1
                throw OAuthServerException::invalidRequest('code_challenge');
294
            }
295
296 5
            $codeChallengeMethod = $this->getQueryStringParameter('code_challenge_method', $request, 'plain');
297 5
            if (in_array($codeChallengeMethod, ['plain', 'S256'], true) === false) {
298 1
                throw OAuthServerException::invalidRequest(
299 1
                    'code_challenge_method',
300 1
                    'Code challenge method must be `plain` or `S256`'
301
                );
302
            }
303
304
            // Validate code_challenge according to RFC-7636
305
            // @see: https://tools.ietf.org/html/rfc7636#section-4.2
306 4
            if (preg_match('/^[A-Za-z0-9-._~]{43,128}$/', $codeChallenge) !== 1) {
307 3
                throw OAuthServerException::invalidRequest(
308 3
                    'code_challenged',
309 3
                    'Code challenge must follow the specifications of RFC-7636.'
310
                );
311
            }
312
313 1
            $authorizationRequest->setCodeChallenge($codeChallenge);
314 1
            $authorizationRequest->setCodeChallengeMethod($codeChallengeMethod);
315
        }
316
317 4
        return $authorizationRequest;
318
    }
319
320
    /**
321
     * {@inheritdoc}
322
     */
323 7
    public function completeAuthorizationRequest(AuthorizationRequest $authorizationRequest)
324
    {
325 7
        if ($authorizationRequest->getUser() instanceof UserEntityInterface === false) {
326 1
            throw new \LogicException('An instance of UserEntityInterface should be set on the AuthorizationRequest');
327
        }
328
329 6
        $finalRedirectUri = ($authorizationRequest->getRedirectUri() === null)
330 6
            ? is_array($authorizationRequest->getClient()->getRedirectUri())
331
                ? $authorizationRequest->getClient()->getRedirectUri()[0]
332 6
                : $authorizationRequest->getClient()->getRedirectUri()
333 6
            : $authorizationRequest->getRedirectUri();
334
335
        // The user approved the client, redirect them back with an auth code
336 6
        if ($authorizationRequest->isAuthorizationApproved() === true) {
337 5
            $authCode = $this->issueAuthCode(
338 5
                $this->authCodeTTL,
339 5
                $authorizationRequest->getClient(),
340 5
                $authorizationRequest->getUser()->getIdentifier(),
341 5
                $authorizationRequest->getRedirectUri(),
342 5
                $authorizationRequest->getScopes()
343
            );
344
345
            $payload = [
346 3
                'client_id'             => $authCode->getClient()->getIdentifier(),
347 3
                'redirect_uri'          => $authCode->getRedirectUri(),
348 3
                'auth_code_id'          => $authCode->getIdentifier(),
349 3
                'scopes'                => $authCode->getScopes(),
350 3
                'user_id'               => $authCode->getUserIdentifier(),
351 3
                'expire_time'           => (new \DateTime())->add($this->authCodeTTL)->format('U'),
352 3
                'code_challenge'        => $authorizationRequest->getCodeChallenge(),
353 3
                'code_challenge_method' => $authorizationRequest->getCodeChallengeMethod(),
354
            ];
355
356 3
            $response = new RedirectResponse();
357 3
            $response->setRedirectUri(
358 3
                $this->makeRedirectUri(
359 3
                    $finalRedirectUri,
360
                    [
361 3
                        'code'  => $this->encrypt(
362 3
                            json_encode(
363 3
                                $payload
364
                            )
365
                        ),
366 3
                        'state' => $authorizationRequest->getState(),
367
                    ]
368
                )
369
            );
370
371 3
            return $response;
372
        }
373
374
        // The user denied the client, redirect them back with an error
375 1
        throw OAuthServerException::accessDenied(
376 1
            'The user denied the request',
377 1
            $this->makeRedirectUri(
378 1
                $finalRedirectUri,
379
                [
380 1
                    'state' => $authorizationRequest->getState(),
381
                ]
382
            )
383
        );
384
    }
385
}
386