Completed
Pull Request — 1.1 (#10)
by David
07:43
created
src/ServiceProvider/ExtendServiceFromRegistryDefinition.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
     }
70 70
 
71 71
     /**
72
-     * @return CallbackWrapperDefinition
72
+     * @return DumpableInterface
73 73
      */
74 74
     public function getPreviousDefinition()
75 75
     {
Please login to merge, or discard this patch.
src/ServiceProvider/ServiceProviderLoader.php 2 patches
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -134,10 +134,11 @@  discard block
 block discarded – undo
134 134
     }
135 135
 
136 136
     /**
137
-     * @param $serviceName
137
+     * @param string $serviceName
138 138
      * @param int                            $serviceProviderKey
139 139
      * @param callable                       $callable
140 140
      * @param ContainerDefinition            $containerDefinition
141
+     * @param string $decoratedServiceName
141 142
      *
142 143
      * @return DumpableInterface
143 144
      */
@@ -163,11 +164,12 @@  discard block
 block discarded – undo
163 164
     }
164 165
 
165 166
     /**
166
-     * @param $serviceName
167
+     * @param string $serviceName
167 168
      * @param int                            $serviceProviderKey
168 169
      * @param callable                       $callable
169 170
      * @param ContainerDefinition            $containerDefinition
170
-     * @param CallbackWrapperDefinition|null $previousDefinition
171
+     * @param null|DumpableInterface $previousDefinition
172
+     * @param string $decoratedServiceName
171 173
      *
172 174
      * @return DumpableInterface
173 175
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
         } elseif (is_string($callable) && strpos($callable, '::') !== false) {
154 154
             $pos = strpos($callable, '::');
155 155
             $className = substr($callable, 0, $pos);
156
-            $methodName = substr($callable, $pos + 2);
156
+            $methodName = substr($callable, $pos+2);
157 157
 
158 158
             return new FactoryCallDefinition($decoratedServiceName, $className, $methodName, [$containerDefinition]);
159 159
         }
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
         } elseif (is_string($callable) && strpos($callable, '::') !== false) {
184 184
             $pos = strpos($callable, '::');
185 185
             $className = substr($callable, 0, $pos);
186
-            $methodName = substr($callable, $pos + 2);
186
+            $methodName = substr($callable, $pos+2);
187 187
 
188 188
             return new FactoryCallDefinition($decoratedServiceName, $className, $methodName, [$containerDefinition, $previousDefinition]);
189 189
         }
Please login to merge, or discard this patch.