Completed
Pull Request — 1.0 (#8)
by David
05:17
created
src/ServiceProvider/ServiceProviderLoader.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
         } elseif (is_string($callable) && strpos($callable, '::') !== false) {
144 144
             $pos = strpos($callable, '::');
145 145
             $className = substr($callable, 0, $pos);
146
-            $methodName = substr($callable, $pos + 2);
146
+            $methodName = substr($callable, $pos+2);
147 147
             $params = [$containerDefinition];
148 148
             if ($callbackWrapperDefinition) {
149 149
                 $params[] = $callbackWrapperDefinition;
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -63,7 +63,6 @@  discard block
 block discarded – undo
63 63
 
64 64
     /**
65 65
      * @param string          $serviceName
66
-     * @param ServiceProvider $serviceProvider
67 66
      * @param int             $serviceProviderKey
68 67
      * @param callable        $callable
69 68
      *
@@ -120,11 +119,12 @@  discard block
 block discarded – undo
120 119
     }
121 120
 
122 121
     /**
123
-     * @param $serviceName
122
+     * @param string $serviceName
124 123
      * @param int                            $serviceProviderKey
125 124
      * @param callable                       $callable
126 125
      * @param ContainerDefinition            $containerDefinition
127 126
      * @param CallbackWrapperDefinition|null $callbackWrapperDefinition
127
+     * @param string $decoratedServiceName
128 128
      *
129 129
      * @return DumpableInterface
130 130
      */
Please login to merge, or discard this patch.
src/Compiler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
             $convertedDefinitions[$identifier] = $this->converter->convert($identifier, $definition);
178 178
         }
179 179
 
180
-        $allDefinitions = $convertedDefinitions + $this->dumpableDefinitions;
180
+        $allDefinitions = $convertedDefinitions+$this->dumpableDefinitions;
181 181
 
182 182
         foreach ($allDefinitions as $identifier => $definition) {
183 183
             $inlineEntry = $definition->toPhpCode('$container', ['$container']);
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
     {
197 197
         $pos = strrpos($className, '\\');
198 198
         if ($pos !== false) {
199
-            $shortClassName = substr($className, $pos + 1);
199
+            $shortClassName = substr($className, $pos+1);
200 200
             $namespaceLine = 'namespace '.substr($className, 0, $pos).';';
201 201
         } else {
202 202
             $shortClassName = $className;
Please login to merge, or discard this patch.