thecodingmachine / washingmachine

src/Clover/DiffService.php

Indentation +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 
         // Now, let's order the differences by crap order.
         usort($differences, function(Difference $d1, Difference $d2) {
-           return $d2->getCrapScore() <=> $d1->getCrapScore();
+            return $d2->getCrapScore() <=> $d1->getCrapScore();
         });
 
         // Now, let's limit the number of returned differences

src/Gitlab/Message.php

Spacing +1 added lines, -1 removed lines

@@ -125,7 +125,7 @@
         $url = $this->getArtifactFileUrl($file->getFilename(), $gitlabUrl, $projectName, $buildId);
 
         $this->msg .= sprintf("\n<strong>[%s](%s)</strong>\n", $file->getFilename(), $url);
-        $this->msg .= sprintf("```\n%s%s```\n", $text, $isComplete?'':"... (file truncated)\n");
+        $this->msg .= sprintf("```\n%s%s```\n", $text, $isComplete ? '' : "... (file truncated)\n");
 
         if (!$isComplete) {
             $this->msg .= sprintf("[Download complete file](%s)\n", $url);

src/Commands/Config.php

Spacing +2 added lines, -2 removed lines

@@ -53,9 +53,9 @@
                 throw new \RuntimeException('Could not find the Gitlab URL in the "CI_REPOSITORY_URL" environment variable (usually set by Gitlab CI). Either set this environment variable or pass the URL via the --gitlab-url command line option.');
             }
             $parsed_url = parse_url($ciProjectUrl);
-            $scheme   = isset($parsed_url['scheme']) ? $parsed_url['scheme'] . '://' : '';
+            $scheme   = isset($parsed_url['scheme']) ? $parsed_url['scheme'].'://' : '';
             $host     = isset($parsed_url['host']) ? $parsed_url['host'] : '';
-            $port     = isset($parsed_url['port']) ? ':' . $parsed_url['port'] : '';
+            $port     = isset($parsed_url['port']) ? ':'.$parsed_url['port'] : '';
             $gitlabUrl = $scheme.$host.$port;
         }
         return rtrim($gitlabUrl, '/');

src/Git/GitRepository.php

Spacing +3 added lines, -3 removed lines

@@ -11,7 +11,7 @@ 
     public function getMergeBase(string $commit1, string $commit2) : string
     {
         try {
-            $this->extractFromCommand('git merge-base --is-ancestor ' . escapeshellarg($commit1) . ' ' . escapeshellarg($commit2));
+            $this->extractFromCommand('git merge-base --is-ancestor '.escapeshellarg($commit1).' '.escapeshellarg($commit2));
         } catch (GitException $e) {
             // The command will return exit code 1 if $commit1 is an ancestor of $commit2
             // Exit code one triggers an exception. We catch it.
@@ -19,14 +19,14 @@ 
         }
 
 
-        $results = $this->extractFromCommand('git merge-base ' . escapeshellarg($commit1). ' '. escapeshellarg($commit2));
+        $results = $this->extractFromCommand('git merge-base '.escapeshellarg($commit1).' '.escapeshellarg($commit2));
 
         return $results[0];
     }
 
     public function getLatestCommitForBranch(string $branch) : string
     {
-        $results = $this->extractFromCommand('git log -n 1 --pretty=format:"%H" ' . escapeshellarg($branch));
+        $results = $this->extractFromCommand('git log -n 1 --pretty=format:"%H" '.escapeshellarg($branch));
 
         return $results[0];
     }

src/Gitlab/BuildService.php

Doc Comments +2 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
      * @param string $commitId
      * @param string|null $excludePipelineId A pipeline ID we want to exclude (we don't want to get the current pipeline ID).
      * @param int $numIter
-     * @return array
+     * @return string
      * @throws BuildNotFoundException
      */
     public function getLatestPipelineFromCommitId(string $projectName, string $commitId, string $excludePipelineId = null, int $numIter = 0) : array
@@ -116,7 +116,7 @@ 
      * @param string $projectName
      * @param string $branchName
      * @param string $excludePipelineId A pipeline ID we want to exclude (we don't want to get the current pipeline ID).
-     * @return array
+     * @return string
      * @throws BuildNotFoundException
      */
     public function getLatestPipelineFromBranch(string $projectName, string $branchName, string $excludePipelineId) : array

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace TheCodingMachine\WashingMachine\Gitlab;
 use Gitlab\Client;
 use Gitlab\ResultPager;
-use GuzzleHttp\Psr7\Stream;
 use GuzzleHttp\Psr7\StreamWrapper;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Filesystem\Filesystem;

Indentation +1 added lines, -1 removed lines

@@ -183,7 +183,7 @@
                 $jobItem['stage'] === $jobStage &&
                 isset($jobItem['artifacts_file']) &&
                 (in_array($jobItem['status'], ['failed', 'success']))
-           ) {
+            ) {
                 $job = $jobItem;
                 break;
             }

Spacing +2 added lines, -2 removed lines

@@ -80,7 +80,7 @@ 
         if (!isset($this->pipelines[$projectName])) {
             $pager = new ResultPager($this->client);
             $this->pipelines[$projectName] = $pager->fetchAll($this->client->api('projects'), 'pipelines',
-                [ $projectName ]
+                [$projectName]
             );
         }
         return $this->pipelines[$projectName];
@@ -192,7 +192,7 @@ 
         if ($job === null) {
             throw new BuildNotFoundException('Could not find finished job with build name "'.$buildName.'", stage "'.$jobStage.'" and artifacts file in pipeline "'.$pipelineId.'"');
         }
-        $this->logger->debug('Found job '. $job['id'] . ' for pipeline ' . $pipelineId);
+        $this->logger->debug('Found job '.$job['id'].' for pipeline '.$pipelineId);
 
         $artifactContent = $this->client->jobs->artifacts($projectName, $job['id']);
 

src/Commands/RunCommand.php

Spacing +2 added lines, -2 removed lines

@@ -274,7 +274,7 @@ 
 
         $commit = $project->commit($commitRef);
 
-        return $commit->committer ? $commit->committer->id :  null;
+        return $commit->committer ? $commit->committer->id : null;
     }
 
     /**
@@ -293,7 +293,7 @@ 
 
             $buildService->dumpArtifactFromBranch($projectName, $targetBranch, $buildName, $jobStage, $tmpFile, $excludePipelineId);
             $zipFile = new \ZipArchive();
-            if ($zipFile->open($tmpFile)!==true) {
+            if ($zipFile->open($tmpFile) !== true) {
                 throw new \RuntimeException('Invalid ZIP archive '.$tmpFile);
             }
             return $this->getMeasuresFromZipFile($zipFile, $cloverPath, $crap4JPath);