thecodingmachine / service-provider-bridge-bundle

src/Tests/Fixtures/TestServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
     public function getServices()
     {
         return [
-            'serviceA' => function (ContainerInterface $container) {
+            'serviceA' => function(ContainerInterface $container) {
                 $instance = new \stdClass();
                 $instance->serviceB = $container->get('serviceB');
 

src/Tests/Fixtures/TestServiceProviderOverride2.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
     public function getServices()
     {
         return [
-            'serviceA' => [self::class, 'overrideServiceA'],
+            'serviceA' => [ self::class, 'overrideServiceA' ],
         ];
     }
 

src/Exception/ContainerException.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
         ));
 
         if ($prev) {
-            $message .= ' Message: ' . $prev->getMessage();
+            $message .= ' Message: '.$prev->getMessage();
         }
 
         return new static($message, 0, $prev);

src/InteropServiceProviderBridgeBundle.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
      * @param array $serviceProviders An array of service providers, in the format specified in thecodingmachine/service-provider-registry: https://github.com/thecodingmachine/service-provider-registry#how-does-it-work
      * @param bool $usePuli
      */
-    public function __construct(array $serviceProviders = [], $usePuli = true)
+    public function __construct(array $serviceProviders = [ ], $usePuli = true)
     {
         $this->serviceProviders = $serviceProviders;
         $this->usePuli = $usePuli;

tests/ServiceProviderCompilationPassTest.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Puli\Discovery\Api\Type\BindingType;
 use Puli\Discovery\Binding\ClassBinding;
 use Puli\Discovery\InMemoryDiscovery;
-use Puli\SymfonyBundle\PuliBundle;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use TheCodingMachine\Interop\ServiceProviderBridgeBundle\Tests\Fixtures\TestServiceProvider;
 use TheCodingMachine\Interop\ServiceProviderBridgeBundle\Tests\Fixtures\TestServiceProviderOverride;

Spacing +2 added lines, -2 removed lines

@@ -71,7 +71,7 @@ 
      */
     public function testExceptionMessageIfNoPuliBundle()
     {
-        $bundle = new InteropServiceProviderBridgeBundle([], true);
+        $bundle = new InteropServiceProviderBridgeBundle([ ], true);
         $container = new ContainerBuilder();
         $bundle->build($container);
         $container->compile();
@@ -82,7 +82,7 @@ 
      */
     public function testPuliBundle()
     {
-        $container = $this->getContainer([], true);
+        $container = $this->getContainer([ ], true);
 
         $serviceA = $container->get('serviceA');
 

src/ServiceProviderCompilationPass.php

Unused Use Statements -4 removed lines

@@ -5,14 +5,10 @@
 
 
 use Interop\Container\ServiceProvider;
-use Invoker\Reflection\CallableReflection;
-use Puli\Discovery\Binding\ClassBinding;
-use Puli\GeneratedPuliFactory;
 use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
-use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
 use Symfony\Component\DependencyInjection\Reference;
 use TheCodingMachine\ServiceProvider\Registry;
 

Spacing +1 added lines, -1 removed lines

@@ -145,7 +145,7 @@
         $factoryDefinition = new Definition('Class'); // TODO: in PHP7, we can get the return type of the function!
         $containerDefinition = new Reference('interop_service_provider_acclimated_container');
 
-        if ((is_array($callable) && is_string($callable[0])) || is_string($callable)) {
+        if ((is_array($callable) && is_string($callable[ 0 ])) || is_string($callable)) {
             $factoryDefinition->setFactory($callable);
             $factoryDefinition->addArgument(new Reference('interop_service_provider_acclimated_container'));
         } else {

Doc Comments +4 added lines, -2 removed lines

@@ -24,8 +24,6 @@ 
 
     /**
      * @param int $registryId
-     * @param array $serviceProvidersLazyArray
-     * @param bool $usePuli
      */
     public function __construct($registryId, RegistryProviderInterface $registryProvider)
     {
@@ -82,6 +80,10 @@ 
         }
     }
 
+    /**
+     * @param integer $serviceName
+     * @param callable $callable
+     */
     private function registerService($serviceName, $serviceProviderKey, ServiceProvider $serviceProvider, $callable, ContainerBuilder $container) {
         $factoryDefinition = $this->getServiceDefinitionFromCallable($serviceName, $serviceProviderKey, $callable);