Completed
Push — 1.0 ( abbd04...04b968 )
by David
09:59
created
tests/ServiceProviderCompilationPassTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use Puli\Discovery\Api\Type\BindingType;
8 8
 use Puli\Discovery\Binding\ClassBinding;
9 9
 use Puli\Discovery\InMemoryDiscovery;
10
-use Puli\SymfonyBundle\PuliBundle;
11 10
 use Symfony\Component\DependencyInjection\ContainerBuilder;
12 11
 use TheCodingMachine\Interop\ServiceProviderBridgeBundle\Tests\Fixtures\TestServiceProvider;
13 12
 use TheCodingMachine\Interop\ServiceProviderBridgeBundle\Tests\Fixtures\TestServiceProviderOverride;
Please login to merge, or discard this patch.
src/ServiceProviderCompilationPass.php 2 patches
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -5,14 +5,10 @@
 block discarded – undo
5 5
 
6 6
 
7 7
 use Interop\Container\ServiceProvider;
8
-use Invoker\Reflection\CallableReflection;
9
-use Puli\Discovery\Binding\ClassBinding;
10
-use Puli\GeneratedPuliFactory;
11 8
 use Symfony\Component\DependencyInjection\Alias;
12 9
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
13 10
 use Symfony\Component\DependencyInjection\ContainerBuilder;
14 11
 use Symfony\Component\DependencyInjection\Definition;
15
-use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
16 12
 use Symfony\Component\DependencyInjection\Reference;
17 13
 use TheCodingMachine\ServiceProvider\Registry;
18 14
 
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,8 +24,6 @@  discard block
 block discarded – undo
24 24
 
25 25
     /**
26 26
      * @param int $registryId
27
-     * @param array $serviceProvidersLazyArray
28
-     * @param bool $usePuli
29 27
      */
30 28
     public function __construct($registryId, RegistryProviderInterface $registryProvider)
31 29
     {
@@ -82,6 +80,10 @@  discard block
 block discarded – undo
82 80
         }
83 81
     }
84 82
 
83
+    /**
84
+     * @param integer $serviceName
85
+     * @param callable $callable
86
+     */
85 87
     private function registerService($serviceName, $serviceProviderKey, ServiceProvider $serviceProvider, $callable, ContainerBuilder $container) {
86 88
         $factoryDefinition = $this->getServiceDefinitionFromCallable($serviceName, $serviceProviderKey, $callable);
87 89
 
Please login to merge, or discard this patch.