thecodingmachine / phpstan-strict-rules

src/Rules/Exceptions/DoNotThrowExceptionBaseClassRule.php

Unused Use Statements -2 removed lines

@@ -5,9 +5,7 @@
 
 
 use PhpParser\Node;
-use PhpParser\Node\Stmt\Catch_;
 use PHPStan\Analyser\Scope;
-use PHPStan\Broker\Broker;
 use PHPStan\Rules\Rule;
 
 /**

src/Rules/Exceptions/EmptyExceptionRule.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Catch_;
 use PHPStan\Analyser\Scope;
-use PHPStan\Broker\Broker;
 use PHPStan\Rules\Rule;
 
 class EmptyExceptionRule implements Rule

src/Rules/Exceptions/ThrowMustBundlePreviousExceptionRule.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 use PHPStan\Analyser\Scope;
-use PHPStan\Broker\Broker;
 use PHPStan\Rules\Rule;
 
 /**

src/Rules/TypeHints/AbstractMissingTypeHintRule.php

Spacing +11 added lines, -11 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace TheCodingMachine\PHPStan\Rules\TypeHints;
 
@@ -88,7 +88,7 @@ 
      * @param ReflectionParameter $parameter
      * @return null|string
      */
-    private function analyzeParameter(ReflectionParameter $parameter): ?string
+    private function analyzeParameter(ReflectionParameter $parameter): ? string
     {
         $phpTypeHint = $parameter->getTypeHint();
         $docBlockTypeHints = $parameter->getDocBlockTypes();
@@ -105,7 +105,7 @@ 
      * @param ReflectionFunction|ReflectionMethod $function
      * @return null|string
      */
-    private function analyzeReturnType($function): ?string
+    private function analyzeReturnType($function): ? string
     {
         $reflectionPhpTypeHint = $function->getReturnType();
         $phpTypeHint = null;
@@ -128,7 +128,7 @@ 
      * @param Type[] $docBlockTypeHints
      * @return null|string
      */
-    private function analyzeWithTypehint($context, Type $phpTypeHint, array $docBlockTypeHints): ?string
+    private function analyzeWithTypehint($context, Type $phpTypeHint, array $docBlockTypeHints): ? string
     {
         $docblockWithoutNullable = $this->typesWithoutNullable($docBlockTypeHints);
 
@@ -157,9 +157,9 @@ 
             foreach ($docblockWithoutNullable as $docblockTypehint) {
                 if (!$docblockTypehint instanceof Array_) {
                     if ($context instanceof ReflectionParameter) {
-                        return sprintf('%s, mismatching type-hints for parameter %s. PHP type hint is "array" and docblock type hint is %s.', $this->getContext($context), $context->getName(), (string)$docblockTypehint);
+                        return sprintf('%s, mismatching type-hints for parameter %s. PHP type hint is "array" and docblock type hint is %s.', $this->getContext($context), $context->getName(), (string) $docblockTypehint);
                     } else {
-                        return sprintf('%s, mismatching type-hints for return type. PHP type hint is "array" and docblock declared return type is %s.', $this->getContext($context), (string)$docblockTypehint);
+                        return sprintf('%s, mismatching type-hints for return type. PHP type hint is "array" and docblock declared return type is %s.', $this->getContext($context), (string) $docblockTypehint);
                     }
                 }
 
@@ -181,7 +181,7 @@ 
      * @param Type[] $docBlockTypeHints
      * @return null|string
      */
-    private function analyzeWithoutTypehint($context, array $docBlockTypeHints): ?string
+    private function analyzeWithoutTypehint($context, array $docBlockTypeHints): ? string
     {
         if (empty($docBlockTypeHints)) {
             if ($context instanceof ReflectionParameter) {
@@ -208,7 +208,7 @@ 
      * @param Type[] $docBlockTypeHints
      * @return string|null
      */
-    private function isNativelyTypehintable(array $docBlockTypeHints): ?string
+    private function isNativelyTypehintable(array $docBlockTypeHints): ? string
     {
         if (count($docBlockTypeHints) > 2) {
             return null;
@@ -227,11 +227,11 @@ 
         $type = $types[0];
 
         if ($this->isNativeType($type)) {
-            return ($isNullable?'?':'').((string)$type);
+            return ($isNullable ? '?' : '').((string) $type);
         }
 
         if ($type instanceof Array_) {
-            return ($isNullable?'?':'').'array';
+            return ($isNullable ? '?' : '').'array';
         }
 
         // TODO: more definitions to add here
@@ -239,7 +239,7 @@ 
         // Manage array of things => (cast to array)
 
         if ($type instanceof Object_) {
-            return ($isNullable?'?':'').((string)$type);
+            return ($isNullable ? '?' : '').((string) $type);
         }
 
         return null;

src/Rules/TypeHints/MissingTypeHintInFunctionRule.php

Unused Use Statements -2 removed lines

@@ -3,9 +3,7 @@
 
 namespace TheCodingMachine\PHPStan\Rules\TypeHints;
 
-use BetterReflection\Reflection\ReflectionFunction;
 use BetterReflection\Reflection\ReflectionFunctionAbstract;
-use BetterReflection\Reflection\ReflectionMethod;
 use BetterReflection\Reflection\ReflectionParameter;
 use PhpParser\Node;
 

src/Rules/TypeHints/MissingTypeHintInMethodRule.php

Unused Use Statements -3 removed lines

@@ -3,12 +3,9 @@
 
 namespace TheCodingMachine\PHPStan\Rules\TypeHints;
 
-use BetterReflection\Reflection\ReflectionFunction;
 use BetterReflection\Reflection\ReflectionFunctionAbstract;
-use BetterReflection\Reflection\ReflectionMethod;
 use BetterReflection\Reflection\ReflectionParameter;
 use PhpParser\Node;
-use PHPStan\Reflection\MethodReflection;
 
 class MissingTypeHintInMethodRule extends AbstractMissingTypeHintRule
 {