thecodingmachine / phpstan-strict-rules

src/Rules/Exceptions/ThrowMustBundlePreviousExceptionRule.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 use PHPStan\Analyser\Scope;
-use PHPStan\Broker\Broker;
 use PHPStan\Rules\Rule;
 
 /**

src/Rules/TypeHints/MissingTypeHintInMethodRule.php

Unused Use Statements -4 removed lines

@@ -9,10 +9,6 @@
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Reflection\ParametersAcceptorWithPhpDocs;
 use PHPStan\Reflection\Php\PhpMethodReflection;
-use Roave\BetterReflection\Reflection\ReflectionFunction;
-use Roave\BetterReflection\Reflection\ReflectionFunctionAbstract;
-use Roave\BetterReflection\Reflection\ReflectionMethod;
-use Roave\BetterReflection\Reflection\ReflectionParameter;
 use PhpParser\Node;
 use PHPStan\Reflection\MethodReflection;
 

src/Rules/TypeHints/ParameterDebugContext.php

Braces +1 added lines, -2 removed lines

@@ -42,8 +42,7 @@
             }
 
             return sprintf('In method "%s::%s", parameter $%s', $this->scope->getClassReflection()->getDisplayName(), $this->function->name->name, $this->parameter->getName());
-        }
-        elseif ($this->function instanceof Function_) {
+        } elseif ($this->function instanceof Function_) {
             return sprintf('In function "%s", parameter $%s', $this->function->name->name, $this->parameter->getName());
         }
         return 'Should not happen';

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 
 
 use PhpParser\Node\FunctionLike;
-use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
 use PHPStan\Analyser\Scope;

src/Rules/TypeHints/AbstractMissingTypeHintRule.php

Spacing +4 added lines, -4 removed lines

@@ -287,15 +287,15 @@ 
         }
 
         if ($type instanceof ObjectType) {
-            return ($isNullable?'?':'').'\\'.$type->describe(VerbosityLevel::typeOnly());
+            return ($isNullable ? '?' : '').'\\'.$type->describe(VerbosityLevel::typeOnly());
         }
 
         if ($type instanceof ArrayType) {
-            return ($isNullable?'?':'').'array';
+            return ($isNullable ? '?' : '').'array';
         }
 
         if ($this->isNativeType($type)) {
-            return ($isNullable?'?':'').$type->describe(VerbosityLevel::typeOnly());
+            return ($isNullable ? '?' : '').$type->describe(VerbosityLevel::typeOnly());
         }
 
         // TODO: more definitions to add here
@@ -345,7 +345,7 @@ 
     private function typesWithoutNullable(Type $docBlockTypeHints): Type
     {
         if ($docBlockTypeHints instanceof UnionType) {
-            $filteredTypes = array_values(array_filter($docBlockTypeHints->getTypes(), function (Type $item) {
+            $filteredTypes = array_values(array_filter($docBlockTypeHints->getTypes(), function(Type $item) {
                 return !$item instanceof NullType;
             }));
             if (\count($filteredTypes) === 1) {

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 
 namespace TheCodingMachine\PHPStan\Rules\TypeHints;
 
-use PHPStan\Reflection\Php\PhpFunctionReflection;
-use PHPStan\Reflection\Php\PhpMethodReflection;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\BooleanType;
 use PHPStan\Type\CallableType;

src/Rules/TypeHints/FunctionDebugContext.php

Braces +1 added lines, -2 removed lines

@@ -37,8 +37,7 @@
             }
 
             return sprintf('In method "%s::%s",', $this->scope->getClassReflection()->getDisplayName(), $this->function->name->name);
-        }
-        elseif ($this->function instanceof Function_) {
+        } elseif ($this->function instanceof Function_) {
             return sprintf('In function "%s",', $this->function->name->name);
         }
         return 'Should not happen';

Unused Use Statements -2 removed lines

@@ -5,11 +5,9 @@
 
 
 use PhpParser\Node\FunctionLike;
-use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
 use PHPStan\Analyser\Scope;
-use PHPStan\Reflection\Php\PhpParameterReflection;
 
 class FunctionDebugContext implements DebugContextInterface
 {

src/Rules/Exceptions/MustRethrowRule.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 use PHPStan\Analyser\Scope;
-use PHPStan\Broker\Broker;
 use PHPStan\Rules\Rule;
 use RuntimeException;
 use TheCodingMachine\PHPStan\Utils\PrefixGenerator;

Spacing +2 added lines, -2 removed lines

@@ -37,8 +37,8 @@
         // Let's only apply the filter to \Exception, \RuntimeException or \Throwable
         $exceptionType = null;
         foreach ($node->types as $type) {
-            if (in_array((string)$type, [Exception::class, RuntimeException::class, Throwable::class], true)) {
-                $exceptionType = (string)$type;
+            if (in_array((string) $type, [Exception::class, RuntimeException::class, Throwable::class], true)) {
+                $exceptionType = (string) $type;
                 break;
             }
         }

src/Rules/Exceptions/EmptyExceptionRule.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Catch_;
 use PHPStan\Analyser\Scope;
-use PHPStan\Broker\Broker;
 use PHPStan\Rules\Rule;
 use function strpos;