thecodingmachine / phpstan-strict-rules

src/Rules/Exceptions/EmptyExceptionRule.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Catch_;
 use PHPStan\Analyser\Scope;
-use PHPStan\Broker\Broker;
 use PHPStan\Rules\Rule;
 
 class EmptyExceptionRule implements Rule

src/Rules/Exceptions/ThrowMustBundlePreviousExceptionRule.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 use PHPStan\Analyser\Scope;
-use PHPStan\Broker\Broker;
 use PHPStan\Rules\Rule;
 
 /**

src/Rules/TypeHints/MissingTypeHintInFunctionRule.php

Unused Use Statements -2 removed lines

@@ -3,9 +3,7 @@
 
 namespace TheCodingMachine\PHPStan\Rules\TypeHints;
 
-use Roave\BetterReflection\Reflection\ReflectionFunction;
 use Roave\BetterReflection\Reflection\ReflectionFunctionAbstract;
-use Roave\BetterReflection\Reflection\ReflectionMethod;
 use Roave\BetterReflection\Reflection\ReflectionParameter;
 use PhpParser\Node;
 

src/Rules/TypeHints/MissingTypeHintInMethodRule.php

Unused Use Statements -3 removed lines

@@ -3,12 +3,9 @@
 
 namespace TheCodingMachine\PHPStan\Rules\TypeHints;
 
-use Roave\BetterReflection\Reflection\ReflectionFunction;
 use Roave\BetterReflection\Reflection\ReflectionFunctionAbstract;
-use Roave\BetterReflection\Reflection\ReflectionMethod;
 use Roave\BetterReflection\Reflection\ReflectionParameter;
 use PhpParser\Node;
-use PHPStan\Reflection\MethodReflection;
 
 class MissingTypeHintInMethodRule extends AbstractMissingTypeHintRule
 {

src/Rules/TypeHints/AbstractMissingTypeHintRule.php

Unused Use Statements -3 removed lines

@@ -3,7 +3,6 @@ 
 
 namespace TheCodingMachine\PHPStan\Rules\TypeHints;
 
-use phpDocumentor\Reflection\DocBlockFactory;
 use phpDocumentor\Reflection\Type;
 use phpDocumentor\Reflection\Types\Array_;
 use phpDocumentor\Reflection\Types\Boolean;
@@ -26,8 +25,6 @@ 
 use Roave\BetterReflection\Reflection\ReflectionMethod;
 use Roave\BetterReflection\Reflection\ReflectionParameter;
 use Roave\BetterReflection\Reflector\Exception\IdentifierNotFound;
-use Roave\BetterReflection\TypesFinder\PhpDocumentor\NamespaceNodeToReflectionTypeContext;
-use Roave\BetterReflection\TypesFinder\ResolveTypes;
 
 abstract class AbstractMissingTypeHintRule implements Rule
 {

Spacing +7 added lines, -7 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace TheCodingMachine\PHPStan\Rules\TypeHints;
 
@@ -189,9 +189,9 @@ 
             foreach ($docblockWithoutNullable as $docblockTypehint) {
                 if (!$this->isTypeIterable($docblockTypehint)) {
                     if ($context instanceof ReflectionParameter) {
-                        return sprintf('%s, mismatching type-hints for parameter %s. PHP type hint is "array" and docblock type hint is %s.', $this->getContext($context), $context->getName(), (string)$docblockTypehint);
+                        return sprintf('%s, mismatching type-hints for parameter %s. PHP type hint is "array" and docblock type hint is %s.', $this->getContext($context), $context->getName(), (string) $docblockTypehint);
                     } else {
-                        return sprintf('%s, mismatching type-hints for return type. PHP type hint is "array" and docblock declared return type is %s.', $this->getContext($context), (string)$docblockTypehint);
+                        return sprintf('%s, mismatching type-hints for return type. PHP type hint is "array" and docblock declared return type is %s.', $this->getContext($context), (string) $docblockTypehint);
                     }
                 }
 
@@ -299,11 +299,11 @@ 
         $type = $types[0];
 
         if ($this->isNativeType($type)) {
-            return ($isNullable?'?':'').((string)$type);
+            return ($isNullable ? '?' : '').((string) $type);
         }
 
         if ($type instanceof Array_) {
-            return ($isNullable?'?':'').'array';
+            return ($isNullable ? '?' : '').'array';
         }
 
         // TODO: more definitions to add here
@@ -311,7 +311,7 @@ 
         // Manage array of things => (cast to array)
 
         if ($type instanceof Object_) {
-            return ($isNullable?'?':'').((string)$type);
+            return ($isNullable ? '?' : '').((string) $type);
         }
 
         return null;
@@ -354,7 +354,7 @@ 
      */
     private function typesWithoutNullable(array $docBlockTypeHints): array
     {
-        return array_values(array_filter($docBlockTypeHints, function ($item) {
+        return array_values(array_filter($docBlockTypeHints, function($item) {
             return !$item instanceof Null_;
         }));
     }