Mouf\NodeJsInstaller\NodeJsVersionsLister::getList()

Complexity

Conditions	2
Paths	2

Size

Total Lines

16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getList()
    {
        // Let's download the content of HTML page https://nodejs.org/dist/
        $html = $this->rfs->getContents(parse_url(self::NODEJS_DIST_URL, PHP_URL_HOST), self::NODEJS_DIST_URL, false);

It seems like parse_url(self::NODEJS_DIST_URL, PHP_URL_HOST) targeting parse_url() can also be of type false; however, Composer\Util\RemoteFilesystem::getContents() does only seem to accept string, did you maybe forget to handle an error condition?

        // Now, let's parse it!
        $matches = array();
        preg_match_all("$>v([0-9]*\\.[0-9]*\\.[0-9]*)/<$", $html, $matches);

        if (!isset($matches[1])) {
            throw new NodeJsInstallerException("Error while querying ".self::NODEJS_DIST_URL.". Unable to find NodeJS
            versions on this page.");
        }

        return $matches[1];
    }
}