Mouf\NodeJsInstaller\NodeJsVersionsLister

Complexity

Total Complexity

3

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getList()	0	16	2

<?php
namespace Mouf\NodeJsInstaller;

use Composer\Composer;
use Composer\IO\IOInterface;
use Composer\Util\RemoteFilesystem;

/**
 * A class in charge of retrieving all the available versions of NodeJS.
 */
class NodeJsVersionsLister
{
    /**
     * @var IOInterface
     */
    private $io;

    protected $rfs;

    const NODEJS_DIST_URL = "https://nodejs.org/dist/";

    public function __construct(IOInterface $io, Composer $composer)
    {
        $this->io = $io;
        $this->rfs = new RemoteFilesystem($io, $composer->getConfig());
    }

    public function getList()
    {
        // Let's download the content of HTML page https://nodejs.org/dist/
        $html = $this->rfs->getContents(parse_url(self::NODEJS_DIST_URL, PHP_URL_HOST), self::NODEJS_DIST_URL, false);

It seems like parse_url(self::NODEJS_DIST_URL, PHP_URL_HOST) targeting parse_url() can also be of type false; however, Composer\Util\RemoteFilesystem::getContents() does only seem to accept string, did you maybe forget to handle an error condition?

        // Now, let's parse it!
        $matches = array();
        preg_match_all("$>v([0-9]*\\.[0-9]*\\.[0-9]*)/<$", $html, $matches);

        if (!isset($matches[1])) {
            throw new NodeJsInstallerException("Error while querying ".self::NODEJS_DIST_URL.". Unable to find NodeJS
            versions on this page.");
        }

        return $matches[1];
    }
}