Completed
Pull Request — 8.0 (#30)
by Marc
21:26
created
src/Mouf/Mvc/Splash/Routers/ExceptionRouter.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Mouf\Mvc\Splash\Routers;
4 4
 
5 5
 use Mouf\Mvc\Splash\Controllers\Http500HandlerInterface;
6
-use Psr\Http\Message\ResponseInterface as Response;
7 6
 use Psr\Http\Message\ResponseInterface;
8 7
 use Psr\Http\Message\ServerRequestInterface as Request;
9 8
 use Psr\Log\LoggerInterface;
Please login to merge, or discard this patch.
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,6 @@
 block discarded – undo
35 35
     /**
36 36
      * @Important
37 37
      *
38
-     * @param HttpKernelInterface $router The default router (the router we will catch exceptions from).
39 38
      * @param LoggerInterface     $log    Logger to log errors.
40 39
      */
41 40
     public function __construct(Http500HandlerInterface $errorController, LoggerInterface $log = null)
Please login to merge, or discard this patch.
src/Mouf/Mvc/Splash/Routers/PhpVarsCheckRouter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
     /**
69 69
      * Returns the number of bytes from php.ini parameter.
70 70
      *
71
-     * @param $val
71
+     * @param string $val
72 72
      *
73 73
      * @return int|string
74 74
      */
Please login to merge, or discard this patch.
src/Mouf/Mvc/Splash/Services/SplashCreateControllerService.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -441,6 +441,9 @@
 block discarded – undo
441 441
         return '<p>Hello {{message}}</p>';
442 442
     }
443 443
 
444
+    /**
445
+     * @param string $controllerFQCN
446
+     */
444 447
     private function generatePhpView($controllerFQCN)
445 448
     {
446 449
         return '<?php /* @var $this '.$controllerFQCN.' */ ?>
Please login to merge, or discard this patch.
src/Mouf/Mvc/Splash/Services/SplashRequestContext.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -61,6 +61,9 @@
 block discarded – undo
61 61
         return $this->request;
62 62
     }
63 63
 
64
+    /**
65
+     * @param string $key
66
+     */
64 67
     public function hasParameter($key) : bool
65 68
     {
66 69
         if (isset($this->urlParameters[$key])) {
Please login to merge, or discard this patch.
src/Mouf/Mvc/Splash/Utils/ExceptionUtils.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
      *
10 10
      * @param unknown_type $backtrace
11 11
      *
12
-     * @return unknown
12
+     * @return string
13 13
      */
14 14
     private static function getHTMLBackTrace($backtrace)
15 15
     {
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      * Function called to display an exception if it occurs.
52 52
      * It will make sure to purge anything in the buffer before calling the exception displayer.
53 53
      *
54
-     * @param Exception $exception
54
+     * @param \Exception $exception
55 55
      */
56 56
     public static function getHtmlForException(\Exception $exception)
57 57
     {
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      * Function called to display an exception if it occurs.
88 88
      * It will make sure to purge anything in the buffer before calling the exception displayer.
89 89
      *
90
-     * @param Exception $exception
90
+     * @param \Exception $exception
91 91
      */
92 92
     public static function getTextForException(\Exception $exception)
93 93
     {
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
      *
106 106
      * @param unknown_type $backtrace
107 107
      *
108
-     * @return unknown
108
+     * @return string
109 109
      */
110 110
     private static function getTextBackTrace($backtrace)
111 111
     {
@@ -180,6 +180,9 @@  discard block
 block discarded – undo
180 180
         return 'Unknown type variable';
181 181
     }
182 182
 
183
+    /**
184
+     * @return string
185
+     */
183 186
     private static function displayFile($file)
184 187
     {
185 188
         $realpath = realpath($file);
Please login to merge, or discard this patch.
src/Mouf/Mvc/Splash/Services/SplashRequestFetcher.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      * @param mixed $data The data generated by "getFetcherData"
53 53
      * @param SplashRequestContext $context
54 54
      *
55
-     * @return mixed
55
+     * @return \Psr\Http\Message\ServerRequestInterface
56 56
      */
57 57
     public function fetchValue($data, SplashRequestContext $context)
58 58
     {
Please login to merge, or discard this patch.
src/Mouf/Mvc/Splash/Routers/CacheRouter.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Psr\Http\Message\ResponseInterface;
6 6
 use Psr\Http\Message\ServerRequestInterface;
7
-use Symfony\Component\HttpFoundation\Request;
8 7
 use Symfony\Component\HttpFoundation\Response;
9 8
 use Mouf\Utils\Cache\CacheInterface;
10 9
 use Psr\Log\LoggerInterface;
Please login to merge, or discard this patch.
src/Mouf/Mvc/Splash/Services/ControllerAnalyzer.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,6 @@
 block discarded – undo
71 71
     /**
72 72
      * Returns an array of SplashRoute for the controller passed in parameter.
73 73
      *
74
-     * @param object $controller
75 74
      *
76 75
      * @return SplashRoute[]
77 76
      *
Please login to merge, or discard this patch.