thecodingmachine / mvc.splash-common

src/Mouf/Mvc/Splash/Routers/CacheRouter.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
-use Symfony\Component\HttpKernel\HttpKernelInterface;
-use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Mouf\Utils\Cache\CacheInterface;
 use Psr\Log\LoggerInterface;

src/Mouf/Mvc/Splash/Routers/ExceptionRouter.php

Doc Comments +1 added lines, -2 removed lines

@@ -35,7 +35,6 @@ 
     /**
      * @Important
      *
-     * @param HttpKernelInterface $router The default router (the router we will catch exceptions from).
      * @param LoggerInterface     $log    Logger to log errors.
      */
     public function __construct(Http500HandlerInterface $errorController, LoggerInterface $log = null)
@@ -85,7 +84,7 @@ 
      * @param Response      $response
      * @param null|callable $out
      *
-     * @return null|Response
+     * @return Response
      */
     public function __invoke($error, Request $request, Response $response, callable $out = null)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Mouf\Mvc\Splash\Routers;
 
 use Mouf\Mvc\Splash\Controllers\Http500HandlerInterface;
-use Psr\Http\Message\ResponseInterface as Response;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface as Request;
 use Psr\Log\LoggerInterface;

src/Mouf/Mvc/Splash/Routers/PhpVarsCheckRouter.php

Doc Comments +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
     /**
      * Returns the number of bytes from php.ini parameter.
      *
-     * @param $val
+     * @param string $val
      *
      * @return int|string
      */

src/Mouf/Mvc/Splash/Services/FilterUtils.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
  */
 use Mouf\Mvc\Splash\Filters\AbstractFilter;
 use Mouf\MoufManager;
-use Mouf\Mvc\Splash\Controllers\Controller;
 use Mouf\Reflection\MoufReflectionMethod;
 
 class FilterUtils

src/Mouf/Mvc/Splash/Services/SplashCreateControllerService.php

Doc Comments +3 added lines

@@ -441,6 +441,9 @@
         return '<p>Hello {{message}}</p>';
     }
 
+    /**
+     * @param string $controllerFQCN
+     */
     private function generatePhpView($controllerFQCN)
     {
         return '<?php /* @var $this '.$controllerFQCN.' */ ?>

src/Mouf/Mvc/Splash/Services/SplashRequestContext.php

Doc Comments +3 added lines

@@ -61,6 +61,9 @@
         return $this->request;
     }
 
+    /**
+     * @param string $key
+     */
     public function hasParameter($key) : bool
     {
         if (isset($this->urlParameters[$key])) {

src/Mouf/Mvc/Splash/Services/SplashRequestParameterFetcher.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Mouf\Mvc\Splash\Services;
 
 use Mouf\Reflection\MoufReflectionParameter;
-use Mouf\Utils\Common\Validators\ValidatorInterface;
 
 /**
  * This class fetches the parameter from the request.

src/Mouf/Mvc/Splash/Utils/ExceptionUtils.php

Doc Comments +7 added lines, -4 removed lines

@@ -9,7 +9,7 @@ 
      *
      * @param unknown_type $backtrace
      *
-     * @return unknown
+     * @return string
      */
     private static function getHTMLBackTrace($backtrace)
     {
@@ -51,7 +51,7 @@ 
      * Function called to display an exception if it occurs.
      * It will make sure to purge anything in the buffer before calling the exception displayer.
      *
-     * @param Exception $exception
+     * @param \Exception $exception
      */
     public static function getHtmlForException(\Exception $exception)
     {
@@ -87,7 +87,7 @@ 
      * Function called to display an exception if it occurs.
      * It will make sure to purge anything in the buffer before calling the exception displayer.
      *
-     * @param Exception $exception
+     * @param \Exception $exception
      */
     public static function getTextForException(\Exception $exception)
     {
@@ -105,7 +105,7 @@ 
      *
      * @param unknown_type $backtrace
      *
-     * @return unknown
+     * @return string
      */
     private static function getTextBackTrace($backtrace)
     {
@@ -180,6 +180,9 @@ 
         return 'Unknown type variable';
     }
 
+    /**
+     * @return string
+     */
     private static function displayFile($file)
     {
         $realpath = realpath($file);

src/Mouf/Mvc/Splash/Routers/SplashDefaultRouter.php

Unused Use Statements -4 removed lines

@@ -6,17 +6,13 @@
 use Interop\Container\ContainerInterface;
 use Mouf\Mvc\Splash\Services\ParameterFetcher;
 use Mouf\Mvc\Splash\Services\ParameterFetcherRegistry;
-use Mouf\Mvc\Splash\Services\SplashRequestParameterFetcher;
 use Mouf\Mvc\Splash\Services\UrlProviderInterface;
 use Mouf\Mvc\Splash\Utils\SplashException;
 use Psr\Cache\CacheItemPoolInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
-use Mouf\Utils\Cache\CacheInterface;
-use Mouf\MoufManager;
 use Mouf\Mvc\Splash\Store\SplashUrlNode;
 use Psr\Log\LoggerInterface;
-use Mouf\Mvc\Splash\Controllers\WebServiceInterface;
 use Mouf\Mvc\Splash\Services\SplashRequestContext;
 use Mouf\Mvc\Splash\Services\SplashUtils;
 use Psr\Log\NullLogger;