thecodingmachine / magic-query

src/Mouf/Database/MagicQuery/Twig/SqlTwigEnvironmentFactory.php

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 namespace Mouf\Database\MagicQuery\Twig;
 
-use Doctrine\DBAL\Connection;
-
 /**
  * Class in charge of creating the Twig environment
  */

src/Mouf/Database/QueryWriter/Condition/ParamNotAvailableCondition.php

Doc Comments -1 removed lines

@@ -24,7 +24,6 @@
     }
 
     /**
-     * @param string $caller
      */
     public function isOk($parameters = null)
     {

src/SQLParser/Node/NodeFactory.php

Doc Comments +4 added lines, -1 removed lines

@@ -635,6 +635,9 @@ 
         });
     }
 
+    /**
+     * @param \Closure $callback
+     */
     private static function array_map_deep($array, $callback)
     {
         $new = array();
@@ -661,7 +664,7 @@ 
      * @param array       $parameters
      * @param string      $delimiter
      * @param bool|string $wrapInBrackets
-     * @param int|number  $indent
+     * @param integer  $indent
      * @param int         $conditionsMode
      *
      * @return null|string

Spacing +4 added lines, -4 removed lines

@@ -335,7 +335,7 @@ 
             if (!empty($subTree) && !isset($subTree[0])) {
                 $subTree = StatementFactory::toObject($subTree);
             } else {
-                $subTree = array_map(function ($item) {
+                $subTree = array_map(function($item) {
                     if (is_array($item)) {
                         return self::toObject($item);
                     } else {
@@ -365,7 +365,7 @@ 
             array('NOT'),
             array('&&', 'AND'),
             array('XOR'),
-            array('||', 'OR'), );
+            array('||', 'OR'),);
 
     private static $OPERATOR_TO_CLASS = array(
             '=' => 'SQLParser\Node\Equal',
@@ -626,7 +626,7 @@ 
     {
         $instanceDescriptor = $moufManager->createInstance(get_called_class());
 
-        return self::array_map_deep($node, function ($item) use ($moufManager) {
+        return self::array_map_deep($node, function($item) use ($moufManager) {
             if ($item instanceof NodeInterface) {
                 return $item->toInstanceDescriptor($moufManager);
             } else {
@@ -670,7 +670,7 @@ 
     {
         if (is_array($nodes)) {
             $elems = array();
-            array_walk_recursive($nodes, function ($item) use (&$elems, $dbConnection, $indent, $delimiter, $parameters, $conditionsMode) {
+            array_walk_recursive($nodes, function($item) use (&$elems, $dbConnection, $indent, $delimiter, $parameters, $conditionsMode) {
                 if ($item instanceof SqlRenderInterface) {
                     $itemSql = $item->toSql($parameters, $dbConnection, $indent, $conditionsMode);
                     if ($itemSql !== null) {

src/SQLParser/Node/SubQuery.php

Doc Comments +1 added lines, -1 removed lines

@@ -181,7 +181,7 @@
      *
      * @param Connection $dbConnection
      * @param array $parameters
-     * @param number $indent
+     * @param integer $indent
      * @param int $conditionsMode
      *
      * @return string

Unused Use Statements -1 removed lines

@@ -39,7 +39,6 @@
 use SQLParser\Query\Select;
 use Mouf\MoufInstanceDescriptor;
 use Mouf\MoufManager;
-use SQLParser\SqlRenderInterface;
 
 /**
  * This class represents a subquery (and optionally a JOIN .. ON expression in an SQL expression.

src/SQLParser/OracleSQLTranslator.php

Doc Comments +13 added lines

@@ -57,6 +57,9 @@ 
         $this->allTables = array();
     }
 
+    /**
+     * @param string $txt
+     */
     public static function dbgprint($txt)
     {
         if (isset($_ENV['DEBUG'])) {
@@ -95,6 +98,9 @@ 
         return 'DELETE';
     }
 
+    /**
+     * @param string $column
+     */
     public static function getColumnNameFor($column)
     {
         if (strtolower($column) === 'uid') {
@@ -198,6 +204,10 @@ 
         return ($res >= 1);
     }
 
+    /**
+     * @param string $table
+     * @param string $column
+     */
     protected function isCLOBColumn($table, $column)
     {
         $tables = end($this->allTables);
@@ -314,6 +324,9 @@ 
         return 'SELECT '.$sql;
     }
 
+    /**
+     * @param string $sql
+     */
     private function correctColRefStatement($sql)
     {
         $alias = '';

Switch Indentation +8 added lines, -8 removed lines

@@ -368,14 +368,14 @@
     {
         $k = key($parsed);
         switch ($k) {
-        case 'USE':
-        # this statement is not an Oracle statement
-            $this->created = '';
-            break;
-
-        default:
-            $this->created = parent::create($parsed);
-            break;
+            case 'USE':
+            # this statement is not an Oracle statement
+                $this->created = '';
+                break;
+
+            default:
+                $this->created = parent::create($parsed);
+                break;
         }
 
         return $this->created;

src/SQLParser/PHPSQLLexer.php

Doc Comments +4 added lines

@@ -237,6 +237,10 @@
 
     # backticks are not balanced within one token, so we have
     # to re-combine some tokens
+
+    /**
+     * @param integer $idx
+     */
     private function balanceCharacter($tokens, $idx, $char)
     {
         $token_count = count($tokens);

src/SQLParser/PHPSQLParserUtils.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,6 @@ 
     /**
      * Prints an array only if debug mode is on.
      *
-     * @param array $s
      * @param bool  $return, if true, the formatted array is returned via return parameter
      */
     protected function preprint($arr, $return = false)
@@ -80,6 +79,7 @@ 
 
     /**
      * Revokes the escaping characters from an expression.
+     * @param string $sql
      */
     protected function revokeEscaping($sql)
     {

src/SQLParser/PositionCalculator.php

Doc Comments +7 added lines

@@ -73,6 +73,9 @@ 
         return $parsed;
     }
 
+    /**
+     * @param string $sql
+     */
     private function findPositionWithinString($sql, $value, $expr_type)
     {
         $offset = 0;
@@ -130,6 +133,10 @@ 
         return $pos;
     }
 
+    /**
+     * @param integer $charPos
+     * @param integer $key
+     */
     private function lookForBaseExpression($sql, &$charPos, &$parsed, $key, &$backtracking)
     {
         if (!is_numeric($key)) {

Indentation +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 {
     private static $allowedOnOperator = array("\t", "\n", "\r", ' ', ',', '(', ')', '_', "'", '"');
     private static $allowedOnOther = array("\t", "\n", "\r", ' ', ',', '(', ')', '<', '>', '*', '+', '-', '/', '|',
-                                           '&', '=', '!', ';', );
+                                            '&', '=', '!', ';', );
 
     private function printPos($text, $sql, $charPos, $key, $parsed, $backtracking)
     {

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 {
     private static $allowedOnOperator = array("\t", "\n", "\r", ' ', ',', '(', ')', '_', "'", '"');
     private static $allowedOnOther = array("\t", "\n", "\r", ' ', ',', '(', ')', '<', '>', '*', '+', '-', '/', '|',
-                                           '&', '=', '!', ';', );
+                                           '&', '=', '!', ';',);
 
     private function printPos($text, $sql, $charPos, $key, $parsed, $backtracking)
     {

src/SQLParser/Query/Select.php

Doc Comments +1 added lines, -1 removed lines

@@ -277,7 +277,7 @@
      *
      * @param Connection $dbConnection
      * @param array      $parameters
-     * @param number     $indent
+     * @param integer     $indent
      * @param int        $conditionsMode
      *
      * @return string

Spacing +1 added lines, -1 removed lines

@@ -360,7 +360,7 @@
         if ($children) {
             if (is_array($children)) {
                 foreach ($children as $key => $operand) {
-                    if($operand) {
+                    if ($operand) {
                         $result2 = $operand->walk($visitor);
                         if ($result2 === NodeTraverser::REMOVE_NODE) {
                             unset($children[$key]);