TasksCollection - Code Metrics - the-junty/junty-taskrunner - Measure and Improve Code Quality continuously with Scrutinizer

TasksCollection A
last analyzed 2016-04-20 20:55 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Metric	Value
wmc	7
lcom	0
cbo	2
dl	0
loc	38
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
B	set()	0	17	6
A	add()	0	4	1

<?php
/**
 * Junty
 *
 * @author Gabriel Jacinto aka. GabrielJMJ <[email protected]>
 * @license MIT License
 */
 
namespace Junty\TaskRunner\Task;

use Junty\TaskRunner\Task\{Task, TaskInterface};
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Doctrine\Common\Collections\ArrayCollection;

class TasksCollection extends ArrayCollection
{
    /**
     * Registres a task
     *
     * @param string|TaskInterface $key
     * @param callable             $value
     */
    public function set($key, $value)
    {
        if ($value !== null && !is_callable($value)) {
            throw new \InvalidArgumentException('Callback must be callable.');
        }

        if (!is_string($key) && !$key instanceof TaskInterface) {
            throw new \InvalidArgumentException('Pass an instance of TaskInterface or a callback');
        }

        if ($key instanceof TaskInterface) {
            parent::set($key->getName(), $key);
            return;
        }

        parent::set($key, new Task($key, $value));
    }

    /**
     * Invalid method for task registration
     *
     * @param mixed $element
     *
     * @throws \BadMethodCallException
     */
    public function add($element)
    {
        throw new \BadMethodCallException('Use TaskCollection::set to register a task.');
    }
}

1			<?php
2			/**
3			* Junty
4			*
5			* @author Gabriel Jacinto aka. GabrielJMJ <[email protected]>
6			* @license MIT License
7			*/
8
9			namespace Junty\TaskRunner\Task;
10
11			use Junty\TaskRunner\Task\{Task, TaskInterface};
			0 ignored issues – show Bug introduced 2016-04-12 01:30 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Junty\TaskRunner\Task\Task`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history... Bug introduced 2016-04-12 01:30 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Junty\TaskRunner\Task\TaskInterface`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
12			use Doctrine\Common\Collections\ArrayCollection;
13
14			class TasksCollection extends ArrayCollection
15			{
16			/**
17			* Registres a task
18			*
19			* @param string\|TaskInterface $key
20			* @param callable $value
21			*/
22			public function set($key, $value)
23			{
24			if ($value !== null && !is_callable($value)) {
25			throw new \InvalidArgumentException('Callback must be callable.');
26			}
27
28			if (!is_string($key) && !$key instanceof TaskInterface) {
29			throw new \InvalidArgumentException('Pass an instance of TaskInterface or a callback');
30			}
31
32			if ($key instanceof TaskInterface) {
33			parent::set($key->getName(), $key);
34			return;
35			}
36
37			parent::set($key, new Task($key, $value));
38			}
39
40			/**
41			* Invalid method for task registration
42			*
43			* @param mixed $element
44			*
45			* @throws \BadMethodCallException
46			*/
47			public function add($element)
48			{
49			throw new \BadMethodCallException('Use TaskCollection::set to register a task.');
50			}
51			}

the-junty / junty-taskrunner

TasksCollection A last analyzed 2016-04-20 20:55 UTC

Complexity

Size/Duplication

Coupling/Cohesion

2 Methods

Duplication Side-by-Side

Filter issues like

TasksCollection A
last analyzed 2016-04-20 20:55 UTC