the-badger / badger

src/Badger/GameBundle/Doctrine/Repository/QuestRepository.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Badger\TagBundle\Taggable\TaggableInterface;
 use Badger\UserBundle\Entity\UserInterface;
 use Doctrine\DBAL\Connection;
-use Doctrine\ORM\Query;
 use Doctrine\ORM\EntityRepository;
 
 /**

src/Badger/TagBundle/Controller/TagController.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-
 use Badger\TagBundle\Entity\Tag;
 use Badger\TagBundle\Form\TagType;
 use Symfony\Component\HttpFoundation\Response;

src/Badger/GateBundle/GateBundle.php

Indentation -1 removed lines

@@ -5,7 +5,6 @@
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 
 /**
-
  * @license http://opensource.org/licenses/MIT The MIT License (MIT)
  */
 class GateBundle extends Bundle

src/Badger/GameBundle/Notifier/SlackNotifier.php

Spacing +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
         $promise = $client->sendAsync($request, ['timeout' => 10]);
 
         $promise->then(
-            function (ResponseInterface $res) use ($data) {
+            function(ResponseInterface $res) use ($data) {
                 $this->logger->info(
                     sprintf(
                         'Request to SLACK webhook OK [%s] with data: %s',
@@ -58,7 +58,7 @@ 
                     )
                 );
             },
-            function (RequestException $e) {
+            function(RequestException $e) {
                 $this->logger->error(
                     sprintf(
                         'Request to SLACK webhook FAILED with message: %s',

src/Badger/GameBundle/Tests/Controller/AdventureStepCompletionTest.php

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
         $adventureStepCompletion = $adventureStepCompletionRepo->findOneBy(['pending' => 1])->getId();
         $client->request('GET', sprintf('admin/claimed-adventure-step/%s/reject', $adventureStepCompletion));
 
-        $this->assertCount($count-=1, $adventureStepCompletionRepo->findAll(), 'Adventure step has been rejected and deleted');
+        $this->assertCount($count -= 1, $adventureStepCompletionRepo->findAll(), 'Adventure step has been rejected and deleted');
     }
 
     public function testAcceptAction()
@@ -33,7 +33,7 @@ 
         $countAccepted = count($adventureStepCompletionRepo->findBy(['pending' => 0]));
         $client->request('GET', sprintf('admin/claimed-adventure-step/%s/accept', current($adventureStepCompletions)->getId()));
 
-        $this->assertCount($countPending-=1, $adventureStepCompletionRepo->findBy(['pending' => 1]), 'Adventure step has been accepted');
-        $this->assertCount($countAccepted+=1, $adventureStepCompletionRepo->findBy(['pending' => 0]), 'Adventure step has been accepted');
+        $this->assertCount($countPending -= 1, $adventureStepCompletionRepo->findBy(['pending' => 1]), 'Adventure step has been accepted');
+        $this->assertCount($countAccepted += 1, $adventureStepCompletionRepo->findBy(['pending' => 0]), 'Adventure step has been accepted');
     }
 }

src/Badger/GameBundle/Tests/Controller/AdventureControllerTest.php

Spacing +10 added lines, -10 removed lines

@@ -68,8 +68,8 @@ 
             ]
         ]);
 
-        $this->assertCount($adventureCount+=1, $this->adventureRepository->findAll());
-        $this->assertCount($adventureStepsCount+=2, $this->adventureStepRepository->findAll());
+        $this->assertCount($adventureCount += 1, $this->adventureRepository->findAll());
+        $this->assertCount($adventureStepsCount += 2, $this->adventureStepRepository->findAll());
     }
 
     public function testContraintsFormAction()
@@ -108,9 +108,9 @@ 
             'form'    => []
         ]);
 
-        $this->assertCount($adventureCount-=1, $this->adventureRepository->findAll(), 'Adventure is removed');
-        $this->assertCount($adventureStepCount-=2, $this->adventureStepRepository->findAll(), 'Steps of adventure are removed');
-        $this->assertCount($adventureComplRepoCount-=1, $this->adventureComplRepo->findAll(), 'Completions steps of adventure are removed');
+        $this->assertCount($adventureCount -= 1, $this->adventureRepository->findAll(), 'Adventure is removed');
+        $this->assertCount($adventureStepCount -= 2, $this->adventureStepRepository->findAll(), 'Steps of adventure are removed');
+        $this->assertCount($adventureComplRepoCount -= 1, $this->adventureComplRepo->findAll(), 'Completions steps of adventure are removed');
         $this->assertCount($badgeCount, $this->badgeRepository->findAll(), 'Badge are not removed when an adventure is removed');
     }
 
@@ -144,8 +144,8 @@ 
         ]);
 
         $this->assertCount($adventureCount, $this->adventureRepository->findAll(), 'No adventure added or removed');
-        $this->assertCount($adventureStepsCount-=1, $this->adventureStepRepository->findAll(), 'Step deleted');
-        $this->assertCount($adventureCompletionCount-=1, $this->adventureComplRepo->findAll(), 'Adventure Completion linked to deleted step is removed');
+        $this->assertCount($adventureStepsCount -= 1, $this->adventureStepRepository->findAll(), 'Step deleted');
+        $this->assertCount($adventureCompletionCount -= 1, $this->adventureComplRepo->findAll(), 'Adventure Completion linked to deleted step is removed');
     }
 
     public function testDeleteWhenStepsAreLinkedToBadges()
@@ -163,9 +163,9 @@ 
             'form'    => []
         ]);
 
-        $this->assertCount($adventureCount-=1, $this->adventureRepository->findAll(), 'Adventure is removed');
-        $this->assertCount($adventureStepCount-=4, $this->adventureStepRepository->findAll(), 'Steps of adventure are removed');
-        $this->assertCount($adventureComplRepoCount-=2, $this->adventureComplRepo->findAll(), 'Completions steps of adventure are removed');
+        $this->assertCount($adventureCount -= 1, $this->adventureRepository->findAll(), 'Adventure is removed');
+        $this->assertCount($adventureStepCount -= 4, $this->adventureStepRepository->findAll(), 'Steps of adventure are removed');
+        $this->assertCount($adventureComplRepoCount -= 2, $this->adventureComplRepo->findAll(), 'Completions steps of adventure are removed');
         $this->assertCount($badgeCount, $this->badgeRepository->findAll(), 'Badge are not removed when an adventure is removed');
     }
 }

src/Badger/GameBundle/Tests/Controller/BadgeControllerTest.php

Spacing +5 added lines, -5 removed lines

@@ -32,7 +32,7 @@ 
         $badge = $this->get('badger.game.repository.badge')->findOneBy(['title' => 'Master Contributor']);
         $this->deleteBadge($client, $badge->getId());
 
-        $this->assertCount($count-=1, $this->get('badger.game.repository.badge')->findAll());
+        $this->assertCount($count -= 1, $this->get('badger.game.repository.badge')->findAll());
     }
 
     public function testDeleteWhenBadgeHasBeenClaimed()
@@ -45,8 +45,8 @@ 
         $badge = $this->get('badger.game.repository.badge')->findOneBy(['title' => 'Bug Hunter']);
         $this->deleteBadge($client, $badge->getId());
 
-        $this->assertCount($countBadge-=1, $this->get('badger.game.repository.badge')->findAll(), 'Badge is removed');
-        $this->assertCount($countClaimedBadge-=1, $this->get('badger.game.repository.claimed_badge')->findAll(), 'Claimed badge is removed');
+        $this->assertCount($countBadge -= 1, $this->get('badger.game.repository.badge')->findAll(), 'Badge is removed');
+        $this->assertCount($countClaimedBadge -= 1, $this->get('badger.game.repository.claimed_badge')->findAll(), 'Claimed badge is removed');
     }
 
     public function testDeleteWhenBadgeHasBeenUnlocked()
@@ -59,8 +59,8 @@ 
         $badge = $this->get('badger.game.repository.badge')->findOneBy(['title' => 'ASS Disruptor']);
         $this->deleteBadge($client, $badge->getId());
 
-        $this->assertCount($countBadge-=1, $this->get('badger.game.repository.badge')->findAll(), 'Badge is removed');
-        $this->assertCount($countUnlockedBadge-=1, $this->get('badger.game.repository.unlocked_badge')->findAll(), 'Unlocked badge is removed');
+        $this->assertCount($countBadge -= 1, $this->get('badger.game.repository.badge')->findAll(), 'Badge is removed');
+        $this->assertCount($countUnlockedBadge -= 1, $this->get('badger.game.repository.unlocked_badge')->findAll(), 'Unlocked badge is removed');
     }
 
     /**

src/Badger/GameBundle/Tests/Unlocker/BadgeUnlockerTest.php

Spacing +3 added lines, -3 removed lines

@@ -19,7 +19,7 @@ 
 
         $this->get('badger.game.unlocker.badge')->unlockBadge($user, $badge);
 
-        $this->assertCount($count+=1, $this->get('badger.game.repository.unlocked_badge')->getUnlockedBadgeIdsByUser($user));
+        $this->assertCount($count += 1, $this->get('badger.game.repository.unlocked_badge')->getUnlockedBadgeIdsByUser($user));
     }
 
     public function testUnlockBadgeWhenUserHasAlreadyTheBadge()
@@ -44,7 +44,7 @@ 
 
         $this->get('badger.game.unlocker.badge')->unlockBadgeFromClaim(current($claimedBadges));
 
-        $this->assertCount($count-=1, $this->get('badger.game.repository.claimed_badge')->findAll(), 'Claimed badge has been removed');
-        $this->assertCount($countBadges+=1, $this->get('badger.game.repository.unlocked_badge')->getUnlockedBadgeIdsByUser($user), 'Badge has been added');
+        $this->assertCount($count -= 1, $this->get('badger.game.repository.claimed_badge')->findAll(), 'Claimed badge has been removed');
+        $this->assertCount($countBadges += 1, $this->get('badger.game.repository.unlocked_badge')->getUnlockedBadgeIdsByUser($user), 'Badge has been added');
     }
 }

src/Badger/GameBundle/Entity/Quest.php

Spacing +1 added lines, -1 removed lines

@@ -181,7 +181,7 @@
      */
     public function getApprovedCompletionsCount()
     {
-        return $this->completions->filter(function ($completion) {
+        return $this->completions->filter(function($completion) {
             return !$completion->isPending();
         })->count();
     }