tfboe / fm-lib

src/Entity/Helpers/SubClassData.php

Doc Comments +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
   /**
    * Adds an subclass property if it is not already existent. The default value is used as value.
    * @param string $name the property name
-   * @param mixed $default the default value for the property
+   * @param string|null $default the default value for the property
    * @return $this|SubClassData
    */
   public function addPropertyIfNotExistent(string $name, $default)

src/Entity/Helpers/SubClassDataInterface.php

Doc Comments +4 added lines, -3 removed lines

@@ -23,13 +23,14 @@ 
    * Adds an subclass property if it is not already existent. The default value is used as value.
    * @param string $name the property name
    * @param mixed $default the default value for the property
-   * @return $this|SubClassData
+   * @return SubClassData
    */
   public function addPropertyIfNotExistent(string $name, $default);
 
   /**
    * clones the subclass data from other into this
    * @param SubClassData $other
+   * @return void
    */
   public function cloneSubClassDataFrom($other);
 
@@ -51,7 +52,7 @@ 
   /**
    * Initializes the subclassData structure and adds the given keys with null values to it.
    * @param string[] $keys the keys of the subclass data properties (the names).
-   * @return $this|SubClassData
+   * @return SubClassData
    */
   public function initSubClassData(array $keys);
 
@@ -66,7 +67,7 @@ 
    * Sets a property with the given name and the given value
    * @param string $name the name of the property to set
    * @param mixed $value the new value for the property
-   * @return $this|SubClassData
+   * @return SubClassData
    * @throws PropertyNotExistingException
    */
   public function setProperty(string $name, $value);

src/Service/RankingSystem/EloRanking.php

Doc Comments +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
 //<editor-fold desc="Private Methods">
   /**
    * @param RankingSystemChangeInterface[] $changes
-   * @param Collection|PlayerInterface[] $players
+   * @param Collection $players
    * @param TournamentHierarchyEntity $entity
    * @param RankingSystemInterface $ranking
    */

src/Service/RankingSystem/RankingSystemService.php

Doc Comments +1 added lines, -1 removed lines

@@ -214,7 +214,7 @@
   }
 
   /**
-   * @param Collection|PlayerInterface[] $players
+   * @param Collection $players
    * @param RankingSystemListInterface $list
    * @return RankingSystemListEntryInterface[] $entries
    */

tests/Unit/Service/RankingSystem/RankingSystemServiceTest.php

Doc Comments +1 added lines

@@ -1223,6 +1223,7 @@
    * prepares a new ranking system service for update ranking from
    * @param MockObject $ranking the ranking entity
    * @param EntityManagerInterface|null $entityManager the entity manager or null if a mock should be used
+   * @param MockObject[] $listsArray
    * @return RankingSystemService
    */
   private function prepareUpdateRankingFrom(MockObject $ranking, ?EntityManagerInterface $entityManager = null,

src/Service/LoadingService.php

Doc Comments +1 added lines, -1 removed lines

@@ -151,7 +151,7 @@
    * Computes the key corresponding to the given entity in the given property map, or null if no key was found.
    * @param mixed $entity the entity to search the key for
    * @param string[][][] $propertyMap a property map which maps classes to lists of groups of properties to fetch
-   * @return null|string
+   * @return integer|null
    */
   private function keyOfPropertyMap($entity, $propertyMap): ?string
   {

src/Providers/FmLibServiceProvider.php

Unused Use Statements -2 removed lines

@@ -21,8 +21,6 @@
 use Tfboe\FmLib\Entity\Helpers\UTCDateTimeType;
 use Tfboe\FmLib\Exceptions\Handler;
 use Tfboe\FmLib\Http\Middleware\Authenticate;
-use Tfboe\FmLib\Service\DeletionService;
-use Tfboe\FmLib\Service\DeletionServiceInterface;
 use Tfboe\FmLib\Service\DynamicServiceLoadingService;
 use Tfboe\FmLib\Service\DynamicServiceLoadingServiceInterface;
 use Tfboe\FmLib\Service\LoadingService;

tests/Unit/Service/PlayerServiceTest.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Tfboe\FmLib\Entity\TeamInterface;
 use Tfboe\FmLib\Entity\TeamMembershipInterface;
 use Tfboe\FmLib\Entity\TournamentInterface;
-use Tfboe\FmLib\Service\DeletionServiceInterface;
 use Tfboe\FmLib\Service\LoadingServiceInterface;
 use Tfboe\FmLib\Service\PlayerService;
 use Tfboe\FmLib\Service\RankingSystemServiceInterface;