Tfboe\FmLib\Exceptions\ValueNotValid::__construct()

Complexity

Conditions	3
Paths	2

Size

Total Lines

12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
  public function __construct($value, ?string $enumName = null, string $valueFunction = "getValues")
  {
    $message = "The following value is not valid: " . json_encode($value);
    if ($enumName != null && method_exists($enumName, $valueFunction)) {

It seems like you are loosely comparing $enumName of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

      /** @var mixed[] $values */
      $values = call_user_func([$enumName, $valueFunction]);
      assert(!in_array($value, $values, true));
      $message .= " in " . $enumName . ". Possible values: " .
        implode(', ', array_map("json_encode", $values)) . ".";
    }
    parent::__construct($message);
  }
//</editor-fold desc="Constructor">
}