Tfboe\FmLib\Exceptions\ValueNotValid

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	3

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: benedikt
 * Date: 9/15/17
 * Time: 11:18 PM
 */

namespace Tfboe\FmLib\Exceptions;

/**
 * Class AuthenticationException
 * @package Tfboe\FmLib\Exceptions
 */
class ValueNotValid extends AbstractException
{
//<editor-fold desc="Constructor">
  /**
   * @param mixed $value
   * @param string|null $enumName the corresponding enum class name or null
   * @param string $valueFunction the function to call on the enum class to get the list of possible values
   */
  public function __construct($value, ?string $enumName = null, string $valueFunction = "getValues")
  {
    $message = "The following value is not valid: " . json_encode($value);
    if ($enumName != null && method_exists($enumName, $valueFunction)) {

It seems like you are loosely comparing $enumName of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

      /** @var mixed[] $values */
      $values = call_user_func([$enumName, $valueFunction]);
      assert(!in_array($value, $values, true));
      $message .= " in " . $enumName . ". Possible values: " .
        implode(', ', array_map("json_encode", $values)) . ".";
    }
    parent::__construct($message);
  }
//</editor-fold desc="Constructor">
}