tenside / core

src/Console/Application.php

Unused Use Statements +4 added lines, -4 removed lines

@@ -22,19 +22,19 @@
 
 use Composer\Command as ComposerCommand;
 use Composer\Command\ScriptAliasCommand;
+use Composer\Factory as ComposerFactory;
+use Composer\IO\ConsoleIO;
 use Composer\IO\IOInterface;
 use Psr\Log\LoggerInterface;
 use Symfony\Bundle\FrameworkBundle\Console\Shell;
 use Symfony\Component\Console\Application as SymfonyApplication;
-use Composer\IO\ConsoleIO;
 use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Formatter\OutputFormatter;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\BufferedOutput;
-use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Output\ConsoleOutput;
-use Symfony\Component\Console\Formatter\OutputFormatter;
-use Composer\Factory as ComposerFactory;
+use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 use Symfony\Component\HttpKernel\Kernel;

Spacing +1 added lines, -1 removed lines

@@ -250,7 +250,7 @@
         // Add non-standard scripts as own commands - keep this last to ensure we do not override internal commands.
         if ($file->has('scripts')) {
             foreach (array_keys($file->get('scripts')) as $script) {
-                if (!defined('Composer\Script\ScriptEvents::'.str_replace('-', '_', strtoupper($script)))) {
+                if (!defined('Composer\Script\ScriptEvents::' . str_replace('-', '_', strtoupper($script)))) {
                     if ($this->has($script)) {
                         $output->writeln(
                             sprintf(

src/CoreBundle/Command/SelfUpdateCommand.php

Doc Comments +2 added lines, -2 removed lines

@@ -281,7 +281,7 @@ 
      *
      * @param string $newFilename   The new file name.
      *
-     * @param null   $backupTarget  The backup file name.
+     * @param string   $backupTarget  The backup file name.
      *
      * @return \UnexpectedValueException|\PharException|null
      *
@@ -329,7 +329,7 @@ 
      *
      * @param string $rollbackDir The directory where the rollback files are contained within.
      *
-     * @return bool|string
+     * @return string|false
      */
     protected function getLastBackupVersion($rollbackDir)
     {

Unused Use Statements +2 added lines, -2 removed lines

@@ -21,13 +21,13 @@
 namespace Tenside\CoreBundle\Command;
 
 use Composer\Command\Command;
+use Composer\Downloader\FilesystemException;
 use Composer\Factory;
 use Composer\Util\Filesystem;
 use Composer\Util\RemoteFilesystem;
-use Composer\Downloader\FilesystemException;
+use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
 use Symfony\Component\DependencyInjection\ContainerAwareTrait;

Spacing +5 added lines, -5 removed lines

@@ -133,7 +133,7 @@ 
             );
         }
         if (!is_writable($localFilename)) {
-            throw new FilesystemException('Self update failed: the "'.$localFilename.'" file could not be written');
+            throw new FilesystemException('Self update failed: the "' . $localFilename . '" file could not be written');
         }
 
         if ($input->getOption('rollback')) {
@@ -157,7 +157,7 @@ 
             return 0;
         }
 
-        $tempFilename = $tmpDir . '/' . basename($localFilename, '.phar').'-temp.phar';
+        $tempFilename = $tmpDir . '/' . basename($localFilename, '.phar') . '-temp.phar';
         $backupFile   = sprintf(
             '%s/%s-%s%s',
             $rollbackDir,
@@ -183,7 +183,7 @@ 
         }
 
         if ($err = $this->setLocalPhar($localFilename, $tempFilename, $backupFile)) {
-            $inputOutput->writeError('<error>The file is corrupted ('.$err->getMessage().').</error>');
+            $inputOutput->writeError('<error>The file is corrupted (' . $err->getMessage() . ').</error>');
             $inputOutput->writeError('<error>Please re-run the self-update command to try again.</error>');
 
             return 1;
@@ -249,10 +249,10 @@ 
         $old = $rollbackDir . '/' . $rollbackVersion . self::OLD_INSTALL_EXT;
 
         if (!is_file($old)) {
-            throw new FilesystemException('Composer rollback failed: "'.$old.'" could not be found');
+            throw new FilesystemException('Composer rollback failed: "' . $old . '" could not be found');
         }
         if (!is_readable($old)) {
-            throw new FilesystemException('Composer rollback failed: "'.$old.'" could not be read');
+            throw new FilesystemException('Composer rollback failed: "' . $old . '" could not be read');
         }
 
         $oldFile     = sprintf('%s/"%s"', $rollbackDir, $rollbackVersion, self::OLD_INSTALL_EXT);

src/CoreBundle/Controller/PackageController.php

Unused Use Statements -1 removed lines

@@ -29,7 +29,6 @@
 use Composer\Repository\RepositoryInterface;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\NotAcceptableHttpException;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Tenside\Composer\PackageConverter;

src/CoreBundle/Controller/SearchPackageController.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -27,8 +27,8 @@
 use Composer\Repository\RepositoryInterface;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
-use Tenside\Composer\Package\VersionedPackage;
 use Tenside\Composer\PackageConverter;
+use Tenside\Composer\Package\VersionedPackage;
 use Tenside\Composer\Search\CompositeSearch;
 use Tenside\Composer\Search\RepositorySearch;
 use Tenside\Util\JsonArray;

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
         $filters = [];
         if ('contao' === $data->get('type')) {
             $filters[] =
-                function ($package) {
+                function($package) {
                     /** @var PackageInterface $package */
                     return in_array($package->getType(), ['contao-module', 'contao-bundle', 'legacy-contao-module']);
                 };

src/CoreBundle/Security/JavascriptWebToken.php

Doc Comments +2 added lines, -2 removed lines

@@ -49,9 +49,9 @@
      *
      * @param string                   $providerKey The provider key
      *
-     * @param string|object            $user        The user
+     * @param \Symfony\Component\Security\Core\User\UserInterface            $user        The user
      *
-     * @param RoleInterface[]|string[] $roles       An array of roles
+     * @param \Symfony\Component\Security\Core\Role\Role[] $roles       An array of roles
      *
      * @throws \InvalidArgumentException When the provider key is empty.
      */

src/CoreBundle/Security/JWTAuthenticator.php

Doc Comments +3 added lines, -3 removed lines

@@ -66,7 +66,7 @@ 
      *
      * @param UserInformationInterface $userData The user data to issue a token for.
      *
-     * @param int|null                 $lifetime The lifetime in seconds this token shall be valid.
+     * @param integer                 $lifetime The lifetime in seconds this token shall be valid.
      *                                           Use null for no limit.
      *
      * @return string
@@ -187,7 +187,7 @@ 
      *
      * @param string $jwt The jwt as string.
      *
-     * @return object
+     * @return string
      *
      * @throws \UnexpectedValueException When the token does not match the local id.
      */
@@ -210,7 +210,7 @@ 
      *
      * @param null|array $customPayload Any custom payload to be added to the token.
      *
-     * @param int|null   $lifetime      The lifetime in seconds this token shall be valid. Use null for no limit.
+     * @param integer   $lifetime      The lifetime in seconds this token shall be valid. Use null for no limit.
      *
      * @return string
      */

src/CoreBundle/Security/UserInformation.php

Doc Comments +1 added lines, -1 removed lines

@@ -145,7 +145,7 @@
     /**
      * Get the granted access levels.
      *
-     * @return int
+     * @return string|null
      */
     public function getAccessLevel()
     {

Spacing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
     public function getRoles()
     {
         $user       = $this;
-        $comparator = function ($level) use ($user) {
+        $comparator = function($level) use ($user) {
             return $user->hasAccessLevel($level);
         };
 

src/Task/AbstractComposerCommandTask.php

Doc Comments +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
      *
      * @param Command $command The command to patch.
      *
-     * @return Command
+     * @return WrappedCommandTrait
      *
      * @throws \InvalidArgumentException When no setComposerFactory method is declared.
      */

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
 
         /** @var WrappedCommandTrait $command */
         $command->setComposerFactory(
-            function () {
+            function() {
                 return Factory::create($this->getIO());
             }
         );

src/Task/TaskList.php

Doc Comments +1 added lines, -1 removed lines

@@ -196,7 +196,7 @@
      *
      * @param JsonArray $config The configuration of the task.
      *
-     * @return Task|null
+     * @return Task
      */
     private function createTaskFromMetaData(JsonArray $config)
     {