Completed
Pull Request — master (#2)
by Tim
03:25
created
src/Services/ProductUrlRewriteProcessor.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -79,10 +79,10 @@  discard block
 block discarded – undo
79 79
      *
80 80
      * @param \TechDivision\Import\Connection\ConnectionInterface                           $connection                          The connection to use
81 81
      * @param \TechDivision\Import\Product\Repositories\ProductVarcharRepository            $productVarcharRepository            The product varchar repository to use
82
-     * @param \TechDivision\Import\Product\Repositories\UrlRewriteRepository                $urlRewriteRepository                The URL rewrite repository to use
83
-     * @param \TechDivision\Import\Product\Repositories\UrlRewriteProductCategoryRepository $urlRewriteProductCategoryRepository The URL rewrite product category repository to use
82
+     * @param UrlRewriteRepository                $urlRewriteRepository                The URL rewrite repository to use
83
+     * @param UrlRewriteProductCategoryRepository $urlRewriteProductCategoryRepository The URL rewrite product category repository to use
84 84
      * @param \TechDivision\Import\Actions\UrlRewriteAction                                 $urlRewriteAction                    The URL rewrite action to use
85
-     * @param \TechDivision\Import\Product\Actions\UrlRewriteProductCategoryAction          $urlRewriteProductCategoryAction     The URL rewrite product category action to use
85
+     * @param UrlRewriteProductCategoryAction          $urlRewriteProductCategoryAction     The URL rewrite product category action to use
86 86
      */
87 87
     public function __construct(
88 88
         ConnectionInterface $connection,
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
      * Commits a transaction, returning the database connection to autocommit mode until the next call to
141 141
      * ProductProcessor::beginTransaction() starts a new transaction.
142 142
      *
143
-     * @return boolean Returns TRUE on success or FALSE on failure
143
+     * @return boolean|null Returns TRUE on success or FALSE on failure
144 144
      * @link http://php.net/manual/en/pdo.commit.php
145 145
      */
146 146
     public function commit()
Please login to merge, or discard this patch.
src/Observers/UrlRewriteObserver.php 2 patches
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -155,14 +155,14 @@  discard block
 block discarded – undo
155 155
         if ($this->storeViewHasBeenProcessed($sku, $storeViewCode)) {
156 156
             // log a message
157 157
             $this->getSubject()
158
-                 ->getSystemLogger()
159
-                 ->warning(
160
-                     sprintf(
161
-                         'URL rewrites for SKU "%s" + store view code "%s" has already been processed',
162
-                         $sku,
163
-                         $storeViewCode
164
-                     )
165
-                 );
158
+                    ->getSystemLogger()
159
+                    ->warning(
160
+                        sprintf(
161
+                            'URL rewrites for SKU "%s" + store view code "%s" has already been processed',
162
+                            $sku,
163
+                            $storeViewCode
164
+                        )
165
+                    );
166 166
 
167 167
             // return immediately
168 168
             return;
@@ -306,8 +306,8 @@  discard block
 block discarded – undo
306 306
                 $this->productCategoryIds[$categoryId] = $entityId;
307 307
             } else {
308 308
                 $this->getSubject()
309
-                     ->getSystemLogger()
310
-                     ->debug(sprintf('Don\'t create URL rewrite for category "%s" because of missing anchor flag', $category[MemberNames::PATH]));
309
+                        ->getSystemLogger()
310
+                        ->debug(sprintf('Don\'t create URL rewrite for category "%s" because of missing anchor flag', $category[MemberNames::PATH]));
311 311
             }
312 312
         }
313 313
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
     /**
117 117
      * Return's the product bunch processor instance.
118 118
      *
119
-     * @return \TechDivision\Import\Product\Services\ProductBunchProcessorInterface The product bunch processor instance
119
+     * @return ProductUrlRewriteProcessorInterface The product bunch processor instance
120 120
      */
121 121
     protected function getProductUrlRewriteProcessor()
122 122
     {
Please login to merge, or discard this patch.
RoboFile.php 1 patch
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -60,9 +60,9 @@  discard block
 block discarded – undo
60 60
     {
61 61
         // optimize autoloader with custom path
62 62
         $this->taskComposerInstall()
63
-             ->preferDist()
64
-             ->optimizeAutoloader()
65
-             ->run();
63
+                ->preferDist()
64
+                ->optimizeAutoloader()
65
+                ->run();
66 66
     }
67 67
 
68 68
     /**
@@ -74,9 +74,9 @@  discard block
 block discarded – undo
74 74
     {
75 75
         // optimize autoloader with custom path
76 76
         $this->taskComposerUpdate()
77
-             ->preferDist()
78
-             ->optimizeAutoloader()
79
-             ->run();
77
+                ->preferDist()
78
+                ->optimizeAutoloader()
79
+                ->run();
80 80
     }
81 81
 
82 82
     /**
@@ -97,10 +97,10 @@  discard block
 block discarded – undo
97 97
     public function prepare()
98 98
     {
99 99
         $this->taskFileSystemStack()
100
-             ->mkdir($this->properties['dist.dir'])
101
-             ->mkdir($this->properties['target.dir'])
102
-             ->mkdir(sprintf('%s/reports', $this->properties['target.dir']))
103
-             ->run();
100
+                ->mkdir($this->properties['dist.dir'])
101
+                ->mkdir($this->properties['target.dir'])
102
+                ->mkdir(sprintf('%s/reports', $this->properties['target.dir']))
103
+                ->run();
104 104
     }
105 105
 
106 106
     /**
@@ -170,8 +170,8 @@  discard block
 block discarded – undo
170 170
 
171 171
         // run PHPUnit
172 172
         $this->taskPHPUnit(sprintf('%s/bin/phpunit', $this->properties['vendor.dir']))
173
-             ->configFile('phpunit.xml')
174
-             ->run();
173
+                ->configFile('phpunit.xml')
174
+                ->run();
175 175
     }
176 176
 
177 177
     /**
Please login to merge, or discard this patch.