techdivision / import-configuration-jms

src/Configuration/Operation.php

Spacing +1 added lines, -1 removed lines

@@ -76,7 +76,7 @@
 
         // create an empty collection if no plugins has been specified
         if ($this->plugins === null) {
-            $this->plugins= new ArrayCollection();
+            $this->plugins = new ArrayCollection();
         }
     }
 

src/Configuration/Subject/FileResolver.php

Doc Comments +1 added lines, -1 removed lines

@@ -179,7 +179,7 @@
     /**
      * Return's the elements the filenames consists of.
      *
-     * @return array The array with the filename elements
+     * @return string The array with the filename elements
      */
     public function getPatternElements()
     {

RoboFile.php

Unused Use Statements -4 removed lines

@@ -18,10 +18,6 @@
  * @link      http://www.techdivision.com
  */
 
-use Lurker\Event\FilesystemEvent;
-
-use Symfony\Component\Finder\Finder;
-
 /**
  * Defines the available build tasks.
  *

src/Configuration/Plugin.php

Doc Comments +2 added lines, -2 removed lines

@@ -164,7 +164,7 @@ 
     /**
      * Return's the reference to the configuration instance.
      *
-     * @return \TechDivision\Import\ConfigurationInterface The configuration instance
+     * @return string The configuration instance
      */
     public function getConfiguration()
     {
@@ -248,7 +248,7 @@ 
     /**
      * Set's the configuration of the operation the plugin has been configured for.
      *
-     * @param \\TechDivision\Import\Configuration\OperationConfigurationInterface $operationConfiguration The operation configuration
+     * @param OperationConfigurationInterface $operationConfiguration The operation configuration
      *
      * @return void
      */

src/ConfigurationFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
      * @param string $params      A serialized string with additional params that'll be passed to the configuration
      * @param string $paramsFile  A filename that contains serialized data with additional params that'll be passed to the configuration
      *
-     * @return void
+     * @return \TechDivision\Import\ConfigurationInterface
      */
     public function factoryFromDirectories(array $directories = array(), $format = 'json', $params = null, $paramsFile = null)
     {

src/ConfigurationParserFactory.php

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
 
         // query whether or not a configuration parser mapping is available
         if (isset($this->parserMappings[$format])) {
-            return $this->container->get( $this->parserMappings[$format]);
+            return $this->container->get($this->parserMappings[$format]);
         }
 
         // throw an exception, if NO mapping for the passed format has been available

src/Serializer/Serializer.php

Doc Comments +3 added lines

@@ -187,6 +187,9 @@
         ->get();
     }
 
+    /**
+     * @param string $format
+     */
     private function visit(VisitorInterface $visitor, Context $context, $data, $format, array $type = null)
     {
         $context->initialize(

Spacing +3 added lines, -3 removed lines

@@ -89,7 +89,7 @@ 
 
     public function serialize($data, $format, SerializationContext $context = null)
     {
-        if ( ! $this->serializationVisitors->containsKey($format)) {
+        if (!$this->serializationVisitors->containsKey($format)) {
             throw new UnsupportedFormatException(sprintf('The format "%s" is not supported for serialization.', $format));
         }
 
@@ -112,7 +112,7 @@ 
 
     public function deserialize($data, $type, $format, DeserializationContext $context = null)
     {
-        if ( ! $this->deserializationVisitors->containsKey($format)) {
+        if (!$this->deserializationVisitors->containsKey($format)) {
             throw new UnsupportedFormatException(sprintf('The format "%s" is not supported for deserialization.', $format));
         }
 
@@ -155,7 +155,7 @@ 
         ->map(function(JsonSerializationVisitor $visitor) use ($context, $data) {
             $this->visit($visitor, $context, $data, 'json');
             $result = $this->convertArrayObjects($visitor->getRoot());
-            if ( ! is_array($result)) {
+            if (!is_array($result)) {
                 throw new RuntimeException(sprintf(
                     'The input data of type "%s" did not convert to an array, but got a result of type "%s".',
                     is_object($data) ? get_class($data) : gettype($data),

src/Serializer/SerializerBuilder.php

Spacing +13 added lines, -13 removed lines

@@ -97,10 +97,10 @@ 
     }
     public function setCacheDir($dir)
     {
-        if ( ! is_dir($dir)) {
+        if (!is_dir($dir)) {
             $this->createDir($dir);
         }
-        if ( ! is_writable($dir)) {
+        if (!is_writable($dir)) {
             throw new InvalidArgumentException(sprintf('The cache directory "%s" is not writable.', $dir));
         }
         $this->cacheDir = $dir;
@@ -200,7 +200,7 @@ 
     public function setMetadataDirs(array $namespacePrefixToDirMap)
     {
         foreach ($namespacePrefixToDirMap as $dir) {
-            if ( ! is_dir($dir)) {
+            if (!is_dir($dir)) {
                 throw new InvalidArgumentException(sprintf('The directory "%s" does not exist.', $dir));
             }
         }
@@ -235,7 +235,7 @@ 
      */
     public function addMetadataDir($dir, $namespacePrefix = '')
     {
-        if ( ! is_dir($dir)) {
+        if (!is_dir($dir)) {
             throw new InvalidArgumentException(sprintf('The directory "%s" does not exist.', $dir));
         }
         if (isset($this->metadataDirs[$namespacePrefix])) {
@@ -271,10 +271,10 @@ 
      */
     public function replaceMetadataDir($dir, $namespacePrefix = '')
     {
-        if ( ! is_dir($dir)) {
+        if (!is_dir($dir)) {
             throw new InvalidArgumentException(sprintf('The directory "%s" does not exist.', $dir));
         }
-        if ( ! isset($this->metadataDirs[$namespacePrefix])) {
+        if (!isset($this->metadataDirs[$namespacePrefix])) {
             throw new InvalidArgumentException(sprintf('There is no directory configured for namespace prefix "%s". Please use addMetadataDir() for adding new directories.', $namespacePrefix));
         }
         $this->metadataDirs[$namespacePrefix] = $dir;
@@ -290,24 +290,24 @@ 
         if (null === $annotationReader) {
             $annotationReader = new AnnotationReader();
             if (null !== $this->cacheDir) {
-                $this->createDir($this->cacheDir.'/annotations');
-                $annotationReader = new FileCacheReader($annotationReader, $this->cacheDir.'/annotations', $this->debug);
+                $this->createDir($this->cacheDir . '/annotations');
+                $annotationReader = new FileCacheReader($annotationReader, $this->cacheDir . '/annotations', $this->debug);
             }
         }
         $metadataDriver = $this->driverFactory->createDriver($this->metadataDirs, $annotationReader);
         $metadataFactory = new MetadataFactory($metadataDriver, null, $this->debug);
         $metadataFactory->setIncludeInterfaces($this->includeInterfaceMetadata);
         if (null !== $this->cacheDir) {
-            $this->createDir($this->cacheDir.'/metadata');
-            $metadataFactory->setCache(new FileCache($this->cacheDir.'/metadata'));
+            $this->createDir($this->cacheDir . '/metadata');
+            $metadataFactory->setCache(new FileCache($this->cacheDir . '/metadata'));
         }
-        if ( ! $this->handlersConfigured) {
+        if (!$this->handlersConfigured) {
             $this->addDefaultHandlers();
         }
-        if ( ! $this->listenersConfigured) {
+        if (!$this->listenersConfigured) {
             $this->addDefaultListeners();
         }
-        if ( ! $this->visitorsAdded) {
+        if (!$this->visitorsAdded) {
             $this->addDefaultSerializationVisitors();
             $this->addDefaultDeserializationVisitors();
         }

src/Parsers/JsonParser.php

Doc Comments +1 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
      *
      * @param array $directories An array with diretories to parse
      *
-     * @return void
+     * @return string
      * @throws \Exception Is thrown if the configuration can not be loaded from the configuration files
      */
     public function parse(array $directories)
@@ -113,7 +113,6 @@ 
      * List the filenames of a directory.
      *
      * @param string  $directory The directory to list
-     * @param boolean $recursive Whether to list recursively
      *
      * @return array A list of filenames
      */

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 
 namespace TechDivision\Import\Configuration\Jms\Parsers;
 
-use TechDivision\Import\Adapter\PhpFilesystemAdapterInterface;
 use TechDivision\Import\Configuration\Jms\Utils\ArrayUtilInterface;
 use TechDivision\Import\Configuration\Jms\ConfigurationParserInterface;
 

Spacing +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
         $files = glob($pattern = sprintf('%s/%s', $directory, $suffix), 0);
 
         // parse the subdirectories also
-        $dirs = glob($directory. DIRECTORY_SEPARATOR . '*', GLOB_ONLYDIR|GLOB_NOSORT|GLOB_BRACE);
+        $dirs = glob($directory . DIRECTORY_SEPARATOR . '*', GLOB_ONLYDIR | GLOB_NOSORT | GLOB_BRACE);
 
         // iterate over the subdirectories for its files
         foreach ($dirs as $dir) {