Completed
Pull Request — master (#74)
by Tim
03:07 queued 01:31
created
src/Observers/UrlRewriteUpdateObserver.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 
100 100
                 // skip update of URL rewrite, if nothing to change
101 101
                 if ($targetPath === $existingUrlRewrite[MemberNames::TARGET_PATH] &&
102
-                    301 === (int)$existingUrlRewrite[MemberNames::REDIRECT_TYPE]) {
102
+                    301 === (int) $existingUrlRewrite[MemberNames::REDIRECT_TYPE]) {
103 103
                     // stop processing the URL rewrite
104 104
                     continue;
105 105
                 }
Please login to merge, or discard this patch.
src/Subjects/BunchSubject.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
     {
228 228
 
229 229
         // explode the path of the root category
230
-        list ($rootCategoryPath, ) = explode('/', $path);
230
+        list ($rootCategoryPath,) = explode('/', $path);
231 231
 
232 232
         // query whether or not a root category with the given path exists
233 233
         if ($rootCategory = $this->getCategoryByPath($rootCategoryPath)) {
@@ -295,9 +295,9 @@  discard block
 block discarded – undo
295 295
      */
296 296
     public function isUrlKeyOf(array $urlRewrite)
297 297
     {
298
-        return ((integer) $urlRewrite[MemberNames::ENTITY_ID]      === (integer) $this->getLastEntityId()) &&
299
-               ((integer) $urlRewrite[MemberNames::STORE_ID]       === (integer) $this->getRowStoreId()) &&
300
-               ((integer) $urlRewrite[MemberNames::REDIRECT_TYPE]  === 0);
298
+        return ((integer) $urlRewrite[MemberNames::ENTITY_ID] === (integer) $this->getLastEntityId()) &&
299
+               ((integer) $urlRewrite[MemberNames::STORE_ID] === (integer) $this->getRowStoreId()) &&
300
+               ((integer) $urlRewrite[MemberNames::REDIRECT_TYPE] === 0);
301 301
     }
302 302
 
303 303
     /**
Please login to merge, or discard this patch.
src/Observers/UrlKeyAndPathObserver.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -288,7 +288,7 @@
 block discarded – undo
288 288
      *
289 289
      * @param \TechDivision\Import\Subjects\UrlKeyAwareSubjectInterface $subject  The subject to make the URL key unique for
290 290
      * @param string                                                    $urlKey   The URL key to make unique
291
-     * @param array                                                     $urlPaths The URL paths to make unique
291
+     * @param string[]                                                     $urlPaths The URL paths to make unique
292 292
      *
293 293
      * @return string The unique URL key
294 294
      */
Please login to merge, or discard this patch.