Completed
Pull Request — master (#74)
by Tim
03:17 queued 01:36
created
src/Observers/UrlRewriteUpdateObserver.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 
100 100
                 // skip update of URL rewrite, if nothing to change
101 101
                 if ($targetPath === $existingUrlRewrite[MemberNames::TARGET_PATH] &&
102
-                    301 === (int)$existingUrlRewrite[MemberNames::REDIRECT_TYPE]) {
102
+                    301 === (int) $existingUrlRewrite[MemberNames::REDIRECT_TYPE]) {
103 103
                     // stop processing the URL rewrite
104 104
                     continue;
105 105
                 }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -211,7 +211,7 @@
 block discarded – undo
211 211
      * @param integer $entityId   The entity ID to load the URL rewrites for
212 212
      * @param integer $storeId    The store ID to load the URL rewrites for
213 213
      *
214
-     * @return array The URL rewrites
214
+     * @return \Generator The URL rewrites
215 215
      */
216 216
     protected function loadUrlRewritesByEntityTypeAndEntityIdAndStoreId($entityType, $entityId, $storeId)
217 217
     {
Please login to merge, or discard this patch.
src/Observers/UrlKeyAndPathObserver.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -313,7 +313,7 @@
 block discarded – undo
313 313
      * @param \TechDivision\Import\Subjects\UrlKeyAwareSubjectInterface $subject  The subject to make the URL key unique for
314 314
      * @param array                                                     $entity   The entity to make the URL key unique for
315 315
      * @param string                                                    $urlKey   The URL key to make unique
316
-     * @param array                                                     $urlPaths The URL paths to make unique
316
+     * @param string[]                                                     $urlPaths The URL paths to make unique
317 317
      *
318 318
      * @return string The unique URL key
319 319
      */
Please login to merge, or discard this patch.
src/Observers/UrlRewriteObserver.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -231,7 +231,7 @@
 block discarded – undo
231 231
      *
232 232
      * @param array $row The URL rewrite to persist
233 233
      *
234
-     * @return string The ID of the persisted entity
234
+     * @return integer The ID of the persisted entity
235 235
      */
236 236
     protected function persistUrlRewrite($row)
237 237
     {
Please login to merge, or discard this patch.