techdivision / import-attribute

RoboFile.php

Indentation +12 added lines, -12 removed lines

@@ -59,9 +59,9 @@ 
     {
         // optimize autoloader with custom path
         $this->taskComposerInstall()
-             ->preferDist()
-             ->optimizeAutoloader()
-             ->run();
+                ->preferDist()
+                ->optimizeAutoloader()
+                ->run();
     }
 
     /**
@@ -73,9 +73,9 @@ 
     {
         // optimize autoloader with custom path
         $this->taskComposerUpdate()
-             ->preferDist()
-             ->optimizeAutoloader()
-             ->run();
+                ->preferDist()
+                ->optimizeAutoloader()
+                ->run();
     }
 
     /**
@@ -96,10 +96,10 @@ 
     public function prepare()
     {
         $this->taskFileSystemStack()
-             ->mkdir($this->properties['dist.dir'])
-             ->mkdir($this->properties['target.dir'])
-             ->mkdir(sprintf('%s/reports', $this->properties['target.dir']))
-             ->run();
+                ->mkdir($this->properties['dist.dir'])
+                ->mkdir($this->properties['target.dir'])
+                ->mkdir(sprintf('%s/reports', $this->properties['target.dir']))
+                ->run();
     }
 
     /**
@@ -169,8 +169,8 @@ 
 
         // run PHPUnit
         $this->taskPHPUnit(sprintf('%s/bin/phpunit', $this->properties['vendor.dir']))
-             ->configFile('phpunit.xml')
-             ->run();
+                ->configFile('phpunit.xml')
+                ->run();
     }
 
     /**

Unused Use Statements -3 removed lines

@@ -18,9 +18,6 @@
  * @link      http://www.techdivision.com
  */
 
-use Lurker\Event\FilesystemEvent;
-use Symfony\Component\Finder\Finder;
-
 /**
  * Defines the available build tasks.
  *

src/Observers/AttributeObserver.php

Doc Comments +1 added lines, -1 removed lines

@@ -189,7 +189,7 @@
      *
      * @param array $attribute The attribute to persist
      *
-     * @return void
+     * @return string
      */
     protected function persistAttribute(array $attribute)
     {

src/Observers/AttributeOptionObserver.php

Doc Comments +1 added lines, -1 removed lines

@@ -164,7 +164,7 @@
      *
      * @param array $attributeOption The attribute option to persist
      *
-     * @return void
+     * @return string
      */
     protected function persistAttributeOption(array $attributeOption)
     {

src/Subjects/BunchSubject.php

Spacing +1 added lines, -1 removed lines

@@ -203,7 +203,7 @@
      */
     public function preLoadAttributeId(array $attribute)
     {
-        $this->preLoadedAttributeIds[$attribute[MemberNames::ATTRIBUTE_CODE]]= $attribute[MemberNames::ATTRIBUTE_ID];
+        $this->preLoadedAttributeIds[$attribute[MemberNames::ATTRIBUTE_CODE]] = $attribute[MemberNames::ATTRIBUTE_ID];
     }
 
     /**

src/Actions/Processors/CatalogAttributeUpdateProcessor.php

Spacing +1 added lines, -1 removed lines

@@ -76,7 +76,7 @@
             unset($keys[array_search(EntityStatus::MEMBER_NAME, $keys, true)]);
 
             // prepare the SET part of the SQL statement
-            array_walk($keys, function (&$value, $key) {
+            array_walk($keys, function(&$value, $key) {
                 $value = sprintf('%s=:%s', $value, $value);
             });
 

tests/unit/Observers/CatalogAttributeUpdateObserverTest.php

Indentation +17 added lines, -17 removed lines

@@ -62,8 +62,8 @@ 
 
         // mock the attribute bunch processor
         $this->mockBunchProcessor = $this->getMockBuilder('TechDivision\Import\Attribute\Services\AttributeBunchProcessorInterface')
-                                         ->setMethods(get_class_methods('TechDivision\Import\Attribute\Services\AttributeBunchProcessorInterface'))
-                                         ->getMock();
+                                            ->setMethods(get_class_methods('TechDivision\Import\Attribute\Services\AttributeBunchProcessorInterface'))
+                                            ->getMock();
 
         // the observer instance we want to test
         $this->observer = new CatalogAttributeUpdateObserver($this->mockBunchProcessor);
@@ -116,7 +116,7 @@ 
                         array(ColumnKeys::IS_FILTERABLE_IN_GRID),
                         array(ColumnKeys::SEARCH_WEIGHT),
                         array(ColumnKeys::ADDITIONAL_DATA)
-                     )
+                        )
                     ->willReturnOnConsecutiveCalls(
                         true,
                         false,
@@ -189,14 +189,14 @@ 
 
         // mock the method that loads the existing entity
         $this->mockBunchProcessor->expects($this->once())
-                                 ->method('loadCatalogAttribute')
-                                 ->with($lastAttributeId)
-                                 ->willReturn($existingEntity);
+                                    ->method('loadCatalogAttribute')
+                                    ->with($lastAttributeId)
+                                    ->willReturn($existingEntity);
         // mock the method that persists the entity
         $this->mockBunchProcessor->expects($this->once())
-                                 ->method('persistCatalogAttribute')
-                                 ->with($expectedEntity)
-                                 ->willReturn(null);
+                                    ->method('persistCatalogAttribute')
+                                    ->with($expectedEntity)
+                                    ->willReturn(null);
 
         // invoke the handle method
         $this->assertSame($row, $this->observer->handle($mockSubject));
@@ -309,7 +309,7 @@ 
                         array(ColumnKeys::ADDITIONAL_DATA),
                         array(ColumnKeys::ATTRIBUTE_OPTION_VALUES),
                         array(ColumnKeys::ATTRIBUTE_OPTION_SWATCH)
-                     )
+                        )
                     ->willReturnOnConsecutiveCalls(
                         0,
                         1,
@@ -359,7 +359,7 @@ 
                         23,
                         7,
                         8
-                     );
+                        );
         $mockSubject->expects($this->once())
                     ->method('hasBeenProcessed')
                     ->with($attributeCode)
@@ -444,14 +444,14 @@ 
 
         // mock the method that loads the existing entity
         $this->mockBunchProcessor->expects($this->once())
-                                 ->method('loadCatalogAttribute')
-                                 ->with($lastAttributeId)
-                                 ->willReturn($existingEntity);
+                                    ->method('loadCatalogAttribute')
+                                    ->with($lastAttributeId)
+                                    ->willReturn($existingEntity);
         // mock the method that persists the entity
         $this->mockBunchProcessor->expects($this->once())
-                                 ->method('persistCatalogAttribute')
-                                 ->with($expectedEntity)
-                                 ->willReturn(null);
+                                    ->method('persistCatalogAttribute')
+                                    ->with($expectedEntity)
+                                    ->willReturn(null);
 
         // invoke the handle method
         $this->assertSame($row, $this->observer->handle($mockSubject));

tests/unit/Observers/CatalogAttributeObserverTest.php

Indentation +6 added lines, -6 removed lines

@@ -62,8 +62,8 @@ 
 
         // mock the attribute bunch processor
         $this->mockBunchProcessor = $this->getMockBuilder('TechDivision\Import\Attribute\Services\AttributeBunchProcessorInterface')
-                                         ->setMethods(get_class_methods('TechDivision\Import\Attribute\Services\AttributeBunchProcessorInterface'))
-                                         ->getMock();
+                                            ->setMethods(get_class_methods('TechDivision\Import\Attribute\Services\AttributeBunchProcessorInterface'))
+                                            ->getMock();
 
         // the observer instance we want to test
         $this->observer = new CatalogAttributeObserver($this->mockBunchProcessor);
@@ -116,7 +116,7 @@ 
                         array(ColumnKeys::IS_FILTERABLE_IN_GRID),
                         array(ColumnKeys::SEARCH_WEIGHT),
                         array(ColumnKeys::ADDITIONAL_DATA)
-                     )
+                        )
                     ->willReturnOnConsecutiveCalls(
                         true,
                         false,
@@ -163,9 +163,9 @@ 
 
         // mock the method that persists the entity
         $this->mockBunchProcessor->expects($this->once())
-                                 ->method('persistCatalogAttribute')
-                                 ->with($expectedEntity)
-                                 ->willReturn(null);
+                                    ->method('persistCatalogAttribute')
+                                    ->with($expectedEntity)
+                                    ->willReturn(null);
 
         // invoke the handle method
         $this->assertSame($row, $this->observer->handle($mockSubject));

src/Callbacks/OptionValueAndSwatchHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
     /**
      * Returns the swatch type loader instance.
      *
-     * @return \\TechDivision\Import\Attribute\Callbacks\SwatchTypeLoaderInterface The swatch type loader instance
+     * @return SwatchTypeLoaderInterface The swatch type loader instance
      */
     protected function getSwatchTypeLoader()
     {

src/Services/AttributeBunchProcessor.php

Doc Comments +1 added lines, -1 removed lines

@@ -251,7 +251,7 @@
      * Commits a transaction, returning the database connection to autocommit mode until the next call to
      * ProductProcessor::beginTransaction() starts a new transaction.
      *
-     * @return boolean Returns TRUE on success or FALSE on failure
+     * @return boolean|null Returns TRUE on success or FALSE on failure
      * @link http://php.net/manual/en/pdo.commit.php
      */
     public function commit()