AbstractTableTest::insertDocumentWithNumber() - Code Metrics - Inspection of "Add serveral operations" - tbolier/php-rethink-ql - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#34)

by Timon

created 2018-02-22 13:32 UTC

AbstractTableTest::insertDocumentWithNumber() A

↳ Parent: AbstractTableTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	9
nc	1
nop	2

<?php
declare(strict_types = 1);

namespace TBolier\RethinkQL\IntegrationTest\Query;

use TBolier\RethinkQL\IntegrationTest\AbstractTestCase;
use TBolier\RethinkQL\Response\ResponseInterface;

abstract class AbstractTableTest extends AbstractTestCase
{
    public function setUp()
    {
        parent::setUp();

        $res = $this->r()->db()->tableList()->run();
        if (\is_array($res->getData()) && !\in_array('tabletest', $res->getData(), true)) {
            $this->r()->db()->tableCreate('tabletest')->run();
        }
    }

    public function tearDown()
    {
        $res = $this->r()->db()->tableList()->run();
        if (\is_array($res->getData()) && \in_array('tabletest', $res->getData(), true)) {
            $this->r()->db()->tableDrop('tabletest')->run();
        }

        parent::tearDown();
    }

    /**
     * @param int|string $id
     * @return ResponseInterface
     */
    protected function insertDocument($id): ResponseInterface
    {
        $res = $this->r()
            ->table('tabletest')
            ->insert([
                'id' => $id,
                'title' => 'Test document '.$id,
                'description' => 'A document description.',
            ])
            ->run();

        return $res;

    }

    /**
     * @param int|string $id
     * @param int $number
     * @return ResponseInterface
     */
    protected function insertDocumentWithNumber($id, int $number): ResponseInterface
    {
        $res = $this->r()
            ->table('tabletest')
            ->insert([
                'id' => $id,
                'title' => 'Test document '.$id,
                'number' => $number,
                'description' => 'A document description.',
            ])
            ->run();

        return $res;
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace TBolier\RethinkQL\IntegrationTest\Query;
5
6			use TBolier\RethinkQL\IntegrationTest\AbstractTestCase;
7			use TBolier\RethinkQL\Response\ResponseInterface;
8
9			abstract class AbstractTableTest extends AbstractTestCase
10			{
11			public function setUp()
12			{
13			parent::setUp();
14
15			$res = $this->r()->db()->tableList()->run();
16			if (\is_array($res->getData()) && !\in_array('tabletest', $res->getData(), true)) {
17			$this->r()->db()->tableCreate('tabletest')->run();
18			}
19			}
20
21			public function tearDown()
22			{
23			$res = $this->r()->db()->tableList()->run();
24			if (\is_array($res->getData()) && \in_array('tabletest', $res->getData(), true)) {
25			$this->r()->db()->tableDrop('tabletest')->run();
26			}
27
28			parent::tearDown();
29			}
30
31			/**
32			* @param int\|string $id
33			* @return ResponseInterface
34			*/
35			protected function insertDocument($id): ResponseInterface
36			{
37			$res = $this->r()
38			->table('tabletest')
39			->insert([
40			'id' => $id,
41			'title' => 'Test document '.$id,
42			'description' => 'A document description.',
43			])
44			->run();
45
46			return $res;
			0 ignored issues – show Bug Best Practice introduced 2018-02-22 13:39 UTC by Report Bug Copy Issue Report The expression `return $res` could return the type `iterable` which is incompatible with the type-hinted return `TBolier\RethinkQL\Response\ResponseInterface`. Consider adding an additional type-check to rule them out. Loading history...
47			}
48
49			/**
50			* @param int\|string $id
51			* @param int $number
52			* @return ResponseInterface
53			*/
54			protected function insertDocumentWithNumber($id, int $number): ResponseInterface
55			{
56			$res = $this->r()
57			->table('tabletest')
58			->insert([
59			'id' => $id,
60			'title' => 'Test document '.$id,
61			'number' => $number,
62			'description' => 'A document description.',
63			])
64			->run();
65
66			return $res;
67			}
68			}
69

tbolier / php-rethink-ql

Pull Request — master (#34)

AbstractTableTest::insertDocumentWithNumber() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like