TBolier\RethinkQL\IntegrationTest\Query\AbstractTableTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	tearDown()	0	8	3
A	setUp()	0	7	3
A	insertDocument()	0	12	1
A	insertDocumentWithNumber()	0	13	1

<?php
declare(strict_types = 1);

namespace TBolier\RethinkQL\IntegrationTest\Query;

use TBolier\RethinkQL\IntegrationTest\AbstractTestCase;
use TBolier\RethinkQL\Response\ResponseInterface;

abstract class AbstractTableTest extends AbstractTestCase
{
    public function setUp()
    {
        parent::setUp();

        $res = $this->r()->db()->tableList()->run();
        if (\is_array($res->getData()) && !\in_array('tabletest', $res->getData(), true)) {
            $this->r()->db()->tableCreate('tabletest')->run();
        }
    }

    public function tearDown()
    {
        $res = $this->r()->db()->tableList()->run();
        if (\is_array($res->getData()) && \in_array('tabletest', $res->getData(), true)) {
            $this->r()->db()->tableDrop('tabletest')->run();
        }

        parent::tearDown();
    }

    /**
     * @param int|string $id
     * @return ResponseInterface
     */
    protected function insertDocument($id): ResponseInterface
    {
        $res = $this->r()
            ->table('tabletest')
            ->insert([
                'id' => $id,
                'title' => 'Test document '.$id,
                'description' => 'A document description.',
            ])
            ->run();

        return $res;

The expression return $res could return the type iterable which is incompatible with the type-hinted return TBolier\RethinkQL\Response\ResponseInterface. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param int|string $id
     * @param int $number
     * @return ResponseInterface
     */
    protected function insertDocumentWithNumber($id, int $number): ResponseInterface
    {
        $res = $this->r()
            ->table('tabletest')
            ->insert([
                'id' => $id,
                'title' => 'Test document '.$id,
                'number' => $number,
                'description' => 'A document description.',
            ])
            ->run();

        return $res;
    }
}