tas2580 / seourls

event/listener.php

Indentation +528 added lines, -528 removed lines

@@ -18,533 +18,533 @@
 class listener implements EventSubscriberInterface
 {
 
-	/** @var \phpbb\auth\auth */
-	protected $auth;
-
-	/** @var \phpbb\config\config */
-	protected $config;
-
-	/** @var \phpbb\template\template */
-	protected $template;
-
-	/** @var \phpbb\request\request */
-	protected $request;
-
-	/** @var \phpbb\user */
-	protected $user;
-
-	/** @var \phpbb\path_helper */
-	protected $path_helper;
-
-	/** @var string phpbb_root_path */
-	protected $phpbb_root_path;
-
-	/**
-	 * Constructor
-	 *
-	 * @param \phpbb\auth\auth				auth					Authentication object
-	 * @param \phpbb\config\config			$config				Config Object
-	 * @param \phpbb\template\template		$template				Template object
-	 * @param \phpbb\request\request			$request				Request object
-	 * @param \phpbb\user					$user				User Object
-	 * @param \phpbb\path_helper			$path_helper			Controller helper object
-	 * @param string						$phpbb_root_path		phpbb_root_path
-	 * @access public
-	 */
-	public function __construct(\phpbb\auth\auth $auth, \phpbb\config\config $config, \phpbb\template\template $template, \phpbb\request\request $request, \phpbb\user $user, \phpbb\path_helper $path_helper, $phpbb_root_path)
-	{
-		$this->auth = $auth;
-		$this->config = $config;
-		$this->template = $template;
-		$this->request = $request;
-		$this->user = $user;
-		$this->path_helper = $path_helper;
-		$this->phpbb_root_path = $phpbb_root_path;
-	}
-
-	/**
-	 * Assign functions defined in this class to event listeners in the core
-	 *
-	 * @return array
-	 * @static
-	 * @access public
-	 */
-	static public function getSubscribedEvents()
-	{
-		return array(
-			'core.display_forums_modify_sql'			=> 'display_forums_modify_sql',
-			'core.display_forums_modify_template_vars'	=> 'display_forums_modify_template_vars',
-			'core.display_forums_modify_forum_rows'		=> 'display_forums_modify_forum_rows',
-			'core.display_forums_modify_sql'			=> 'display_forums_modify_sql',
-			'core.generate_forum_nav'				=> 'generate_forum_nav',
-			'core.make_jumpbox_modify_tpl_ary'			=> 'make_jumpbox_modify_tpl_ary',				// Not in phpBB
-			'core.pagination_generate_page_link'		=> 'pagination_generate_page_link',
-			'core.search_modify_tpl_ary'				=> 'search_modify_tpl_ary',
-			'core.viewforum_modify_topicrow'			=> 'viewforum_modify_topicrow',
-			'core.viewforum_get_topic_data'			=> 'viewforum_get_topic_data',
-			'core.viewtopic_assign_template_vars_before'	=> 'viewtopic_assign_template_vars_before',
-			'core.viewtopic_modify_page_title'			=> 'viewtopic_modify_page_title',
-			'core.viewtopic_modify_post_row'			=> 'viewtopic_modify_post_row',
-			'core.viewtopic_get_post_data'				=> 'viewtopic_get_post_data',
-
-			// Rewrite other Extensions
-			'rmcgirr83.topfive.sql_pull_topics_data'		=> 'topfive_sql_pull_topics_data',
-			'rmcgirr83.topfive.modify_tpl_ary'			=> 'topfive_modify_tpl_ary',
-			'tas2580.sitemap_modify_before_output'		=> 'sitemap_modify_before_output',
-			'vse.similartopics.modify_topicrow'			=> 'similartopics_modify_topicrow',
-		);
-	}
-
-	/**
-	 * Get informations for the last post from Database
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function display_forums_modify_sql($event)
-	{
-		$sql_array = $event['sql_ary'];
-		$sql_array['LEFT_JOIN'][] = array(
-			'FROM' => array(TOPICS_TABLE => 't'),
-			'ON' => "f.forum_last_post_id = t.topic_last_post_id"
-		);
-		$sql_array['SELECT'] .= ', t.topic_title, t.topic_id, t.topic_posts_approved, t.topic_posts_unapproved, t.topic_posts_softdeleted';
-		$event['sql_ary'] = $sql_array;
-	}
-
-	/**
-	 * Store informations for the last post in forum_rows array
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function display_forums_modify_forum_rows($event)
-	{
-		$forum_rows = $event['forum_rows'];
-		if ($event['row']['forum_last_post_time'] == $forum_rows[$event['parent_id']]['forum_last_post_time'])
-		{
-			$forum_rows[$event['parent_id']]['forum_name_last_post'] =$event['row']['forum_name'];
-			$forum_rows[$event['parent_id']]['topic_id_last_post'] =$event['row']['topic_id'];
-			$forum_rows[$event['parent_id']]['topic_title_last_post'] =$event['row']['topic_title'];
-			$event['forum_rows'] = $forum_rows;
-		}
-	}
-
-	/**
-	 * Rewrite links to forums and subforums in forum index
-	 * also correct the path of the forum images if we are in a forum
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function display_forums_modify_template_vars($event)
-	{
-		// Rewrite URLs of sub forums
-		$subforums_row = $event['subforums_row'];
-		foreach ($subforums_row as $i => $subforum)
-		{
-			// A little bit a dirty way, but there is no better solution
-			$query = str_replace('&', '&', parse_url($subforum['U_SUBFORUM'], PHP_URL_QUERY));
-			parse_str($query, $id);
-			$subforums_row[$i]['U_SUBFORUM'] = append_sid($this->generate_forum_link($id['f'], $subforum['SUBFORUM_NAME']));
-		}
-		$event['subforums_row'] = $subforums_row;
-
-		$forum_row = $event['forum_row'];
-
-		// Update the image source in forums
-		$img = $this->path_helper->update_web_root_path($forum_row['FORUM_IMAGE_SRC']);
-		$forum_row['FORUM_IMAGE'] = preg_replace('#img src=\"(.*)\" alt#', 'img src="' . $img . '" alt', $forum_row['FORUM_IMAGE']);
-
-		// Rewrite links to topics, posts and forums
-		$replies = $this->get_count('topic_posts', $event['row'], $event['row']['forum_id']) - 1;
-		$url = $this->generate_topic_link($event['row']['forum_id_last_post'], $event['row']['forum_name_last_post'], $event['row']['topic_id_last_post'], $event['row']['topic_title_last_post']);
-		$forum_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($replies, $url) . '#p' . $event['row']['forum_last_post_id']);
-		$forum_row['U_VIEWFORUM'] = append_sid($this->generate_forum_link($forum_row['FORUM_ID'], $forum_row['FORUM_NAME']));
-		$event['forum_row'] = $forum_row;
-	}
-
-	/**
-	 * Rewrite links in breadcrumbs
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function generate_forum_nav($event)
-	{
-		$forum_data = $event['forum_data'];
-		$navlinks = $event['navlinks'];
-		$navlinks_parents = $event['navlinks_parents'];
-
-		foreach ($navlinks_parents as $id => $data)
-		{
-			$navlinks_parents[$id]['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($data['FORUM_ID'] , $data['FORUM_NAME']));
-		}
-
-		$navlinks['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($forum_data['forum_id'], $forum_data['forum_name']));
-		$event['navlinks'] = $navlinks;
-		$event['navlinks_parents'] = $navlinks_parents;
-	}
-
-	// Not in phpBB
-	public function make_jumpbox_modify_tpl_ary($event)
-	{
-		$tpl_ary = $event['tpl_ary'];
-		$row = $event['row'];
-		foreach ($tpl_ary as $id => $data)
-		{
-
-			$tpl_ary[$id]['LINK']	 = append_sid($this->generate_forum_link($row['forum_id'], $row['forum_name']));
-		}
-
-		$event['tpl_ary'] = $tpl_ary;
-	}
-
-	/**
-	 * Rewrite pagination links
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function pagination_generate_page_link($event)
-	{
-		// If we have a sort key we do not rewrite the URL
-		$query = str_replace('&', '&', parse_url($event['base_url'], PHP_URL_QUERY));
-		parse_str($query, $param);
-		if (isset($param['sd']) || isset($param['sk']) || isset($param['st']))
-		{
-			return;
-		}
-
-		$start = (($event['on_page'] - 1) * $event['per_page']);
-		if (!empty($this->topic_title))
-		{
-			$event['generate_page_link_override'] = append_sid($this->generate_topic_link($this->forum_id, $this->forum_title, $this->topic_id, $this->topic_title, $start));
-		}
-		else if (!empty($this->forum_title))
-		{
-			$event['generate_page_link_override'] = append_sid($this->generate_forum_link($this->forum_id, $this->forum_title, $start));
-		}
-	}
-
-	/**
-	 * Rewrite links in the search result
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function search_modify_tpl_ary($event)
-	{
-		$replies = $this->get_count('topic_posts', $event['row'], $event['row']['forum_id']) - 1;
-		$u_view_topic = $this->generate_topic_link($event['row']['forum_id'], $event['row']['forum_name'], $event['row']['topic_id'], $event['row']['topic_title']);
-
-		$tpl_ary = $event['tpl_ary'];
-		$tpl_ary['U_LAST_POST'] = append_sid($this->generate_lastpost_link($replies, $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
-		$tpl_ary['U_VIEW_TOPIC'] = append_sid($u_view_topic);
-		$tpl_ary['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($event['row']['forum_id'], $event['row']['forum_name']));
-
-		$event['tpl_ary'] = $tpl_ary;
-	}
-
-	/**
-	 * Rewrite links to topics in forum view
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function viewforum_modify_topicrow($event)
-	{
-		$topic_row = $event['topic_row'];
-		$this->forum_title = $topic_row['FORUM_NAME'];
-		$this->forum_id = $topic_row['FORUM_ID'];
-		$this->topic_title = $topic_row['TOPIC_TITLE'];
-		$this->topic_id = $topic_row['TOPIC_ID'];
-
-		$u_view_topic = $this->generate_topic_link($this->forum_id, $this->forum_title, $this->topic_id, $this->topic_title);
-		$topic_row['U_VIEW_TOPIC'] = append_sid($u_view_topic);
-		$topic_row['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($this->forum_id, $this->forum_title));
-		$topic_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($event['topic_row']['REPLIES'], $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
-
-		$event['topic_row'] = $topic_row;
-	}
-
-	/**
-	 * Rewrite the canonical URL on viewforum.php
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function viewforum_get_topic_data($event)
-	{
-		$this->forum_title = $event['forum_data']['forum_name'];
-		$this->forum_id = $event['forum_data']['forum_id'];
-		$start = $this->request->variable('start', 0);
-		$this->template->assign_vars(array(
-			'U_VIEW_FORUM'	=> append_sid($this->generate_forum_link($this->forum_id, $this->forum_title, $start)),
-			'U_CANONICAL'		=> $this->generate_forum_link($this->forum_id, $this->forum_title, $start, true),
-		));
-	}
-
-	/**
-	 * Rewrite the topic URL for the headline of the topic page and the link back to forum
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function viewtopic_get_post_data($event)
-	{
-		$data = $event['topic_data'];
-		$this->template->assign_vars(array(
-			'U_VIEW_TOPIC'		=> append_sid($this->generate_topic_link($event['forum_id'] , $data['forum_name'], $event['topic_id'], $data['topic_title'], $event['start'])),
-			'U_VIEW_FORUM'	=> append_sid($this->generate_forum_link($event['forum_id'] , $data['forum_name'])),
-		));
-	}
-
-	/**
-	 * Assign topic data to global variables for pagination
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function viewtopic_assign_template_vars_before($event)
-	{
-		$this->forum_title = $event['topic_data']['forum_name'];
-		$this->forum_id = $event['topic_data']['forum_id'];
-		$this->topic_title = $event['topic_data']['topic_title'];
-		$this->topic_id = $event['topic_data']['topic_id'];
-	}
-
-	/**
-	 * Rewrite the canonical URL on viewtopic.php
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function viewtopic_modify_page_title($event)
-	{
-		$start = $this->request->variable('start', 0);
-		$data = $event['topic_data'];
-		$this->template->assign_vars(array(
-			'U_CANONICAL'		=> $this->generate_topic_link($data['forum_id'], $data['forum_name'], $data['topic_id'], $data['topic_title'], $start, true),
-		));
-	}
-
-	/**
-	 * Rewrite mini post img link
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function viewtopic_modify_post_row($event)
-	{
-		$row = $event['post_row'];
-		$start = $this->request->variable('start', 0);
-		$data = $event['topic_data'];
-		$row['U_MINI_POST'] = append_sid($this->generate_topic_link($data['forum_id'], $data['forum_name'], $data['topic_id'], $data['topic_title'], $start) . '#p' . $event['row']['post_id']);
-		$event['post_row'] = $row;
-	}
-
-	/**
-	 * Rewrite URLs in tas2580 Sitemap Extension
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function sitemap_modify_before_output($event)
-	{
-		// Nothing to rewrite in the sitemap index
-		if ($event['type'] == 'sitemapindex')
-		{
-			return;
-		}
-
-		$url_data =$event['url_data'] ;
-
-		foreach ($url_data as $id => $data)
-		{
-			$row = $data['row'];
-			if (isset($row['topic_id']))
-			{
-				$url_data[$id]['url'] = $this->generate_topic_link($row['forum_id'], $row['forum_name'], $row['topic_id'], $row['topic_title'],  $data['start'], true);
-			}
-			else if (isset($row['forum_id']))
-			{
-				$url_data[$id]['url'] = $this->generate_forum_link($row['forum_id'], $row['forum_name'], $data['start'], true);
-			}
-		}
-
-		$event['url_data'] = $url_data;
-	}
-
-	/**
-	 * Rewrite URLs in Similar Topics Extension
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function similartopics_modify_topicrow($event)
-	{
-		$this->forum_title = $event['row']['forum_name'];
-		$this->forum_id = $event['row']['forum_id'];
-		$this->topic_title = $event['row']['topic_title'];
-		$this->topic_id = $event['row']['topic_id'];
-
-		$topic_row = $event['topic_row'];
-		$u_view_topic= $this->generate_topic_link($this->forum_id, $this->forum_title, $this->topic_id, $this->topic_title);
-		$topic_row['U_VIEW_TOPIC'] = append_sid($u_view_topic);
-		$topic_row['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($this->forum_id, $this->forum_title));
-		$topic_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($topic_row['TOPIC_REPLIES'], $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
-		$event['topic_row'] = $topic_row;
-	}
-
-	/**
-	 * Rewrite URLs in Top 5 Extension
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function topfive_sql_pull_topics_data($event)
-	{
-		$sql_array = $event['sql_array'];
-		$sql_array['SELECT'] = array_merge($sql_array, array('SELECT' => 'f.forum_name'));
-		$sql_array['LEFT_JOIN'] = array_merge($sql_array['LEFT_JOIN'], array('FROM' => array(FORUMS_TABLE => 'f'), 'ON' => 'f.forum_id = t.forum_id'));
-		//	$event['sql_array'] = $sql_array;
-	}
-
-	/**
-	 * Rewrite URLs in Top 5 Extension
-	 *
-	 * @param	object	$event	The event object
-	 * @return	null
-	 * @access	public
-	 */
-	public function topfive_modify_tpl_ary($event)
-	{
-		$tpl_ary = $event['tpl_ary'];
-		$replies = $this->get_count('topic_posts', $event['row'], $event['row']['forum_id']) - 1;
-		$u_view_topic = $this->generate_topic_link($event['row']['forum_id'], $event['row']['forum_name'], $event['row']['topic_id'], $event['row']['topic_title']);
-		$tpl_ary['U_TOPIC'] = append_sid($this->generate_lastpost_link($replies, $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
-		$event['tpl_ary'] = $tpl_ary;
-	}
-
-	/**
-	 * Generate the SEO link for a topic
-	 *
-	 * @param	int		$forum_id		The ID of the forum
-	 * @param	string	$forum_name		The title of the forum
-	 * @param	int		$topic_id		The ID if the topic
-	 * @param	string	$topic_title	The title of the topic
-	 * @param	int		$start			Optional start parameter
-	 * @param	bool	$full			Return the full URL
-	 * @return	string	The SEO URL
-	 * @access private
-	 */
-	private function generate_topic_link($forum_id, $forum_name, $topic_id, $topic_title, $start = 0, $full = false)
-	{
-		if ($full)
-		{
-			return generate_board_url() . '/' . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . $this->title_to_url($topic_title) . '-t' . $topic_id . ($start ? '-s' . $start : '') . '.html';
-		}
-		return $this->phpbb_root_path . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . $this->title_to_url($topic_title) . '-t' . $topic_id . ($start ? '-s' . $start : '') . '.html';
-	}
-
-	/**
-	 * Generate the SEO link for a forum
-	 *
-	 * @param	int		$forum_id		The ID of the forum
-	 * @param	string	$forum_name		The title of the forum
-	 * @param	int		$start			Optional start parameter
-	 * @param	bool	$full			Return the full URL
-	 * @return	string	The SEO URL
-	 * @access private
-	 */
-	private function generate_forum_link($forum_id, $forum_name, $start = 0, $full = false)
-	{
-		if ($full)
-		{
-			return generate_board_url() . '/' . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . ($start ? 'index-s' . $start . '.html' : '');
-		}
-		return $this->phpbb_root_path . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . ($start ? 'index-s' . $start . '.html' : '');
-	}
-
-	/**
-	 *
-	 * @global	type	$_SID
-	 * @param	int		$replies	Replays in the topic
-	 * @param	string	$url		URL oft the topic
-	 * @return	string				The URL with start included
-	 */
-	private function generate_lastpost_link($replies, $url)
-	{
-		$url = str_replace('.html', '', $url);
-		$per_page = ($this->config['posts_per_page'] <= 0) ? 1 : $this->config['posts_per_page'];
-		if (($replies + 1) > $per_page)
-		{
-			for ($j = 0; $j < $replies + 1; $j += $per_page)
-			{
-				$last_post_link = $url . '-s' . $j . '.html';
-			}
-		}
-		else
-		{
-			$last_post_link = $url . '.html';
-		}
-		return $last_post_link;
-	}
-
-	/**
-	 * Replace letters to use title in URL
-	 *
-	 * @param	string	$title	The title to use in the URL
-	 * @return	string	Title to use in URLs
-	 */
-	public static function title_to_url($title)
-	{
-		$url = strtolower(censor_text(utf8_normalize_nfc(strip_tags($title))));
-
-		// Let's replace
-		$url_search = array(' ', 'í', 'ý', 'ß', 'ö', 'ô', 'ó', 'ò', 'ä', 'â', 'à', 'á', 'é', 'è', 'ü', 'ú', 'ù', 'ñ', 'ß', '²', '³', '@', '€', '$');
-		$url_replace = array('-', 'i', 'y', 's', 'oe', 'o', 'o', 'o', 'ae', 'a', 'a', 'a', 'e', 'e', 'ue', 'u', 'u', 'n', 'ss', '2', '3', 'at', 'eur', 'usd');
-		$url = str_replace($url_search, $url_replace, $url);
-		$url_search = array('&amp;', '&quot;', '&', '"', "'", '¸', '`', '(', ')', '[', ']', '<', '>', '{', '}', '.', ':', ',', ';', '!', '?', '+', '*', '/', '=', 'µ', '#', '~', '"', '§', '%', '|', '°', '^', '„', '“');
-		$url = str_replace($url_search, '-', $url);
-		$url = str_replace(array('----', '---', '--'), '-', $url);
-
-		$url = substr($url, 0, 50); // Max length for a title in URL
-		return urlencode($url);
-	}
-
-	/**
-	 * Get the topics post count or the forums post/topic count based on permissions
-	 *
-	 * @param $mode            string    One of topic_posts, forum_posts or forum_topics
-	 * @param $data            array    Array with the topic/forum data to calculate from
-	 * @param $forum_id        int        The forum id is used for permission checks
-	 * @return int    Number of posts/topics the user can see in the topic/forum
-	 */
-	private function get_count($mode, $data, $forum_id)
-	{
-		if (!$this->auth->acl_get('m_approve', $forum_id))
-		{
-			return (int) $data[$mode . '_approved'];
-		}
-
-		return (int) $data[$mode . '_approved'] + (int) $data[$mode . '_unapproved'] + (int) $data[$mode . '_softdeleted'];
-	}
+    /** @var \phpbb\auth\auth */
+    protected $auth;
+
+    /** @var \phpbb\config\config */
+    protected $config;
+
+    /** @var \phpbb\template\template */
+    protected $template;
+
+    /** @var \phpbb\request\request */
+    protected $request;
+
+    /** @var \phpbb\user */
+    protected $user;
+
+    /** @var \phpbb\path_helper */
+    protected $path_helper;
+
+    /** @var string phpbb_root_path */
+    protected $phpbb_root_path;
+
+    /**
+     * Constructor
+     *
+     * @param \phpbb\auth\auth				auth					Authentication object
+     * @param \phpbb\config\config			$config				Config Object
+     * @param \phpbb\template\template		$template				Template object
+     * @param \phpbb\request\request			$request				Request object
+     * @param \phpbb\user					$user				User Object
+     * @param \phpbb\path_helper			$path_helper			Controller helper object
+     * @param string						$phpbb_root_path		phpbb_root_path
+     * @access public
+     */
+    public function __construct(\phpbb\auth\auth $auth, \phpbb\config\config $config, \phpbb\template\template $template, \phpbb\request\request $request, \phpbb\user $user, \phpbb\path_helper $path_helper, $phpbb_root_path)
+    {
+        $this->auth = $auth;
+        $this->config = $config;
+        $this->template = $template;
+        $this->request = $request;
+        $this->user = $user;
+        $this->path_helper = $path_helper;
+        $this->phpbb_root_path = $phpbb_root_path;
+    }
+
+    /**
+     * Assign functions defined in this class to event listeners in the core
+     *
+     * @return array
+     * @static
+     * @access public
+     */
+    static public function getSubscribedEvents()
+    {
+        return array(
+            'core.display_forums_modify_sql'			=> 'display_forums_modify_sql',
+            'core.display_forums_modify_template_vars'	=> 'display_forums_modify_template_vars',
+            'core.display_forums_modify_forum_rows'		=> 'display_forums_modify_forum_rows',
+            'core.display_forums_modify_sql'			=> 'display_forums_modify_sql',
+            'core.generate_forum_nav'				=> 'generate_forum_nav',
+            'core.make_jumpbox_modify_tpl_ary'			=> 'make_jumpbox_modify_tpl_ary',				// Not in phpBB
+            'core.pagination_generate_page_link'		=> 'pagination_generate_page_link',
+            'core.search_modify_tpl_ary'				=> 'search_modify_tpl_ary',
+            'core.viewforum_modify_topicrow'			=> 'viewforum_modify_topicrow',
+            'core.viewforum_get_topic_data'			=> 'viewforum_get_topic_data',
+            'core.viewtopic_assign_template_vars_before'	=> 'viewtopic_assign_template_vars_before',
+            'core.viewtopic_modify_page_title'			=> 'viewtopic_modify_page_title',
+            'core.viewtopic_modify_post_row'			=> 'viewtopic_modify_post_row',
+            'core.viewtopic_get_post_data'				=> 'viewtopic_get_post_data',
+
+            // Rewrite other Extensions
+            'rmcgirr83.topfive.sql_pull_topics_data'		=> 'topfive_sql_pull_topics_data',
+            'rmcgirr83.topfive.modify_tpl_ary'			=> 'topfive_modify_tpl_ary',
+            'tas2580.sitemap_modify_before_output'		=> 'sitemap_modify_before_output',
+            'vse.similartopics.modify_topicrow'			=> 'similartopics_modify_topicrow',
+        );
+    }
+
+    /**
+     * Get informations for the last post from Database
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function display_forums_modify_sql($event)
+    {
+        $sql_array = $event['sql_ary'];
+        $sql_array['LEFT_JOIN'][] = array(
+            'FROM' => array(TOPICS_TABLE => 't'),
+            'ON' => "f.forum_last_post_id = t.topic_last_post_id"
+        );
+        $sql_array['SELECT'] .= ', t.topic_title, t.topic_id, t.topic_posts_approved, t.topic_posts_unapproved, t.topic_posts_softdeleted';
+        $event['sql_ary'] = $sql_array;
+    }
+
+    /**
+     * Store informations for the last post in forum_rows array
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function display_forums_modify_forum_rows($event)
+    {
+        $forum_rows = $event['forum_rows'];
+        if ($event['row']['forum_last_post_time'] == $forum_rows[$event['parent_id']]['forum_last_post_time'])
+        {
+            $forum_rows[$event['parent_id']]['forum_name_last_post'] =$event['row']['forum_name'];
+            $forum_rows[$event['parent_id']]['topic_id_last_post'] =$event['row']['topic_id'];
+            $forum_rows[$event['parent_id']]['topic_title_last_post'] =$event['row']['topic_title'];
+            $event['forum_rows'] = $forum_rows;
+        }
+    }
+
+    /**
+     * Rewrite links to forums and subforums in forum index
+     * also correct the path of the forum images if we are in a forum
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function display_forums_modify_template_vars($event)
+    {
+        // Rewrite URLs of sub forums
+        $subforums_row = $event['subforums_row'];
+        foreach ($subforums_row as $i => $subforum)
+        {
+            // A little bit a dirty way, but there is no better solution
+            $query = str_replace('&amp;', '&', parse_url($subforum['U_SUBFORUM'], PHP_URL_QUERY));
+            parse_str($query, $id);
+            $subforums_row[$i]['U_SUBFORUM'] = append_sid($this->generate_forum_link($id['f'], $subforum['SUBFORUM_NAME']));
+        }
+        $event['subforums_row'] = $subforums_row;
+
+        $forum_row = $event['forum_row'];
+
+        // Update the image source in forums
+        $img = $this->path_helper->update_web_root_path($forum_row['FORUM_IMAGE_SRC']);
+        $forum_row['FORUM_IMAGE'] = preg_replace('#img src=\"(.*)\" alt#', 'img src="' . $img . '" alt', $forum_row['FORUM_IMAGE']);
+
+        // Rewrite links to topics, posts and forums
+        $replies = $this->get_count('topic_posts', $event['row'], $event['row']['forum_id']) - 1;
+        $url = $this->generate_topic_link($event['row']['forum_id_last_post'], $event['row']['forum_name_last_post'], $event['row']['topic_id_last_post'], $event['row']['topic_title_last_post']);
+        $forum_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($replies, $url) . '#p' . $event['row']['forum_last_post_id']);
+        $forum_row['U_VIEWFORUM'] = append_sid($this->generate_forum_link($forum_row['FORUM_ID'], $forum_row['FORUM_NAME']));
+        $event['forum_row'] = $forum_row;
+    }
+
+    /**
+     * Rewrite links in breadcrumbs
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function generate_forum_nav($event)
+    {
+        $forum_data = $event['forum_data'];
+        $navlinks = $event['navlinks'];
+        $navlinks_parents = $event['navlinks_parents'];
+
+        foreach ($navlinks_parents as $id => $data)
+        {
+            $navlinks_parents[$id]['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($data['FORUM_ID'] , $data['FORUM_NAME']));
+        }
+
+        $navlinks['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($forum_data['forum_id'], $forum_data['forum_name']));
+        $event['navlinks'] = $navlinks;
+        $event['navlinks_parents'] = $navlinks_parents;
+    }
+
+    // Not in phpBB
+    public function make_jumpbox_modify_tpl_ary($event)
+    {
+        $tpl_ary = $event['tpl_ary'];
+        $row = $event['row'];
+        foreach ($tpl_ary as $id => $data)
+        {
+
+            $tpl_ary[$id]['LINK']	 = append_sid($this->generate_forum_link($row['forum_id'], $row['forum_name']));
+        }
+
+        $event['tpl_ary'] = $tpl_ary;
+    }
+
+    /**
+     * Rewrite pagination links
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function pagination_generate_page_link($event)
+    {
+        // If we have a sort key we do not rewrite the URL
+        $query = str_replace('&amp;', '&', parse_url($event['base_url'], PHP_URL_QUERY));
+        parse_str($query, $param);
+        if (isset($param['sd']) || isset($param['sk']) || isset($param['st']))
+        {
+            return;
+        }
+
+        $start = (($event['on_page'] - 1) * $event['per_page']);
+        if (!empty($this->topic_title))
+        {
+            $event['generate_page_link_override'] = append_sid($this->generate_topic_link($this->forum_id, $this->forum_title, $this->topic_id, $this->topic_title, $start));
+        }
+        else if (!empty($this->forum_title))
+        {
+            $event['generate_page_link_override'] = append_sid($this->generate_forum_link($this->forum_id, $this->forum_title, $start));
+        }
+    }
+
+    /**
+     * Rewrite links in the search result
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function search_modify_tpl_ary($event)
+    {
+        $replies = $this->get_count('topic_posts', $event['row'], $event['row']['forum_id']) - 1;
+        $u_view_topic = $this->generate_topic_link($event['row']['forum_id'], $event['row']['forum_name'], $event['row']['topic_id'], $event['row']['topic_title']);
+
+        $tpl_ary = $event['tpl_ary'];
+        $tpl_ary['U_LAST_POST'] = append_sid($this->generate_lastpost_link($replies, $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
+        $tpl_ary['U_VIEW_TOPIC'] = append_sid($u_view_topic);
+        $tpl_ary['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($event['row']['forum_id'], $event['row']['forum_name']));
+
+        $event['tpl_ary'] = $tpl_ary;
+    }
+
+    /**
+     * Rewrite links to topics in forum view
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function viewforum_modify_topicrow($event)
+    {
+        $topic_row = $event['topic_row'];
+        $this->forum_title = $topic_row['FORUM_NAME'];
+        $this->forum_id = $topic_row['FORUM_ID'];
+        $this->topic_title = $topic_row['TOPIC_TITLE'];
+        $this->topic_id = $topic_row['TOPIC_ID'];
+
+        $u_view_topic = $this->generate_topic_link($this->forum_id, $this->forum_title, $this->topic_id, $this->topic_title);
+        $topic_row['U_VIEW_TOPIC'] = append_sid($u_view_topic);
+        $topic_row['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($this->forum_id, $this->forum_title));
+        $topic_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($event['topic_row']['REPLIES'], $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
+
+        $event['topic_row'] = $topic_row;
+    }
+
+    /**
+     * Rewrite the canonical URL on viewforum.php
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function viewforum_get_topic_data($event)
+    {
+        $this->forum_title = $event['forum_data']['forum_name'];
+        $this->forum_id = $event['forum_data']['forum_id'];
+        $start = $this->request->variable('start', 0);
+        $this->template->assign_vars(array(
+            'U_VIEW_FORUM'	=> append_sid($this->generate_forum_link($this->forum_id, $this->forum_title, $start)),
+            'U_CANONICAL'		=> $this->generate_forum_link($this->forum_id, $this->forum_title, $start, true),
+        ));
+    }
+
+    /**
+     * Rewrite the topic URL for the headline of the topic page and the link back to forum
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function viewtopic_get_post_data($event)
+    {
+        $data = $event['topic_data'];
+        $this->template->assign_vars(array(
+            'U_VIEW_TOPIC'		=> append_sid($this->generate_topic_link($event['forum_id'] , $data['forum_name'], $event['topic_id'], $data['topic_title'], $event['start'])),
+            'U_VIEW_FORUM'	=> append_sid($this->generate_forum_link($event['forum_id'] , $data['forum_name'])),
+        ));
+    }
+
+    /**
+     * Assign topic data to global variables for pagination
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function viewtopic_assign_template_vars_before($event)
+    {
+        $this->forum_title = $event['topic_data']['forum_name'];
+        $this->forum_id = $event['topic_data']['forum_id'];
+        $this->topic_title = $event['topic_data']['topic_title'];
+        $this->topic_id = $event['topic_data']['topic_id'];
+    }
+
+    /**
+     * Rewrite the canonical URL on viewtopic.php
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function viewtopic_modify_page_title($event)
+    {
+        $start = $this->request->variable('start', 0);
+        $data = $event['topic_data'];
+        $this->template->assign_vars(array(
+            'U_CANONICAL'		=> $this->generate_topic_link($data['forum_id'], $data['forum_name'], $data['topic_id'], $data['topic_title'], $start, true),
+        ));
+    }
+
+    /**
+     * Rewrite mini post img link
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function viewtopic_modify_post_row($event)
+    {
+        $row = $event['post_row'];
+        $start = $this->request->variable('start', 0);
+        $data = $event['topic_data'];
+        $row['U_MINI_POST'] = append_sid($this->generate_topic_link($data['forum_id'], $data['forum_name'], $data['topic_id'], $data['topic_title'], $start) . '#p' . $event['row']['post_id']);
+        $event['post_row'] = $row;
+    }
+
+    /**
+     * Rewrite URLs in tas2580 Sitemap Extension
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function sitemap_modify_before_output($event)
+    {
+        // Nothing to rewrite in the sitemap index
+        if ($event['type'] == 'sitemapindex')
+        {
+            return;
+        }
+
+        $url_data =$event['url_data'] ;
+
+        foreach ($url_data as $id => $data)
+        {
+            $row = $data['row'];
+            if (isset($row['topic_id']))
+            {
+                $url_data[$id]['url'] = $this->generate_topic_link($row['forum_id'], $row['forum_name'], $row['topic_id'], $row['topic_title'],  $data['start'], true);
+            }
+            else if (isset($row['forum_id']))
+            {
+                $url_data[$id]['url'] = $this->generate_forum_link($row['forum_id'], $row['forum_name'], $data['start'], true);
+            }
+        }
+
+        $event['url_data'] = $url_data;
+    }
+
+    /**
+     * Rewrite URLs in Similar Topics Extension
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function similartopics_modify_topicrow($event)
+    {
+        $this->forum_title = $event['row']['forum_name'];
+        $this->forum_id = $event['row']['forum_id'];
+        $this->topic_title = $event['row']['topic_title'];
+        $this->topic_id = $event['row']['topic_id'];
+
+        $topic_row = $event['topic_row'];
+        $u_view_topic= $this->generate_topic_link($this->forum_id, $this->forum_title, $this->topic_id, $this->topic_title);
+        $topic_row['U_VIEW_TOPIC'] = append_sid($u_view_topic);
+        $topic_row['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($this->forum_id, $this->forum_title));
+        $topic_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($topic_row['TOPIC_REPLIES'], $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
+        $event['topic_row'] = $topic_row;
+    }
+
+    /**
+     * Rewrite URLs in Top 5 Extension
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function topfive_sql_pull_topics_data($event)
+    {
+        $sql_array = $event['sql_array'];
+        $sql_array['SELECT'] = array_merge($sql_array, array('SELECT' => 'f.forum_name'));
+        $sql_array['LEFT_JOIN'] = array_merge($sql_array['LEFT_JOIN'], array('FROM' => array(FORUMS_TABLE => 'f'), 'ON' => 'f.forum_id = t.forum_id'));
+        //	$event['sql_array'] = $sql_array;
+    }
+
+    /**
+     * Rewrite URLs in Top 5 Extension
+     *
+     * @param	object	$event	The event object
+     * @return	null
+     * @access	public
+     */
+    public function topfive_modify_tpl_ary($event)
+    {
+        $tpl_ary = $event['tpl_ary'];
+        $replies = $this->get_count('topic_posts', $event['row'], $event['row']['forum_id']) - 1;
+        $u_view_topic = $this->generate_topic_link($event['row']['forum_id'], $event['row']['forum_name'], $event['row']['topic_id'], $event['row']['topic_title']);
+        $tpl_ary['U_TOPIC'] = append_sid($this->generate_lastpost_link($replies, $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
+        $event['tpl_ary'] = $tpl_ary;
+    }
+
+    /**
+     * Generate the SEO link for a topic
+     *
+     * @param	int		$forum_id		The ID of the forum
+     * @param	string	$forum_name		The title of the forum
+     * @param	int		$topic_id		The ID if the topic
+     * @param	string	$topic_title	The title of the topic
+     * @param	int		$start			Optional start parameter
+     * @param	bool	$full			Return the full URL
+     * @return	string	The SEO URL
+     * @access private
+     */
+    private function generate_topic_link($forum_id, $forum_name, $topic_id, $topic_title, $start = 0, $full = false)
+    {
+        if ($full)
+        {
+            return generate_board_url() . '/' . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . $this->title_to_url($topic_title) . '-t' . $topic_id . ($start ? '-s' . $start : '') . '.html';
+        }
+        return $this->phpbb_root_path . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . $this->title_to_url($topic_title) . '-t' . $topic_id . ($start ? '-s' . $start : '') . '.html';
+    }
+
+    /**
+     * Generate the SEO link for a forum
+     *
+     * @param	int		$forum_id		The ID of the forum
+     * @param	string	$forum_name		The title of the forum
+     * @param	int		$start			Optional start parameter
+     * @param	bool	$full			Return the full URL
+     * @return	string	The SEO URL
+     * @access private
+     */
+    private function generate_forum_link($forum_id, $forum_name, $start = 0, $full = false)
+    {
+        if ($full)
+        {
+            return generate_board_url() . '/' . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . ($start ? 'index-s' . $start . '.html' : '');
+        }
+        return $this->phpbb_root_path . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . ($start ? 'index-s' . $start . '.html' : '');
+    }
+
+    /**
+     *
+     * @global	type	$_SID
+     * @param	int		$replies	Replays in the topic
+     * @param	string	$url		URL oft the topic
+     * @return	string				The URL with start included
+     */
+    private function generate_lastpost_link($replies, $url)
+    {
+        $url = str_replace('.html', '', $url);
+        $per_page = ($this->config['posts_per_page'] <= 0) ? 1 : $this->config['posts_per_page'];
+        if (($replies + 1) > $per_page)
+        {
+            for ($j = 0; $j < $replies + 1; $j += $per_page)
+            {
+                $last_post_link = $url . '-s' . $j . '.html';
+            }
+        }
+        else
+        {
+            $last_post_link = $url . '.html';
+        }
+        return $last_post_link;
+    }
+
+    /**
+     * Replace letters to use title in URL
+     *
+     * @param	string	$title	The title to use in the URL
+     * @return	string	Title to use in URLs
+     */
+    public static function title_to_url($title)
+    {
+        $url = strtolower(censor_text(utf8_normalize_nfc(strip_tags($title))));
+
+        // Let's replace
+        $url_search = array(' ', 'í', 'ý', 'ß', 'ö', 'ô', 'ó', 'ò', 'ä', 'â', 'à', 'á', 'é', 'è', 'ü', 'ú', 'ù', 'ñ', 'ß', '²', '³', '@', '€', '$');
+        $url_replace = array('-', 'i', 'y', 's', 'oe', 'o', 'o', 'o', 'ae', 'a', 'a', 'a', 'e', 'e', 'ue', 'u', 'u', 'n', 'ss', '2', '3', 'at', 'eur', 'usd');
+        $url = str_replace($url_search, $url_replace, $url);
+        $url_search = array('&amp;', '&quot;', '&', '"', "'", '¸', '`', '(', ')', '[', ']', '<', '>', '{', '}', '.', ':', ',', ';', '!', '?', '+', '*', '/', '=', 'µ', '#', '~', '"', '§', '%', '|', '°', '^', '„', '“');
+        $url = str_replace($url_search, '-', $url);
+        $url = str_replace(array('----', '---', '--'), '-', $url);
+
+        $url = substr($url, 0, 50); // Max length for a title in URL
+        return urlencode($url);
+    }
+
+    /**
+     * Get the topics post count or the forums post/topic count based on permissions
+     *
+     * @param $mode            string    One of topic_posts, forum_posts or forum_topics
+     * @param $data            array    Array with the topic/forum data to calculate from
+     * @param $forum_id        int        The forum id is used for permission checks
+     * @return int    Number of posts/topics the user can see in the topic/forum
+     */
+    private function get_count($mode, $data, $forum_id)
+    {
+        if (!$this->auth->acl_get('m_approve', $forum_id))
+        {
+            return (int) $data[$mode . '_approved'];
+        }
+
+        return (int) $data[$mode . '_approved'] + (int) $data[$mode . '_unapproved'] + (int) $data[$mode . '_softdeleted'];
+    }
 
 }

Spacing +26 added lines, -26 removed lines

@@ -77,7 +77,7 @@ 
 			'core.display_forums_modify_forum_rows'		=> 'display_forums_modify_forum_rows',
 			'core.display_forums_modify_sql'			=> 'display_forums_modify_sql',
 			'core.generate_forum_nav'				=> 'generate_forum_nav',
-			'core.make_jumpbox_modify_tpl_ary'			=> 'make_jumpbox_modify_tpl_ary',				// Not in phpBB
+			'core.make_jumpbox_modify_tpl_ary'			=> 'make_jumpbox_modify_tpl_ary', // Not in phpBB
 			'core.pagination_generate_page_link'		=> 'pagination_generate_page_link',
 			'core.search_modify_tpl_ary'				=> 'search_modify_tpl_ary',
 			'core.viewforum_modify_topicrow'			=> 'viewforum_modify_topicrow',
@@ -125,9 +125,9 @@ 
 		$forum_rows = $event['forum_rows'];
 		if ($event['row']['forum_last_post_time'] == $forum_rows[$event['parent_id']]['forum_last_post_time'])
 		{
-			$forum_rows[$event['parent_id']]['forum_name_last_post'] =$event['row']['forum_name'];
-			$forum_rows[$event['parent_id']]['topic_id_last_post'] =$event['row']['topic_id'];
-			$forum_rows[$event['parent_id']]['topic_title_last_post'] =$event['row']['topic_title'];
+			$forum_rows[$event['parent_id']]['forum_name_last_post'] = $event['row']['forum_name'];
+			$forum_rows[$event['parent_id']]['topic_id_last_post'] = $event['row']['topic_id'];
+			$forum_rows[$event['parent_id']]['topic_title_last_post'] = $event['row']['topic_title'];
 			$event['forum_rows'] = $forum_rows;
 		}
 	}
@@ -157,12 +157,12 @@ 
 
 		// Update the image source in forums
 		$img = $this->path_helper->update_web_root_path($forum_row['FORUM_IMAGE_SRC']);
-		$forum_row['FORUM_IMAGE'] = preg_replace('#img src=\"(.*)\" alt#', 'img src="' . $img . '" alt', $forum_row['FORUM_IMAGE']);
+		$forum_row['FORUM_IMAGE'] = preg_replace('#img src=\"(.*)\" alt#', 'img src="'.$img.'" alt', $forum_row['FORUM_IMAGE']);
 
 		// Rewrite links to topics, posts and forums
 		$replies = $this->get_count('topic_posts', $event['row'], $event['row']['forum_id']) - 1;
 		$url = $this->generate_topic_link($event['row']['forum_id_last_post'], $event['row']['forum_name_last_post'], $event['row']['topic_id_last_post'], $event['row']['topic_title_last_post']);
-		$forum_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($replies, $url) . '#p' . $event['row']['forum_last_post_id']);
+		$forum_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($replies, $url).'#p'.$event['row']['forum_last_post_id']);
 		$forum_row['U_VIEWFORUM'] = append_sid($this->generate_forum_link($forum_row['FORUM_ID'], $forum_row['FORUM_NAME']));
 		$event['forum_row'] = $forum_row;
 	}
@@ -182,7 +182,7 @@ 
 
 		foreach ($navlinks_parents as $id => $data)
 		{
-			$navlinks_parents[$id]['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($data['FORUM_ID'] , $data['FORUM_NAME']));
+			$navlinks_parents[$id]['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($data['FORUM_ID'], $data['FORUM_NAME']));
 		}
 
 		$navlinks['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($forum_data['forum_id'], $forum_data['forum_name']));
@@ -198,7 +198,7 @@ 
 		foreach ($tpl_ary as $id => $data)
 		{
 
-			$tpl_ary[$id]['LINK']	 = append_sid($this->generate_forum_link($row['forum_id'], $row['forum_name']));
+			$tpl_ary[$id]['LINK'] = append_sid($this->generate_forum_link($row['forum_id'], $row['forum_name']));
 		}
 
 		$event['tpl_ary'] = $tpl_ary;
@@ -245,7 +245,7 @@ 
 		$u_view_topic = $this->generate_topic_link($event['row']['forum_id'], $event['row']['forum_name'], $event['row']['topic_id'], $event['row']['topic_title']);
 
 		$tpl_ary = $event['tpl_ary'];
-		$tpl_ary['U_LAST_POST'] = append_sid($this->generate_lastpost_link($replies, $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
+		$tpl_ary['U_LAST_POST'] = append_sid($this->generate_lastpost_link($replies, $u_view_topic).'#p'.$event['row']['topic_last_post_id']);
 		$tpl_ary['U_VIEW_TOPIC'] = append_sid($u_view_topic);
 		$tpl_ary['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($event['row']['forum_id'], $event['row']['forum_name']));
 
@@ -270,7 +270,7 @@ 
 		$u_view_topic = $this->generate_topic_link($this->forum_id, $this->forum_title, $this->topic_id, $this->topic_title);
 		$topic_row['U_VIEW_TOPIC'] = append_sid($u_view_topic);
 		$topic_row['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($this->forum_id, $this->forum_title));
-		$topic_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($event['topic_row']['REPLIES'], $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
+		$topic_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($event['topic_row']['REPLIES'], $u_view_topic).'#p'.$event['row']['topic_last_post_id']);
 
 		$event['topic_row'] = $topic_row;
 	}
@@ -304,8 +304,8 @@ 
 	{
 		$data = $event['topic_data'];
 		$this->template->assign_vars(array(
-			'U_VIEW_TOPIC'		=> append_sid($this->generate_topic_link($event['forum_id'] , $data['forum_name'], $event['topic_id'], $data['topic_title'], $event['start'])),
-			'U_VIEW_FORUM'	=> append_sid($this->generate_forum_link($event['forum_id'] , $data['forum_name'])),
+			'U_VIEW_TOPIC'		=> append_sid($this->generate_topic_link($event['forum_id'], $data['forum_name'], $event['topic_id'], $data['topic_title'], $event['start'])),
+			'U_VIEW_FORUM'	=> append_sid($this->generate_forum_link($event['forum_id'], $data['forum_name'])),
 		));
 	}
 
@@ -352,7 +352,7 @@ 
 		$row = $event['post_row'];
 		$start = $this->request->variable('start', 0);
 		$data = $event['topic_data'];
-		$row['U_MINI_POST'] = append_sid($this->generate_topic_link($data['forum_id'], $data['forum_name'], $data['topic_id'], $data['topic_title'], $start) . '#p' . $event['row']['post_id']);
+		$row['U_MINI_POST'] = append_sid($this->generate_topic_link($data['forum_id'], $data['forum_name'], $data['topic_id'], $data['topic_title'], $start).'#p'.$event['row']['post_id']);
 		$event['post_row'] = $row;
 	}
 
@@ -371,14 +371,14 @@ 
 			return;
 		}
 
-		$url_data =$event['url_data'] ;
+		$url_data = $event['url_data'];
 
 		foreach ($url_data as $id => $data)
 		{
 			$row = $data['row'];
 			if (isset($row['topic_id']))
 			{
-				$url_data[$id]['url'] = $this->generate_topic_link($row['forum_id'], $row['forum_name'], $row['topic_id'], $row['topic_title'],  $data['start'], true);
+				$url_data[$id]['url'] = $this->generate_topic_link($row['forum_id'], $row['forum_name'], $row['topic_id'], $row['topic_title'], $data['start'], true);
 			}
 			else if (isset($row['forum_id']))
 			{
@@ -404,10 +404,10 @@ 
 		$this->topic_id = $event['row']['topic_id'];
 
 		$topic_row = $event['topic_row'];
-		$u_view_topic= $this->generate_topic_link($this->forum_id, $this->forum_title, $this->topic_id, $this->topic_title);
+		$u_view_topic = $this->generate_topic_link($this->forum_id, $this->forum_title, $this->topic_id, $this->topic_title);
 		$topic_row['U_VIEW_TOPIC'] = append_sid($u_view_topic);
 		$topic_row['U_VIEW_FORUM'] = append_sid($this->generate_forum_link($this->forum_id, $this->forum_title));
-		$topic_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($topic_row['TOPIC_REPLIES'], $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
+		$topic_row['U_LAST_POST'] = append_sid($this->generate_lastpost_link($topic_row['TOPIC_REPLIES'], $u_view_topic).'#p'.$event['row']['topic_last_post_id']);
 		$event['topic_row'] = $topic_row;
 	}
 
@@ -438,7 +438,7 @@ 
 		$tpl_ary = $event['tpl_ary'];
 		$replies = $this->get_count('topic_posts', $event['row'], $event['row']['forum_id']) - 1;
 		$u_view_topic = $this->generate_topic_link($event['row']['forum_id'], $event['row']['forum_name'], $event['row']['topic_id'], $event['row']['topic_title']);
-		$tpl_ary['U_TOPIC'] = append_sid($this->generate_lastpost_link($replies, $u_view_topic) . '#p' . $event['row']['topic_last_post_id']);
+		$tpl_ary['U_TOPIC'] = append_sid($this->generate_lastpost_link($replies, $u_view_topic).'#p'.$event['row']['topic_last_post_id']);
 		$event['tpl_ary'] = $tpl_ary;
 	}
 
@@ -458,9 +458,9 @@ 
 	{
 		if ($full)
 		{
-			return generate_board_url() . '/' . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . $this->title_to_url($topic_title) . '-t' . $topic_id . ($start ? '-s' . $start : '') . '.html';
+			return generate_board_url().'/'.$this->title_to_url($forum_name).'-f'.$forum_id.'/'.$this->title_to_url($topic_title).'-t'.$topic_id.($start ? '-s'.$start : '').'.html';
 		}
-		return $this->phpbb_root_path . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . $this->title_to_url($topic_title) . '-t' . $topic_id . ($start ? '-s' . $start : '') . '.html';
+		return $this->phpbb_root_path.$this->title_to_url($forum_name).'-f'.$forum_id.'/'.$this->title_to_url($topic_title).'-t'.$topic_id.($start ? '-s'.$start : '').'.html';
 	}
 
 	/**
@@ -477,9 +477,9 @@ 
 	{
 		if ($full)
 		{
-			return generate_board_url() . '/' . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . ($start ? 'index-s' . $start . '.html' : '');
+			return generate_board_url().'/'.$this->title_to_url($forum_name).'-f'.$forum_id.'/'.($start ? 'index-s'.$start.'.html' : '');
 		}
-		return $this->phpbb_root_path . $this->title_to_url($forum_name) . '-f' . $forum_id . '/' . ($start ? 'index-s' . $start . '.html' : '');
+		return $this->phpbb_root_path.$this->title_to_url($forum_name).'-f'.$forum_id.'/'.($start ? 'index-s'.$start.'.html' : '');
 	}
 
 	/**
@@ -497,12 +497,12 @@ 
 		{
 			for ($j = 0; $j < $replies + 1; $j += $per_page)
 			{
-				$last_post_link = $url . '-s' . $j . '.html';
+				$last_post_link = $url.'-s'.$j.'.html';
 			}
 		}
 		else
 		{
-			$last_post_link = $url . '.html';
+			$last_post_link = $url.'.html';
 		}
 		return $last_post_link;
 	}
@@ -541,10 +541,10 @@ 
 	{
 		if (!$this->auth->acl_get('m_approve', $forum_id))
 		{
-			return (int) $data[$mode . '_approved'];
+			return (int) $data[$mode.'_approved'];
 		}
 
-		return (int) $data[$mode . '_approved'] + (int) $data[$mode . '_unapproved'] + (int) $data[$mode . '_softdeleted'];
+		return (int) $data[$mode.'_approved'] + (int) $data[$mode.'_unapproved'] + (int) $data[$mode.'_softdeleted'];
 	}
 
 }