tarsana / functional

src/common.php

Doc Comments -2 removed lines

@@ -24,7 +24,6 @@ 
  * ```
  *
  * @signature * -> String
- * @param  mixed $data
  * @return string
  */
 function type() {
@@ -79,7 +78,6 @@ 
  * ```
  *
  * @signature * -> String
- * @param  mixed $something
  * @return string
  */
 function toString () {

Spacing +4 added lines, -4 removed lines

@@ -82,7 +82,7 @@ 
  * @param  mixed $something
  * @return string
  */
-function toString () {
+function toString() {
     $toString = function($something) {
         switch (type($something)) {
             case 'String':
@@ -105,11 +105,11 @@ 
                 return $something->__toString();
             case 'Object':
             case 'Array':
-                return '{' . join(', ', map(function($pair){
-                    return $pair[0].': '. toString($pair[1]);
+                return '{' . join(', ', map(function($pair) {
+                    return $pair[0] . ': ' . toString($pair[1]);
                 }, toPairs($something))) . '}';
             default:
-                return '['.type($something).']';
+                return '[' . type($something) . ']';
         }
     };
     return apply(curry($toString), func_get_args());

Braces +12 added lines, -5 removed lines

@@ -29,9 +29,15 @@ 
  */
 function type() {
     $type = function($data) {
-        if ($data instanceof Error) return 'Error';
-        if ($data instanceof Stream) return "Stream({$data->type})";
-        if (is_callable($data)) return 'Function';
+        if ($data instanceof Error) {
+            return 'Error';
+        }
+        if ($data instanceof Stream) {
+            return "Stream({$data->type})";
+        }
+        if (is_callable($data)) {
+            return 'Function';
+        }
         switch (gettype($data)) {
             case 'boolean':
                 return 'Boolean';
@@ -45,8 +51,9 @@ 
             case 'resource':
                 return 'Resource';
             case 'array':
-                if (allSatisfies('is_numeric', keys($data)))
-                    return 'List';
+                if (allSatisfies('is_numeric', keys($data))) {
+                                    return 'List';
+                }
                 return 'Array';
             case 'object':
                 return 'Object';

src/functions.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
  * This file contains functions dealing with functions.
  */
 
-use Tarsana\Functional\Exceptions\InvalidArgument;
-
 /**
  * Adds the `Tarsana\Functional\` namespace to a function name.
  * This is useful to pass non-curried functions as parameter.

Braces +9 added lines, -6 removed lines

@@ -59,8 +59,9 @@ 
     $addArgument = function($currentBoundArgs, $arg) use($fnArgsCount) {
         $currentBoundArgsCount = count($currentBoundArgs);
         $placeholderPosition = 0;
-        while($placeholderPosition < $currentBoundArgsCount && !_is_placeholder($currentBoundArgs[$placeholderPosition]))
-            $placeholderPosition ++;
+        while($placeholderPosition < $currentBoundArgsCount && !_is_placeholder($currentBoundArgs[$placeholderPosition])) {
+                    $placeholderPosition ++;
+        }
         if ($currentBoundArgsCount < $fnArgsCount || $placeholderPosition == $currentBoundArgsCount) {
             $currentBoundArgs[] = $arg;
         } else { // There is a placeholder and number of bound args >= $fnArgsCount
@@ -87,8 +88,9 @@ 
         $boundArgs = _merge_args($argsCount, $boundArgs, func_get_args());
         $numberOfPlaceholders = count(array_filter($boundArgs, _f('_is_placeholder')));
         $numberOfGivenArgs = count($boundArgs) - $numberOfPlaceholders;
-        if ($numberOfGivenArgs >= $argsCount)
-            return call_user_func_array($fn, $boundArgs);
+        if ($numberOfGivenArgs >= $argsCount) {
+                    return call_user_func_array($fn, $boundArgs);
+        }
         return _curried_function($fn, $argsCount, $boundArgs);
     };
 }
@@ -179,8 +181,9 @@ 
  */
 function pipe() {
     $fns = func_get_args();
-    if(count($fns) < 1)
-        return _f('identity');
+    if(count($fns) < 1) {
+            return _f('identity');
+    }
     return curry(function () use ($fns) {
         $result = _apply(array_shift($fns), func_get_args());
         foreach ($fns as $fn) {

src/math.php

Doc Comments -13 removed lines

@@ -11,8 +11,6 @@ 
  * ```
  *
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function plus() {
@@ -29,8 +27,6 @@ 
  * ```
  *
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function minus() {
@@ -48,7 +44,6 @@ 
  * ```
  *
  * @signature Number -> Number
- * @param  int|float $x
  * @return int|float
  */
 function negate() {
@@ -65,8 +60,6 @@ 
  * ```
  *
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function multiply() {
@@ -83,8 +76,6 @@ 
  * ```
  *
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function divide() {
@@ -101,8 +92,6 @@ 
  * ```
  *
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function modulo() {
@@ -120,7 +109,6 @@ 
  * ```
  *
  * @signature [Number] -> Number
- * @param  array $numbers
  * @return int|float
  */
 function sum() {
@@ -137,7 +125,6 @@ 
  * ```
  *
  * @signature [Number] -> Number
- * @param  array $numbers
  * @return int|float
  */
 function product() {

Spacing +9 added lines, -9 removed lines

@@ -16,7 +16,7 @@ 
  * @return int|float
  */
 function plus() {
-    $plus = curry(function($x, $y){
+    $plus = curry(function($x, $y) {
         return $x + $y;
     });
     return apply($plus, func_get_args());
@@ -34,7 +34,7 @@ 
  * @return int|float
  */
 function minus() {
-    $minus = curry(function($x, $y){
+    $minus = curry(function($x, $y) {
         return $x - $y;
     });
     return apply($minus, func_get_args());
@@ -52,8 +52,8 @@ 
  * @return int|float
  */
 function negate() {
-    return apply(curry(function($x){
-        return -$x;
+    return apply(curry(function($x) {
+        return - $x;
     }), func_get_args());
 }
 
@@ -70,7 +70,7 @@ 
  * @return int|float
  */
 function multiply() {
-    $multiply = curry(function($x, $y){
+    $multiply = curry(function($x, $y) {
         return $y * $x;
     });
     return apply($multiply, func_get_args());
@@ -88,7 +88,7 @@ 
  * @return int|float
  */
 function divide() {
-    $divide = curry(function($x, $y){
+    $divide = curry(function($x, $y) {
         return $x / $y;
     });
     return apply($divide, func_get_args());
@@ -106,7 +106,7 @@ 
  * @return int|float
  */
 function modulo() {
-    $modulo = curry(function($x, $y){
+    $modulo = curry(function($x, $y) {
         return $x % $y;
     });
     return apply($modulo, func_get_args());
@@ -124,7 +124,7 @@ 
  * @return int|float
  */
 function sum() {
-    return apply(curry(function($numbers){
+    return apply(curry(function($numbers) {
         return reduce(plus(), 0, $numbers);
     }), func_get_args());
 }
@@ -141,7 +141,7 @@ 
  * @return int|float
  */
 function product() {
-    return apply(curry(function($numbers){
+    return apply(curry(function($numbers) {
         return reduce(multiply(), 1, $numbers);
     }), func_get_args());
 }

src/object.php

Doc Comments -18 removed lines

@@ -19,7 +19,6 @@ 
  * ```
  *
  * @signature a -> a
- * @param  mixed $value
  * @return mixed
  */
 function clone_() {
@@ -67,7 +66,6 @@ 
  * ```
  *
  * @signature {k: v} -> {k: v}
- * @param  object $object
  * @return array
  */
 function attributes() {
@@ -143,8 +141,6 @@ 
  * ```
  *
  * @signature k -> {k: v} -> Boolean
- * @param  string|int $name
- * @param  mixed $object
  * @return bool
  */
 function has() {
@@ -173,8 +169,6 @@ 
  * ```
  *
  * @signature k -> {k: v} -> Maybe(v)
- * @param  string $name
- * @param  array $object
  * @return mixed
  */
 function get() {
@@ -201,8 +195,6 @@ 
  * ```
  *
  * @signature [k] -> {k: v} -> v
- * @param  array $path
- * @param  mixed $object
  * @return mixed
  */
 function getPath() {
@@ -229,9 +221,6 @@ 
  * ```
  *
  * @signature k -> v -> {k: v} -> {k: v}
- * @param  string|int $name
- * @param  mixed $value
- * @param  mixed $object
  * @return mixed
  */
 function set() {
@@ -258,9 +247,6 @@ 
  * ```
  *
  * @signature (a -> Boolean) -> k -> {k : a} -> Boolean
- * @param  callable $predicate
- * @param  string|int $key
- * @param  mixed $object
  * @return bool
  */
 function satisfies() {
@@ -294,8 +280,6 @@ 
  * ```
  *
  * @signature {String: (a -> Boolean)} -> {k : a} -> Boolean
- * @param  array $predicates
- * @param  mixed $object
  * @return bool
  */
 function satisfiesAll() {
@@ -335,8 +319,6 @@ 
  * ```
  *
  * @signature {String: (a -> Boolean)} -> {k : a} -> Boolean
- * @param  array $predicates
- * @param  mixed $object
  * @return bool
  */
 function satisfiesAny() {

src/string.php

Spacing +2 added lines, -3 removed lines

@@ -32,7 +32,7 @@ 
  * @return string
  */
 function join() {
-    return apply(curry(function($glue, $pieces){
+    return apply(curry(function($glue, $pieces) {
         return implode($glue, $pieces);
     }), func_get_args());
 }
@@ -306,8 +306,7 @@ 
         $updateCountAt = curry(function($item, $counts, $index) use($openings, $closings) {
             $count = occurences(__(), $item);
             return ($openings[$index] == $closings[$index]) ?
-                ($counts[$index] + $count($openings[$index])) % 2 :
-                $counts[$index] + $count($openings[$index]) - $count($closings[$index]);
+                ($counts[$index] + $count($openings[$index])) % 2 : $counts[$index] + $count($openings[$index]) - $count($closings[$index]);
         });
         // Updates counts for all surrenders
         $updateCounts = curry(function($item, $counts) use($indexes, $updateCountAt) {