tarsana / functional

src/operators.php

Braces +3 added lines, -2 removed lines

@@ -97,8 +97,9 @@
 function equals() {
     $equals = function($a, $b) {
             $type = type($a);
-            if ($type != type($b))
-                return false;
+            if ($type != type($b)) {
+                            return false;
+            }
             switch ($type) {
                 case 'Null':
                 case 'Boolean':

Doc Comments -23 removed lines

@@ -8,8 +8,6 @@ 
  * Returns `$a && $b`.
  *
  * @signature Boolean -> Boolean -> Boolean
- * @param  bool $a
- * @param  bool $b
  * @return bool
  */
 function and_() {
@@ -22,8 +20,6 @@ 
  * Returns `$a || $b`.
  *
  * @signature Boolean -> Boolean -> Boolean
- * @param  bool $a
- * @param  bool $b
  * @return bool
  */
 function or_() {
@@ -36,7 +32,6 @@ 
  * Returns `!$x`.
  *
  * @signature Boolean -> Boolean
- * @param  bool $x
  * @return bool
  */
 function not() {
@@ -50,8 +45,6 @@ 
  * Returns `$x == $y`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function eq() {
@@ -64,8 +57,6 @@ 
  * Returns `$x != $y`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function notEq() {
@@ -78,8 +69,6 @@ 
  * Returns `$x === $y`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function eqq() {
@@ -92,8 +81,6 @@ 
  * Returns `$x !== $y`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function notEqq() {
@@ -118,8 +105,6 @@ 
  * ```
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function equals() {
@@ -157,8 +142,6 @@ 
  * Returns `$a < $b`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function lt() {
@@ -171,8 +154,6 @@ 
  * Returns `$a <= $b`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function lte() {
@@ -185,8 +166,6 @@ 
  * Returns `$a > $b`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function gt() {
@@ -199,8 +178,6 @@ 
  * Returns `$a >= $b`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function gte() {

Spacing +11 added lines, -13 removed lines

@@ -22,7 +22,7 @@ 
  */
 function and_() {
     static $and = false;
-    $and = $and ?: curry(function($a, $b){
+    $and = $and ?: curry(function($a, $b) {
         return $a && $b;
     });
     return _apply($and, func_get_args());
@@ -45,7 +45,7 @@ 
  */
 function or_() {
     static $or = false;
-    $or = $or ?: curry(function($a, $b){
+    $or = $or ?: curry(function($a, $b) {
         return $a || $b;
     });
     return _apply($or, func_get_args());
@@ -85,7 +85,7 @@ 
  * @return bool
  */
 function eq() {
-    $eq = curry(function($a, $b){
+    $eq = curry(function($a, $b) {
         return $a == $b;
     });
     return _apply($eq, func_get_args());
@@ -106,7 +106,7 @@ 
  */
 function notEq() {
     static $notEq = false;
-    $notEq = $notEq ?: curry(function($a, $b){
+    $notEq = $notEq ?: curry(function($a, $b) {
         return $a != $b;
     });
     return _apply($notEq, func_get_args());
@@ -126,7 +126,7 @@ 
  */
 function eqq() {
     static $eqq = false;
-    $eqq = $eqq ?: curry(function($a, $b){
+    $eqq = $eqq ?: curry(function($a, $b) {
         return $a === $b;
     });
     return _apply($eqq, func_get_args());
@@ -147,7 +147,7 @@ 
  */
 function notEqq() {
     static $notEqq = false;
-    $notEqq = $notEqq ?: curry(function($a, $b){
+    $notEqq = $notEqq ?: curry(function($a, $b) {
         return $a !== $b;
     });
     return _apply($notEqq, func_get_args());
@@ -196,9 +196,7 @@ 
                     return $a == $b;
                 case 'List':
                     $length = length($a);
-                    return length($b) != $length ? false :
-                           0 == $length ? true :
-                           equals(head($a), head($b)) && equals(tail($a), tail($b));
+                    return length($b) != $length ? false : 0 == $length ? true : equals(head($a), head($b)) && equals(tail($a), tail($b));
                 case 'Array':
                 case 'ArrayObject':
                 case 'Object':
@@ -252,7 +250,7 @@ 
  */
 function lt() {
     static $lt = false;
-    $lt = $lt ?: curry(function($a, $b){
+    $lt = $lt ?: curry(function($a, $b) {
         return $a < $b;
     });
     return _apply($lt, func_get_args());
@@ -274,7 +272,7 @@ 
  */
 function lte() {
     static $lte = false;
-    $lte = $lte ?: curry(function($a, $b){
+    $lte = $lte ?: curry(function($a, $b) {
         return $a <= $b;
     });
     return _apply($lte, func_get_args());
@@ -296,7 +294,7 @@ 
  */
 function gt() {
     static $gt = false;
-    $gt = $gt ?: curry(function($a, $b){
+    $gt = $gt ?: curry(function($a, $b) {
         return $a > $b;
     });
     return _apply($gt, func_get_args());
@@ -318,7 +316,7 @@ 
  */
 function gte() {
     static $gte = false;
-    $gte = $gte ?: curry(function($a, $b){
+    $gte = $gte ?: curry(function($a, $b) {
         return $a >= $b;
     });
     return _apply($gte, func_get_args());

src/object.php

Braces +11 added lines, -8 removed lines

@@ -72,8 +72,9 @@ 
  */
 function attributes() {
     $attrs = function($object) {
-        if (is_object($object))
-            return get_object_vars($object);
+        if (is_object($object)) {
+                    return get_object_vars($object);
+        }
         return $object;
     };
     return apply(curry($attrs), func_get_args());
@@ -208,8 +209,9 @@ 
 function getPath() {
     $getPath = function($path, $object){
         return reduce(function($result, $name) {
-            if ($result !== null)
-                $result = get($name, $result);
+            if ($result !== null) {
+                            $result = get($name, $result);
+            }
             return $result;
         }, $object, $path);
     };
@@ -237,10 +239,11 @@ 
 function set() {
     $set = function($name, $value, $object) {
         $object = clone_($object);
-        if (is_object($object))
-            $object->{$name} = $value;
-        else
-            $object[$name] = $value;
+        if (is_object($object)) {
+                    $object->{$name} = $value;
+        } else {
+                    $object[$name] = $value;
+        }
         return $object;
     };
     return apply(curry($set), func_get_args());

Doc Comments -24 removed lines

@@ -22,7 +22,6 @@ 
  * ```
  *
  * @signature a -> a
- * @param  mixed $value
  * @return mixed
  */
 function clone_() {
@@ -73,7 +72,6 @@ 
  *
  * @stream
  * @signature {k: v} -> {k: v}
- * @param  object|array $object
  * @return array
  */
 function attributes() {
@@ -98,7 +96,6 @@ 
  * @stream
  * @signature [*] -> [Number]
  * @signature {k: v} -> [k]
- * @param object|array $object
  * @return array
  */
 function keys() {
@@ -121,7 +118,6 @@ 
  * @stream
  * @signature [a] -> [a]
  * @signature {k: v} -> [v]
- * @param object|array $object
  * @return array
  */
 function values() {
@@ -162,8 +158,6 @@ 
  *
  * @stream
  * @signature k -> {k: v} -> Boolean
- * @param  string|int $name
- * @param  mixed $object
  * @return bool
  */
 function has() {
@@ -195,8 +189,6 @@ 
  *
  * @stream
  * @signature k -> {k: v} -> Maybe(v)
- * @param  string $name
- * @param  array $object
  * @return mixed
  */
 function get() {
@@ -227,8 +219,6 @@ 
  *
  * @stream
  * @signature [k] -> {k: v} -> v
- * @param  array $path
- * @param  mixed $object
  * @return mixed
  */
 function getPath() {
@@ -259,9 +249,6 @@ 
  *
  * @stream
  * @signature k -> v -> {k: v} -> {k: v}
- * @param  string|int $name
- * @param  mixed $value
- * @param  mixed $object
  * @return mixed
  */
 function set() {
@@ -293,9 +280,6 @@ 
  *
  * @stream
  * @signature k -> (v -> v) -> {k: v} -> {k: v}
- * @param  string|int $name
- * @param  callable $fn
- * @param  mixed $object
  * @return mixed
  */
 function update() {
@@ -321,9 +305,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> k -> {k : a} -> Boolean
- * @param  callable $predicate
- * @param  string|int $key
- * @param  mixed $object
  * @return bool
  */
 function satisfies() {
@@ -356,8 +337,6 @@ 
  *
  * @stream
  * @signature {String: (a -> Boolean)} -> {k : a} -> Boolean
- * @param  array $predicates
- * @param  mixed $object
  * @return bool
  */
 function satisfiesAll() {
@@ -394,8 +373,6 @@ 
  *
  * @stream
  * @signature {String: (a -> Boolean)} -> {k : a} -> Boolean
- * @param  array $predicates
- * @param  mixed $object
  * @return bool
  */
 function satisfiesAny() {
@@ -420,7 +397,6 @@ 
  *
  * @stream
  * @signature {k: v} -> [(k,v)]
- * @param  array $object
  * @return array
  */
 function toPairs() {

Spacing +3 added lines, -3 removed lines

@@ -168,7 +168,7 @@ 
  */
 function has() {
     static $has = false;
-    $has = $has ?: curry(function($name, $object){
+    $has = $has ?: curry(function($name, $object) {
         return contains($name, keys($object));
     });
     return _apply($has, func_get_args());
@@ -201,7 +201,7 @@ 
  */
 function get() {
     static $get = false;
-    $get = $get ?: curry(function($name, $object){
+    $get = $get ?: curry(function($name, $object) {
         $object = attributes($object);
         return has($name, $object)
             ? $object[$name]
@@ -233,7 +233,7 @@ 
  */
 function getPath() {
     static $getPath = false;
-    $getPath = $getPath ?: curry(function($path, $object){
+    $getPath = $getPath ?: curry(function($path, $object) {
         return reduce(function($result, $name) {
             if ($result !== null)
                 $result = get($name, $result);

src/common.php

Spacing +4 added lines, -4 removed lines

@@ -82,7 +82,7 @@ 
  * @param  mixed $something
  * @return string
  */
-function toString () {
+function toString() {
     $toString = function($something) {
         switch (type($something)) {
             case 'String':
@@ -105,11 +105,11 @@ 
                 return $something->__toString();
             case 'Object':
             case 'Array':
-                return '{' . join(', ', map(function($pair){
-                    return $pair[0].': '. toString($pair[1]);
+                return '{' . join(', ', map(function($pair) {
+                    return $pair[0] . ': ' . toString($pair[1]);
                 }, toPairs($something))) . '}';
             default:
-                return '['.type($something).']';
+                return '[' . type($something) . ']';
         }
     };
     return apply(curry($toString), func_get_args());

Doc Comments -4 removed lines

@@ -26,7 +26,6 @@ 
  * ```
  *
  * @signature * -> String
- * @param  mixed $data
  * @return string
  */
 function type() {
@@ -73,8 +72,6 @@ 
  *
  * @stream
  * @signature String -> * -> Boolean
- * @param  string $type
- * @param  mixed $data
  * @return boolean
  */
 function is() {
@@ -109,7 +106,6 @@ 
  *
  * @stream
  * @signature * -> String
- * @param  mixed $something
  * @return string
  */
 function toString () {

Braces +12 added lines, -5 removed lines

@@ -32,9 +32,15 @@ 
 function type() {
     static $type = false;
     $type = $type ?: curry(function($data) {
-        if ($data instanceof Error) return 'Error';
-        if ($data instanceof Stream) return "Stream";
-        if (is_callable($data)) return 'Function';
+        if ($data instanceof Error) {
+            return 'Error';
+        }
+        if ($data instanceof Stream) {
+            return "Stream";
+        }
+        if (is_callable($data)) {
+            return 'Function';
+        }
         switch (gettype($data)) {
             case 'boolean':
                 return 'Boolean';
@@ -48,8 +54,9 @@ 
             case 'resource':
                 return 'Resource';
             case 'array':
-                if (allSatisfies('is_numeric', keys($data)))
-                    return 'List';
+                if (allSatisfies('is_numeric', keys($data))) {
+                                    return 'List';
+                }
                 return 'Array';
             case 'object':
                 return 'Object';

build.php

Doc Comments -3 removed lines

@@ -634,8 +634,6 @@ 
  * Gets an element of the stream methods list.
  *
  * @signature String -> Block -> String
- * @param  string $moduleName
- * @param  object $block
  * @return string
  */
 function stream_method_link() {
@@ -661,7 +659,6 @@ 
  * Dump a variable and returns it.
  *
  * @signature a -> a
- * @param  mixed $something
  * @return mixed
  */
 function log() {

Spacing +15 added lines, -15 removed lines

@@ -116,7 +116,7 @@ 
  * @return array
  */
 function get_modules() {
-    $composer = json_decode(file_get_contents(__DIR__.'/composer.json'));
+    $composer = json_decode(file_get_contents(__DIR__ . '/composer.json'));
     return $composer->autoload->files;
 }
 
@@ -147,10 +147,10 @@ 
  */
 function write_module($module) {
     if ($module->docs) {
-        $docsDir  = dirname($module->docsPath);
+        $docsDir = dirname($module->docsPath);
         if (!is_dir($docsDir))
             mkdir($docsDir, 0777, true);
-        file_put_contents($module->docsPath,  $module->docs);
+        file_put_contents($module->docsPath, $module->docs);
     }
     if ($module->tests) {
         $testsDir = dirname($module->testsPath);
@@ -179,7 +179,7 @@ 
         'fill_docs_path',
         'fill_tests_path',
         'fill_blocks'
-    ]), [(object)['path' => $path]]);
+    ]), [(object) ['path' => $path]]);
 }
 
 /**
@@ -233,8 +233,8 @@ 
 function fill_blocks($module) {
     $module->blocks = apply(pipe(
         prepend('dox -r < '), // "dox -r < src/...php"
-        'shell_exec',         // "[{...}, ...]"
-        'json_decode',        // [DoxBlock]
+        'shell_exec', // "[{...}, ...]"
+        'json_decode', // [DoxBlock]
         map(_f('make_block'))
         // sort()
     ), [$module->path]);
@@ -256,7 +256,7 @@ 
     if (has('class', $tags)) $type = 'class';
     if (has('method', $tags)) $type = 'method';
 
-    $params = map(function($tag){
+    $params = map(function($tag) {
         $parts = split(' ', get('value', $tag));
         return [
             'type' => $parts[0],
@@ -292,7 +292,7 @@ 
  */
 function tags_of($doxBlock) {
     if ($doxBlock->tags)
-        return map(function($tag){
+        return map(function($tag) {
             return (object) [
                 'name'  => $tag->type,
                 'value' => $tag->string
@@ -341,7 +341,7 @@ 
  * @return object
  */
 function generate_docs_sommaire($module) {
-    $blocks = filter (
+    $blocks = filter(
         satisfiesAll(['ignore' => not(), 'internal' => not(), 'type' => equals('function')]),
         $module->blocks
     );
@@ -371,7 +371,7 @@ 
  * @return object
  */
 function generate_docs_contents($module) {
-    $blocks = filter (
+    $blocks = filter(
         satisfiesAll(['ignore' => not(), 'internal' => not()]),
         $module->blocks
     );
@@ -429,7 +429,7 @@ 
     $additionalNamespace = replace("/", "\\", remove(6, dirname($module->testsPath)));
     if ($additionalNamespace)
         $namespace .= "\\" . $additionalNamespace;
-    $name = remove(-4, last(split("/", $module->testsPath)));
+    $name = remove(- 4, last(split("/", $module->testsPath)));
     $module->tests .= "<?php namespace {$namespace};\n\nuse Tarsana\Functional as F;\n\nclass {$name} extends \Tarsana\UnitTests\Functional\UnitTest {\n";
     return $module;
 }
@@ -442,7 +442,7 @@ 
  * @return object
  */
 function generate_tests_contents($module) {
-    $blocks = filter (
+    $blocks = filter(
         satisfiesAll(['ignore' => not()]),
         $module->blocks
     );
@@ -499,7 +499,7 @@ 
     if (!contains('```php', $description))
         return '';
     $code = remove(7 + indexOf('```php', $description), $description);
-    return remove(-4, trim($code));
+    return remove(- 4, trim($code));
 }
 
 /**
@@ -552,7 +552,7 @@ 
  * @return array
  */
 function generate_stream_operations($module) {
-    $blocks = filter (
+    $blocks = filter(
         satisfiesAll(['ignore' => equals(false), 'stream' => equals(true)]),
         $module->blocks
     );
@@ -621,7 +621,7 @@ 
  * @return array
  */
 function generate_stream_methods($module) {
-    $blocks = filter (
+    $blocks = filter(
         satisfiesAll(['ignore' => equals(false), 'stream' => equals(true)]),
         $module->blocks
     );

Braces +52 added lines, -35 removed lines

@@ -148,14 +148,16 @@ 
 function write_module($module) {
     if ($module->docs) {
         $docsDir  = dirname($module->docsPath);
-        if (!is_dir($docsDir))
-            mkdir($docsDir, 0777, true);
+        if (!is_dir($docsDir)) {
+                    mkdir($docsDir, 0777, true);
+        }
         file_put_contents($module->docsPath,  $module->docs);
     }
     if ($module->tests) {
         $testsDir = dirname($module->testsPath);
-        if (!is_dir($testsDir))
-            mkdir($testsDir, 0777, true);
+        if (!is_dir($testsDir)) {
+                    mkdir($testsDir, 0777, true);
+        }
         file_put_contents($module->testsPath, $module->tests);
     }
     if ($module->streamOperations) {
@@ -252,9 +254,15 @@ 
     $tags = groupBy(get('name'), tags_of($doxBlock));
 
     $type = 'function';
-    if (has('file', $tags)) $type = 'file';
-    if (has('class', $tags)) $type = 'class';
-    if (has('method', $tags)) $type = 'method';
+    if (has('file', $tags)) {
+        $type = 'file';
+    }
+    if (has('class', $tags)) {
+        $type = 'class';
+    }
+    if (has('method', $tags)) {
+        $type = 'method';
+    }
 
     $params = map(function($tag){
         $parts = split(' ', get('value', $tag));
@@ -266,8 +274,9 @@ 
 
     $return = getPath(['return', 0, 'value'], $tags);
     $signatures = get('signature', $tags);
-    if ($signatures)
-        $signatures = map(get('value'), $signatures);
+    if ($signatures) {
+            $signatures = map(get('value'), $signatures);
+    }
     return (object) [
         'type' => $type,
         'name' => getPath(['ctx', 'name'], $doxBlock),
@@ -291,12 +300,13 @@ 
  * @return array
  */
 function tags_of($doxBlock) {
-    if ($doxBlock->tags)
-        return map(function($tag){
+    if ($doxBlock->tags) {
+            return map(function($tag){
             return (object) [
                 'name'  => $tag->type,
                 'value' => $tag->string
             ];
+    }
         }, $doxBlock->tags);
     return [];
 }
@@ -310,8 +320,9 @@ 
  */
 function generate_docs($module) {
     $module->docs = '';
-    if (startsWith('_', $module->name))
-        return $module;
+    if (startsWith('_', $module->name)) {
+            return $module;
+    }
     return apply(process_of([
         'generate_docs_header',
         'generate_docs_sommaire',
@@ -388,15 +399,17 @@ 
  * @return string
  */
 function generate_docs_contents_item($block) {
-    if ($block->type != 'function')
-        return '';
+    if ($block->type != 'function') {
+            return '';
+    }
     $params = join(', ', map(pipe(values(), join(' ')), get('params', $block)));
     $return = get('return', $block);
     $prototype = "```php\n{$block->name}({$params}) : {$return}\n```\n\n";
     $signature = '';
     $blockSignature = join("\n", $block->signatures);
-    if ($blockSignature)
-        $signature = "```\n{$blockSignature}\n```\n\n";
+    if ($blockSignature) {
+            $signature = "```\n{$blockSignature}\n```\n\n";
+    }
     return "# {$block->name}\n\n{$prototype}{$signature}{$block->description}\n\n";
 }
 
@@ -427,8 +440,9 @@ 
 function generate_tests_header($module) {
     $namespace = "Tarsana\UnitTests\Functional";
     $additionalNamespace = replace("/", "\\", remove(6, dirname($module->testsPath)));
-    if ($additionalNamespace)
-        $namespace .= "\\" . $additionalNamespace;
+    if ($additionalNamespace) {
+            $namespace .= "\\" . $additionalNamespace;
+    }
     $name = remove(-4, last(split("/", $module->testsPath)));
     $module->tests .= "<?php namespace {$namespace};\n\nuse Tarsana\Functional as F;\n\nclass {$name} extends \Tarsana\UnitTests\Functional\UnitTest {\n";
     return $module;
@@ -449,10 +463,11 @@ 
     $contents = join("\n", map(function($block) use($module) {
         return generate_tests_contents_item($block, $module);
     }, $blocks));
-    if (trim($contents) != '')
-        $module->tests .= $contents;
-    else
-        $module->tests = '';
+    if (trim($contents) != '') {
+            $module->tests .= $contents;
+    } else {
+            $module->tests = '';
+    }
     return $module;
 }
 
@@ -465,8 +480,9 @@ 
  * @return string
  */
 function generate_tests_contents_item($block, $module) {
-    if ($block->type != 'function')
-        return '';
+    if ($block->type != 'function') {
+            return '';
+    }
 
     $code = apply(pipe(
         _f('code_from_description'),
@@ -480,8 +496,9 @@ 
         join("\n")
     ), [$block]);
 
-    if ('' == trim($code))
-        return '';
+    if ('' == trim($code)) {
+            return '';
+    }
     return prepend("\tpublic function test_{$block->name}() {\n",
         append("\n\t}\n", $code)
     );
@@ -496,8 +513,9 @@ 
  */
 function code_from_description($block) {
     $description = get('description', $block);
-    if (!contains('```php', $description))
-        return '';
+    if (!contains('```php', $description)) {
+            return '';
+    }
     $code = remove(7 + indexOf('```php', $description), $description);
     return remove(-4, trim($code));
 }
@@ -513,8 +531,7 @@ 
     if (contains('; //=> ', $part)) {
         $pieces = split('; //=> ', $part);
         $part = "\$this->assertEquals({$pieces[1]}, {$pieces[0]});";
-    }
-    elseif (contains('; // throws ', $part)) {
+    } elseif (contains('; // throws ', $part)) {
         $pieces = split('; // throws ', $part);
         $variables = match('/ \$[0-9a-zA-Z_]+/', $pieces[0]);
         $use = '';
@@ -523,8 +540,7 @@ 
             $use = "use({$variables}) ";
         }
         return "\$this->assertErrorThrown(function() {$use}{\n\t$pieces[0]; \n},\n{$pieces[1]});";
-    }
-    elseif (startsWith('class ', $part) || startsWith('function ', $part)) {
+    } elseif (startsWith('class ', $part) || startsWith('function ', $part)) {
         $module->testsFooter .= $part . "\n\n";
         $part = '';
     }
@@ -539,8 +555,9 @@ 
  * @return object
  */
 function generate_tests_footer($module) {
-    if ($module->tests)
-        $module->tests .= "}\n\n{$module->testsFooter}";
+    if ($module->tests) {
+            $module->tests .= "}\n\n{$module->testsFooter}";
+    }
     return $module;
 }
 

src/Classes/Stream.php

Doc Comments +4 added lines, -5 removed lines

@@ -36,7 +36,7 @@ 
      * Creates a new Stream.
      *
      * @param  mixed $data
-     * @return Tarsana\Functional\Stream
+     * @return Stream
      */
     public static function of($data)
     {
@@ -47,7 +47,7 @@ 
      * Adds a new operation to the Stream class.
      *
      * @param  string $name
-     * @param  string $signature
+     * @param  string $signatures
      * @param  callable $fn
      * @return void
      */
@@ -65,7 +65,7 @@ 
      * Checks if the Stream class has an operation with the given name.
      *
      * @param  string  $name
-     * @return boolean
+     * @return \PHPUnit_Framework_Constraint_TraversableContains
      */
     public static function hasOperation($name)
     {
@@ -87,7 +87,6 @@ 
     /**
      * Creates a new Stream with some data.
      *
-     * @param mixed $data
      */
     protected function __construct($stream)
     {
@@ -120,7 +119,7 @@ 
      *
      * @param  string $name The name of the operation
      * @param  array  $args
-     * @return Tarsana\Functional\Stream
+     * @return Stream
      */
     public function __call($name, $args)
     {

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      */
     public static function operation($name, $signatures, $fn = null)
     {
-        if (! is_array($signatures)) {
+        if (!is_array($signatures)) {
             $signatures = [$signatures];
         }
         foreach ($signatures as $signature) {

src/Internal/_functions.php

Doc Comments +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
  * @param  callable $fn
  * @param  int $argsCount
  * @param  array  $boundArgs
- * @return callable
+ * @return \Closure
  */
 function _curried_function($fn, $argsCount, $boundArgs = []) {
     return function() use($fn, $argsCount, $boundArgs) {

Spacing +2 added lines, -3 removed lines

@@ -32,8 +32,7 @@ 
  */
 function _number_of_args($fn) {
     $reflector = is_array($fn) ?
-        new \ReflectionMethod($fn[0], $fn[1]) :
-        new \ReflectionFunction($fn);
+        new \ReflectionMethod($fn[0], $fn[1]) : new \ReflectionFunction($fn);
     return $reflector->getNumberOfRequiredParameters();
 }
 
@@ -65,7 +64,7 @@ 
     $addArgument = function($currentBoundArgs, $arg) use($fnArgsCount) {
         $currentBoundArgsCount = count($currentBoundArgs);
         $placeholderPosition = 0;
-        while($placeholderPosition < $currentBoundArgsCount && !_is_placeholder($currentBoundArgs[$placeholderPosition]))
+        while ($placeholderPosition < $currentBoundArgsCount && !_is_placeholder($currentBoundArgs[$placeholderPosition]))
             $placeholderPosition ++;
         if ($currentBoundArgsCount < $fnArgsCount || $placeholderPosition == $currentBoundArgsCount) {
             $currentBoundArgs[] = $arg;

Braces +6 added lines, -4 removed lines

@@ -65,8 +65,9 @@ 
     $addArgument = function($currentBoundArgs, $arg) use($fnArgsCount) {
         $currentBoundArgsCount = count($currentBoundArgs);
         $placeholderPosition = 0;
-        while($placeholderPosition < $currentBoundArgsCount && !_is_placeholder($currentBoundArgs[$placeholderPosition]))
-            $placeholderPosition ++;
+        while($placeholderPosition < $currentBoundArgsCount && !_is_placeholder($currentBoundArgs[$placeholderPosition])) {
+                    $placeholderPosition ++;
+        }
         if ($currentBoundArgsCount < $fnArgsCount || $placeholderPosition == $currentBoundArgsCount) {
             $currentBoundArgs[] = $arg;
         } else { // There is a placeholder and number of bound args >= $fnArgsCount
@@ -92,8 +93,9 @@ 
         $boundArgs = _merge_args($argsCount, $boundArgs, func_get_args());
         $numberOfPlaceholders = count(array_filter($boundArgs, _f('_is_placeholder')));
         $numberOfGivenArgs = count($boundArgs) - $numberOfPlaceholders;
-        if ($numberOfGivenArgs >= $argsCount)
-            return call_user_func_array($fn, $boundArgs);
+        if ($numberOfGivenArgs >= $argsCount) {
+                    return call_user_func_array($fn, $boundArgs);
+        }
         return _curried_function($fn, $argsCount, $boundArgs);
     };
 }

src/Internal/_stream.php

Doc Comments +1 added lines, -6 removed lines

@@ -40,7 +40,7 @@ 
  * Returns supported types in signatures.
  *
  * @signature List
- * @return array
+ * @return string[]
  */
 function _stream_types() {
     return [
@@ -126,7 +126,6 @@ 
  * @signature String -> String -> Maybe(Function) -> Operation
  * @param  string $name
  * @param  string $signature
- * @param  callable $fn
  * @return array
  */
 function _stream_operation($name, $signature, $callable = null) {
@@ -190,8 +189,6 @@ 
  * F\_stream_ensure_type('List -> Bar', 'Bar'); // throws "Stream: invalid signature 'List -> Bar' it should follow the syntax 'TypeArg1 -> TypeArg2 -> ... -> ReturnType' and types to use are Boolean, Number, String, Resource, Function, List, Array, Object, Any"
  * ```
  * @signature String -> String -> String
- * @param  string $signature
- * @param  string $type
  * @return string
  */
 function _stream_ensure_type() {
@@ -491,8 +488,6 @@ 
  * ```
  *
  * @signature [String] -> Operation -> Boolean
- * @param  array $argsTypes
- * @param  array $operation
  * @return bool
  */
 function _stream_operation_is_applicable() {

Spacing +3 added lines, -3 removed lines

@@ -166,7 +166,7 @@ 
     if (length($parts) < 2)
         _stream_throw_error('invalid-signature', $text);
 
-    return reduce(function($result, $part){
+    return reduce(function($result, $part) {
         return chain(function($item) use($result){
             return map(append($item), $result);
         }, $part);
@@ -196,7 +196,7 @@ 
  */
 function _stream_ensure_type() {
     $ensureType = function($signature, $type) {
-        if (! contains($type, _stream_types()))
+        if (!contains($type, _stream_types()))
             _stream_throw_error('invalid-signature', $signature);
         return $type;
     };
@@ -571,7 +571,7 @@ 
     $args = append(get('data', $stream), get('args', $transformation));
     $argsTypes = map(type(), $args);
     $operation = get('operation', $transformation);
-    if (! _stream_operation_is_applicable($argsTypes, $operation)) {
+    if (!_stream_operation_is_applicable($argsTypes, $operation)) {
         _stream_throw_error('wrong-transformation-args', $operation['name'], $argsTypes, init(head(get('signatures', $operation))));
     }
 

Braces +12 added lines, -8 removed lines

@@ -131,8 +131,9 @@ 
  */
 function _stream_operation($name, $signature, $callable = null) {
     $callable = $callable ?: $name;
-    if (!is_callable($callable))
-        _stream_throw_error('unknown-callable', $callable);
+    if (!is_callable($callable)) {
+            _stream_throw_error('unknown-callable', $callable);
+    }
 
     return [
         'name' => $name,
@@ -163,8 +164,9 @@ 
     // Assuming $text  = 'Number|List -> Number -> String|Array -> Number'
     $parts = map(pipe(split('|'), map(pipe('trim', _stream_ensure_type($text)))), split('->', $text));
     // $parts = [['Number', 'List'], ['Number'], ['String', 'Array'], ['Number']]
-    if (length($parts) < 2)
-        _stream_throw_error('invalid-signature', $text);
+    if (length($parts) < 2) {
+            _stream_throw_error('invalid-signature', $text);
+    }
 
     return reduce(function($result, $part){
         return chain(function($item) use($result){
@@ -196,8 +198,9 @@ 
  */
 function _stream_ensure_type() {
     $ensureType = function($signature, $type) {
-        if (! contains($type, _stream_types()))
-            _stream_throw_error('invalid-signature', $signature);
+        if (! contains($type, _stream_types())) {
+                    _stream_throw_error('invalid-signature', $signature);
+        }
         return $type;
     };
     return apply(curry($ensureType), func_get_args());
@@ -553,8 +556,9 @@ 
  * @return array
  */
 function _stream_resolve($stream) {
-    if (get('resolved', $stream))
-        return $stream;
+    if (get('resolved', $stream)) {
+            return $stream;
+    }
     $transformations = get('transformations', $stream);
     $transformation = head($transformations);
     if (null === $transformation) {

src/list.php

Doc Comments -78 removed lines

@@ -14,8 +14,6 @@ 
  *
  * @stream
  * @signature (a -> b) -> [a] -> [b]
- * @param  callable $fn
- * @param  array $list
  * @return array
  */
 function map() {
@@ -37,8 +35,6 @@ 
  *
  * @stream
  * @signature (a -> [b]) -> [a] -> [b]
- * @param  callable $fn
- * @param  array $list
  * @return array
  */
 function chain() {
@@ -60,8 +56,6 @@ 
  * ```
  * @stream
  * @signature (a -> Boolean) -> [a] -> [a]
- * @param  callable $fn
- * @param  array $list
  * @return array
  */
 function filter() {
@@ -84,9 +78,6 @@ 
  *
  * @stream
  * @signature (* -> a -> *) -> * -> [a] -> *
- * @param  callable $fn
- * @param  mixed $initial
- * @param  array $list
  * @return array
  */
 function reduce() {
@@ -112,8 +103,6 @@ 
  *
  * @stream
  * @signature (a -> *) -> [a] -> [a]
- * @param  callable $fn
- * @param  array $list
  * @return array
  */
 function each() {
@@ -140,7 +129,6 @@ 
  * @stream
  * @signature [a] -> a
  * @signature String -> String
- * @param  array|string $list
  * @return mixed
  */
 function head() {
@@ -168,7 +156,6 @@ 
  * @stream
  * @signature [a] -> a
  * @signature String -> String
- * @param  array|string $list
  * @return mixed
  */
 function last () {
@@ -197,7 +184,6 @@ 
  * @stream
  * @signature [a] -> a
  * @signature String -> String
- * @param  array|string $list
  * @return array
  */
 function init () {
@@ -228,7 +214,6 @@ 
  * @stream
  * @signature [a] -> a
  * @signature String -> String
- * @param  array|string $list
  * @return array
  */
 function tail () {
@@ -256,7 +241,6 @@ 
  * @stream
  * @signature [a] -> [a]
  * @signature String -> String
- * @param  array|string $list
  * @return array
  */
 function reverse () {
@@ -280,7 +264,6 @@ 
  * @stream
  * @signature [a] -> Number
  * @signature String -> Number
- * @param  array|string $list
  * @return int
  */
 function length() {
@@ -304,8 +287,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> Boolean
- * @param  callable $predicate
- * @param  array $list
  * @return bool
  */
 function allSatisfies() {
@@ -327,8 +308,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> Boolean
- * @param  callable $predicate
- * @param  array $list
  * @return bool
  */
 function anySatisfies() {
@@ -350,8 +329,6 @@ 
  * @stream
  * @signature [*] -> [*] -> [*]
  * @signature String -> String -> String
- * @param  array $list1
- * @param  array $list2
  * @return array
  */
 function concat() {
@@ -376,7 +353,6 @@ 
  *
  * @stream
  * @signature [[a]] -> [a]
- * @param  array $lists
  * @return array
  */
 function concatAll() {
@@ -404,9 +380,6 @@ 
  * @stream
  * @signature Number -> a -> [a] -> [a]
  * @signature Number -> String -> String -> String
- * @param  int $position
- * @param  mixed $item
- * @param  array $list
  * @return array
  */
 function insert() {
@@ -434,9 +407,6 @@ 
  * @stream
  * @signature Number -> [a] -> [a] -> [a]
  * @signature Number -> String -> String -> String
- * @param  int $position
- * @param  mixed $items
- * @param  array $list
  * @return array
  */
 function insertAll() {
@@ -465,8 +435,6 @@ 
  * @stream
  * @signature * -> [*] -> [*]
  * @signature String -> String -> String
- * @param  mixed $item
- * @param  array $list
  * @return array
  */
 function append() {
@@ -489,8 +457,6 @@ 
  * @stream
  * @signature a -> [a] -> [a]
  * @signature String -> String -> String
- * @param  mixed $item
- * @param  array $list
  * @return array
  */
 function prepend() {
@@ -513,8 +479,6 @@ 
  * @stream
  * @signature Number -> [a] -> [a]
  * @signature Number -> String -> String
- * @param  int $count
- * @param  array $list
  * @return array
  */
 function take() {
@@ -547,8 +511,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> [a]
- * @param  callable $predicate
- * @param  array $list
  * @return array
  */
 function takeWhile() {
@@ -574,8 +536,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> [a]
- * @param  callable $predicate
- * @param  array $list
  * @return array
  */
 function takeLastWhile() {
@@ -602,8 +562,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> [a]
- * @param  callable $predicate
- * @param  array $list
  * @return array
  */
 function takeUntil() {
@@ -625,8 +583,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> [a]
- * @param  callable $predicate
- * @param  array $list
  * @return array
  */
 function takeLastUntil() {
@@ -654,8 +610,6 @@ 
  * @stream
  * @signature Number -> [a] -> [a]
  * @signature Number -> String -> String
- * @param  int $count
- * @param  array $list
  * @return array
  */
 function remove() {
@@ -683,8 +637,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> [a]
- * @param  callable $predicate
- * @param  array $list
  * @return array
  */
 function removeWhile() {
@@ -706,8 +658,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> [a]
- * @param  callable $predicate
- * @param  array $list
  * @return array
  */
 function removeLastWhile() {
@@ -731,8 +681,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> [a]
- * @param  callable $predicate
- * @param  array $list
  * @return array
  */
 function removeUntil() {
@@ -755,8 +703,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> [a]
- * @param  callable $predicate
- * @param  array $list
  * @return array
  */
 function removeLastUntil() {
@@ -776,7 +722,6 @@ 
  *
  * @stream
  * @signature [(k, v)] -> {k: v}
- * @param  array $pairs
  * @return stdClass
  */
 function fromPairs() {
@@ -805,8 +750,6 @@ 
  * @stream
  * @signature Number -> [a] -> [[a]]
  * @signature Number -> String -> [String]
- * @param  int $size
- * @param  array $list
  * @return array
  */
 function slices() {
@@ -834,8 +777,6 @@ 
  * @stream
  * @signature a -> [a] -> Boolean
  * @signature String -> String -> Boolean
- * @param  mixed $item
- * @param  array|string $list
  * @return bool
  */
 function contains() {
@@ -859,8 +800,6 @@ 
  * @stream
  * @signature (a -> Boolean) -> [a] -> Maybe(Number)
  * @signature (v -> Boolean) -> {k: v} -> Maybe(k)
- * @param  callable $predicate
- * @param  array $list
  * @return mixed
  */
 function findIndex() {
@@ -888,8 +827,6 @@ 
  * @stream
  * @signature (a -> Boolean) -> [a] -> Maybe(Number)
  * @signature (v -> Boolean) -> {k: v} -> Maybe(k)
- * @param  callable $predicate
- * @param  array $list
  * @return mixed
  */
 function findLastIndex() {
@@ -915,8 +852,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> Maybe(a)
- * @param  callable $predicate
- * @param  array $list
  * @return mixed
  */
 function find() {
@@ -938,8 +873,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> [a] -> Maybe(a)
- * @param  callable $predicate
- * @param  array $list
  * @return mixed
  */
 function findLast() {
@@ -970,8 +903,6 @@ 
  * @signature a -> [a] -> Number
  * @signature v -> {k: v} -> Maybe(k)
  * @signature String -> String -> Number
- * @param  mixed $item
- * @param  array $list
  * @return int
  */
 function indexOf() {
@@ -1003,8 +934,6 @@ 
  * @stream
  * @signature a -> [a] -> Number
  * @signature String -> String -> Number
- * @param  mixed $item
- * @param  array $list
  * @return int
  */
 function lastIndexOf() {
@@ -1033,8 +962,6 @@ 
  *
  * @stream
  * @signature (a -> a -> Boolean) -> [a] -> [a]
- * @param  callable $areEqual
- * @param  array $list
  * @return array
  */
 function uniqueBy() {
@@ -1065,7 +992,6 @@ 
  *
  * @stream
  * @signature [a] -> [a]
- * @param  array $list
  * @return array
  */
 function unique() {
@@ -1098,8 +1024,6 @@ 
  *
  * @stream
  * @signature (a -> String) -> [a] -> {String: a}
- * @param  callable $fn
- * @param  array $list
  * @return array
  */
 function groupBy() {
@@ -1128,8 +1052,6 @@ 
  *
  * @stream
  * @signature [a] -> [b] -> [[a,b]]
- * @param  array $list1
- * @param  array $list2
  * @return array
  */
 function pairsFrom() {

Spacing +21 added lines, -22 removed lines

@@ -66,7 +66,7 @@ 
  */
 function filter() {
     static $filter = false;
-    $filter = $filter ?: curry(function($fn, $list){
+    $filter = $filter ?: curry(function($fn, $list) {
         return array_values(array_filter($list, $fn));
     });
     return _apply($filter, func_get_args());
@@ -91,7 +91,7 @@ 
  */
 function reduce() {
     static $reduce = false;
-    $reduce = $reduce ?: curry(function($fn, $initial, $list){
+    $reduce = $reduce ?: curry(function($fn, $initial, $list) {
         return array_reduce($list, $fn, $initial);
     });
     return _apply($reduce, func_get_args());
@@ -118,7 +118,7 @@ 
  */
 function each() {
     static $each = false;
-    $each = $each ?: curry(function($fn, $list){
+    $each = $each ?: curry(function($fn, $list) {
         foreach ($list as $item) {
             apply($fn, [$item]);
         }
@@ -146,7 +146,7 @@ 
 function head() {
     static $head = false;
     $head = $head ?: curry(function($list) {
-        if(is_string($list))
+        if (is_string($list))
             return substr($list, 0, 1);
         return (count($list) > 0)
             ? $list[0]
@@ -171,10 +171,10 @@ 
  * @param  array|string $list
  * @return mixed
  */
-function last () {
+function last() {
     static $last = false;
     $last = $last ?: curry(function($list) {
-        if(is_string($list))
+        if (is_string($list))
             return substr($list, -1);
         return (count($list) > 0)
             ? $list[count($list) - 1]
@@ -200,10 +200,10 @@ 
  * @param  array|string $list
  * @return array
  */
-function init () {
+function init() {
     static $init = false;
     $init = $init ?: curry(function($list) {
-        if(is_string($list))
+        if (is_string($list))
             return (strlen($list) > 1)
                 ? substr($list, 0, strlen($list) - 1)
                 : '';
@@ -231,10 +231,10 @@ 
  * @param  array|string $list
  * @return array
  */
-function tail () {
+function tail() {
     static $tail = false;
     $tail = $tail ?: curry(function($list) {
-        if(is_string($list))
+        if (is_string($list))
             return (strlen($list) > 1)
                 ? substr($list, 1)
                 : '';
@@ -259,7 +259,7 @@ 
  * @param  array|string $list
  * @return array
  */
-function reverse () {
+function reverse() {
     static $reverse = false;
     $reverse = $reverse ?: curry(function($list) {
         return is_string($list)
@@ -382,8 +382,7 @@ 
 function concatAll() {
     static $concatAll = false;
     $concatAll = $concatAll ?: curry(function($lists) {
-        return length($lists) == 0 ? [] :
-            reduce(concat(), head($lists), tail($lists));
+        return length($lists) == 0 ? [] : reduce(concat(), head($lists), tail($lists));
     });
     return _apply($concatAll, func_get_args());
 }
@@ -471,7 +470,7 @@ 
  */
 function append() {
     static $append = false;
-    $append = $append ?: curry(function ($item, $list) {
+    $append = $append ?: curry(function($item, $list) {
         return insert(length($list), $item, $list);
     });
     return _apply($append, func_get_args());
@@ -523,7 +522,7 @@ 
         $length = length($list);
         if ($count > $length || $count < -$length)
             return [];
-        if(is_string($list)) {
+        if (is_string($list)) {
             return ($count >= 0)
                 ? substr($list, 0, $count)
                 : substr($list, $count);
@@ -812,9 +811,9 @@ 
 function slices() {
     static $slices = false;
     $slices = $slices ?: curry(function($size, $list) {
-        if(empty($list))
+        if (empty($list))
             return is_string($list) ? '' : [];
-        if(length($list) <= $size)
+        if (length($list) <= $size)
             return [$list];
         return prepend(take($size, $list), slices($size, remove($size, $list)));
     });
@@ -841,7 +840,7 @@ 
 function contains() {
     static $contains = false;
     $contains = $contains ?: curry(function($item, $list) {
-        return -1 != indexOf($item, $list);
+        return - 1 != indexOf($item, $list);
     });
     return _apply($contains, func_get_args());
 }
@@ -896,7 +895,7 @@ 
     static $findLastIndex = false;
     $findLastIndex = $findLastIndex ?: curry(function($predicate, $list) {
         foreach (reverse(toPairs($list)) as $pair) {
-            if($predicate($pair[1]))
+            if ($predicate($pair[1]))
                 return $pair[0];
         }
         return null;
@@ -983,7 +982,7 @@ 
             $index = findIndex(equals($item), $list);
         }
         return (false === $index || null === $index)
-            ? -1
+            ? - 1
             : $index;
     });
     return _apply($indexOf, func_get_args());
@@ -1016,7 +1015,7 @@ 
             $index = findLastIndex(equals($item), $list);
         }
         return (false === $index || null === $index)
-            ? -1
+            ? - 1
             : $index;
     });
     return _apply($lastIndexOf, func_get_args());
@@ -1107,7 +1106,7 @@ 
     $groupBy = $groupBy ?: curry(function($fn, $list) {
         return reduce(function($result, $item) use($fn) {
             $index = $fn($item);
-            if (! isset($result[$index]))
+            if (!isset($result[$index]))
                 $result[$index] = [];
             $result[$index][] = $item;
             return $result;

Braces +45 added lines, -30 removed lines

@@ -146,8 +146,9 @@ 
 function head() {
     static $head = false;
     $head = $head ?: curry(function($list) {
-        if(is_string($list))
-            return substr($list, 0, 1);
+        if(is_string($list)) {
+                    return substr($list, 0, 1);
+        }
         return (count($list) > 0)
             ? $list[0]
             : null;
@@ -174,8 +175,9 @@ 
 function last () {
     static $last = false;
     $last = $last ?: curry(function($list) {
-        if(is_string($list))
-            return substr($list, -1);
+        if(is_string($list)) {
+                    return substr($list, -1);
+        }
         return (count($list) > 0)
             ? $list[count($list) - 1]
             : null;
@@ -203,10 +205,11 @@ 
 function init () {
     static $init = false;
     $init = $init ?: curry(function($list) {
-        if(is_string($list))
-            return (strlen($list) > 1)
+        if(is_string($list)) {
+                    return (strlen($list) > 1)
                 ? substr($list, 0, strlen($list) - 1)
                 : '';
+        }
         return (count($list) > 1)
             ? array_slice($list, 0, count($list) - 1)
             : [];
@@ -234,10 +237,11 @@ 
 function tail () {
     static $tail = false;
     $tail = $tail ?: curry(function($list) {
-        if(is_string($list))
-            return (strlen($list) > 1)
+        if(is_string($list)) {
+                    return (strlen($list) > 1)
                 ? substr($list, 1)
                 : '';
+        }
         return (count($list) > 1)
             ? array_slice($list, 1)
             : [];
@@ -359,8 +363,9 @@ 
     $concat = $concat ?: curry(function($list1, $list2) {
         $t1 = toString($list1);
         $t2 = toString($list2);
-        if (is_string($list1) && is_string($list2))
-            return $list1 . $list2;
+        if (is_string($list1) && is_string($list2)) {
+                    return $list1 . $list2;
+        }
         return array_merge($list1, $list2);
     });
     return _apply($concat, func_get_args());
@@ -443,10 +448,12 @@ 
     static $insertAll = false;
     $insertAll = $insertAll ?: curry(function($position, $items, $list) {
         $length = length($list);
-        if ($position < 0)
-            $position = $length + $position;
-        if ($position < 0)
-            $position = 0;
+        if ($position < 0) {
+                    $position = $length + $position;
+        }
+        if ($position < 0) {
+                    $position = 0;
+        }
         return ($position >= $length)
             ? concat($list, $items)
             : concatAll([take($position, $list), $items, remove($position, $list)]);
@@ -521,8 +528,9 @@ 
     static $take = false;
     $take = $take ?: curry(function($count, $list) {
         $length = length($list);
-        if ($count > $length || $count < -$length)
-            return [];
+        if ($count > $length || $count < -$length) {
+                    return [];
+        }
         if(is_string($list)) {
             return ($count >= 0)
                 ? substr($list, 0, $count)
@@ -662,8 +670,9 @@ 
     static $remove = false;
     $remove = $remove ?: curry(function($count, $list) {
         $length = length($list);
-        if ($count > $length || $count < -$length)
-            return [];
+        if ($count > $length || $count < -$length) {
+                    return [];
+        }
         return ($count > 0)
             ? take($count - $length, $list)
             : take($count + $length, $list);
@@ -812,10 +821,12 @@ 
 function slices() {
     static $slices = false;
     $slices = $slices ?: curry(function($size, $list) {
-        if(empty($list))
-            return is_string($list) ? '' : [];
-        if(length($list) <= $size)
-            return [$list];
+        if(empty($list)) {
+                    return is_string($list) ? '' : [];
+        }
+        if(length($list) <= $size) {
+                    return [$list];
+        }
         return prepend(take($size, $list), slices($size, remove($size, $list)));
     });
     return _apply($slices, func_get_args());
@@ -867,8 +878,9 @@ 
     static $findIndex = false;
     $findIndex = $findIndex ?: curry(function($predicate, $list) {
         foreach ($list as $key => $value) {
-            if ($predicate($value))
-                return $key;
+            if ($predicate($value)) {
+                            return $key;
+            }
         }
         return null;
     });
@@ -896,8 +908,9 @@ 
     static $findLastIndex = false;
     $findLastIndex = $findLastIndex ?: curry(function($predicate, $list) {
         foreach (reverse(toPairs($list)) as $pair) {
-            if($predicate($pair[1]))
-                return $pair[0];
+            if($predicate($pair[1])) {
+                            return $pair[0];
+            }
         }
         return null;
     });
@@ -1107,8 +1120,9 @@ 
     $groupBy = $groupBy ?: curry(function($fn, $list) {
         return reduce(function($result, $item) use($fn) {
             $index = $fn($item);
-            if (! isset($result[$index]))
-                $result[$index] = [];
+            if (! isset($result[$index])) {
+                            $result[$index] = [];
+            }
             $result[$index][] = $item;
             return $result;
         }, [], $list);
@@ -1137,8 +1151,9 @@ 
     $pairsFrom = $pairsFrom ?: curry(function($list1, $list2) {
         $length1 = length($list1);
         $length2 = length($list2);
-        if (0 == $length1 || 0 == $length2)
-            return [];
+        if (0 == $length1 || 0 == $length2) {
+                    return [];
+        }
         $list1 = values($list1);
         $list2 = values($list2);
         return map(function($index) use($list1, $list2) {

src/math.php

Doc Comments -23 removed lines

@@ -14,8 +14,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function plus() {
@@ -35,8 +33,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function minus() {
@@ -57,7 +53,6 @@ 
  *
  * @stream
  * @signature Number -> Number
- * @param  int|float $x
  * @return int|float
  */
 function negate() {
@@ -78,8 +73,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function multiply() {
@@ -99,8 +92,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function divide() {
@@ -120,8 +111,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function modulo() {
@@ -142,7 +131,6 @@ 
  *
  * @stream
  * @signature [Number] -> Number
- * @param  array $numbers
  * @return int|float
  */
 function sum() {
@@ -163,7 +151,6 @@ 
  *
  * @stream
  * @signature [Number] -> Number
- * @param  array $numbers
  * @return int|float
  */
 function product() {
@@ -184,8 +171,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  number $a
- * @param  number $b
  * @return number
  */
 function min() {
@@ -206,9 +191,6 @@ 
  *
  * @stream
  * @signature (a -> Number) -> a -> a -> a
- * @param  callable $fn
- * @param  mixed $a
- * @param  mixed $b
  * @return mixed
  */
 function minBy() {
@@ -229,8 +211,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  number $a
- * @param  number $b
  * @return number
  */
 function max() {
@@ -251,9 +231,6 @@ 
  *
  * @stream
  * @signature (a -> Number) -> a -> a -> a
- * @param  callable $fn
- * @param  mixed $a
- * @param  mixed $b
  * @return mixed
  */
 function maxBy() {

Spacing +13 added lines, -13 removed lines

@@ -20,7 +20,7 @@ 
  */
 function plus() {
     static $plus = false;
-    $plus = $plus ?: curry(function($x, $y){
+    $plus = $plus ?: curry(function($x, $y) {
         return $x + $y;
     });
     return _apply($plus, func_get_args());
@@ -41,7 +41,7 @@ 
  */
 function minus() {
     static $minus = false;
-    $minus = $minus ?: curry(function($x, $y){
+    $minus = $minus ?: curry(function($x, $y) {
         return $x - $y;
     });
     return _apply($minus, func_get_args());
@@ -62,8 +62,8 @@ 
  */
 function negate() {
     static $negate = false;
-    $negate = $negate ?: curry(function($x){
-        return -$x;
+    $negate = $negate ?: curry(function($x) {
+        return - $x;
     });
     return _apply($negate, func_get_args());
 }
@@ -84,7 +84,7 @@ 
  */
 function multiply() {
     static $multiply = false;
-    $multiply = $multiply ?: curry(function($x, $y){
+    $multiply = $multiply ?: curry(function($x, $y) {
         return $y * $x;
     });
     return _apply($multiply, func_get_args());
@@ -105,7 +105,7 @@ 
  */
 function divide() {
     static $divide = false;
-    $divide = $divide ?: curry(function($x, $y){
+    $divide = $divide ?: curry(function($x, $y) {
         return $x / $y;
     });
     return _apply($divide, func_get_args());
@@ -126,7 +126,7 @@ 
  */
 function modulo() {
     static $modulo = false;
-    $modulo = $modulo ?: curry(function($x, $y){
+    $modulo = $modulo ?: curry(function($x, $y) {
         return $x % $y;
     });
     return _apply($modulo, func_get_args());
@@ -147,7 +147,7 @@ 
  */
 function sum() {
     static $sum = false;
-    $sum = $sum ?: curry(function($numbers){
+    $sum = $sum ?: curry(function($numbers) {
         return reduce(plus(), 0, $numbers);
     });
     return _apply($sum, func_get_args());
@@ -168,7 +168,7 @@ 
  */
 function product() {
     static $product = false;
-    $product = $product ?: curry(function($numbers){
+    $product = $product ?: curry(function($numbers) {
         return reduce(multiply(), 1, $numbers);
     });
     return _apply($product, func_get_args());
@@ -190,7 +190,7 @@ 
  */
 function min() {
     static $min = false;
-    $min = $min ?: curry(function($a, $b){
+    $min = $min ?: curry(function($a, $b) {
         return $a < $b ? $a : $b;
     });
     return _apply($min, func_get_args());
@@ -213,7 +213,7 @@ 
  */
 function minBy() {
     static $minBy = false;
-    $minBy = $minBy ?: curry(function($fn, $a, $b){
+    $minBy = $minBy ?: curry(function($fn, $a, $b) {
         return $fn($a) < $fn($b) ? $a : $b;
     });
     return _apply($minBy, func_get_args());
@@ -235,7 +235,7 @@ 
  */
 function max() {
     static $max = false;
-    $max = $max ?: curry(function($a, $b){
+    $max = $max ?: curry(function($a, $b) {
         return $a > $b ? $a : $b;
     });
     return _apply($max, func_get_args());
@@ -258,7 +258,7 @@ 
  */
 function maxBy() {
     static $maxBy = false;
-    $maxBy = $maxBy ?: curry(function($fn, $a, $b){
+    $maxBy = $maxBy ?: curry(function($fn, $a, $b) {
         return $fn($a) > $fn($b) ? $a : $b;
     });
     return _apply($maxBy, func_get_args());