tarsana / functional

src/operators.php

Doc Comments -23 removed lines

@@ -8,8 +8,6 @@ 
  * Returns `$a && $b`.
  *
  * @signature Boolean -> Boolean -> Boolean
- * @param  bool $a
- * @param  bool $b
  * @return bool
  */
 function and_() {
@@ -22,8 +20,6 @@ 
  * Returns `$a || $b`.
  *
  * @signature Boolean -> Boolean -> Boolean
- * @param  bool $a
- * @param  bool $b
  * @return bool
  */
 function or_() {
@@ -36,7 +32,6 @@ 
  * Returns `!$x`.
  *
  * @signature Boolean -> Boolean
- * @param  bool $x
  * @return bool
  */
 function not() {
@@ -50,8 +45,6 @@ 
  * Returns `$x == $y`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function eq() {
@@ -64,8 +57,6 @@ 
  * Returns `$x != $y`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function notEq() {
@@ -78,8 +69,6 @@ 
  * Returns `$x === $y`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function eqq() {
@@ -92,8 +81,6 @@ 
  * Returns `$x !== $y`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function notEqq() {
@@ -118,8 +105,6 @@ 
  * ```
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function equals() {
@@ -157,8 +142,6 @@ 
  * Returns `$a < $b`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function lt() {
@@ -171,8 +154,6 @@ 
  * Returns `$a <= $b`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function lte() {
@@ -185,8 +166,6 @@ 
  * Returns `$a > $b`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function gt() {
@@ -199,8 +178,6 @@ 
  * Returns `$a >= $b`.
  *
  * @signature * -> * -> Boolean
- * @param  mixed $a
- * @param  mixed $b
  * @return bool
  */
 function gte() {

Spacing +10 added lines, -10 removed lines

@@ -22,7 +22,7 @@ 
  */
 function and_() {
     static $and = false;
-    $and = $and ?: curry(function($a, $b){
+    $and = $and ?: curry(function($a, $b) {
         return $a && $b;
     });
     return _apply($and, func_get_args());
@@ -45,7 +45,7 @@ 
  */
 function or_() {
     static $or = false;
-    $or = $or ?: curry(function($a, $b){
+    $or = $or ?: curry(function($a, $b) {
         return $a || $b;
     });
     return _apply($or, func_get_args());
@@ -85,7 +85,7 @@ 
  * @return bool
  */
 function eq() {
-    $eq = curry(function($a, $b){
+    $eq = curry(function($a, $b) {
         return $a == $b;
     });
     return _apply($eq, func_get_args());
@@ -106,7 +106,7 @@ 
  */
 function notEq() {
     static $notEq = false;
-    $notEq = $notEq ?: curry(function($a, $b){
+    $notEq = $notEq ?: curry(function($a, $b) {
         return $a != $b;
     });
     return _apply($notEq, func_get_args());
@@ -126,7 +126,7 @@ 
  */
 function eqq() {
     static $eqq = false;
-    $eqq = $eqq ?: curry(function($a, $b){
+    $eqq = $eqq ?: curry(function($a, $b) {
         return $a === $b;
     });
     return _apply($eqq, func_get_args());
@@ -147,7 +147,7 @@ 
  */
 function notEqq() {
     static $notEqq = false;
-    $notEqq = $notEqq ?: curry(function($a, $b){
+    $notEqq = $notEqq ?: curry(function($a, $b) {
         return $a !== $b;
     });
     return _apply($notEqq, func_get_args());
@@ -264,7 +264,7 @@ 
  */
 function lt() {
     static $lt = false;
-    $lt = $lt ?: curry(function($a, $b){
+    $lt = $lt ?: curry(function($a, $b) {
         return $a < $b;
     });
     return _apply($lt, func_get_args());
@@ -286,7 +286,7 @@ 
  */
 function lte() {
     static $lte = false;
-    $lte = $lte ?: curry(function($a, $b){
+    $lte = $lte ?: curry(function($a, $b) {
         return $a <= $b;
     });
     return _apply($lte, func_get_args());
@@ -308,7 +308,7 @@ 
  */
 function gt() {
     static $gt = false;
-    $gt = $gt ?: curry(function($a, $b){
+    $gt = $gt ?: curry(function($a, $b) {
         return $a > $b;
     });
     return _apply($gt, func_get_args());
@@ -330,7 +330,7 @@ 
  */
 function gte() {
     static $gte = false;
-    $gte = $gte ?: curry(function($a, $b){
+    $gte = $gte ?: curry(function($a, $b) {
         return $a >= $b;
     });
     return _apply($gte, func_get_args());

Braces +18 added lines, -12 removed lines

@@ -184,17 +184,20 @@ 
 }
 function _equals($a, $b) {
     $type = type($a);
-    if ($type != type($b))
-        return false;
+    if ($type != type($b)) {
+            return false;
+    }
     switch ($type) {
         case 'List':
             $length = count($a);
-            if (count($b) != $length)
-                return false;
+            if (count($b) != $length) {
+                            return false;
+            }
             $index = 0;
             while ($index < $length) {
-                if (!_equals($a[$index], $b[$index]))
-                    return false;
+                if (!_equals($a[$index], $b[$index])) {
+                                    return false;
+                }
                 $index ++;
             }
             return true;
@@ -204,14 +207,17 @@ 
             $keysA = keys($a);
             $keysB = keys($b);
             $length = count($keysA);
-            if (count($keysB) != $length)
-                return false;
+            if (count($keysB) != $length) {
+                            return false;
+            }
             $index = 0;
             while ($index < $length) {
-                if (!_equals($keysA[$index], $keysB[$index]))
-                    return false;
-                if (!_equals(get($keysA[$index], $a), get($keysB[$index], $b)))
-                    return false;
+                if (!_equals($keysA[$index], $keysB[$index])) {
+                                    return false;
+                }
+                if (!_equals(get($keysA[$index], $a), get($keysB[$index], $b))) {
+                                    return false;
+                }
                 $index ++;
             }
             return true;

src/common.php

Spacing +4 added lines, -4 removed lines

@@ -82,7 +82,7 @@ 
  * @param  mixed $something
  * @return string
  */
-function toString () {
+function toString() {
     $toString = function($something) {
         switch (type($something)) {
             case 'String':
@@ -105,11 +105,11 @@ 
                 return $something->__toString();
             case 'Object':
             case 'Array':
-                return '{' . join(', ', map(function($pair){
-                    return $pair[0].': '. toString($pair[1]);
+                return '{' . join(', ', map(function($pair) {
+                    return $pair[0] . ': ' . toString($pair[1]);
                 }, toPairs($something))) . '}';
             default:
-                return '['.type($something).']';
+                return '[' . type($something) . ']';
         }
     };
     return apply(curry($toString), func_get_args());

Doc Comments -4 removed lines

@@ -26,7 +26,6 @@ 
  * ```
  *
  * @signature * -> String
- * @param  mixed $data
  * @return string
  */
 function type() {
@@ -73,8 +72,6 @@ 
  *
  * @stream
  * @signature String -> * -> Boolean
- * @param  string $type
- * @param  mixed $data
  * @return boolean
  */
 function is() {
@@ -109,7 +106,6 @@ 
  *
  * @stream
  * @signature * -> String
- * @param  mixed $something
  * @return string
  */
 function toString () {

Braces +12 added lines, -5 removed lines

@@ -33,9 +33,15 @@ 
 function type() {
     static $type = false;
     $type = $type ?: curry(function($data) {
-        if ($data instanceof Error) return 'Error';
-        if ($data instanceof Stream) return 'Stream';
-        if (is_callable($data)) return 'Function';
+        if ($data instanceof Error) {
+            return 'Error';
+        }
+        if ($data instanceof Stream) {
+            return 'Stream';
+        }
+        if (is_callable($data)) {
+            return 'Function';
+        }
         switch (gettype($data)) {
             case 'boolean':
                 return 'Boolean';
@@ -49,8 +55,9 @@ 
             case 'resource':
                 return 'Resource';
             case 'array':
-                if (allSatisfies('is_numeric', keys($data)))
-                    return 'List';
+                if (allSatisfies('is_numeric', keys($data))) {
+                                    return 'List';
+                }
                 return 'Array';
             case 'object':
                 return 'Object';

build.php

Doc Comments -3 removed lines

@@ -634,8 +634,6 @@ 
  * Gets an element of the stream methods list.
  *
  * @signature String -> Block -> String
- * @param  string $moduleName
- * @param  object $block
  * @return string
  */
 function stream_method_link() {
@@ -661,7 +659,6 @@ 
  * Dump a variable and returns it.
  *
  * @signature a -> a
- * @param  mixed $something
  * @return mixed
  */
 function log() {

Spacing +15 added lines, -15 removed lines

@@ -116,7 +116,7 @@ 
  * @return array
  */
 function get_modules() {
-    $composer = json_decode(file_get_contents(__DIR__.'/composer.json'));
+    $composer = json_decode(file_get_contents(__DIR__ . '/composer.json'));
     return $composer->autoload->files;
 }
 
@@ -147,10 +147,10 @@ 
  */
 function write_module($module) {
     if ($module->docs) {
-        $docsDir  = dirname($module->docsPath);
+        $docsDir = dirname($module->docsPath);
         if (!is_dir($docsDir))
             mkdir($docsDir, 0777, true);
-        file_put_contents($module->docsPath,  $module->docs);
+        file_put_contents($module->docsPath, $module->docs);
     }
     if ($module->tests) {
         $testsDir = dirname($module->testsPath);
@@ -179,7 +179,7 @@ 
         'fill_docs_path',
         'fill_tests_path',
         'fill_blocks'
-    ]), [(object)['path' => $path]]);
+    ]), [(object) ['path' => $path]]);
 }
 
 /**
@@ -233,8 +233,8 @@ 
 function fill_blocks($module) {
     $module->blocks = apply(pipe(
         prepend('dox -r < '), // "dox -r < src/...php"
-        'shell_exec',         // "[{...}, ...]"
-        'json_decode',        // [DoxBlock]
+        'shell_exec', // "[{...}, ...]"
+        'json_decode', // [DoxBlock]
         map(_f('make_block'))
         // sort()
     ), [$module->path]);
@@ -256,7 +256,7 @@ 
     if (has('class', $tags)) $type = 'class';
     if (has('method', $tags)) $type = 'method';
 
-    $params = map(function($tag){
+    $params = map(function($tag) {
         $parts = split(' ', get('value', $tag));
         return [
             'type' => $parts[0],
@@ -292,7 +292,7 @@ 
  */
 function tags_of($doxBlock) {
     if ($doxBlock->tags)
-        return map(function($tag){
+        return map(function($tag) {
             return (object) [
                 'name'  => $tag->type,
                 'value' => $tag->string
@@ -341,7 +341,7 @@ 
  * @return object
  */
 function generate_docs_sommaire($module) {
-    $blocks = filter (
+    $blocks = filter(
         satisfiesAll(['ignore' => not(), 'internal' => not(), 'type' => equals('function')]),
         $module->blocks
     );
@@ -371,7 +371,7 @@ 
  * @return object
  */
 function generate_docs_contents($module) {
-    $blocks = filter (
+    $blocks = filter(
         satisfiesAll(['ignore' => not(), 'internal' => not()]),
         $module->blocks
     );
@@ -429,7 +429,7 @@ 
     $additionalNamespace = replace("/", "\\", remove(6, dirname($module->testsPath)));
     if ($additionalNamespace)
         $namespace .= "\\" . $additionalNamespace;
-    $name = remove(-4, last(split("/", $module->testsPath)));
+    $name = remove(- 4, last(split("/", $module->testsPath)));
     $module->tests .= "<?php namespace {$namespace};\n\nuse Tarsana\Functional as F;\n\nclass {$name} extends \Tarsana\UnitTests\Functional\UnitTest {\n";
     return $module;
 }
@@ -442,7 +442,7 @@ 
  * @return object
  */
 function generate_tests_contents($module) {
-    $blocks = filter (
+    $blocks = filter(
         satisfiesAll(['ignore' => not()]),
         $module->blocks
     );
@@ -499,7 +499,7 @@ 
     if (!contains('```php', $description))
         return '';
     $code = remove(7 + indexOf('```php', $description), $description);
-    return remove(-4, trim($code));
+    return remove(- 4, trim($code));
 }
 
 /**
@@ -552,7 +552,7 @@ 
  * @return array
  */
 function generate_stream_operations($module) {
-    $blocks = filter (
+    $blocks = filter(
         satisfiesAll(['ignore' => equals(false), 'stream' => equals(true)]),
         $module->blocks
     );
@@ -621,7 +621,7 @@ 
  * @return array
  */
 function generate_stream_methods($module) {
-    $blocks = filter (
+    $blocks = filter(
         satisfiesAll(['ignore' => equals(false), 'stream' => equals(true)]),
         $module->blocks
     );

Braces +55 added lines, -37 removed lines

@@ -148,14 +148,16 @@ 
 function write_module($module) {
     if ($module->docs) {
         $docsDir  = dirname($module->docsPath);
-        if (!is_dir($docsDir))
-            mkdir($docsDir, 0777, true);
+        if (!is_dir($docsDir)) {
+                    mkdir($docsDir, 0777, true);
+        }
         file_put_contents($module->docsPath,  $module->docs);
     }
     if ($module->tests) {
         $testsDir = dirname($module->testsPath);
-        if (!is_dir($testsDir))
-            mkdir($testsDir, 0777, true);
+        if (!is_dir($testsDir)) {
+                    mkdir($testsDir, 0777, true);
+        }
         file_put_contents($module->testsPath, $module->tests);
     }
     if ($module->streamOperations) {
@@ -252,9 +254,15 @@ 
     $tags = groupBy(get('name'), tags_of($doxBlock));
 
     $type = 'function';
-    if (has('file', $tags)) $type = 'file';
-    if (has('class', $tags)) $type = 'class';
-    if (has('method', $tags)) $type = 'method';
+    if (has('file', $tags)) {
+        $type = 'file';
+    }
+    if (has('class', $tags)) {
+        $type = 'class';
+    }
+    if (has('method', $tags)) {
+        $type = 'method';
+    }
 
     $params = map(function($tag){
         $parts = split(' ', get('value', $tag));
@@ -266,8 +274,9 @@ 
 
     $return = getPath(['return', 0, 'value'], $tags);
     $signatures = get('signature', $tags);
-    if ($signatures)
-        $signatures = map(get('value'), $signatures);
+    if ($signatures) {
+            $signatures = map(get('value'), $signatures);
+    }
     return (object) [
         'type' => $type,
         'name' => getPath(['ctx', 'name'], $doxBlock),
@@ -291,12 +300,13 @@ 
  * @return array
  */
 function tags_of($doxBlock) {
-    if ($doxBlock->tags)
-        return map(function($tag){
+    if ($doxBlock->tags) {
+            return map(function($tag){
             return (object) [
                 'name'  => $tag->type,
                 'value' => $tag->string
             ];
+    }
         }, $doxBlock->tags);
     return [];
 }
@@ -310,8 +320,9 @@ 
  */
 function generate_docs($module) {
     $module->docs = '';
-    if (startsWith('_', $module->name))
-        return $module;
+    if (startsWith('_', $module->name)) {
+            return $module;
+    }
     return apply(process_of([
         'generate_docs_header',
         'generate_docs_sommaire',
@@ -388,15 +399,17 @@ 
  * @return string
  */
 function generate_docs_contents_item($block) {
-    if ($block->type != 'function')
-        return '';
+    if ($block->type != 'function') {
+            return '';
+    }
     $params = join(', ', map(pipe(values(), join(' ')), get('params', $block)));
     $return = get('return', $block);
     $prototype = "```php\n{$block->name}({$params}) : {$return}\n```\n\n";
     $signature = '';
     $blockSignature = join("\n", $block->signatures);
-    if ($blockSignature)
-        $signature = "```\n{$blockSignature}\n```\n\n";
+    if ($blockSignature) {
+            $signature = "```\n{$blockSignature}\n```\n\n";
+    }
     return "# {$block->name}\n\n{$prototype}{$signature}{$block->description}\n\n";
 }
 
@@ -427,8 +440,9 @@ 
 function generate_tests_header($module) {
     $namespace = "Tarsana\UnitTests\Functional";
     $additionalNamespace = replace("/", "\\", remove(6, dirname($module->testsPath)));
-    if ($additionalNamespace)
-        $namespace .= "\\" . $additionalNamespace;
+    if ($additionalNamespace) {
+            $namespace .= "\\" . $additionalNamespace;
+    }
     $name = remove(-4, last(split("/", $module->testsPath)));
     $module->tests .= "<?php namespace {$namespace};\n\nuse Tarsana\Functional as F;\n\nclass {$name} extends \Tarsana\UnitTests\Functional\UnitTest {\n";
     return $module;
@@ -449,10 +463,11 @@ 
     $contents = join("\n", map(function($block) use($module) {
         return generate_tests_contents_item($block, $module);
     }, $blocks));
-    if (trim($contents) != '')
-        $module->tests .= $contents;
-    else
-        $module->tests = '';
+    if (trim($contents) != '') {
+            $module->tests .= $contents;
+    } else {
+            $module->tests = '';
+    }
     return $module;
 }
 
@@ -465,8 +480,9 @@ 
  * @return string
  */
 function generate_tests_contents_item($block, $module) {
-    if ($block->type != 'function')
-        return '';
+    if ($block->type != 'function') {
+            return '';
+    }
 
     $code = apply(pipe(
         _f('code_from_description'),
@@ -480,8 +496,9 @@ 
         join("\n")
     ), [$block]);
 
-    if ('' == trim($code))
-        return '';
+    if ('' == trim($code)) {
+            return '';
+    }
     return prepend("\tpublic function test_{$block->name}() {\n",
         append("\n\t}\n", $code)
     );
@@ -496,8 +513,9 @@ 
  */
 function code_from_description($block) {
     $description = get('description', $block);
-    if (!contains('```php', $description))
-        return '';
+    if (!contains('```php', $description)) {
+            return '';
+    }
     $code = remove(7 + indexOf('```php', $description), $description);
     return remove(-4, trim($code));
 }
@@ -513,8 +531,7 @@ 
     if (contains('; //=> ', $part)) {
         $pieces = split('; //=> ', $part);
         $part = "\$this->assertEquals({$pieces[1]}, {$pieces[0]});";
-    }
-    elseif (contains('; // throws ', $part)) {
+    } elseif (contains('; // throws ', $part)) {
         $pieces = split('; // throws ', $part);
         $variables = match('/ \$[0-9a-zA-Z_]+/', $pieces[0]);
         $use = '';
@@ -523,8 +540,7 @@ 
             $use = "use({$variables}) ";
         }
         return "\$this->assertErrorThrown(function() {$use}{\n\t$pieces[0]; \n},\n{$pieces[1]});";
-    }
-    elseif (startsWith('class ', $part) || startsWith('function ', $part)) {
+    } elseif (startsWith('class ', $part) || startsWith('function ', $part)) {
         $module->testsFooter .= $part . "\n\n";
         $part = '';
     }
@@ -539,8 +555,9 @@ 
  * @return object
  */
 function generate_tests_footer($module) {
-    if ($module->tests)
-        $module->tests .= "}\n\n{$module->testsFooter}";
+    if ($module->tests) {
+            $module->tests .= "}\n\n{$module->testsFooter}";
+    }
     return $module;
 }
 
@@ -676,8 +693,9 @@ 
 
 // Convert Warnings to Exceptions
 set_error_handler(function($errno, $errstr, $errfile, $errline, array $errcontext) {
-    if (0 === error_reporting())
-        return false;
+    if (0 === error_reporting()) {
+            return false;
+    }
     throw new \ErrorException($errstr, 0, $errno, $errfile, $errline);
 });
 

src/Classes/Stream.php

Doc Comments +4 added lines, -5 removed lines

@@ -36,7 +36,7 @@ 
      * Creates a new Stream.
      *
      * @param  mixed $data
-     * @return Tarsana\Functional\Stream
+     * @return Stream
      */
     public static function of($data)
     {
@@ -47,7 +47,7 @@ 
      * Adds a new operation to the Stream class.
      *
      * @param  string $name
-     * @param  string $signature
+     * @param  string $signatures
      * @param  callable $fn
      * @return void
      */
@@ -65,7 +65,7 @@ 
      * Checks if the Stream class has an operation with the given name.
      *
      * @param  string  $name
-     * @return boolean
+     * @return \PHPUnit_Framework_Constraint_TraversableContains
      */
     public static function hasOperation($name)
     {
@@ -87,7 +87,6 @@ 
     /**
      * Creates a new Stream with some data.
      *
-     * @param mixed $data
      */
     protected function __construct($stream)
     {
@@ -120,7 +119,7 @@ 
      *
      * @param  string $name The name of the operation
      * @param  array  $args
-     * @return Tarsana\Functional\Stream
+     * @return Stream
      */
     public function __call($name, $args)
     {

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      */
     public static function operation($name, $signatures, $fn = null)
     {
-        if (! is_array($signatures)) {
+        if (!is_array($signatures)) {
             $signatures = [$signatures];
         }
         foreach ($signatures as $signature) {

src/Internal/_stream.php

Doc Comments +1 added lines, -6 removed lines

@@ -40,7 +40,7 @@ 
  * Returns supported types in signatures.
  *
  * @signature List
- * @return array
+ * @return string[]
  */
 function _stream_types() {
     return [
@@ -126,7 +126,6 @@ 
  * @signature String -> String -> Maybe(Function) -> Operation
  * @param  string $name
  * @param  string $signature
- * @param  callable $fn
  * @return array
  */
 function _stream_operation($name, $signature, $callable = null) {
@@ -190,8 +189,6 @@ 
  * F\_stream_ensure_type('List -> Bar', 'Bar'); // throws "Stream: invalid signature 'List -> Bar' it should follow the syntax 'TypeArg1 -> TypeArg2 -> ... -> ReturnType' and types to use are Boolean, Number, String, Resource, Function, List, Array, Object, Any"
  * ```
  * @signature String -> String -> String
- * @param  string $signature
- * @param  string $type
  * @return string
  */
 function _stream_ensure_type() {
@@ -491,8 +488,6 @@ 
  * ```
  *
  * @signature [String] -> Operation -> Boolean
- * @param  array $argsTypes
- * @param  array $operation
  * @return bool
  */
 function _stream_operation_is_applicable() {

Braces +12 added lines, -8 removed lines

@@ -131,8 +131,9 @@ 
  */
 function _stream_operation($name, $signature, $callable = null) {
     $callable = $callable ?: $name;
-    if (!is_callable($callable))
-        _stream_throw_error('unknown-callable', $callable);
+    if (!is_callable($callable)) {
+            _stream_throw_error('unknown-callable', $callable);
+    }
 
     return [
         'name' => $name,
@@ -163,8 +164,9 @@ 
     // Assuming $text  = 'Number|List -> Number -> String|Array -> Number'
     $parts = map(pipe(split('|'), map(pipe('trim', _stream_ensure_type($text)))), split('->', $text));
     // $parts = [['Number', 'List'], ['Number'], ['String', 'Array'], ['Number']]
-    if (length($parts) < 2)
-        _stream_throw_error('invalid-signature', $text);
+    if (length($parts) < 2) {
+            _stream_throw_error('invalid-signature', $text);
+    }
 
     return reduce(function($result, $part){
         return chain(function($item) use($result){
@@ -196,8 +198,9 @@ 
  */
 function _stream_ensure_type() {
     $ensureType = function($signature, $type) {
-        if (! contains($type, _stream_types()))
-            _stream_throw_error('invalid-signature', $signature);
+        if (! contains($type, _stream_types())) {
+                    _stream_throw_error('invalid-signature', $signature);
+        }
         return $type;
     };
     return apply(curry($ensureType), func_get_args());
@@ -553,8 +556,9 @@ 
  * @return array
  */
 function _stream_resolve($stream) {
-    if (get('resolved', $stream))
-        return $stream;
+    if (get('resolved', $stream)) {
+            return $stream;
+    }
     $transformations = get('transformations', $stream);
     $transformation = head($transformations);
     if (null === $transformation) {

Spacing +2 added lines, -2 removed lines

@@ -167,7 +167,7 @@ 
     if (length($parts) < 2)
         _stream_throw_error('invalid-signature', $text);
 
-    return reduce(function($result, $part){
+    return reduce(function($result, $part) {
         return chain(function($item) use($result){
             return map(append($item), $result);
         }, $part);
@@ -197,7 +197,7 @@ 
  */
 function _stream_ensure_type() {
     $ensureType = function($signature, $type) {
-        if (! contains($type, _stream_types()))
+        if (!contains($type, _stream_types()))
             _stream_throw_error('invalid-signature', $signature);
         return $type;
     };

src/math.php

Doc Comments -23 removed lines

@@ -14,8 +14,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function plus() {
@@ -35,8 +33,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function minus() {
@@ -57,7 +53,6 @@ 
  *
  * @stream
  * @signature Number -> Number
- * @param  int|float $x
  * @return int|float
  */
 function negate() {
@@ -78,8 +73,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function multiply() {
@@ -99,8 +92,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function divide() {
@@ -120,8 +111,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  int|float $x
- * @param  int|float $y
  * @return int|float
  */
 function modulo() {
@@ -142,7 +131,6 @@ 
  *
  * @stream
  * @signature [Number] -> Number
- * @param  array $numbers
  * @return int|float
  */
 function sum() {
@@ -163,7 +151,6 @@ 
  *
  * @stream
  * @signature [Number] -> Number
- * @param  array $numbers
  * @return int|float
  */
 function product() {
@@ -184,8 +171,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  number $a
- * @param  number $b
  * @return number
  */
 function min() {
@@ -206,9 +191,6 @@ 
  *
  * @stream
  * @signature (a -> Number) -> a -> a -> a
- * @param  callable $fn
- * @param  mixed $a
- * @param  mixed $b
  * @return mixed
  */
 function minBy() {
@@ -229,8 +211,6 @@ 
  *
  * @stream
  * @signature Number -> Number -> Number
- * @param  number $a
- * @param  number $b
  * @return number
  */
 function max() {
@@ -251,9 +231,6 @@ 
  *
  * @stream
  * @signature (a -> Number) -> a -> a -> a
- * @param  callable $fn
- * @param  mixed $a
- * @param  mixed $b
  * @return mixed
  */
 function maxBy() {

Spacing +11 added lines, -11 removed lines

@@ -20,7 +20,7 @@ 
  */
 function plus() {
     static $plus = false;
-    $plus = $plus ?: curry(function($x, $y){
+    $plus = $plus ?: curry(function($x, $y) {
         return $x + $y;
     });
     return _apply($plus, func_get_args());
@@ -41,7 +41,7 @@ 
  */
 function minus() {
     static $minus = false;
-    $minus = $minus ?: curry(function($x, $y){
+    $minus = $minus ?: curry(function($x, $y) {
         return $x - $y;
     });
     return _apply($minus, func_get_args());
@@ -62,8 +62,8 @@ 
  */
 function negate() {
     static $negate = false;
-    $negate = $negate ?: curry(function($x){
-        return -$x;
+    $negate = $negate ?: curry(function($x) {
+        return - $x;
     });
     return _apply($negate, func_get_args());
 }
@@ -84,7 +84,7 @@ 
  */
 function multiply() {
     static $multiply = false;
-    $multiply = $multiply ?: curry(function($x, $y){
+    $multiply = $multiply ?: curry(function($x, $y) {
         return $y * $x;
     });
     return _apply($multiply, func_get_args());
@@ -105,7 +105,7 @@ 
  */
 function divide() {
     static $divide = false;
-    $divide = $divide ?: curry(function($x, $y){
+    $divide = $divide ?: curry(function($x, $y) {
         return $x / $y;
     });
     return _apply($divide, func_get_args());
@@ -126,7 +126,7 @@ 
  */
 function modulo() {
     static $modulo = false;
-    $modulo = $modulo ?: curry(function($x, $y){
+    $modulo = $modulo ?: curry(function($x, $y) {
         return $x % $y;
     });
     return _apply($modulo, func_get_args());
@@ -186,7 +186,7 @@ 
  */
 function min() {
     static $min = false;
-    $min = $min ?: curry(function($a, $b){
+    $min = $min ?: curry(function($a, $b) {
         return $a < $b ? $a : $b;
     });
     return _apply($min, func_get_args());
@@ -209,7 +209,7 @@ 
  */
 function minBy() {
     static $minBy = false;
-    $minBy = $minBy ?: curry(function($fn, $a, $b){
+    $minBy = $minBy ?: curry(function($fn, $a, $b) {
         return $fn($a) < $fn($b) ? $a : $b;
     });
     return _apply($minBy, func_get_args());
@@ -231,7 +231,7 @@ 
  */
 function max() {
     static $max = false;
-    $max = $max ?: curry(function($a, $b){
+    $max = $max ?: curry(function($a, $b) {
         return $a > $b ? $a : $b;
     });
     return _apply($max, func_get_args());
@@ -254,7 +254,7 @@ 
  */
 function maxBy() {
     static $maxBy = false;
-    $maxBy = $maxBy ?: curry(function($fn, $a, $b){
+    $maxBy = $maxBy ?: curry(function($fn, $a, $b) {
         return $fn($a) > $fn($b) ? $a : $b;
     });
     return _apply($maxBy, func_get_args());

src/object.php

Doc Comments -24 removed lines

@@ -22,7 +22,6 @@ 
  * ```
  *
  * @signature a -> a
- * @param  mixed $value
  * @return mixed
  */
 function clone_() {
@@ -73,7 +72,6 @@ 
  *
  * @stream
  * @signature {k: v} -> {k: v}
- * @param  object|array $object
  * @return array
  */
 function attributes() {
@@ -98,7 +96,6 @@ 
  * @stream
  * @signature [*] -> [Number]
  * @signature {k: v} -> [k]
- * @param object|array $object
  * @return array
  */
 function keys() {
@@ -121,7 +118,6 @@ 
  * @stream
  * @signature [a] -> [a]
  * @signature {k: v} -> [v]
- * @param object|array $object
  * @return array
  */
 function values() {
@@ -162,8 +158,6 @@ 
  *
  * @stream
  * @signature k -> {k: v} -> Boolean
- * @param  string|int $name
- * @param  mixed $object
  * @return bool
  */
 function has() {
@@ -195,8 +189,6 @@ 
  *
  * @stream
  * @signature k -> {k: v} -> Maybe(v)
- * @param  string $name
- * @param  array $object
  * @return mixed
  */
 function get() {
@@ -227,8 +219,6 @@ 
  *
  * @stream
  * @signature [k] -> {k: v} -> v
- * @param  array $path
- * @param  mixed $object
  * @return mixed
  */
 function getPath() {
@@ -259,9 +249,6 @@ 
  *
  * @stream
  * @signature k -> v -> {k: v} -> {k: v}
- * @param  string|int $name
- * @param  mixed $value
- * @param  mixed $object
  * @return mixed
  */
 function set() {
@@ -293,9 +280,6 @@ 
  *
  * @stream
  * @signature k -> (v -> v) -> {k: v} -> {k: v}
- * @param  string|int $name
- * @param  callable $fn
- * @param  mixed $object
  * @return mixed
  */
 function update() {
@@ -321,9 +305,6 @@ 
  *
  * @stream
  * @signature (a -> Boolean) -> k -> {k : a} -> Boolean
- * @param  callable $predicate
- * @param  string|int $key
- * @param  mixed $object
  * @return bool
  */
 function satisfies() {
@@ -356,8 +337,6 @@ 
  *
  * @stream
  * @signature {String: (a -> Boolean)} -> {k : a} -> Boolean
- * @param  array $predicates
- * @param  mixed $object
  * @return bool
  */
 function satisfiesAll() {
@@ -394,8 +373,6 @@ 
  *
  * @stream
  * @signature {String: (a -> Boolean)} -> {k : a} -> Boolean
- * @param  array $predicates
- * @param  mixed $object
  * @return bool
  */
 function satisfiesAny() {
@@ -420,7 +397,6 @@ 
  *
  * @stream
  * @signature {k: v} -> [(k,v)]
- * @param  array $object
  * @return array
  */
 function toPairs() {

Spacing +2 added lines, -2 removed lines

@@ -173,7 +173,7 @@ 
  */
 function has() {
     static $has = false;
-    $has = $has ?: curry(function($name, $object){
+    $has = $has ?: curry(function($name, $object) {
         if (is_object($object)) return isset($object->{$name});
         if (is_array($object)) return isset($object[$name]);
         return false;
@@ -208,7 +208,7 @@ 
  */
 function get() {
     static $get = false;
-    $get = $get ?: curry(function($name, $object){
+    $get = $get ?: curry(function($name, $object) {
         return is_object($object)
             ? (isset($object->{$name}) ? $object->{$name} : null)
             : (isset($object[$name]) ? $object[$name] : null);

Braces +21 added lines, -12 removed lines

@@ -80,8 +80,9 @@ 
 function attributes() {
     static $attrs = false;
     $attrs = $attrs ?: curry(function($object) {
-        if (is_object($object))
-            return get_object_vars($object);
+        if (is_object($object)) {
+                    return get_object_vars($object);
+        }
         return $object;
     });
     return _apply($attrs, func_get_args());
@@ -174,8 +175,12 @@ 
 function has() {
     static $has = false;
     $has = $has ?: curry(function($name, $object){
-        if (is_object($object)) return isset($object->{$name});
-        if (is_array($object)) return isset($object[$name]);
+        if (is_object($object)) {
+            return isset($object->{$name});
+        }
+        if (is_array($object)) {
+            return isset($object[$name]);
+        }
         return false;
     });
     return _apply($has, func_get_args());
@@ -276,8 +281,9 @@ 
         if (is_object($object)) {
             $object = clone_($object);
             $object->{$name} = $value;
-        } else
-            $object[$name] = $value;
+        } else {
+                    $object[$name] = $value;
+        }
         return $object;
     });
     return _apply($set, func_get_args());
@@ -370,8 +376,9 @@ 
     static $satisfiesAll = false;
     $satisfiesAll = $satisfiesAll ?: curry(function($predicates, $object) {
         foreach ($predicates as $key => $predicate) {
-            if (!satisfies($predicate, $key, $object))
-                return false;
+            if (!satisfies($predicate, $key, $object)) {
+                            return false;
+            }
         }
         return true;
     });
@@ -408,8 +415,9 @@ 
     static $satisfiesAny = false;
     $satisfiesAny = $satisfiesAny ?: curry(function($predicates, $object) {
         foreach ($predicates as $key => $predicate) {
-            if (satisfies($predicate, $key, $object))
-                return true;
+            if (satisfies($predicate, $key, $object)) {
+                            return true;
+            }
         }
         return false;
     });
@@ -433,8 +441,9 @@ 
 function toPairs() {
     static $toPairs = false;
     $toPairs = $toPairs ?: curry(function($object) {
-        if (is_object($object))
-            $object = get_object_vars($object);
+        if (is_object($object)) {
+                    $object = get_object_vars($object);
+        }
         $result = [];
         foreach ($object as $key => $value) {
             $result[] = [$key, $value];

src/string.php

Doc Comments -28 removed lines

@@ -14,8 +14,6 @@ 
  *
  * @stream
  * @signature String -> String -> [String]
- * @param string $delimiter
- * @param string $string
  * @return array
  */
 function split() {
@@ -34,8 +32,6 @@ 
  *
  * @stream
  * @signature String -> [String] -> String
- * @param string $glue
- * @param array $pieces
  * @return string
  */
 function join() {
@@ -59,9 +55,6 @@ 
  *
  * @stream
  * @signature String|[String] -> String|[String] -> String -> String
- * @param  string $search
- * @param  string $replacement
- * @param  string $string
  * @return string
  */
 function replace() {
@@ -81,9 +74,6 @@ 
  *
  * @stream
  * @signature String -> String -> String -> String
- * @param  string $pattern
- * @param  string $replacement
- * @param  string $string
  * @return string
  */
 function regReplace() {
@@ -101,7 +91,6 @@ 
  *
  * @stream
  * @signature String -> String
- * @param  string $string
  * @return string
  */
 function upperCase() {
@@ -119,7 +108,6 @@ 
  *
  * @stream
  * @signature String -> String
- * @param  string $string
  * @return string
  */
 function lowerCase() {
@@ -137,7 +125,6 @@ 
  *
  * @stream
  * @signature String -> String
- * @param  string $string
  * @return string
  */
 function camelCase() {
@@ -164,8 +151,6 @@ 
  *
  * @stream
  * @signature String -> String -> String
- * @param  string $delimiter
- * @param  string $string
  * @return string
  */
 function snakeCase() {
@@ -194,8 +179,6 @@ 
  *
  * @stream
  * @signature String -> String -> Boolean
- * @param  string $token
- * @param  string $string
  * @return bool
  */
 function startsWith() {
@@ -220,8 +203,6 @@ 
  *
  * @stream
  * @signature String -> String -> Boolean
- * @param  string $token
- * @param  string $string
  * @return bool
  */
 function endsWith() {
@@ -246,8 +227,6 @@ 
  *
  * @stream
  * @signature String -> String -> Boolean
- * @param  string $pattern
- * @param  string $string
  * @return bool
  */
 function test() {
@@ -270,8 +249,6 @@ 
  *
  * @stream
  * @signature String -> String -> [String]
- * @param  string $pattern
- * @param  string $string
  * @return array
  */
 function match() {
@@ -295,8 +272,6 @@ 
  *
  * @stream
  * @signature String -> String -> Number
- * @param  string $token
- * @param  string $text
  * @return int
  */
 function occurences() {
@@ -322,9 +297,6 @@ 
  *
  * @stream
  * @signature String -> String -> String -> [String]
- * @param  string $surrounders
- * @param  string $separator
- * @param  sring $text
  * @return array
  */
 function chunks() {

Indentation +3 added lines, -3 removed lines

@@ -336,10 +336,10 @@
         // $text = 'foo ("bar baz" alpha) beta'
         $counters = [
             'values'   => [], // each item of this array refers to the number
-                              // of closings needed for an opening
+                                // of closings needed for an opening
             'openings' => [], // an associative array where the key is an opening
-                              // and the value is the index of corresponding cell
-                              // in the 'values' field
+                                // and the value is the index of corresponding cell
+                                // in the 'values' field
             'closings' => [], // associative array for closings like the previous one
             'total'    => 0   // the total number of needed closings
         ];

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
  */
 function join() {
     static $join = false;
-    $join = $join ?: curry(function($glue, $pieces){
+    $join = $join ?: curry(function($glue, $pieces) {
         return implode($glue, $pieces);
     });
     return _apply($join, func_get_args());

Braces +8 added lines, -6 removed lines

@@ -345,10 +345,11 @@ 
         ];
         foreach (str_split($surrounders) as $key => $char) {
             $counters['values'][$key / 2] = 0;
-            if ($key % 2 == 0)
-                $counters['openings'][$char] = $key / 2;
-            else
-                $counters['closings'][$char] = $key / 2;
+            if ($key % 2 == 0) {
+                            $counters['openings'][$char] = $key / 2;
+            } else {
+                            $counters['closings'][$char] = $key / 2;
+            }
         }
         // $counters = [
         //   'values'   => [0, 0, 0],
@@ -394,8 +395,9 @@ 
                 $index ++;
             }
         }
-        if ($buffer != '')
-            $result[] = $buffer;
+        if ($buffer != '') {
+                    $result[] = $buffer;
+        }
 
         return $result;
     });

src/Classes/Error.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
      * @param  Error|null $error
      * @return Error
      */
-    public static function of ($message, $code = 0, Error $error = null)
+    public static function of($message, $code = 0, Error $error = null)
     {
         return new Error($message, $code, $error);
     }