tarsana / command

src/Command.php

Doc Comments +3 added lines, -3 removed lines

@@ -185,7 +185,7 @@ 
      * @param  string $name
      * @param  string $description
      * @param  mixed  $default
-     * @return Tarsana\Command\Syntax\SyntaxBuilder
+     * @return Command
      */
     public function describe($name, $description, $default = null)
     {
@@ -212,7 +212,7 @@ 
      * adds/overrides or gets a sub command.
      *
      * @param  string  $name
-     * @param  Tarsana\Command\Command|null $cmd
+     * @param  null|Command $cmd
      * @return Tarsana\Command\Command
      */
     public function command ($name, Command $cmd = null)
@@ -299,7 +299,7 @@ 
      * Runs the command.
      *
      * @param  string|null $args
-     * @param  League\CLImate\CLImate|null $console
+     * @param  null|CLImate $console
      * @return void
      */
     public function run ($args = null, CLImate $console = null)

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Tarsana\Functional as F;
 use Tarsana\Functional\Stream;
 use Tarsana\Command\Environment;
-use Tarsana\Syntax\Factory as S;
 use Tarsana\Command\TemplateLoader;
 use Tarsana\Command\Commands\HelpCommand;
 use Tarsana\Command\Syntax\SyntaxBuilder;

Indentation +2 added lines, -2 removed lines

@@ -327,7 +327,7 @@ 
 
                 else
                     $this->args($this->syntax()->parse($args))
-                         ->execute();
+                            ->execute();
             }
         } catch (\Exception $e) {
             $this->error(
@@ -378,7 +378,7 @@ 
         if (! ($this instanceof HelpCommand) && ! ($this instanceof VersionCommand)) {
             $helpCommand = new HelpCommand($this);
             $this->command('--help', $helpCommand)
-                 ->command('help', $helpCommand);
+                    ->command('help', $helpCommand);
 
             $versionCommand = new VersionCommand($this);
             $this->command('--version', $versionCommand);

Spacing +17 added lines, -17 removed lines

@@ -86,7 +86,7 @@ 
      * Creates a new Command.
      *
      */
-    public function __construct ()
+    public function __construct()
     {
         $this->templateLoader = new TemplateLoader;
         $this->fs = new Filesystem('.');
@@ -107,7 +107,7 @@ 
      * @param  string|void $value
      * @return string|self
      */
-    public function name ($value = null)
+    public function name($value = null)
     {
         if (null === $value)
             return $this->name;
@@ -122,7 +122,7 @@ 
      * @param  string|void $value
      * @return string|self
      */
-    public function description ($value = null)
+    public function description($value = null)
     {
         if (null === $value)
             return $this->description;
@@ -137,7 +137,7 @@ 
      * @param  string|void $value
      * @return string|self
      */
-    public function version ($value = null)
+    public function version($value = null)
     {
         if (null === $value)
             return $this->version;
@@ -152,7 +152,7 @@ 
      * @param  League\CLImate\CLImate|void $value
      * @return League\CLImate\CLImate|self
      */
-    public function console ($value = null)
+    public function console($value = null)
     {
         if (null === $value)
             return $this->console;
@@ -168,7 +168,7 @@ 
      * @return Tarsana\Syntax\Syntax|self
      * @throws InvalidArgumentException
      */
-    public function syntax ($value = null)
+    public function syntax($value = null)
     {
         if (null === $value)
             return $this->syntaxBuilder->get();
@@ -215,7 +215,7 @@ 
      * @param  Tarsana\Command\Command|null $cmd
      * @return Tarsana\Command\Command
      */
-    public function command ($name, Command $cmd = null)
+    public function command($name, Command $cmd = null)
     {
         if (null === $cmd) {
             if (!$this->hasCommand($name))
@@ -233,7 +233,7 @@ 
      * @param  string  $name
      * @return boolean
      */
-    public function hasCommand ($name) {
+    public function hasCommand($name) {
         return isset($this->subCommands[$name]);
     }
 
@@ -302,7 +302,7 @@ 
      * @param  League\CLImate\CLImate|null $console
      * @return void
      */
-    public function run ($args = null, CLImate $console = null)
+    public function run($args = null, CLImate $console = null)
     {
         try {
 
@@ -317,7 +317,7 @@ 
                 $this->command($firstArg)->run($args, $console);
             } else {
                 $this->console($console);
-                if (! $this->syntax()->canParse($args)) {
+                if (!$this->syntax()->canParse($args)) {
                     $errors = F\s($this->syntax()->checkParse($args))
                         ->then(F\append("Invalid arguments: '{$args}' for command '{$this->name}'"))
                         ->then(F\join(PHP_EOL))
@@ -357,7 +357,7 @@ 
      *
      * @return string
      */
-    protected function consoleArguments ()
+    protected function consoleArguments()
     {
         return Stream::of($_SERVER['argv'])    // ['script.php', foo', 'lorem ipsum']
             ->then(F\f('tail'))                // ['foo', 'lorem ipsum']
@@ -373,9 +373,9 @@ 
     /**
      * Adds Help and Version sub commands.
      */
-    protected function addDefaultSubCommands ()
+    protected function addDefaultSubCommands()
     {
-        if (! ($this instanceof HelpCommand) && ! ($this instanceof VersionCommand)) {
+        if (!($this instanceof HelpCommand) && !($this instanceof VersionCommand)) {
             $helpCommand = new HelpCommand($this);
             $this->command('--help', $helpCommand)
                  ->command('help', $helpCommand);
@@ -391,7 +391,7 @@ 
      * @param  string $message
      * @return void
      */
-    protected function error ($message)
+    protected function error($message)
     {
         $this->console->style->addCommand('error', 'white');
         $this->console->backgroundRed()->error($message);
@@ -406,7 +406,7 @@ 
      * @param  CLImate $console
      * @return void
      */
-    protected function call ($name, $args = null, CLImate $console = null)
+    protected function call($name, $args = null, CLImate $console = null)
     {
         return Environment::get()
             ->command($name)
@@ -420,12 +420,12 @@ 
      *
      * @return void
      */
-    protected function init () {}
+    protected function init() {}
 
     /**
      * The logic of the command goes in this method.
      *
      * @return self
      */
-    abstract protected function execute ();
+    abstract protected function execute();
 }

Braces +33 added lines, -24 removed lines

@@ -109,8 +109,9 @@ 
      */
     public function name ($value = null)
     {
-        if (null === $value)
-            return $this->name;
+        if (null === $value) {
+                    return $this->name;
+        }
 
         $this->name = $value;
         return $this;
@@ -124,8 +125,9 @@ 
      */
     public function description ($value = null)
     {
-        if (null === $value)
-            return $this->description;
+        if (null === $value) {
+                    return $this->description;
+        }
 
         $this->description = $value;
         return $this;
@@ -139,8 +141,9 @@ 
      */
     public function version ($value = null)
     {
-        if (null === $value)
-            return $this->version;
+        if (null === $value) {
+                    return $this->version;
+        }
 
         $this->version = $value;
         return $this;
@@ -154,8 +157,9 @@ 
      */
     public function console ($value = null)
     {
-        if (null === $value)
-            return $this->console;
+        if (null === $value) {
+                    return $this->console;
+        }
 
         $this->console = $value;
         return $this;
@@ -170,8 +174,9 @@ 
      */
     public function syntax ($value = null)
     {
-        if (null === $value)
-            return $this->syntaxBuilder->get();
+        if (null === $value) {
+                    return $this->syntaxBuilder->get();
+        }
 
         $this->syntaxBuilder = SyntaxBuilder::of($value);
 
@@ -218,8 +223,9 @@ 
     public function command ($name, Command $cmd = null)
     {
         if (null === $cmd) {
-            if (!$this->hasCommand($name))
-                throw new CommandNotFound("Command '{$name}' not found");
+            if (!$this->hasCommand($name)) {
+                            throw new CommandNotFound("Command '{$name}' not found");
+            }
             return $this->subCommands[$name];
         }
 
@@ -245,8 +251,9 @@ 
      */
     public function args($value = null)
     {
-        if (null === $value)
-            return $this->args;
+        if (null === $value) {
+                    return $this->args;
+        }
 
         $this->args = $value;
         return $this;
@@ -306,10 +313,12 @@ 
     {
         try {
 
-            if (null === $args)
-                $args = $this->consoleArguments();
-            if (null === $console)
-                $console = new CLImate;
+            if (null === $args) {
+                            $args = $this->consoleArguments();
+            }
+            if (null === $console) {
+                            $console = new CLImate;
+            }
 
             $firstArg = F\head(F\split(' ', $args));
             if ($this->hasCommand($firstArg)) {
@@ -323,11 +332,10 @@ 
                         ->then(F\join(PHP_EOL))
                         ->get();
                     $this->error($errors);
-                }
-
-                else
-                    $this->args($this->syntax()->parse($args))
+                } else {
+                                    $this->args($this->syntax()->parse($args))
                          ->execute();
+                }
             }
         } catch (\Exception $e) {
             $this->error(
@@ -346,8 +354,9 @@ 
      */
     protected function template($name)
     {
-        if (null === $this->templateLoader)
-            throw new NullPropertyAccess("The templatesLoader is not initialized; Please set it before trying to load a template !");
+        if (null === $this->templateLoader) {
+                    throw new NullPropertyAccess("The templatesLoader is not initialized; Please set it before trying to load a template !");
+        }
 
         return $this->templateLoader->load($name);
     }

src/Commands/HelpCommand.php

Doc Comments +6 added lines

@@ -74,6 +74,9 @@ 
         }
     }
 
+    /**
+     * @param integer $level
+     */
     protected function showSyntax($name, $syntax, $level)
     {
         $type = $this->typeOf($syntax);
@@ -102,6 +105,9 @@ 
         }
     }
 
+    /**
+     * @return integer
+     */
     protected function typeOf(Syntax $syntax)
     {
         if ($syntax instanceof ObjectSyntax) {

Unused Use Statements -2 removed lines

@@ -5,9 +5,7 @@
 use Tarsana\Functional as F;
 use Tarsana\Command\SubCommand;
 use Tarsana\Syntax\ArraySyntax;
-use Tarsana\Syntax\Factory as S;
 use Tarsana\Syntax\ObjectSyntax;
-use Tarsana\Command\Syntax\SyntaxPrinter;
 
 
 class HelpCommand extends SubCommand {

Indentation +14 added lines, -14 removed lines

@@ -35,15 +35,15 @@ 
         $c = $this->console();
 
         $c->br()
-          ->green()
-          ->inline($command->name() . ' ')
-          ->yellow()
-          ->out($command->version())
-          ->br()
-          ->out($command->description())
-          ->br()
-          ->yellow()
-          ->inline('Arguments: ');
+            ->green()
+            ->inline($command->name() . ' ')
+            ->yellow()
+            ->out($command->version())
+            ->br()
+            ->out($command->description())
+            ->br()
+            ->yellow()
+            ->inline('Arguments: ');
 
         $args = F\s(array_keys($command->syntax()->fields()))
             ->then(F\join(' '))
@@ -67,9 +67,9 @@ 
                 ->get() * 2;
             foreach ($command->subCommands() as $name => $cmd) {
                 $c->tab()
-                  ->padding($padding)->char(' ')
-                  ->label("<green>{$name}</green>")
-                  ->result($cmd->description());
+                    ->padding($padding)->char(' ')
+                    ->label("<green>{$name}</green>")
+                    ->result($cmd->description());
             }
         }
     }
@@ -86,8 +86,8 @@ 
             $c->out("(Required)");
         } else {
             $c->inline("(default: ")
-              ->white()->inline(json_encode($syntax->getDefault()))
-              ->yellow()->out(" )");
+                ->white()->inline(json_encode($syntax->getDefault()))
+                ->yellow()->out(" )");
         }
 
         if ($syntax instanceof ArraySyntax) {

Spacing +3 added lines, -3 removed lines

@@ -12,7 +12,7 @@ 
 
 class HelpCommand extends SubCommand {
 
-    protected function init ()
+    protected function init()
     {
         $this
             ->name('Help')
@@ -21,7 +21,7 @@ 
             ->syntax('[command]');
     }
 
-    protected function execute ()
+    protected function execute()
     {
         $command = trim($this->args->command);
         if (empty($command) || !$this->parent()->hasCommand($command))
@@ -30,7 +30,7 @@ 
             $this->showHelpOf($this->parent->command($command));
     }
 
-    protected function showHelpOf (Command $command)
+    protected function showHelpOf(Command $command)
     {
         $c = $this->console();
 

Braces +5 added lines, -4 removed lines

@@ -24,10 +24,11 @@
     protected function execute ()
     {
         $command = trim($this->args->command);
-        if (empty($command) || !$this->parent()->hasCommand($command))
-            $this->showHelpOf($this->parent);
-        else
-            $this->showHelpOf($this->parent->command($command));
+        if (empty($command) || !$this->parent()->hasCommand($command)) {
+                    $this->showHelpOf($this->parent);
+        } else {
+                    $this->showHelpOf($this->parent->command($command));
+        }
     }
 
     protected function showHelpOf (Command $command)

src/SubCommand.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php namespace Tarsana\Command;
 
 use Tarsana\Command\Command;
-use Tarsana\Command\Commands\HelpCommand;
 
 /**
  * A SubCommand which has a parent command and can access it.

src/Syntax/SyntaxBuilder.php

Doc Comments +5 added lines, -5 removed lines

@@ -23,7 +23,7 @@ 
     /**
      * A constructor alias; If you don't like the 'new' keyword.
      * @param  string|Tarsana\Syntax\ObjectSyntax $syntax
-     * @return Tarsana\Command\Syntax\SyntaxBuilder
+     * @return SyntaxBuilder
      * @throws Tarsana\Command\Exceptions\SyntaxBuilderException
      */
     public static function of($syntax)
@@ -88,7 +88,7 @@ 
      * @param  string $name
      * @param  string $description
      * @param  mixed  $default
-     * @return Tarsana\Command\Syntax\SyntaxBuilder
+     * @return SyntaxBuilder
      */
     public function describe($name, $description, $default = null)
     {
@@ -104,7 +104,7 @@ 
     /**
      * Gets a field or subfield from an Syntax.
      *
-     * @param  Tarsana\Syntax\Syntax $syntax
+     * @param  Syntax $syntax
      * @param  array $names
      * @return Tarsana\Syntax\Syntax
      * @throws Tarsana\Command\Exceptions\SyntaxBuilderException
@@ -122,8 +122,8 @@ 
      * Ensures that `$syntax` is an ObjectSyntax or an ArraySyntax of ObjectSyntaxes,
      * and returns the ObjectSyntax or throws a SyntaxBuilderException.
      *
-     * @param  Tarsana\Syntax\Syntax $syntax
-     * @return Tarsana\Syntax\Syntax
+     * @param  Syntax $syntax
+     * @return ObjectSyntax
      * @throws Tarsana\Command\Exceptions\SyntaxBuilderException
      */
     protected function ensureObject(Syntax $syntax)

Spacing +6 added lines, -7 removed lines

@@ -41,7 +41,7 @@ 
     {
         if (is_string($syntax)) {
             $syntax = self::syntaxFromString($syntax);
-        } else if (! ($syntax instanceof ObjectSyntax)) {
+        } else if (!($syntax instanceof ObjectSyntax)) {
             throw new SyntaxBuilderException("The command syntax should be an insatnce of ObjectSyntax");
         }
 
@@ -65,11 +65,11 @@ 
      * @return Tarsana\Syntax\Syntax
      * @throws Tarsana\Command\Exceptions\SyntaxBuilderException
      */
-    protected static function syntaxFromString ($value)
+    protected static function syntaxFromString($value)
     {
         $syntax = F\s($value)->then(        // "first name" [#age]
-            F\chunks('(){}[]""', ' '),      // ["first name", [#age]]
-            F\join(','),                    // "first name",[#age]
+            F\chunks('(){}[]""', ' '), // ["first name", [#age]]
+            F\join(','), // "first name",[#age]
             F\prepend('{ ,'), F\append('}') // { ,"first name",[#age]}
         )->get();
 
@@ -111,8 +111,7 @@ 
      */
     protected function field(Syntax $syntax, $names)
     {
-        return empty($names) ? $syntax :
-            $this->field(
+        return empty($names) ? $syntax : $this->field(
                 $this->ensureObject($syntax)->field(F\head($names)),
                 F\tail($names)
             );
@@ -131,7 +130,7 @@ 
         while ($syntax instanceof ArraySyntax) {
             $syntax = $syntax->itemSyntax();
         }
-        if (! ($syntax instanceof ObjectSyntax)) {
+        if (!($syntax instanceof ObjectSyntax)) {
             throw new SyntaxBuilderException("Could not retreive field of non object syntax '{$syntax}'");
         }
         return $syntax;

Braces +3 added lines, -2 removed lines

@@ -75,8 +75,9 @@
 
         $ss = S::syntax();
 
-        if (!$ss->canParse($syntax))
-            throw new SyntaxBuilderException("Invalid Syntax: '{$syntax}'");
+        if (!$ss->canParse($syntax)) {
+                    throw new SyntaxBuilderException("Invalid Syntax: '{$syntax}'");
+        }
 
         return $ss->parse($syntax);
     }

src/TemplateLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     /**
      * Filesystem getter and setter.
      *
-     * @param  Tarsana\IO\Filesystem|void $value
+     * @param  null|Filesystem $value
      * @return Tarsana\IO\Filesystem|self
      */
     public function fs (Filesystem $value = null)

Spacing +2 added lines, -2 removed lines

@@ -61,7 +61,7 @@ 
      * @param  Tarsana\IO\Filesystem|void $value
      * @return Tarsana\IO\Filesystem|self
      */
-    public function fs (Filesystem $value = null)
+    public function fs(Filesystem $value = null)
     {
         if (null === $value)
             return $this->fs;
@@ -81,7 +81,7 @@ 
      * @throws Tarsana\Command\Exceptions\TemplateNotFound
      * @throws Tarsana\Command\Exceptions\TemplateNameConflict
      */
-    public function load ($name)
+    public function load($name)
     {
         $suportedExtensions = array_keys(self::$providers);
 

Braces +3 added lines, -2 removed lines

@@ -63,8 +63,9 @@
      */
     public function fs (Filesystem $value = null)
     {
-        if (null === $value)
-            return $this->fs;
+        if (null === $value) {
+                    return $this->fs;
+        }
         $this->fs = $value;
         return $this;
     }

src/Templates/TwigTemplateLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
      * Loads a template.
      *
      * @param  string $name
-     * @return Tarsana\Command\Templates\TwigTemplate
+     * @return TwigTemplate
      */
     public function load($name)
     {

src/Templates/TwigTemplate.php

Spacing +3 added lines, -3 removed lines

@@ -21,7 +21,7 @@ 
      */
     protected $data;
 
-    public function __construct (\Twig_TemplateInterface $twig)
+    public function __construct(\Twig_TemplateInterface $twig)
     {
         $this->twig = $twig;
         $this->data = [];
@@ -33,7 +33,7 @@ 
      * @param  array $data
      * @return self
      */
-    public function bind ($data)
+    public function bind($data)
     {
         $this->data = array_merge($this->data, $data);
         return $this;
@@ -57,7 +57,7 @@ 
      *
      * @return self
      */
-    public function clean ()
+    public function clean()
     {
         $this->data = [];
     }

src/Environment.php

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
     public function command($name, $value = null)
     {
         if (null === $value) {
-            if (! $this->hasCommand($name)) {
+            if (!$this->hasCommand($name)) {
                 throw new EnvironmentException("Unable to find the command '{$name}'");
             }
             return $this->store->get($name);

src/Commands/VersionCommand.php

Indentation +3 added lines, -3 removed lines

@@ -19,8 +19,8 @@
     {
         $c = $this->parent();
         $this->console
-             ->green()->inline($c->name())
-             ->white()->inline(' version ')
-             ->yellow()->out($c->version());
+                ->green()->inline($c->name())
+                ->white()->inline(' version ')
+                ->yellow()->out($c->version());
     }
 }

Spacing +2 added lines, -2 removed lines

@@ -7,7 +7,7 @@ 
 
 class VersionCommand extends SubCommand {
 
-    protected function init ()
+    protected function init()
     {
         $this
             ->name('Version')
@@ -15,7 +15,7 @@ 
             ->description('Shows the version of the command');
     }
 
-    protected function execute ()
+    protected function execute()
     {
         $c = $this->parent();
         $this->console