Inspection of "refactor: scrutinizer fixes" - tarlepp/symfony-flex-backend - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( cad016...c41e2d )

by Tarmo

created 2017-10-20 16:01 UTC

Status

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -16,17 +16,17 @@  discard block
 block discarded – undo
 
     public function getCacheDir(): string
     {
-        return dirname(__DIR__).'/var/cache/'.$this->environment;
+        return dirname(__DIR__) . '/var/cache/' . $this->environment;
     }
 
     public function getLogDir(): string
     {
-        return dirname(__DIR__).'/var/log';
+        return dirname(__DIR__) . '/var/log';
     }
 
     public function registerBundles(): iterable
     {
-        $contents = require dirname(__DIR__).'/config/bundles.php';
+        $contents = require dirname(__DIR__) . '/config/bundles.php';
         foreach ($contents as $class => $envs) {
             if (isset($envs['all']) || isset($envs[$this->environment])) {
                 yield new $class();
@@ -36,24 +36,24 @@  discard block
 block discarded – undo
 
     protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader): void
     {
-        $confDir = dirname(__DIR__).'/config';
-        $loader->load($confDir.'/packages/*'.self::CONFIG_EXTS, 'glob');
-        if (is_dir($confDir.'/packages/'.$this->environment)) {
-            $loader->load($confDir.'/packages/'.$this->environment.'/**/*'.self::CONFIG_EXTS, 'glob');
+        $confDir = dirname(__DIR__) . '/config';
+        $loader->load($confDir . '/packages/*' . self::CONFIG_EXTS, 'glob');
+        if (is_dir($confDir . '/packages/' . $this->environment)) {
+            $loader->load($confDir . '/packages/' . $this->environment . '/**/*' . self::CONFIG_EXTS, 'glob');
         }
-        $loader->load($confDir.'/services'.self::CONFIG_EXTS, 'glob');
-        $loader->load($confDir.'/services_'.$this->environment.self::CONFIG_EXTS, 'glob');
+        $loader->load($confDir . '/services' . self::CONFIG_EXTS, 'glob');
+        $loader->load($confDir . '/services_' . $this->environment . self::CONFIG_EXTS, 'glob');
     }
 
     protected function configureRoutes(RouteCollectionBuilder $routes): void
     {
-        $confDir = dirname(__DIR__).'/config';
-        if (is_dir($confDir.'/routes/')) {
-            $routes->import($confDir.'/routes/*'.self::CONFIG_EXTS, '/', 'glob');
+        $confDir = dirname(__DIR__) . '/config';
+        if (is_dir($confDir . '/routes/')) {
+            $routes->import($confDir . '/routes/*' . self::CONFIG_EXTS, '/', 'glob');
         }
-        if (is_dir($confDir.'/routes/'.$this->environment)) {
-            $routes->import($confDir.'/routes/'.$this->environment.'/**/*'.self::CONFIG_EXTS, '/', 'glob');
+        if (is_dir($confDir . '/routes/' . $this->environment)) {
+            $routes->import($confDir . '/routes/' . $this->environment . '/**/*' . self::CONFIG_EXTS, '/', 'glob');
         }
-        $routes->import($confDir.'/routes'.self::CONFIG_EXTS, '/', 'glob');
+        $routes->import($confDir . '/routes' . self::CONFIG_EXTS, '/', 'glob');
     }
 }

Please login to merge, or discard this patch.

src/Utils/JSON.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -52,7 +52,7 @@
 block discarded – undo
      *
      * @throws \LogicException
      */
-    public static function encode($input, ?int $options = null, ?int $depth = null): string
+    public static function encode($input, ?int $options = null, ?int $depth = null) : string
     {
         $options = $options ?? 0;
         $depth = $depth ?? 512;

Please login to merge, or discard this patch.

public/index.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@
 block discarded – undo
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * /public/index.php
  *

Please login to merge, or discard this patch.

public/check.php 2 patches

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * /public/check.php
  *
@@ -42,8 +42,8 @@  discard block
 block discarded – undo
 
 $majorProblems = $symfonyRequirements->getFailedRequirements();
 $minorProblems = $symfonyRequirements->getFailedRecommendations();
-$hasMajorProblems = (bool) count($majorProblems);
-$hasMinorProblems = (bool) count($minorProblems);
+$hasMajorProblems = (bool)count($majorProblems);
+$hasMinorProblems = (bool)count($minorProblems);
 
 ?>
 <!DOCTYPE html>

Please login to merge, or discard this patch.

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

@@ -396,7 +396,10 @@  discard block
 block discarded – undo
                         <?php if ($hasMinorProblems): ?>
                             <h2>Recommendations</h2>
                             <p>
-                                <?php if ($hasMajorProblems): ?>Additionally, to<?php else: ?>To<?php endif; ?> enhance your Symfony experience,
+                                <?php if ($hasMajorProblems): ?>Additionally, to<?php else {
+    : ?>To<?php endif;
+}
+?> enhance your Symfony experience,
                                 it’s recommended that you fix the following:
                             </p>
                             <ol>
@@ -412,9 +415,12 @@  discard block
 block discarded – undo
                             <p id="phpini">*
                                 <?php if ($symfonyRequirements->getPhpIniPath()): ?>
                                     Changes to the <strong>php.ini</strong> file must be done in "<strong><?php echo $symfonyRequirements->getPhpIniPath() ?></strong>".
-                                <?php else: ?>
+                                <?php else {
+    : ?>
                                     To change settings, create a "<strong>php.ini</strong>".
-                                <?php endif; ?>
+                                <?php endif;
+}
+?>
                             </p>
                         <?php endif; ?>
 

Please login to merge, or discard this patch.

bootstrap.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@
 block discarded – undo
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * Application bootstrap file to load specified environment variables.
  *

Please login to merge, or discard this patch.

src/Utils/Tests/Auth.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -131,7 +131,7 @@
 block discarded – undo
         }
 
         if ($response->getStatusCode() !== 200) {
-            throw new \UnexpectedValueException('Invalid status code: '. $response->getStatusCode());
+            throw new \UnexpectedValueException('Invalid status code: ' . $response->getStatusCode());
         }
 
         return JSON::decode($response->getContent())->token;

Please login to merge, or discard this patch.

src/Rest/Traits/RestResourceCount.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -32,7 +32,7 @@
 block discarded – undo
      * @param array   $search
      * @param integer $count
      */
-    public function afterCount(array &$criteria, array &$search, int &$count): void
+    public function afterCount(array &$criteria, array &$search, int&$count): void
     {
     }
 }

Please login to merge, or discard this patch.

src/Rest/Traits/RestResourceUpdate.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
      * @param RestDtoInterface $dto
      * @param EntityInterface  $entity
      */
-    public function beforeUpdate(string &$id, RestDtoInterface $dto, EntityInterface $entity): void
+    public function beforeUpdate(string&$id, RestDtoInterface $dto, EntityInterface $entity): void
     {
     }
 
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
      * @param RestDtoInterface $dto
      * @param EntityInterface  $entity
      */
-    public function afterUpdate(string &$id, RestDtoInterface $dto, EntityInterface $entity): void
+    public function afterUpdate(string&$id, RestDtoInterface $dto, EntityInterface $entity): void
     {
     }
 }

Please login to merge, or discard this patch.

src/Rest/Traits/RestResourceFind.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -26,7 +26,7 @@  discard block
 block discarded – undo
      * @param integer $offset
      * @param array   $search
      */
-    public function beforeFind(array &$criteria, array &$orderBy, int &$limit, int &$offset, array &$search): void
+    public function beforeFind(array &$criteria, array &$orderBy, int&$limit, int&$offset, array &$search): void
     {
     }
 
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
     public function afterFind(
         array &$criteria,
         array &$orderBy,
-        int &$limit,
-        int &$offset,
+        int&$limit,
+        int&$offset,
         array &$search,
         array &$entities
     ): void {

Please login to merge, or discard this patch.

		@@ -52,7 +52,7 @@
		block discarded – undo
52	52	*
53	53	* @throws \LogicException
54	54	*/
55		- public static function encode($input, ?int $options = null, ?int $depth = null): string
	55	+ public static function encode($input, ?int $options = null, ?int $depth = null) : string
56	56	{
57	57	$options = $options ?? 0;
58	58	$depth = $depth ?? 512;

		@@ -131,7 +131,7 @@
		block discarded – undo
131	131	}
132	132
133	133	if ($response->getStatusCode() !== 200) {
134		- throw new \UnexpectedValueException('Invalid status code: '. $response->getStatusCode());
	134	+ throw new \UnexpectedValueException('Invalid status code: ' . $response->getStatusCode());
135	135	}
136	136
137	137	return JSON::decode($response->getContent())->token;

		@@ -16,17 +16,17 @@ discard block
		block discarded – undo
16	16
17	17	public function getCacheDir(): string
18	18	{
19		- return dirname(__DIR__).'/var/cache/'.$this->environment;
	19	+ return dirname(__DIR__) . '/var/cache/' . $this->environment;
20	20	}
21	21
22	22	public function getLogDir(): string
23	23	{
24		- return dirname(__DIR__).'/var/log';
	24	+ return dirname(__DIR__) . '/var/log';
25	25	}
26	26
27	27	public function registerBundles(): iterable
28	28	{
29		- $contents = require dirname(__DIR__).'/config/bundles.php';
	29	+ $contents = require dirname(__DIR__) . '/config/bundles.php';
30	30	foreach ($contents as $class => $envs) {
31	31	if (isset($envs['all']) \|\| isset($envs[$this->environment])) {
32	32	yield new $class();
		@@ -36,24 +36,24 @@ discard block
		block discarded – undo
36	36
37	37	protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader): void
38	38	{
39		- $confDir = dirname(__DIR__).'/config';
40		- $loader->load($confDir.'/packages/*'.self::CONFIG_EXTS, 'glob');
41		- if (is_dir($confDir.'/packages/'.$this->environment)) {
42		- $loader->load($confDir.'/packages/'.$this->environment.'/*/'.self::CONFIG_EXTS, 'glob');
	39	+ $confDir = dirname(__DIR__) . '/config';
	40	+ $loader->load($confDir . '/packages/*' . self::CONFIG_EXTS, 'glob');
	41	+ if (is_dir($confDir . '/packages/' . $this->environment)) {
	42	+ $loader->load($confDir . '/packages/' . $this->environment . '/*/' . self::CONFIG_EXTS, 'glob');
43	43	}
44		- $loader->load($confDir.'/services'.self::CONFIG_EXTS, 'glob');
45		- $loader->load($confDir.'/services_'.$this->environment.self::CONFIG_EXTS, 'glob');
	44	+ $loader->load($confDir . '/services' . self::CONFIG_EXTS, 'glob');
	45	+ $loader->load($confDir . '/services_' . $this->environment . self::CONFIG_EXTS, 'glob');
46	46	}
47	47
48	48	protected function configureRoutes(RouteCollectionBuilder $routes): void
49	49	{
50		- $confDir = dirname(__DIR__).'/config';
51		- if (is_dir($confDir.'/routes/')) {
52		- $routes->import($confDir.'/routes/*'.self::CONFIG_EXTS, '/', 'glob');
	50	+ $confDir = dirname(__DIR__) . '/config';
	51	+ if (is_dir($confDir . '/routes/')) {
	52	+ $routes->import($confDir . '/routes/*' . self::CONFIG_EXTS, '/', 'glob');
53	53	}
54		- if (is_dir($confDir.'/routes/'.$this->environment)) {
55		- $routes->import($confDir.'/routes/'.$this->environment.'/*/'.self::CONFIG_EXTS, '/', 'glob');
	54	+ if (is_dir($confDir . '/routes/' . $this->environment)) {
	55	+ $routes->import($confDir . '/routes/' . $this->environment . '/*/' . self::CONFIG_EXTS, '/', 'glob');
56	56	}
57		- $routes->import($confDir.'/routes'.self::CONFIG_EXTS, '/', 'glob');
	57	+ $routes->import($confDir . '/routes' . self::CONFIG_EXTS, '/', 'glob');
58	58	}
59	59	}

		@@ -1,5 +1,5 @@
		block discarded – undo
1	1	<?php
2		-declare(strict_types=1);
	2	+declare(strict_types = 1);
3	3	/**
4	4	* /public/index.php
5	5	*

		@@ -1,5 +1,5 @@ discard block
		block discarded – undo
1	1	<?php
2		-declare(strict_types=1);
	2	+declare(strict_types = 1);
3	3	/**
4	4	* /public/check.php
5	5	*
		@@ -42,8 +42,8 @@ discard block
		block discarded – undo
42	42
43	43	$majorProblems = $symfonyRequirements->getFailedRequirements();
44	44	$minorProblems = $symfonyRequirements->getFailedRecommendations();
45		-$hasMajorProblems = (bool) count($majorProblems);
46		-$hasMinorProblems = (bool) count($minorProblems);
	45	+$hasMajorProblems = (bool)count($majorProblems);
	46	+$hasMinorProblems = (bool)count($minorProblems);
47	47
48	48	?>
49	49	<!DOCTYPE html>

		@@ -396,7 +396,10 @@ discard block
		block discarded – undo
396	396	<?php if ($hasMinorProblems): ?>
397	397	<h2>Recommendations</h2>
398	398	<p>
399		- <?php if ($hasMajorProblems): ?>Additionally, to<?php else: ?>To<?php endif; ?> enhance your Symfony experience,
	399	+ <?php if ($hasMajorProblems): ?>Additionally, to<?php else {
	400	+ : ?>To<?php endif;
	401	+}
	402	+?> enhance your Symfony experience,
400	403	it’s recommended that you fix the following:
401	404	</p>
402	405	<ol>
		@@ -412,9 +415,12 @@ discard block
		block discarded – undo
412	415	<p id="phpini">*
413	416	<?php if ($symfonyRequirements->getPhpIniPath()): ?>
414	417	Changes to the <strong>php.ini</strong> file must be done in "<strong><?php echo $symfonyRequirements->getPhpIniPath() ?></strong>".
415		- <?php else: ?>
	418	+ <?php else {
	419	+ : ?>
416	420	To change settings, create a "<strong>php.ini</strong>".
417		- <?php endif; ?>
	421	+ <?php endif;
	422	+}
	423	+?>
418	424	</p>
419	425	<?php endif; ?>
420	426

		@@ -32,7 +32,7 @@
		block discarded – undo
32	32	* @param array $search
33	33	* @param integer $count
34	34	*/
35		- public function afterCount(array &$criteria, array &$search, int &$count): void
	35	+ public function afterCount(array &$criteria, array &$search, int&$count): void
36	36	{
37	37	}
38	38	}

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	* @param RestDtoInterface $dto
26	26	* @param EntityInterface $entity
27	27	*/
28		- public function beforeUpdate(string &$id, RestDtoInterface $dto, EntityInterface $entity): void
	28	+ public function beforeUpdate(string&$id, RestDtoInterface $dto, EntityInterface $entity): void
29	29	{
30	30	}
31	31
		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36	* @param RestDtoInterface $dto
37	37	* @param EntityInterface $entity
38	38	*/
39		- public function afterUpdate(string &$id, RestDtoInterface $dto, EntityInterface $entity): void
	39	+ public function afterUpdate(string&$id, RestDtoInterface $dto, EntityInterface $entity): void
40	40	{
41	41	}
42	42	}

		@@ -26,7 +26,7 @@ discard block
		block discarded – undo
26	26	* @param integer $offset
27	27	* @param array $search
28	28	*/
29		- public function beforeFind(array &$criteria, array &$orderBy, int &$limit, int &$offset, array &$search): void
	29	+ public function beforeFind(array &$criteria, array &$orderBy, int&$limit, int&$offset, array &$search): void
30	30	{
31	31	}
32	32
		@@ -43,8 +43,8 @@ discard block
		block discarded – undo
43	43	public function afterFind(
44	44	array &$criteria,
45	45	array &$orderBy,
46		- int &$limit,
47		- int &$offset,
	46	+ int&$limit,
	47	+ int&$offset,
48	48	array &$search,
49	49	array &$entities
50	50	): void {

tarlepp / symfony-flex-backend

Push — master ( cad016...c41e2d )

Status

Category

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch