View GitHub Repository symfony-flex-backend

Schedule Inspection
Subscribe
Passed
Pull Request — master (#1148)
by Tarmo
07:03
created
Status
Category
Toggle Patches
src/Entity/Traits/UserRelations.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-declare(strict_types = 1);
2 
+declare(strict_types=1);
3 3 
 /**
4 4 
  * /src/Entity/Traits/UserRelations.php
5 5 
  *
 
@@ -40,7 +40,7 @@  discard block
 
 block discarded – undo
40 40 
     #[Groups([
41 41 
         'User.userGroups',
42 42 
     ])]
43 
-    protected Collection | ArrayCollection $userGroups;
43 
+    protected Collection|ArrayCollection $userGroups;
44 44
45 45 
     /**
46 46 
      * @var Collection<int, LogRequest>|ArrayCollection<int, LogRequest>
 
@@ -53,7 +53,7 @@  discard block
 
 block discarded – undo
53 53 
     #[Groups([
54 54 
         'User.logsRequest',
55 55 
     ])]
56 
-    protected Collection | ArrayCollection $logsRequest;
56 
+    protected Collection|ArrayCollection $logsRequest;
57 57
58 58 
     /**
59 59 
      * @var Collection<int, LogLogin>|ArrayCollection<int, LogLogin>
 
@@ -66,7 +66,7 @@  discard block
 
 block discarded – undo
66 66 
     #[Groups([
67 67 
         'User.logsLogin',
68 68 
     ])]
69 
-    protected Collection | ArrayCollection $logsLogin;
69 
+    protected Collection|ArrayCollection $logsLogin;
70 70
71 71 
     /**
72 72 
      * @var Collection<int, LogLoginFailure>|ArrayCollection<int, LogLoginFailure>
 
@@ -79,7 +79,7 @@  discard block
 
 block discarded – undo
79 79 
     #[Groups([
80 80 
         'User.logsLoginFailure',
81 81 
     ])]
82 
-    protected Collection | ArrayCollection $logsLoginFailure;
82 
+    protected Collection|ArrayCollection $logsLoginFailure;
83 83
84 84 
     /**
85 85 
      * Getter for roles.
 
@@ -100,7 +100,7 @@  discard block
 
 block discarded – undo
100 100 
     public function getRoles(): array
101 101 
     {
102 102 
         return $this->userGroups
103 
-            ->map(static fn (UserGroup $userGroup): string => $userGroup->getRole()->getId())
103 
+            ->map(static fn(UserGroup $userGroup): string => $userGroup->getRole()->getId())
104 104 
             ->toArray();
105 105 
     }
106 106 
 
@@ -109,7 +109,7 @@  discard block
 
 block discarded – undo
109 109 
      *
110 110 
      * @return Collection<int, UserGroup>|ArrayCollection<int, UserGroup>
111 111 
      */
112 
-    public function getUserGroups(): Collection | ArrayCollection
112 
+    public function getUserGroups(): Collection|ArrayCollection
113 113 
     {
114 114 
         return $this->userGroups;
115 115 
     }
 
@@ -119,7 +119,7 @@  discard block
 
 block discarded – undo
119 119 
      *
120 120 
      * @return Collection<int, LogRequest>|ArrayCollection<int, LogRequest>
121 121 
      */
122 
-    public function getLogsRequest(): Collection | ArrayCollection
122 
+    public function getLogsRequest(): Collection|ArrayCollection
123 123 
     {
124 124 
         return $this->logsRequest;
125 125 
     }
 
@@ -129,7 +129,7 @@  discard block
 
 block discarded – undo
129 129 
      *
130 130 
      * @return Collection<int, LogLogin>|ArrayCollection<int, LogLogin>
131 131 
      */
132 
-    public function getLogsLogin(): Collection | ArrayCollection
132 
+    public function getLogsLogin(): Collection|ArrayCollection
133 133 
     {
134 134 
         return $this->logsLogin;
135 135 
     }
 
@@ -139,7 +139,7 @@  discard block
 
 block discarded – undo
139 139 
      *
140 140 
      * @return Collection<int, LogLoginFailure>|ArrayCollection<int, LogLoginFailure>
141 141 
      */
142 
-    public function getLogsLoginFailure(): Collection | ArrayCollection
142 
+    public function getLogsLoginFailure(): Collection|ArrayCollection
143 143 
     {
144 144 
         return $this->logsLoginFailure;
145 145 
     }
Please login to merge, or discard this patch.
src/Rest/SearchTerm.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-declare(strict_types = 1);
2 
+declare(strict_types=1);
3 3 
 /**
4 4 
  * /src/Rest/SearchTerm.php
5 5 
  *
 
@@ -29,8 +29,8 @@  discard block
 
 block discarded – undo
29 29 
 final class SearchTerm implements SearchTermInterface
30 30 
 {
31 31 
     public static function getCriteria(
32 
-        array | string | null $column,
33 
-        array | string | null $search,
32 
+        array|string|null $column,
33 
+        array|string|null $search,
34 34 
         ?string $operand = null,
35 35 
         ?int $mode = null,
36 36 
     ): ?array {
 
@@ -90,7 +90,7 @@  discard block
 
 block discarded – undo
90 90 
      */
91 91 
     private static function getTermIterator(array $columns, int $mode): Closure
92 92 
     {
93 
-        return static fn (string $term): ?array => !empty($columns)
93 
+        return static fn(string $term): ?array => !empty($columns)
94 94 
             ? array_map(self::getColumnIterator($term, $mode), $columns)
95 95 
             : null;
96 96 
     }
 
@@ -107,7 +107,7 @@  discard block
 
 block discarded – undo
107 107 
          *
108 108 
          * @return array<int, string>
109 109 
          */
110 
-        return static fn (string $column): array => [
110 
+        return static fn(string $column): array => [
111 111 
             !str_contains($column, '.') ? 'entity.' . $column : $column, 'like', self::getTerm($mode, $term),
112 112 
         ];
113 113 
     }
 
@@ -117,7 +117,7 @@  discard block
 
 block discarded – undo
117 117 
      */
118 118 
     private static function getTerm(int $mode, string $term): string
119 119 
     {
120 
-        return match ($mode) {
120 
+        return match($mode) {
121 121 
             self::MODE_STARTS_WITH => $term . '%',
122 122 
             self::MODE_ENDS_WITH => '%' . $term,
123 123 
             default => '%' . $term . '%', // self::MODE_FULL
 
@@ -130,12 +130,12 @@  discard block
 
 block discarded – undo
130 130 
      *
131 131 
      * @return array<int, string>
132 132 
      */
133 
-    private static function getColumns(array | string | null $column): array
133 
+    private static function getColumns(array|string|null $column): array
134 134 
     {
135 135 
         // Normalize column and search parameters
136 136 
         return array_filter(
137 137 
             array_map('trim', (is_array($column) ? $column : (array)(string)$column)),
138 
-            static fn (string $value): bool => trim($value) !== ''
138 
+            static fn(string $value) : bool => trim($value) !== ''
139 139 
         );
140 140 
     }
141 141 
 
@@ -146,12 +146,12 @@  discard block
 
 block discarded – undo
146 146 
      *
147 147 
      * @return array<int, string>
148 148 
      */
149 
-    private static function getSearchTerms(array | string | null $search): array
149 
+    private static function getSearchTerms(array|string|null $search): array
150 150 
     {
151 151 
         return array_unique(
152 152 
             array_filter(
153 153 
                 array_map('trim', (is_array($search) ? $search : explode(' ', (string)$search))),
154 
-                static fn (string $value): bool => trim($value) !== ''
154 
+                static fn(string $value) : bool => trim($value) !== ''
155 155 
             )
156 156 
         );
157 157 
     }
Please login to merge, or discard this patch.
src/Rest/ResponseHandler.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-declare(strict_types = 1);
2 
+declare(strict_types=1);
3 3 
 /**
4 4 
  * /src/Rest/ResponseHandler.php
5 5 
  *
 
@@ -84,7 +84,7 @@  discard block
 
 block discarded – undo
84 84 
             );
85 85
86 86 
             $groups = array_merge([$entityName], $populate);
87 
-            $filter = static fn (string $groupName): bool => strncmp($groupName, 'Set.', 4) === 0;
87 
+            $filter = static fn(string $groupName): bool => strncmp($groupName, 'Set.', 4) === 0;
88 88
89 89 
             if (array_key_exists('populateOnly', $request->query->all())
90 90 
                 || !empty(array_filter($groups, $filter))
 
@@ -127,7 +127,7 @@  discard block
 
 block discarded – undo
127 127
128 128 
         /** @var FormError $error */
129 129 
         foreach ($form->getErrors(true) as $error) {
130 
-            $name = $error->getOrigin()?->getName() ?? '';
130 
+            $name = $error->getOrigin() ? ->getName() ?? '';
131 131
132 132 
             $errors[] = sprintf(
133 133 
                 'Field \'%s\': %s',
 
@@ -162,7 +162,7 @@  discard block
 
 block discarded – undo
162 162 
         if ($populateAll && empty($populate)) {
163 163 
             $associations = $restResource->getAssociations();
164 164 
             $populate = array_map(
165 
-                static fn (string $assocName): string => $entityName . '.' . $assocName,
165 
+                static fn(string $assocName): string => $entityName . '.' . $assocName,
166 166 
                 $associations,
167 167 
             );
168 168 
         }
Please login to merge, or discard this patch.