tarantool-php / mapper

src/Client.php

Doc Comments +3 added lines

@@ -31,6 +31,9 @@
         return $response;
     }
 
+    /**
+     * @param double $start
+     */
     private function log($start, $class, $request = [], $response = [])
     {
         if ($this->logging) {

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
     public function getTimeSummary()
     {
         $summary = 0;
-        foreach($this->log as $request) {
+        foreach ($this->log as $request) {
             $summary += $request[0];
         }
         return $summary;

src/Mapper.php

Doc Comments +9 added lines

@@ -28,6 +28,9 @@ 
         return $plugin;
     }
 
+    /**
+     * @param string $space
+     */
     public function create($space, $data)
     {
         $instance = $this->getRepository($space)->create($data);
@@ -35,11 +38,17 @@ 
         return $instance;
     }
 
+    /**
+     * @param string $space
+     */
     public function findOne($space, $params = [])
     {
         return $this->getRepository($space)->findOne($params);
     }
 
+    /**
+     * @param string $space
+     */
     public function find($space, $params = [])
     {
         return $this->getRepository($space)->find($params);

Spacing +8 added lines, -8 removed lines

@@ -19,8 +19,8 @@ 
 
     public function addPlugin($class)
     {
-        if(!is_subclass_of($class, Plugin::class)) {
-            throw new Exception("Plugin should extend " . Plugin::class . " class");
+        if (!is_subclass_of($class, Plugin::class)) {
+            throw new Exception("Plugin should extend ".Plugin::class." class");
         }
 
         $plugin = is_object($class) ? $class : new $class($this);
@@ -48,8 +48,8 @@ 
 
     public function findRepository(Entity $instance)
     {
-        foreach($this->getSchema()->getSpaces() as $space) {
-            if($space->getRepository()->knows($instance)) {
+        foreach ($this->getSchema()->getSpaces() as $space) {
+            if ($space->getRepository()->knows($instance)) {
                 return $space->getRepository();
             }
         }
@@ -69,7 +69,7 @@ 
 
     public function getPlugin($class)
     {
-        if(!array_key_exists($class, $this->plugins)) {
+        if (!array_key_exists($class, $this->plugins)) {
             throw new Exception("No plugin $class");
         }
         return $this->plugins[$class];
@@ -88,8 +88,8 @@ 
     public function getRepositories()
     {
         $repositories = [];
-        foreach($this->getSchema()->getSpaces() as $space) {
-            if($space->repositoryExists()) {
+        foreach ($this->getSchema()->getSpaces() as $space) {
+            if ($space->repositoryExists()) {
                 $repositories[] = $space->getRepository();
             }
         }
@@ -103,7 +103,7 @@ 
 
     public function remove($space, $params = [])
     {
-        if($space instanceof Entity) {
+        if ($space instanceof Entity) {
             $this->findRepository($space)->removeEntity($space);
 
         } else {

src/Plugins/Sequence.php

Doc Comments +3 added lines

@@ -19,6 +19,9 @@
         }
     }
 
+    /**
+     * @param Space $space
+     */
     private function generateValue($space)
     {
         $spaceId = $space->getId();

Spacing +4 added lines, -4 removed lines

@@ -11,9 +11,9 @@ 
     public function generateKey(Entity $instance, Space $space)
     {
         $primary = $space->getPrimaryIndex();
-        if(count($primary->parts) == 1) {
+        if (count($primary->parts) == 1) {
             $key = $space->getFormat()[$primary->parts[0][0]]['name'];
-            if(!property_exists($instance, $key)) {
+            if (!property_exists($instance, $key)) {
                 $instance->$key = $this->generateValue($space);
             }
         }
@@ -23,7 +23,7 @@ 
     {
         $spaceId = $space->getId();
 
-        if(!$this->mapper->getSchema()->hasSpace('sequence')) {
+        if (!$this->mapper->getSchema()->hasSpace('sequence')) {
 
             $sequence = $this->mapper->getSchema()->createSpace('sequence');
             $sequence->addProperty('space', 'unsigned');
@@ -32,7 +32,7 @@ 
         }
 
         $entity = $this->mapper->findOne('sequence', $space->getId());
-        if(!$entity) {
+        if (!$entity) {
 
             $query = "return box.space.".$space->getName().".index[0]:max()";
             $data = $this->mapper->getClient()->evaluate($query)->getData();

src/Plugins/UserClasses.php

Spacing +9 added lines, -9 removed lines

@@ -15,14 +15,14 @@ 
 
     public function getRepositoryClass(Space $space)
     {
-        if(array_key_exists($space->getName(), $this->repositories)) {
+        if (array_key_exists($space->getName(), $this->repositories)) {
             return $this->repositories[$space->getName()];
         }
     }
 
     public function getEntityClass(Space $space)
     {
-        if(array_key_exists($space->getName(), $this->entities)) {
+        if (array_key_exists($space->getName(), $this->entities)) {
             return $this->entities[$space->getName()];
         }
     }
@@ -31,12 +31,12 @@ 
     {
         $this->validateSpace($space);
 
-        if(!class_exists($class)) {
+        if (!class_exists($class)) {
             throw new Exception("No class $class");
         }
 
-        if(!is_subclass_of($class, Entity::class)) {
-            throw new Exception("Entity should extend " . Entity::class . " class");
+        if (!is_subclass_of($class, Entity::class)) {
+            throw new Exception("Entity should extend ".Entity::class." class");
         }
 
         $this->entities[$space] = $class;
@@ -46,12 +46,12 @@ 
     {
         $this->validateSpace($space);
 
-        if(!class_exists($class)) {
+        if (!class_exists($class)) {
             throw new Exception("No class $class");
         }
 
-        if(!is_subclass_of($class, Repository::class)) {
-            throw new Exception("Repository should extend " . Repository::class . " class");
+        if (!is_subclass_of($class, Repository::class)) {
+            throw new Exception("Repository should extend ".Repository::class." class");
         }
 
         $this->repositories[$space] = $class;
@@ -59,7 +59,7 @@ 
 
     public function validateSpace($space)
     {
-        if(!$this->mapper->getSchema()->hasSpace($space)) {
+        if (!$this->mapper->getSchema()->hasSpace($space)) {
             throw new Exception("No space $space");
         }
     }

src/Bootstrap.php

Spacing +2 added lines, -2 removed lines

@@ -20,8 +20,8 @@
     public function migrate()
     {
         $schema = $this->mapper->getSchema();
-        foreach($this->migrations as $migration) {
-            if(!is_object($migration)) {
+        foreach ($this->migrations as $migration) {
+            if (!is_object($migration)) {
                 $migration = new $migration;
             }
             $schema->once(get_class($migration), function() use ($migration) {

src/Plugins/Spy.php

Spacing +7 added lines, -7 removed lines

@@ -20,7 +20,7 @@ 
     public function beforeUpdate(Entity $instance, Space $space)
     {
         $key = $this->getKey($instance, $space);
-        if(!array_key_exists($key, $this->create)) {
+        if (!array_key_exists($key, $this->create)) {
             $this->update[$key] = $instance;
         }
     }
@@ -29,12 +29,12 @@ 
     {
         $key = $this->getKey($instance, $space);
 
-        if(array_key_exists($key, $this->create)) {
+        if (array_key_exists($key, $this->create)) {
             unset($this->create[$key]);
             return;
         }
 
-        if(array_key_exists($key, $this->update)) {
+        if (array_key_exists($key, $this->update)) {
             unset($this->update[$key]);
         }
 
@@ -53,7 +53,7 @@ 
         $key = [$space->getName()];
 
         $format = $space->getFormat();
-        foreach($space->getPrimaryIndex()->parts as $part) {
+        foreach ($space->getPrimaryIndex()->parts as $part) {
             $key[] = $instance->{$format[$part[0]]['name']};
         }
 
@@ -64,11 +64,11 @@ 
     {
         $result = (object) [];
 
-        foreach(['create', 'update', 'remove'] as $action) {
+        foreach (['create', 'update', 'remove'] as $action) {
             $data = [];
-            foreach($this->$action as $key => $row) {
+            foreach ($this->$action as $key => $row) {
                 list($space) = explode(':', $key);
-                if(!array_key_exists($space, $data)) {
+                if (!array_key_exists($space, $data)) {
                     $data[$space] = [];
                 }
                 $data[$space][] = $row;

src/Space.php

Spacing +46 added lines, -46 removed lines

@@ -27,7 +27,7 @@ 
 
     public function addProperties($config)
     {
-        foreach($config as $name => $type) {
+        foreach ($config as $name => $type) {
             $this->addProperty($name, $type);
         }
         return $this;
@@ -36,8 +36,8 @@ 
     public function addProperty($name, $type)
     {
         $format = $this->getFormat();
-        foreach($format as $field) {
-            if($field['name'] == $name) {
+        foreach ($format as $field) {
+            if ($field['name'] == $name) {
                 throw new Exception("Property $name exists");
             }
         }
@@ -54,7 +54,7 @@ 
     {
         $format = $this->getFormat();
         $last = array_pop($format);
-        if($last['name'] != $name) {
+        if ($last['name'] != $name) {
             throw new Exception("Remove only last property");
         }
         $this->mapper->getClient()->evaluate("box.space[$this->id]:format(...)", [$format]);
@@ -82,13 +82,13 @@ 
     public function createIndex($config)
     {
 
-        if(!is_array($config)) {
+        if (!is_array($config)) {
             $config = ['fields' => $config];
         }
 
 
-        if(!array_key_exists('fields', $config)) {
-            if(array_values($config) != $config) {
+        if (!array_key_exists('fields', $config)) {
+            if (array_values($config) != $config) {
                 throw new Exception("Invalid index configuration");
             }
             $config = [
@@ -96,7 +96,7 @@ 
             ];
         }
 
-        if(!is_array($config['fields'])) {
+        if (!is_array($config['fields'])) {
             $config['fields'] = [$config['fields']];
         }
 
@@ -104,17 +104,17 @@ 
             'parts' => []
         ];
 
-        foreach($config as $k => $v) {
-            if($k != 'name' && $k != 'fields') {
+        foreach ($config as $k => $v) {
+            if ($k != 'name' && $k != 'fields') {
                 $options[$k] = $v;
             }
         }
 
-        foreach($config['fields'] as $property) {
-            if(!$this->getPropertyType($property)) {
+        foreach ($config['fields'] as $property) {
+            if (!$this->getPropertyType($property)) {
                 throw new Exception("Unknown property $property", 1);
             }
-            $options['parts'][] = $this->getPropertyIndex($property)+1;
+            $options['parts'][] = $this->getPropertyIndex($property) + 1;
             $options['parts'][] = $this->getPropertyType($property);
         }
 
@@ -140,15 +140,15 @@ 
 
     public function getFormat()
     {
-        if(!$this->format) {
-            if($this->isSpecial()) {
+        if (!$this->format) {
+            if ($this->isSpecial()) {
                 $this->format = $this->mapper->getClient()
                     ->getSpace(280)->select([$this->id])->getData()[0][6];
 
             } else {
                 $this->format = $this->mapper->findOne('_space', ['id' => $this->id])->format;
             }
-            if(!$this->format) {
+            if (!$this->format) {
                 $this->format = [];
             }
             $this->parseFormat();
@@ -171,7 +171,7 @@ 
     {
         $this->formatTypesHash = [];
         $this->formatNamesHash = [];
-        foreach($this->format as $key => $row) {
+        foreach ($this->format as $key => $row) {
             $this->formatTypesHash[$row['name']] = $row['type'];
             $this->formatNamesHash[$row['name']] = $key;
         }
@@ -186,7 +186,7 @@ 
 
     public function getPropertyType($name)
     {
-        if(!$this->hasProperty($name)) {
+        if (!$this->hasProperty($name)) {
             throw new Exception("No property $name");
         }
         return $this->formatTypesHash[$name];
@@ -194,7 +194,7 @@ 
 
     public function getPropertyIndex($name)
     {
-        if(!$this->hasProperty($name)) {
+        if (!$this->hasProperty($name)) {
             throw new Exception("No property $name");
         }
         return $this->formatNamesHash[$name];
@@ -202,14 +202,14 @@ 
 
     public function getIndexes()
     {
-        if(!$this->indexes) {
-            if($this->isSpecial()) {
+        if (!$this->indexes) {
+            if ($this->isSpecial()) {
                 $this->indexes = [];
                 $indexTuples = $this->mapper->getClient()->getSpace(288)->select([$this->id])->getData();
                 $indexFormat = $this->mapper->getSchema()->getSpace(288)->getFormat();
-                foreach($indexTuples as $tuple) {
+                foreach ($indexTuples as $tuple) {
                     $instance = (object) [];
-                    foreach($indexFormat as $index => $format) {
+                    foreach ($indexFormat as $index => $format) {
                         $instance->{$format['name']} = $tuple[$index];
                     }
                     $this->indexes[] = $instance;
@@ -227,44 +227,44 @@ 
         $keys = array_keys($params);
 
         $keys = [];
-        foreach($params as $name => $value) {
+        foreach ($params as $name => $value) {
             $keys[] = $this->getPropertyIndex($name);
         }
-        if($keys == [0]) {
+        if ($keys == [0]) {
             // primary index
             return 0;
         }
 
         // equals
-        foreach($this->getIndexes() as $index) {
+        foreach ($this->getIndexes() as $index) {
             $equals = false;
-            if(count($keys) == count($index->parts)) {
+            if (count($keys) == count($index->parts)) {
                 // same length
                 $equals = true;
-                foreach($index->parts as $part) {
+                foreach ($index->parts as $part) {
                     $equals = $equals && in_array($part[0], $keys);
                 }
             }
 
-            if($equals) {
+            if ($equals) {
                 return $index->iid;
             }
         }
 
         // index part
-        foreach($this->getIndexes() as $index) {
+        foreach ($this->getIndexes() as $index) {
             $partial = [];
-            foreach($index->parts as $n => $part) {
-                if(!array_key_exists($n, $keys)) {
+            foreach ($index->parts as $n => $part) {
+                if (!array_key_exists($n, $keys)) {
                     break;
                 }
-                if($keys[$n] != $part[0]) {
+                if ($keys[$n] != $part[0]) {
                     break;
                 }
                 $partial[] = $keys[$n];
             }
 
-            if(count($partial) == count($keys)) {
+            if (count($partial) == count($keys)) {
                 return $index->iid;
             }
         }
@@ -275,21 +275,21 @@ 
     public function getIndexValues($indexId, $params)
     {
         $index = null;
-        foreach($this->getIndexes() as $candidate) {
-            if($candidate->iid == $indexId) {
+        foreach ($this->getIndexes() as $candidate) {
+            if ($candidate->iid == $indexId) {
                 $index = $candidate;
                 break;
             }
         }
-        if(!$index) {
+        if (!$index) {
             throw new Exception("Undefined index: $indexId");
         }
 
         $format = $this->getFormat();
         $values = [];
-        foreach($index->parts as $part) {
+        foreach ($index->parts as $part) {
             $name = $format[$part[0]]['name'];
-            if(!array_key_exists($name, $params)) {
+            if (!array_key_exists($name, $params)) {
                 break;
             }
             $values[] = $this->mapper->getSchema()->formatValue($part[1], $params[$name]);
@@ -300,7 +300,7 @@ 
     public function getPrimaryIndex()
     {
         $indexes = $this->getIndexes();
-        if(!count($indexes)) {
+        if (!count($indexes)) {
             throw new Exception("No primary index");
         }
         return $indexes[0];
@@ -309,7 +309,7 @@ 
     public function getTupleKey($tuple)
     {
         $key = [];
-        foreach($this->getPrimaryIndex()->parts as $part) {
+        foreach ($this->getPrimaryIndex()->parts as $part) {
             $key[] = $tuple[$part[0]];
         }
         return count($key) == 1 ? $key[0] : implode(':', $key);
@@ -320,9 +320,9 @@ 
 
         $key = [];
 
-        foreach($this->getPrimaryIndex()->parts as $part) {
+        foreach ($this->getPrimaryIndex()->parts as $part) {
             $name = $this->getFormat()[$part[0]]['name'];
-            if(!property_exists($instance, $name)) {
+            if (!property_exists($instance, $name)) {
                 throw new Exception("Field $name is undefined", 1);
             }
             $key[] = $instance->$name;
@@ -334,10 +334,10 @@ 
     public function getRepository()
     {
         $class = Repository::class;
-        foreach($this->mapper->getPlugins() as $plugin) {
+        foreach ($this->mapper->getPlugins() as $plugin) {
             $repositoryClass = $plugin->getRepositoryClass($this);
-            if($repositoryClass) {
-                if($class != Repository::class) {
+            if ($repositoryClass) {
+                if ($class != Repository::class) {
                     throw new Exception('Repository class override');
                 }
                 $class = $repositoryClass;

src/Schema.php

Spacing +9 added lines, -9 removed lines

@@ -28,7 +28,7 @@ 
 
         $this->spaces[$id] = new Space($this->mapper, $id, $space);
 
-        if($properties) {
+        if ($properties) {
             $this->spaces[$id]->addProperties($properties);
         }
 
@@ -37,7 +37,7 @@ 
 
     public function formatValue($type, $value)
     {
-        switch($type) {
+        switch ($type) {
             case 'STR':
             case 'str':
                 return (string) $value;
@@ -53,15 +53,15 @@ 
 
     public function getSpace($id)
     {
-        if(is_string($id)) {
+        if (is_string($id)) {
             return $this->getSpace($this->getSpaceId($id));
         }
 
-        if(!$id) {
+        if (!$id) {
             throw new Exception("Space id or name not defined");
         }
 
-        if(!array_key_exists($id, $this->spaces)) {
+        if (!array_key_exists($id, $this->spaces)) {
             $this->spaces[$id] = new Space($this->mapper, $id, array_search($id, $this->names));
         }
         return $this->spaces[$id];
@@ -69,7 +69,7 @@ 
 
     public function getSpaceId($name)
     {
-        if(!$this->hasSpace($name)) {
+        if (!$this->hasSpace($name)) {
             throw new Exception("No space $name");
         }
         return $this->names[$name];
@@ -77,7 +77,7 @@ 
 
     public function getSpaces()
     {
-        foreach($this->names as $id) {
+        foreach ($this->names as $id) {
             $this->getSpace($id);
         }
         return $this->spaces;
@@ -90,10 +90,10 @@ 
 
     public function once($name, $callback)
     {
-        $key = 'once' . $name;
+        $key = 'once'.$name;
 
         $rows = $this->mapper->find('_schema', ['key' => $key]);
-        if(!count($rows)) {
+        if (!count($rows)) {
             $this->mapper->create('_schema', ['key' => $key]);
             return $callback($this->mapper);
         }

src/Plugins/Annotation.php

Doc Comments +3 added lines

@@ -120,6 +120,9 @@
 
     private $underscores = [];
 
+    /**
+     * @param string $input
+     */
     private function toUnderscore($input)
     {
         if(!array_key_exists($input, $this->underscores)) {

Unused Use Statements -3 removed lines

@@ -3,13 +3,10 @@
 namespace Tarantool\Mapper\Plugins;
 
 use Exception;
-
 use phpDocumentor\Reflection\DocBlockFactory;
 use ReflectionClass;
 use ReflectionProperty;
-
 use Tarantool\Mapper\Entity;
-use Tarantool\Mapper\Plugin;
 use Tarantool\Mapper\Repository;
 
 class Annotation extends UserClasses

Spacing +26 added lines, -26 removed lines

@@ -22,19 +22,19 @@ 
         $isEntity = is_subclass_of($class, Entity::class);
         $isRepository = is_subclass_of($class, Repository::class);
 
-        if(!$isEntity && !$isRepository) {
+        if (!$isEntity && !$isRepository) {
             throw new Exception("Invalid registration");
         }
 
-        if($isEntity) {
-            if($class == Entity::class) {
+        if ($isEntity) {
+            if ($class == Entity::class) {
                 throw new Exception("Invalid entity registration");
             }
             $this->entities[] = $class;
         }
 
-        if($isRepository) {
-            if($class == Repository::class) {
+        if ($isRepository) {
+            if ($class == Repository::class) {
                 throw new Exception("Invalid repository registration");
             }
             $this->repositories[] = $class;
@@ -42,8 +42,8 @@ 
 
         $reflection = new ReflectionClass($class);
         $space = $this->toUnderscore($reflection->getShortName());
-        if($this->mapper->getSchema()->hasSpace($space)) {
-            if($isEntity) {
+        if ($this->mapper->getSchema()->hasSpace($space)) {
+            if ($isEntity) {
                 $this->mapEntity($space, $class);
             } else {
                 $this->mapRepository($space, $class);
@@ -58,7 +58,7 @@ 
 
         $schema = $this->mapper->getSchema();
 
-        foreach($this->entities as $entity) {
+        foreach ($this->entities as $entity) {
 
             $class = new ReflectionClass($entity);
             $spaceName = $this->toUnderscore($class->getShortName());
@@ -66,34 +66,34 @@ 
             $space = $schema->hasSpace($spaceName) ? $schema->getSpace($spaceName) : $schema->createSpace($spaceName);
             $this->mapEntity($spaceName, $entity);
 
-            foreach($class->getProperties(ReflectionProperty::IS_PUBLIC) as $property) {
+            foreach ($class->getProperties(ReflectionProperty::IS_PUBLIC) as $property) {
 
                 $description = $factory->create($property->getDocComment());
                 $tags = $description->getTags('var');
 
-                if(!count($tags)) {
+                if (!count($tags)) {
                     throw new Exception("No var tag for ".$entity.'::'.$property->getName());
                 }
 
-                if(count($tags) > 1) {
+                if (count($tags) > 1) {
                     throw new Exception("Invalid var tag for ".$entity.'::'.$property->getName());
                 }
 
                 $property = $this->toUnderscore($property->getName());
                 $type = $this->getTarantoolType($tags[0]->getType());
 
-                if(!$space->hasProperty($property)) {
+                if (!$space->hasProperty($property)) {
                     $space->addProperty($property, $type);
                 }
             }
         }
 
-        foreach($this->repositories as $repository) {
+        foreach ($this->repositories as $repository) {
 
             $class = new ReflectionClass($repository);
             $spaceName = $this->toUnderscore($class->getShortName());
 
-            if(!$schema->hasSpace($spaceName)) {
+            if (!$schema->hasSpace($spaceName)) {
                 throw new Exception("Repository with no entity definition");
             }
 
@@ -101,12 +101,12 @@ 
 
             $space = $schema->getSpace($spaceName);
             $properties = $class->getDefaultProperties();
-            if(array_key_exists('indexes', $properties)) {
-                foreach($properties['indexes'] as $index) {
-                    if(!is_array($index)) {
+            if (array_key_exists('indexes', $properties)) {
+                foreach ($properties['indexes'] as $index) {
+                    if (!is_array($index)) {
                         $index = (array) $index;
                     }
-                    if(!array_key_exists('fields', $index)) {
+                    if (!array_key_exists('fields', $index)) {
                         $index = ['fields' => $index];
                     }
 
@@ -116,11 +116,11 @@ 
             }
         }
 
-        foreach($schema->getSpaces() as $space) {
+        foreach ($schema->getSpaces() as $space) {
 
-            if(!count($space->getIndexes())) {
-                if(!$space->hasProperty('id')) {
-                    throw new Exception("No primary index on ". $space->getName());
+            if (!count($space->getIndexes())) {
+                if (!$space->hasProperty('id')) {
+                    throw new Exception("No primary index on ".$space->getName());
                 }
                 $space->addIndex(['id']);
             }
@@ -133,7 +133,7 @@ 
 
     private function toUnderscore($input)
     {
-        if(!array_key_exists($input, $this->underscores)) {
+        if (!array_key_exists($input, $this->underscores)) {
             preg_match_all('!([A-Z][A-Z0-9]*(?=$|[A-Z][a-z0-9])|[A-Za-z][a-z0-9]+)!', $input, $matches);
             $ret = $matches[0];
             foreach ($ret as &$match) {
@@ -148,15 +148,15 @@ 
 
     private function getTarantoolType(string $type)
     {
-        if(array_key_exists($type, $this->tarantoolTypes)) {
+        if (array_key_exists($type, $this->tarantoolTypes)) {
             return $this->tarantoolTypes[$type];
         }
 
-        if($type[0] == '\\') {
+        if ($type[0] == '\\') {
             return $this->tarantoolTypes[$type] = 'unsigned';
         }
 
-        switch($type) {
+        switch ($type) {
             case 'int':
                 return $this->tarantoolTypes[$type] = 'unsigned';