tabulate / tabulate

src/Menus.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 
 use Exception;
 use WordPress\Tabulate\DB\Exception as TabulateException;
-use WordPress\Tabulate\DB\Table;
 use WP_Admin_Bar;
 use WP_Filesystem_Base;
 use wpdb;

Spacing +9 added lines, -9 removed lines

@@ -77,7 +77,7 @@ 
 
 		// Home page (also change the first submenu item's title).
 		add_menu_page( 'Tabulate', 'Tabulate', 'read', TABULATE_SLUG, $dispatch_callback );
-		$page_title = ( isset( $_GET['table'] ) ) ? Text::titlecase( $_GET['table'] ) : 'Tabulate';
+		$page_title = ( isset( $_GET[ 'table' ] ) ) ? Text::titlecase( $_GET[ 'table' ] ) : 'Tabulate';
 		add_submenu_page( TABULATE_SLUG, $page_title, 'Overview', 'read', TABULATE_SLUG, $dispatch_callback );
 
 		// Add submenu pages.
@@ -134,17 +134,17 @@ 
 
 		// Only dispatch when it's our page.
 		$slug_lenth = strlen( TABULATE_SLUG );
-		if ( ! isset( $request['page'] ) || substr( $request['page'], 0, $slug_lenth ) !== TABULATE_SLUG ) {
+		if ( ! isset( $request[ 'page' ] ) || substr( $request[ 'page' ], 0, $slug_lenth ) !== TABULATE_SLUG ) {
 			return;
 		}
 
 		// Discern the controller name, based on an explicit request parameter, or
 		// the trailing part of the page slug (i.e. after 'tabulate_').
 		$controller_name = 'home';
-		if ( isset( $request['controller'] ) && strlen( $request['controller'] ) > 0 ) {
-			$controller_name = $request['controller'];
-		} elseif ( isset( $request['page'] ) && strlen( $request['page'] ) > $slug_lenth ) {
-			$controller_name = substr( $request['page'], $slug_lenth + 1 );
+		if ( isset( $request[ 'controller' ] ) && strlen( $request[ 'controller' ] ) > 0 ) {
+			$controller_name = $request[ 'controller' ];
+		} elseif ( isset( $request[ 'page' ] ) && strlen( $request[ 'page' ] ) > $slug_lenth ) {
+			$controller_name = substr( $request[ 'page' ], $slug_lenth + 1 );
 		}
 
 		// Create the controller and run the action.
@@ -154,8 +154,8 @@ 
 		}
 		$controller = new $controller_classname( $this->wpdb );
 		$controller->set_filesystem( $this->filesystem );
-		$action = ! empty( $request['action'] ) ? $request['action'] : 'index';
-		unset( $request['page'], $request['controller'], $request['action'] );
+		$action = ! empty( $request[ 'action' ] ) ? $request[ 'action' ] : 'index';
+		unset( $request[ 'page' ], $request[ 'controller' ], $request[ 'action' ] );
 		try {
 			$this->output = $controller->$action( $request );
 		} catch ( Exception $e ) {
@@ -202,7 +202,7 @@ 
 		$script_url = plugins_url( TABULATE_SLUG ) . '/assets/scripts.js';
 		$deps = array( 'jquery-ui-autocomplete', 'tabulate-leaflet', 'tabulate-maskedinput', 'tabulate-timepicker' );
 		if ( Util::is_plugin_active( 'rest-api/plugin.php' ) ) {
-			$deps[] = 'wp-api';
+			$deps[ ] = 'wp-api';
 		}
 		wp_enqueue_script( 'tabulate-scripts', $script_url, $deps, TABULATE_VERSION, true );
 

src/Controllers/SchemaController.php

Spacing +25 added lines, -25 removed lines

@@ -33,8 +33,8 @@ 
 		$db = new Database( $this->wpdb );
 		$template->action = 'structure';
 		$template->tables = $db->get_tables();
-		if ( isset( $args['table'] ) ) {
-			$template->table = $db->get_table( $args['table'] );
+		if ( isset( $args[ 'table' ] ) ) {
+			$template->table = $db->get_table( $args[ 'table' ] );
 			$template->record = $template->table->get_default_record();
 		}
 		$template->xtypes = Column::get_xtypes();
@@ -49,7 +49,7 @@ 
 	public function newtable( $args ) {
 		// Create table.
 		$db = new Database( $this->wpdb );
-		$table = $db->create_table( $args['new_table_name'] );
+		$table = $db->create_table( $args[ 'new_table_name' ] );
 
 		// Redirect user with message.
 		$template = new Template( 'table/schema.html' );
@@ -65,49 +65,49 @@ 
 	 * @param string[] $args The request arguments.
 	 */
 	public function save( $args ) {
-		if ( ! isset( $args['table'] ) || ! current_user_can( 'promote_users' ) ) {
+		if ( ! isset( $args[ 'table' ] ) || ! current_user_can( 'promote_users' ) ) {
 			$url = admin_url( 'admin.php?page=tabulate' );
 			wp_safe_redirect( $url );
 			exit;
 		}
 		$db = new Database( $this->wpdb );
-		$table = $db->get_table( $args['table'] );
-		if ( isset( $args['delete'] ) ) {
+		$table = $db->get_table( $args[ 'table' ] );
+		if ( isset( $args[ 'delete' ] ) ) {
 			wp_safe_redirect( $table->get_url( 'delete', null, 'schema' ) );
 			exit;
 		}
 
 		// Rename.
-		$new_name = $args['table'];
-		if ( $table instanceof Table && ! empty( $args['new_name'] ) ) {
-			$table->rename( $args['new_name'] );
+		$new_name = $args[ 'table' ];
+		if ( $table instanceof Table && ! empty( $args[ 'new_name' ] ) ) {
+			$table->rename( $args[ 'new_name' ] );
 			$new_name = $table->get_name();
 		}
 
 		// Set comment.
-		if ( isset( $args['new_comment'] ) ) {
-			$table->set_comment( $args['new_comment'] );
+		if ( isset( $args[ 'new_comment' ] ) ) {
+			$table->set_comment( $args[ 'new_comment' ] );
 		}
 
 		// Update columns.
 		$previous_column_name = '';
-		foreach ( $args['columns'] as $col_info ) {
+		foreach ( $args[ 'columns' ] as $col_info ) {
 			// Validate inputs.
-			$old_col_name = isset( $col_info['old_name'] ) ? $col_info['old_name'] : null;
-			$new_col_name = isset( $col_info['new_name'] ) ? $col_info['new_name'] : null;
-			$xtype = isset( $col_info['xtype'] ) ? $col_info['xtype'] : null;
-			$size = isset( $col_info['size'] ) ? $col_info['size'] : null;
-			$nullable = isset( $col_info['nullable'] );
-			$default = isset( $col_info['default'] ) ? $col_info['default'] : null;
-			$auto_increment = isset( $args['auto_increment'] ) && $args['auto_increment'] === $old_col_name;
-			$unique = isset( $col_info['unique'] );
-			$comment = isset( $col_info['comment'] ) ? $col_info['comment'] : null;
-			$target_table = isset( $col_info['target_table'] ) ? $db->get_table( $col_info['target_table'] ) : null;
+			$old_col_name = isset( $col_info[ 'old_name' ] ) ? $col_info[ 'old_name' ] : null;
+			$new_col_name = isset( $col_info[ 'new_name' ] ) ? $col_info[ 'new_name' ] : null;
+			$xtype = isset( $col_info[ 'xtype' ] ) ? $col_info[ 'xtype' ] : null;
+			$size = isset( $col_info[ 'size' ] ) ? $col_info[ 'size' ] : null;
+			$nullable = isset( $col_info[ 'nullable' ] );
+			$default = isset( $col_info[ 'default' ] ) ? $col_info[ 'default' ] : null;
+			$auto_increment = isset( $args[ 'auto_increment' ] ) && $args[ 'auto_increment' ] === $old_col_name;
+			$unique = isset( $col_info[ 'unique' ] );
+			$comment = isset( $col_info[ 'comment' ] ) ? $col_info[ 'comment' ] : null;
+			$target_table = isset( $col_info[ 'target_table' ] ) ? $db->get_table( $col_info[ 'target_table' ] ) : null;
 
 			// Change existing or insert new column.
 			$altered = false;
 			if ( $old_col_name ) {
-				$col = $table->get_column( $col_info['old_name'] );
+				$col = $table->get_column( $col_info[ 'old_name' ] );
 				if ( $col instanceof Column ) {
 					$col->alter( $new_col_name, $xtype, $size, $nullable, $default, $auto_increment, $unique, $comment, $target_table, $previous_column_name );
 					$altered = true;
@@ -137,10 +137,10 @@ 
 	public function delete( $args ) {
 		$template = new Template( 'table/delete.html' );
 		$db = new Database( $this->wpdb );
-		$table = $db->get_table( $args['table'] );
+		$table = $db->get_table( $args[ 'table' ] );
 
 		// Ask for confirmation.
-		if ( ! isset( $args['confirm_deletion'] ) ) {
+		if ( ! isset( $args[ 'confirm_deletion' ] ) ) {
 			$template->table = $table;
 			return $template->render();
 		}