ConfigFactory::createService() - Code Metrics - t4web/Cron - Measure and Improve Code Quality continuously with Scrutinizer

ConfigFactory::createService() A
last analyzed 2016-10-24 07:16 UTC

↳ Parent: ConfigFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	1

<?php

namespace T4web\Cron;

use Zend\ServiceManager\ServiceLocatorInterface;
use Zend\ServiceManager\FactoryInterface;
use T4web\Cron\Log\FileSystem;

class ConfigFactory implements FactoryInterface
{
    /**
     * Create service
     *
     * @param ServiceLocatorInterface $serviceLocator
     * @return Config
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        $appConfig = $serviceLocator->get('Config');
        $config = [];
        if (isset($appConfig['cron'])) {
            $config = $appConfig['cron'];
        }

        return new Config(
            $config,
            $serviceLocator->get(FileSystem::class)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }
}


1			<?php
2
3			namespace T4web\Cron;
4
5			use Zend\ServiceManager\ServiceLocatorInterface;
6			use Zend\ServiceManager\FactoryInterface;
7			use T4web\Cron\Log\FileSystem;
8
9			class ConfigFactory implements FactoryInterface
10			{
11			/**
12			* Create service
13			*
14			* @param ServiceLocatorInterface $serviceLocator
15			* @return Config
16			*/
17			public function createService(ServiceLocatorInterface $serviceLocator)
18			{
19			$appConfig = $serviceLocator->get('Config');
20			$config = [];
21			if (isset($appConfig['cron'])) {
22			$config = $appConfig['cron'];
23			}
24
25			return new Config(
26			$config,
27			$serviceLocator->get(FileSystem::class)
			0 ignored issues – show Documentation introduced 2016-02-27 10:52 UTC by Report Bug Copy Issue Report `$serviceLocator->get(\T4...\Log\FileSystem::class)` is of type `object\|array`, but the function expects a `null\|object<T4web\Cron\Log\FileSystem>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28			);
29			}
30			}
31

t4web / Cron

ConfigFactory::createService() A last analyzed 2016-10-24 07:16 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ConfigFactory::createService() A
last analyzed 2016-10-24 07:16 UTC