ConfigFactory   A
last analyzed

Complexity

Total Complexity 2

Size/Duplication

Total Lines 22
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 2

Importance

Changes 0
Metric Value
wmc 2
lcom 0
cbo 2
dl 0
loc 22
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A createService() 0 13 2
1
<?php
2
3
namespace T4web\Cron;
4
5
use Zend\ServiceManager\ServiceLocatorInterface;
6
use Zend\ServiceManager\FactoryInterface;
7
use T4web\Cron\Log\FileSystem;
8
9
class ConfigFactory implements FactoryInterface
10
{
11
    /**
12
     * Create service
13
     *
14
     * @param ServiceLocatorInterface $serviceLocator
15
     * @return Config
16
     */
17
    public function createService(ServiceLocatorInterface $serviceLocator)
18
    {
19
        $appConfig = $serviceLocator->get('Config');
20
        $config = [];
21
        if (isset($appConfig['cron'])) {
22
            $config = $appConfig['cron'];
23
        }
24
25
        return new Config(
26
            $config,
27
            $serviceLocator->get(FileSystem::class)
0 ignored issues
show
Documentation introduced by
$serviceLocator->get(\T4...\Log\FileSystem::class) is of type object|array, but the function expects a null|object<T4web\Cron\Log\FileSystem>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
28
        );
29
    }
30
}
31