View GitHub Repository controller-using-templating-http-foundation-http-kernel

Schedule Inspection
Subscribe
Test Failed
Push — master ( 29dc6c...cececf )
by Jean-Bernard
02:13
created
Status
Category
Toggle Patches
tests/Component/EngineAsArgumentInKernelControllerTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -78,7 +78,7 @@  discard block
 
 block discarded – undo
78 78 
             ->will($this->returnValue([
79 79 
                 '_route' => 'foo',
80 80 
                 'name' => 'Fabien',
81 
-                '_controller' => function ($name) {
81 
+                '_controller' => function($name) {
82 82 
                     return new Response('Hello '.$name);
83 83 
                 },
84 84 
             ]))
 
@@ -172,7 +172,7 @@  discard block
 
 block discarded – undo
172 172 
     { // from Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait
173 173 
         $routes->add(
174 174 
             '/',
175 
-            function () {
175 
+            function() {
176 176 
                 return new Response('Hello');
177 177 
             },
178 178 
             'index'
Please login to merge, or discard this patch.
tests/Component/AppKernel.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch 
@@ -49,18 +49,18 @@  discard block
 
 block discarded – undo
49 49 
         // https://symfony.com/doc/current/service_container.html
50 50 
         // HttpKernel has to be added!
51 51
52 
-        $c->register('event_dispatcher',                                ContainerAwareEventDispatcher::class) // services.xml TODO: Obsolete use EventDispatcher instead, but may cause other problems
52 
+        $c->register('event_dispatcher', ContainerAwareEventDispatcher::class) // services.xml TODO: Obsolete use EventDispatcher instead, but may cause other problems
53 53 
             ->addArgument(new Reference('service_container'))
54 54 
         ;
55 55
56 
-        $c->register('http_kernel',                                HttpKernel::class) // services.xml
56 
+        $c->register('http_kernel', HttpKernel::class) // services.xml
57 57 
             ->addArgument(new Reference('event_dispatcher'))
58 58 
             ->addArgument(new Reference('controller_resolver'))
59 59 
             ->addArgument(new Reference('request_stack'))
60 60 
             ->addArgument(new Reference('argument_resolver'))
61 61 
         ;
62 62
63 
-        $c->register('request_stack',                                RequestStack::class); // services.xml
63 
+        $c->register('request_stack', RequestStack::class); // services.xml
64 64
65 65 
 /*
66 66 
         $c->register('service_container')
 
@@ -77,20 +77,20 @@  discard block
 
 block discarded – undo
77 77 
         ;
78 78 
         $c->set('kernel', $this);
79 79
80 
-        $c->register('uri_signer',                                UriSigner::class) // services.xml
80 
+        $c->register('uri_signer', UriSigner::class) // services.xml
81 81 
             ->addArgument('12345') // app config
82 82 
         ;
83 83
84 
-        $c->register('config_cache_factory',                                ResourceCheckerConfigCacheFactory::class) // services.xml
84 
+        $c->register('config_cache_factory', ResourceCheckerConfigCacheFactory::class) // services.xml
85 85 
             ->addArgument([])
86 86 
         ;
87 
-        $c->register('controller_name_converter',                                ControllerNameParser::class) // web.xml
87 
+        $c->register('controller_name_converter', ControllerNameParser::class) // web.xml
88 88 
             ->setPublic(false)
89 89 
             ->addTag('monolog.logger', ['channel' => 'request'])
90 90 
             ->addArgument(new Reference('kernel'))
91 91 
         ;
92 92
93 
-        $c->register('controller_resolver',                                ControllerResolver::class) // web.xml
93 
+        $c->register('controller_resolver', ControllerResolver::class) // web.xml
94 94 
 //            ->setPublic(false)
95 95 
             ->addTag('monolog.logger', ['channel' => 'request'])
96 96 
             ->addArgument(new Reference('service_container'))
 
@@ -98,17 +98,17 @@  discard block
 
 block discarded – undo
98 98 
             ->addArgument(new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE))
99 99 
         ;
100 100
101 
-        $c->register('argument_metadata_factory',                                ArgumentMetadataFactory::class) // web.xml
101 
+        $c->register('argument_metadata_factory', ArgumentMetadataFactory::class) // web.xml
102 102 
 //            ->setPublic(false)
103 103 
         ;
104 104
105 
-        $c->register('argument_resolver',                                ArgumentResolver::class) // web.xml
105 
+        $c->register('argument_resolver', ArgumentResolver::class) // web.xml
106 106 
 //            ->setPublic(false)
107 107 
             ->addArgument(new Reference('argument_metadata_factory'))
108 108 
             ->addArgument([])
109 109 
         ;
110 110
111 
-        $c->setParameter('router.resource',                       'kernel:loadRoutes'); // resource_type: service
111 
+        $c->setParameter('router.resource', 'kernel:loadRoutes'); // resource_type: service
112 112 
 //         $c->setParameter('router.resource',                       new Expression('service("kernel").loadRoutes'));
113 113 
 //        $c->setParameter('router.resource',                       MicroKernel::class . ':loadRoutes');
114 114 
 //         $c->setParameter('router.resource',                       new Reference('kernel') . ':loadRoutes');
 
@@ -119,16 +119,16 @@  discard block
 
 block discarded – undo
119 119 
 //        $c->setParameter('router.resource',                       ['kernel', 'loadRoutes']);
120 120 
 //        $c->setParameter('router.resource',                       [MicroKernel::class, 'loadRoutes']);
121 121
122 
-        $c->setParameter('router.cache_class_prefix',             $c->getParameter('kernel.container_class'));
122 
+        $c->setParameter('router.cache_class_prefix', $c->getParameter('kernel.container_class'));
123 123 
         // symfony/framework-bundle/DependencyInjection/FrameworkExtension.php
124 
-        $c->setParameter('router.options.generator_class',        UrlGenerator::class); // routing.xml
125 
-        $c->setParameter('router.options.generator_base_class',   UrlGenerator::class); // routing.xml
124 
+        $c->setParameter('router.options.generator_class', UrlGenerator::class); // routing.xml
125 
+        $c->setParameter('router.options.generator_base_class', UrlGenerator::class); // routing.xml
126 126 
         $c->setParameter('router.options.generator_dumper_class', PhpGeneratorDumper::class); // routing.xml
127 
-        $c->setParameter('router.options.generator.cache_class',  '%router.cache_class_prefix%UrlGenerator'); // routing.xml
128 
-        $c->setParameter('router.options.matcher_class',          RedirectableUrlMatcher::class); // routing.xml
129 
-        $c->setParameter('router.options.matcher_base_class',     RedirectableUrlMatcher::class); // routing.xml
130 
-        $c->setParameter('router.options.matcher_dumper_class',   PhpMatcherDumper::class); // routing.xml
131 
-        $c->setParameter('router.options.matcher.cache_class',    '%router.cache_class_prefix%UrlMatcher'); // routing.xml
127 
+        $c->setParameter('router.options.generator.cache_class', '%router.cache_class_prefix%UrlGenerator'); // routing.xml
128 
+        $c->setParameter('router.options.matcher_class', RedirectableUrlMatcher::class); // routing.xml
129 
+        $c->setParameter('router.options.matcher_base_class', RedirectableUrlMatcher::class); // routing.xml
130 
+        $c->setParameter('router.options.matcher_dumper_class', PhpMatcherDumper::class); // routing.xml
131 
+        $c->setParameter('router.options.matcher.cache_class', '%router.cache_class_prefix%UrlMatcher'); // routing.xml
132 132
133 133 
         $c->setParameter('router.request_context.host', 'localhost'); // routing.xml
134 134 
         $c->setParameter('router.request_context.scheme', 'http'); // routing.xml
 
@@ -142,17 +142,17 @@  discard block
 
 block discarded – undo
142 142 
             ->setPublic(false)
143 143 
         ;
144 144
145 
-        $c->register('routing.loader.service',                            ServiceRouterLoader::class) // routing.xml
145 
+        $c->register('routing.loader.service', ServiceRouterLoader::class) // routing.xml
146 146 
 //            ->setPublic(false)
147 147 
             ->addTag('routing.loader')
148 148 
             ->addArgument(new Reference('service_container'))
149 149 
         ;
150 
-        $c->register('routing.loader',                            DelegatingLoader::class) // routing.xml
150 
+        $c->register('routing.loader', DelegatingLoader::class) // routing.xml
151 151 
             ->addArgument(new Reference('controller_name_converter'))
152 152 
             ->addArgument(new Reference('routing.resolver'))
153 153 
         ;
154 154 
 //...
155 
-        $c->register('router.default',                            Router::class) // routing.xml
155 
+        $c->register('router.default', Router::class) // routing.xml
156 156 
 //            ->setPublic(false)
157 157 
             ->addTag('monolog.logger', ['channel' => 'router'])
158 158 
             ->addArgument(new Reference('service_container'))
 
@@ -176,7 +176,7 @@  discard block
 
 block discarded – undo
176 176 
         ;
177 177 
         $c->setAlias('router', 'router.default');
178 178
179 
-        $c->register('router_listener',                            RouterListener::class) // routing.xml
179 
+        $c->register('router_listener', RouterListener::class) // routing.xml
180 180 
             ->addTag('kernel.event_subscriber')
181 181 
             ->addTag('monolog.logger', ['channel' => 'request'])
182 182 
             ->addArgument(new Reference('router'))
Please login to merge, or discard this patch.