symbiote / silverstripe-advancedworkflow

src/DataObjects/WorkflowAction.php

Doc Comments +6 added lines, -6 removed lines

@@ -75,7 +75,7 @@ 
      * Admin level users can always edit.
      *
      * @param  DataObject $target
-     * @return bool
+     * @return boolean|null
      */
     public function canEditTarget(DataObject $target)
     {
@@ -91,7 +91,7 @@ 
      * Does this action restrict viewing of the document?
      *
      * @param  DataObject $target
-     * @return bool
+     * @return boolean|null
      */
     public function canViewTarget(DataObject $target)
     {
@@ -102,7 +102,7 @@ 
      * Does this action restrict the publishing of a document?
      *
      * @param  DataObject $target
-     * @return bool
+     * @return boolean|null
      */
     public function canPublishTarget(DataObject $target)
     {
@@ -114,7 +114,7 @@ 
      *
      * @param Member $member
      * @param array $context
-     * @return bool
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = array())
     {
@@ -123,7 +123,7 @@ 
 
     /**
      * @param  Member $member
-     * @return bool
+     * @return boolean|string
      */
     public function canEdit($member = null)
     {
@@ -132,7 +132,7 @@ 
 
     /**
      * @param  Member $member
-     * @return bool
+     * @return boolean|string
      */
     public function canDelete($member = null)
     {

src/DataObjects/WorkflowDefinition.php

Doc Comments +6 added lines, -6 removed lines

@@ -479,7 +479,7 @@ 
      *
      * @param $member
      * @param $target
-     * @return Boolean
+     * @return boolean|string
      */
     public function canWorkflowPublish($member, $target)
     {
@@ -494,7 +494,7 @@ 
      *
      * @param Member $member
      * @param array $context
-     * @return bool
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = [])
     {
@@ -510,7 +510,7 @@ 
     /**
      *
      * @param Member $member
-     * @return boolean
+     * @return boolean|null
      */
     public function canView($member = null)
     {
@@ -520,7 +520,7 @@ 
     /**
      *
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canEdit($member = null)
     {
@@ -530,7 +530,7 @@ 
     /**
      *
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      * @see {@link $this->onBeforeDelete()}
      */
     public function canDelete($member = null)
@@ -558,7 +558,7 @@ 
      * Checks whether the passed user is able to view this ModelAdmin
      *
      * @param Member $member
-     * @return bool
+     * @return boolean|null
      */
     protected function userHasAccess($member)
     {

src/Extensions/AdvancedWorkflowExtension.php

Doc Comments +3 added lines

@@ -158,6 +158,9 @@
         return $this->returnResponse($form);
     }
 
+    /**
+     * @param Form $form
+     */
     protected function returnResponse($form)
     {
         if ($this->owner instanceof GridFieldDetailForm_ItemRequest) {

Unused Use Statements -2 removed lines

@@ -5,11 +5,9 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Core\Extension;
-use SilverStripe\Core\Manifest\ModuleLoader;
 use SilverStripe\Forms\Form;
 use SilverStripe\Forms\GridField\GridFieldDetailForm_ItemRequest;
 use SilverStripe\ORM\DataObject;
-use SilverStripe\Security\Permission;
 use SilverStripe\View\Requirements;
 use Symbiote\AdvancedWorkflow\Extensions\WorkflowApplicable;
 use Symbiote\AdvancedWorkflow\Services\WorkflowService;

src/Extensions/WorkflowApplicable.php

Doc Comments +2 added lines, -1 removed lines

@@ -353,6 +353,7 @@ 
     /**
      * Gets the history of a workflow instance
      *
+     * @param integer $limit
      * @return DataList
      */
     public function getWorkflowHistory($limit = null)
@@ -414,7 +415,7 @@ 
     /**
      * Can only edit content that's NOT in another person's content changeset
      *
-     * @return bool
+     * @return boolean|null
      */
     public function canEdit($member)
     {