WorkflowFieldActionController::handleAdd() - Code Metrics - symbiote/silverstripe-advancedworkflow - Measure and Improve Code Quality continuously with Scrutinizer

WorkflowFieldActionController::handleAdd() A
last analyzed 2019-12-18 23:33 UTC

↳ Parent: WorkflowFieldActionController

Complexity

Conditions	5
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	9.2408
c	0
b	0
f	0
cc	5
nc	4
nop	0

<?php

namespace Symbiote\AdvancedWorkflow\FormFields;

use ReflectionClass;
use SilverStripe\Control\Controller;
use SilverStripe\Control\RequestHandler;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowAction;

/**
 * Handles requests for creating or editing actions.
 *
 * @package silverstripe-advancedworkflow
 */
class WorkflowFieldActionController extends RequestHandler
{
    private static $url_handlers = array(

        'new/$Class' => 'handleAdd',
        'item/$ID'   => 'handleItem'
    );

    private static $allowed_actions = array(

        'handleAdd',
        'handleItem'
    );

    protected $parent;
    protected $name;

    public function __construct($parent, $name)
    {
        $this->parent = $parent;
        $this->name   = $name;

        parent::__construct();
    }

    public function handleAdd()
    {
        $class = $this->unsanitiseClassName($this->request->param('Class'));

        if (!class_exists($class) || !is_subclass_of($class, WorkflowAction::class)) {

            $this->httpError(400);
        }

        $reflector = new ReflectionClass($class);

        if ($reflector->isAbstract() || !singleton($class)->canCreate()) {
            $this->httpError(400);
        }

        $record = new $class();
        $record->WorkflowDefID = $this->parent->Definition()->ID;

        return new WorkflowFieldItemController(
            $this,
            Controller::join_links('new', $this->sanitiseClassName($class)),
            $record
        );
    }

    public function handleItem()

    {
        $id     = $this->request->param('ID');
        $defn   = $this->parent->Definition();
        $action = $defn->Actions()->byID($id);

        if (!$action) {
            $this->httpError(404);
        }

        if (!$action->canEdit()) {
            $this->httpError(403);
        }

        return new WorkflowFieldItemController($this, "item/$id", $action);
    }

    public function RootField()
    {
        return $this->parent;
    }

    public function Link($action = null)
    {
        return Controller::join_links($this->parent->Link(), $this->name, $action);
    }

    /**
     * Sanitise a model class' name for inclusion in a link
     *
     * @param string $class
     * @return string
     */
    protected function sanitiseClassName($class)
    {
        return str_replace('\\', '-', $class);
    }

    /**
     * Unsanitise a model class' name from a URL param
     *
     * @param string $class
     * @return string
     */
    protected function unsanitiseClassName($class)
    {
        return str_replace('-', '\\', $class);
    }
}


1		<?php
2
3		namespace Symbiote\AdvancedWorkflow\FormFields;
4
5		use ReflectionClass;
6		use SilverStripe\Control\Controller;
7		use SilverStripe\Control\RequestHandler;
8		use Symbiote\AdvancedWorkflow\DataObjects\WorkflowAction;
9
10		/**
11		* Handles requests for creating or editing actions.
12		*
13		* @package silverstripe-advancedworkflow
14		*/
15		class WorkflowFieldActionController extends RequestHandler
16		{
17		private static $url_handlers = array(
		0 ignored issues – show Comprehensibility introduced 2017-10-01 23:10 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
18		'new/$Class' => 'handleAdd',
19		'item/$ID' => 'handleItem'
20		);
21
22		private static $allowed_actions = array(
		0 ignored issues – show Comprehensibility introduced 2017-10-01 23:10 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
23		'handleAdd',
24		'handleItem'
25		);
26
27		protected $parent;
28		protected $name;
29
30		public function __construct($parent, $name)
31		{
32		$this->parent = $parent;
33		$this->name = $name;
34
35		parent::__construct();
36		}
37
38		public function handleAdd()
39		{
40		$class = $this->unsanitiseClassName($this->request->param('Class'));
41
42		if (!class_exists($class) \|\| !is_subclass_of($class, WorkflowAction::class)) {
		0 ignored issues – show Bug introduced 2017-10-01 23:10 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` might return inconsistent results on some PHP versions if `\Symbiote\AdvancedWorkfl...s\WorkflowAction::class` can be an interface. If so, you could instead use `ReflectionClass::implementsInterface`. Loading history...
43		$this->httpError(400);
44		}
45
46		$reflector = new ReflectionClass($class);
47
48		if ($reflector->isAbstract() \|\| !singleton($class)->canCreate()) {
49		$this->httpError(400);
50		}
51
52		$record = new $class();
53		$record->WorkflowDefID = $this->parent->Definition()->ID;
54
55		return new WorkflowFieldItemController(
56		$this,
57		Controller::join_links('new', $this->sanitiseClassName($class)),
58		$record
59		);
60		}
61
62	View Code Duplication	public function handleItem()
		0 ignored issues – show Duplication introduced 2017-10-01 23:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		{
64		$id = $this->request->param('ID');
65		$defn = $this->parent->Definition();
66		$action = $defn->Actions()->byID($id);
67
68		if (!$action) {
69		$this->httpError(404);
70		}
71
72		if (!$action->canEdit()) {
73		$this->httpError(403);
74		}
75
76		return new WorkflowFieldItemController($this, "item/$id", $action);
77		}
78
79		public function RootField()
80		{
81		return $this->parent;
82		}
83
84		public function Link($action = null)
85		{
86		return Controller::join_links($this->parent->Link(), $this->name, $action);
87		}
88
89		/**
90		* Sanitise a model class' name for inclusion in a link
91		*
92		* @param string $class
93		* @return string
94		*/
95		protected function sanitiseClassName($class)
96		{
97		return str_replace('\\', '-', $class);
98		}
99
100		/**
101		* Unsanitise a model class' name from a URL param
102		*
103		* @param string $class
104		* @return string
105		*/
106		protected function unsanitiseClassName($class)
107		{
108		return str_replace('-', '\\', $class);
109		}
110		}
111

symbiote / silverstripe-advancedworkflow

GitHub Access Token became invalid

WorkflowFieldActionController::handleAdd() A last analyzed 2019-12-18 23:33 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

WorkflowFieldActionController::handleAdd() A
last analyzed 2019-12-18 23:33 UTC