Symbiote\AdvancedWorkflow\FormFields\WorkflowFieldActionController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	96
Duplicated Lines	16.67 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	handleAdd()	0	23	5
A	handleItem()	16	16	3
A	RootField()	0	4	1
A	Link()	0	4	1
A	sanitiseClassName()	0	4	1
A	unsanitiseClassName()	0	4	1

<?php

namespace Symbiote\AdvancedWorkflow\FormFields;

use ReflectionClass;
use SilverStripe\Control\Controller;
use SilverStripe\Control\RequestHandler;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowAction;

/**
 * Handles requests for creating or editing actions.
 *
 * @package silverstripe-advancedworkflow
 */
class WorkflowFieldActionController extends RequestHandler
{
    private static $url_handlers = array(

Consider using a different property name as you override a private property of the parent class.

        'new/$Class' => 'handleAdd',
        'item/$ID'   => 'handleItem'
    );

    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

        'handleAdd',
        'handleItem'
    );

    protected $parent;
    protected $name;

    public function __construct($parent, $name)
    {
        $this->parent = $parent;
        $this->name   = $name;

        parent::__construct();
    }

    public function handleAdd()
    {
        $class = $this->unsanitiseClassName($this->request->param('Class'));

        if (!class_exists($class) || !is_subclass_of($class, WorkflowAction::class)) {

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \Symbiote\AdvancedWorkflow\DataObjects\WorkflowAction::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            $this->httpError(400);
        }

        $reflector = new ReflectionClass($class);

        if ($reflector->isAbstract() || !singleton($class)->canCreate()) {
            $this->httpError(400);
        }

        $record = new $class();
        $record->WorkflowDefID = $this->parent->Definition()->ID;

        return new WorkflowFieldItemController(
            $this,
            Controller::join_links('new', $this->sanitiseClassName($class)),
            $record
        );
    }

    public function handleItem()

This method seems to be duplicated in your project.

    {
        $id     = $this->request->param('ID');
        $defn   = $this->parent->Definition();
        $action = $defn->Actions()->byID($id);

        if (!$action) {
            $this->httpError(404);
        }

        if (!$action->canEdit()) {
            $this->httpError(403);
        }

        return new WorkflowFieldItemController($this, "item/$id", $action);
    }

    public function RootField()
    {
        return $this->parent;
    }

    public function Link($action = null)
    {
        return Controller::join_links($this->parent->Link(), $this->name, $action);
    }

    /**
     * Sanitise a model class' name for inclusion in a link
     *
     * @param string $class
     * @return string
     */
    protected function sanitiseClassName($class)
    {
        return str_replace('\\', '-', $class);
    }

    /**
     * Unsanitise a model class' name from a URL param
     *
     * @param string $class
     * @return string
     */
    protected function unsanitiseClassName($class)
    {
        return str_replace('-', '\\', $class);
    }
}