supernova-ws / SuperNova

includes/classes/Fleet.php

Spacing +144 added lines, -145 removed lines

@@ -306,9 +306,9 @@ 
   public function renderAvailableShips(&$template_result, $playerRow, $planetRow) {
     $record_index = 0;
     $ship_list = array();
-    foreach(sn_get_groups('fleet') as $n => $unit_id) {
+    foreach (sn_get_groups('fleet') as $n => $unit_id) {
       $unit_level = mrc_get_level($playerRow, $planetRow, $unit_id, false, true);
-      if($unit_level <= 0) {
+      if ($unit_level <= 0) {
         continue;
       }
       $ship_data = get_ship_data($unit_id, $playerRow);
@@ -329,7 +329,7 @@ 
 
     sortUnitRenderedList($ship_list, classSupernova::$user_options[PLAYER_OPTION_FLEET_SHIP_SORT], classSupernova::$user_options[PLAYER_OPTION_FLEET_SHIP_SORT_INVERSE]);
 
-    foreach($ship_list as $ship_data) {
+    foreach ($ship_list as $ship_data) {
       $template_result['.']['ships'][] = $ship_data;
     }
   }
@@ -348,7 +348,7 @@ 
   public function dbInsert() {
     // WARNING! MISSION TIMES MUST BE SET WITH set_times() method!
     // TODO - more checks!
-    if(empty($this->_time_launch)) {
+    if (empty($this->_time_launch)) {
       die('Fleet time not set!');
     }
 
@@ -557,7 +557,7 @@ 
     // Записываем изменения в БД
     $this->dbSave();
 
-    if($this->_group_id) {
+    if ($this->_group_id) {
       // TODO: Make here to delete only one AKS - by adding aks_fleet_count to AKS table
       db_fleet_aks_purge();
     }
@@ -624,18 +624,18 @@ 
    */
   // TODO - separate shipList and unitList
   public function unitsSetFromArray($unit_array) {
-    if(empty($unit_array) || !is_array($unit_array)) {
+    if (empty($unit_array) || !is_array($unit_array)) {
       return;
     }
-    foreach($unit_array as $unit_id => $unit_count) {
+    foreach ($unit_array as $unit_id => $unit_count) {
       $unit_count = floatval($unit_count);
-      if(!$unit_count) {
+      if (!$unit_count) {
         continue;
       }
 
-      if($this->isShip($unit_id)) {
+      if ($this->isShip($unit_id)) {
         $this->unitList->unitSetCount($unit_id, $unit_count);
-      } elseif($this->isResource($unit_id)) {
+      } elseif ($this->isResource($unit_id)) {
         $this->resource_list[$unit_id] = $unit_count;
       } else {
         throw new Exception('Trying to pass to fleet non-resource and non-ship ' . var_export($unit_array, true), ERR_ERROR);
@@ -664,7 +664,7 @@ 
   public function parse_missile_db_row($missile_db_row) {
 //    $this->_reset();
 
-    if(empty($missile_db_row) || !is_array($missile_db_row)) {
+    if (empty($missile_db_row) || !is_array($missile_db_row)) {
       return;
     }
 
@@ -827,7 +827,7 @@ 
   public function shipsGetCapacityRecyclers(array $recycler_info) {
     $recyclers_incoming_capacity = 0;
     $fleet_data = $this->shipsGetArray();
-    foreach($recycler_info as $recycler_id => $recycler_data) {
+    foreach ($recycler_info as $recycler_id => $recycler_data) {
       $recyclers_incoming_capacity += $fleet_data[$recycler_id] * $recycler_data['capacity'];
     }
 
@@ -847,7 +847,7 @@ 
     sn_db_transaction_check(true);
 
     // Если флот уже обработан - не существует или возращается - тогда ничего не делаем
-    if($this->isEmpty()) {
+    if ($this->isEmpty()) {
       return $result;
     }
 
@@ -869,18 +869,18 @@ 
     // TODO - Проверка, что планета всё еще существует на указанных координатах, а не телепортировалась, не удалена хозяином, не уничтожена врагом
     // Флот, который возвращается на захваченную планету, пропадает
     // Ship landing is possible only to fleet owner's planet
-    if($this->getPlayerOwnerId() == $planet_arrival['id_owner']) {
+    if ($this->getPlayerOwnerId() == $planet_arrival['id_owner']) {
       $db_changeset = array();
 
       $fleet_array = $this->shipsGetArray();
-      foreach($fleet_array as $ship_id => $ship_count) {
-        if($ship_count) {
+      foreach ($fleet_array as $ship_id => $ship_count) {
+        if ($ship_count) {
           $db_changeset['unit'][] = sn_db_unit_changeset_prepare($ship_id, $ship_count, $user, $planet_arrival['id']);
         }
       }
 
       // Adjusting ship amount on planet
-      if(!empty($db_changeset)) {
+      if (!empty($db_changeset)) {
         db_changeset_apply($db_changeset);
       }
 
@@ -928,7 +928,7 @@ 
    * @param array $resource_list
    */
   public function resourcesSet($resource_list) {
-    if(!empty($this->propertiesAdjusted['resource_list'])) {
+    if (!empty($this->propertiesAdjusted['resource_list'])) {
       throw new PropertyAccessException('Property "resource_list" already was adjusted so no SET is possible until dbSave in ' . get_called_class() . '::unitSetResourceList', ERR_ERROR);
     }
     $this->resourcesAdjust($resource_list, true);
@@ -942,13 +942,13 @@ 
   public function resourcesAdjust($resource_delta_list, $replace_value = false) {
     !is_array($resource_delta_list) ? $resource_delta_list = array() : false;
 
-    foreach($resource_delta_list as $resource_id => $unit_delta) {
-      if(!UnitResourceLoot::is_in_group($resource_id) || !($unit_delta = floor($unit_delta))) {
+    foreach ($resource_delta_list as $resource_id => $unit_delta) {
+      if (!UnitResourceLoot::is_in_group($resource_id) || !($unit_delta = floor($unit_delta))) {
         // Not a resource or no resources - continuing
         continue;
       }
 
-      if($replace_value) {
+      if ($replace_value) {
         $this->resource_list[$resource_id] = $unit_delta;
       } else {
         $this->resource_list[$resource_id] += $unit_delta;
@@ -958,7 +958,7 @@ 
       }
 
       // Check for negative unit value
-      if($this->resource_list[$resource_id] < 0) {
+      if ($this->resource_list[$resource_id] < 0) {
         // TODO
         throw new Exception('Resource ' . $resource_id . ' will become negative in ' . get_called_class() . '::unitAdjustResourceList', ERR_ERROR);
       }
@@ -1010,7 +1010,7 @@ 
     sn_db_transaction_check(true);
 
     // Если флот уже обработан - не существует или возращается - тогда ничего не делаем
-    if(!$this->resourcesGetTotal()) {
+    if (!$this->resourcesGetTotal()) {
       return $result;
     }
 
@@ -1030,7 +1030,7 @@ 
     // TODO - Проверка, что планета всё еще существует на указанных координатах, а не телепортировалась, не удалена хозяином, не уничтожена врагом
 
     // Restoring resources to planet
-    if($this->resourcesGetTotal()) {
+    if ($this->resourcesGetTotal()) {
       $fleet_resources = $this->resourcesGetList();
       db_planet_set_by_id($planet_arrival['id'],
         "`metal` = `metal` + '{$fleet_resources[RES_METAL]}', `crystal` = `crystal` + '{$fleet_resources[RES_CRYSTAL]}', `deuterium` = `deuterium` + '{$fleet_resources[RES_DEUTERIUM]}'");
@@ -1096,12 +1096,12 @@ 
 
   protected function populateTargetPlanet() {
     $targetPlanetCoords = $this->targetVector;
-    if($this->mission_type != MT_NONE) {
+    if ($this->mission_type != MT_NONE) {
       $this->restrictTargetTypeByMission();
 
       // TODO - Нельзя тут просто менять тип планеты или координат!
       // If current planet type is not allowed on mission - switch planet type
-      if(empty($this->allowed_planet_types[$this->targetVector->type])) {
+      if (empty($this->allowed_planet_types[$this->targetVector->type])) {
         $targetPlanetCoords->type = reset($this->allowed_planet_types);
       }
     }
@@ -1110,14 +1110,14 @@ 
   }
 
   protected function restrictTargetTypeByMission() {
-    if($this->_mission_type == MT_MISSILE) {
+    if ($this->_mission_type == MT_MISSILE) {
       $this->allowed_planet_types = array(PT_PLANET => PT_PLANET);
-    } elseif($this->_mission_type == MT_COLONIZE || $this->_mission_type == MT_EXPLORE) {
+    } elseif ($this->_mission_type == MT_COLONIZE || $this->_mission_type == MT_EXPLORE) {
       // TODO - PT_NONE
       $this->allowed_planet_types = array(PT_PLANET => PT_PLANET);
-    } elseif($this->_mission_type == MT_RECYCLE) {
+    } elseif ($this->_mission_type == MT_RECYCLE) {
       $this->allowed_planet_types = array(PT_DEBRIS => PT_DEBRIS);
-    } elseif($this->_mission_type == MT_DESTROY) {
+    } elseif ($this->_mission_type == MT_DESTROY) {
       $this->allowed_planet_types = array(PT_MOON => PT_MOON);
     } else {
       $this->allowed_planet_types = array(PT_PLANET => PT_PLANET, PT_MOON => PT_MOON);
@@ -1149,13 +1149,13 @@ 
 
 
   public function restrictToKnownSpace() {
-    if(!$this->targetVector->isInKnownSpace()) {
+    if (!$this->targetVector->isInKnownSpace()) {
       throw new Exception('FLIGHT_VECTOR_BEYOND_SYSTEM', FLIGHT_VECTOR_BEYOND_SYSTEM);
     }
   }
 
   public function restrictToTypePlanet($errorCode) {
-    if($this->targetVector->type != PT_PLANET) {
+    if ($this->targetVector->type != PT_PLANET) {
       throw new Exception($errorCode, $errorCode);
     }
   }
@@ -1163,56 +1163,56 @@ 
   public function restrictToNoMissiles() {
     $missilesAttack = $this->unitList->unitsCountById(UNIT_DEF_MISSILE_INTERPLANET);
     $missilesDefense = $this->unitList->unitsCountById(UNIT_DEF_MISSILE_INTERCEPTOR);
-    if($missilesAttack > 0 || $missilesDefense > 0) {
+    if ($missilesAttack > 0 || $missilesDefense > 0) {
       throw new Exception('FLIGHT_SHIPS_NO_MISSILES', FLIGHT_SHIPS_NO_MISSILES);
     }
   }
 
   public function restrictToTargetOwn() {
-    if($this->dbTargetRow['id'] != $this->getPlayerOwnerId()) {
+    if ($this->dbTargetRow['id'] != $this->getPlayerOwnerId()) {
       throw new Exception('FLIGHT_VECTOR_ONLY_OWN', FLIGHT_VECTOR_ONLY_OWN);
     }
   }
 
   public function restrictToTargetOther() {
-    if($this->dbTargetRow['id'] == $this->getPlayerOwnerId()) {
+    if ($this->dbTargetRow['id'] == $this->getPlayerOwnerId()) {
       throw new Exception('FLIGHT_VECTOR_ONLY_OTHER', FLIGHT_VECTOR_ONLY_OTHER);
     }
   }
 
   public function restrictToNotOnlySpies() {
-    if($this->unitList->unitsCountById(SHIP_SPY) == $this->shipsGetTotal()) {
+    if ($this->unitList->unitsCountById(SHIP_SPY) == $this->shipsGetTotal()) {
       throw new Exception('FLIGHT_SHIPS_NOT_ONLY_SPIES', FLIGHT_SHIPS_NOT_ONLY_SPIES);
     }
   }
 
   protected function restrictToUniverse() {
-    if(!$this->targetVector->isInUniverse()) {
+    if (!$this->targetVector->isInUniverse()) {
       throw new Exception('FLIGHT_VECTOR_BEYOND_UNIVERSE', FLIGHT_VECTOR_BEYOND_UNIVERSE);
     }
   }
 
   protected function restrictToMovable() {
-    if(!$this->unitList->unitsIsAllMovable($this->dbOwnerRow)) {
+    if (!$this->unitList->unitsIsAllMovable($this->dbOwnerRow)) {
       throw new Exception('FLIGHT_SHIPS_UNMOVABLE', FLIGHT_SHIPS_UNMOVABLE);
     }
   }
 
   protected function restrictToFleetUnits() {
-    if(!$this->unitList->unitsInGroup(sn_get_groups(array('fleet', 'missile')))) {
+    if (!$this->unitList->unitsInGroup(sn_get_groups(array('fleet', 'missile')))) {
       throw new Exception('FLIGHT_SHIPS_UNIT_WRONG', FLIGHT_SHIPS_UNIT_WRONG);
     }
   }
 
   protected function restrictToColonizer() {
     // Colonization fleet should have at least one colonizer
-    if(!$this->unitList->unitsCountById(SHIP_COLONIZER) <= 0) {
+    if (!$this->unitList->unitsCountById(SHIP_COLONIZER) <= 0) {
       throw new Exception('FLIGHT_SHIPS_NO_COLONIZER', FLIGHT_SHIPS_NO_COLONIZER);
     }
   }
 
   protected function restrictToTargetExists() {
-    if(empty($this->dbTargetRow) || empty($this->dbTargetRow['id'])) {
+    if (empty($this->dbTargetRow) || empty($this->dbTargetRow['id'])) {
       throw new Exception('FLIGHT_VECTOR_NO_TARGET', FLIGHT_VECTOR_NO_TARGET);
     }
   }
@@ -1220,7 +1220,7 @@ 
 
   protected function restrictKnownSpaceOrMissionExplore() {
     // Is it exploration - fleet sent beyond of system?
-    if($this->targetVector->isInKnownSpace()) {
+    if ($this->targetVector->isInKnownSpace()) {
       // No exploration beyond this point
       unset($this->allowed_missions[MT_EXPLORE]);
 
@@ -1238,7 +1238,7 @@ 
 
   protected function restrictTargetExistsOrMissionColonize() {
     // Is it colonization - fleet sent to empty place?
-    if(!empty($this->dbTargetRow)) {
+    if (!empty($this->dbTargetRow)) {
       // No colonization beyond this point
       unset($this->allowed_missions[MT_COLONIZE]);
 
@@ -1257,7 +1257,7 @@ 
   }
 
   protected function restrictNotDebrisOrMissionRecycle() {
-    if($this->targetVector->type != PT_DEBRIS) {
+    if ($this->targetVector->type != PT_DEBRIS) {
       // No recycling beyond this point
       unset($this->allowed_missions[MT_RECYCLE]);
 
@@ -1268,11 +1268,11 @@ 
 
     // restrict to recyclers
     $recyclers = 0;
-    foreach(sn_get_groups('flt_recyclers') as $recycler_id) {
+    foreach (sn_get_groups('flt_recyclers') as $recycler_id) {
       $recyclers += $this->unitList->unitsCountById($recycler_id);
     }
 
-    if($recyclers <= 0) {
+    if ($recyclers <= 0) {
       throw new Exception('FLIGHT_SHIPS_NO_RECYCLERS', FLIGHT_SHIPS_NO_RECYCLERS);
     }
 
@@ -1283,14 +1283,14 @@ 
 
   protected function restrictMissionMissile() {
     $missilesAttack = $this->unitList->unitsCountById(UNIT_DEF_MISSILE_INTERPLANET);
-    if($missilesAttack <= 0) {
+    if ($missilesAttack <= 0) {
       // No missile attack beyond this point
       unset($this->allowed_missions[MT_MISSILE]);
 
       return;
     }
 
-    if($missilesAttack != $this->shipsGetTotal()) {
+    if ($missilesAttack != $this->shipsGetTotal()) {
       throw new Exception('FLIGHT_SHIPS_ONLY_MISSILES', FLIGHT_SHIPS_ONLY_MISSILES);
     }
 
@@ -1302,7 +1302,7 @@ 
   }
 
   protected function restrictToNotOnlySpiesOrMissionSpy() {
-    if($this->unitList->unitsCountById(SHIP_SPY) != $this->shipsGetTotal()) {
+    if ($this->unitList->unitsCountById(SHIP_SPY) != $this->shipsGetTotal()) {
 //      throw new Exception('FLIGHT_SHIPS_ONLY_SPIES', FLIGHT_SHIPS_ONLY_SPIES);
       unset($this->allowed_missions[MT_SPY]);
 
@@ -1318,14 +1318,14 @@ 
   protected function restrictMissionDestroy() {
     // If target vector is not Moon - then it can't be Destroy mission
     // If no Reapers (i.e. Death Star) in fleet - then mission Moon Destroy is unaccessible
-    if($this->targetVector->type != PT_MOON || $this->unitList->unitsCountById(SHIP_HUGE_DEATH_STAR) <= 0) {
+    if ($this->targetVector->type != PT_MOON || $this->unitList->unitsCountById(SHIP_HUGE_DEATH_STAR) <= 0) {
       unset($this->allowed_missions[MT_DESTROY]);
     }
   }
 
   protected function restrictMissionACS() {
     // If no ACS group is shown - then it can't be an ACS attack
-    if(empty($this->_group_id)) {
+    if (empty($this->_group_id)) {
       unset($this->allowed_missions[MT_ACS]);
     }
   }
@@ -1333,7 +1333,7 @@ 
   /** @throws Exception */
   protected function restrictFriendOrFoe() {
     // Checking target owner
-    if($this->dbTargetRow['id'] == $this->getPlayerOwnerId()) {
+    if ($this->dbTargetRow['id'] == $this->getPlayerOwnerId()) {
       // Spying can't be done on owner's planet/moon
       unset($this->allowed_missions[MT_SPY]);
       // Attack can't be done on owner's planet/moon
@@ -1389,51 +1389,51 @@ 
   }
 
   protected function restrictToNotSource() {
-    if($this->targetVector->isEqualToPlanet($this->dbSourcePlanetRow)) {
+    if ($this->targetVector->isEqualToPlanet($this->dbSourcePlanetRow)) {
       throw new Exception('FLIGHT_VECTOR_SAME_SOURCE', FLIGHT_VECTOR_SAME_SOURCE);
     }
   }
 
   protected function restrictToNonVacationSender() {
-    if(!empty($this->dbOwnerRow['vacation']) && $this->dbOwnerRow['vacation'] >= SN_TIME_NOW) {
+    if (!empty($this->dbOwnerRow['vacation']) && $this->dbOwnerRow['vacation'] >= SN_TIME_NOW) {
       throw new Exception('FLIGHT_PLAYER_VACATION_OWN', FLIGHT_PLAYER_VACATION_OWN);
     }
   }
 
   protected function restrictToValidSpeedPercentOld() {
     $speed_possible = array(10, 9, 8, 7, 6, 5, 4, 3, 2, 1);
-    if(!in_array($this->oldSpeedInTens, $speed_possible)) {
+    if (!in_array($this->oldSpeedInTens, $speed_possible)) {
       throw new Exception('FLIGHT_FLEET_SPEED_WRONG', FLIGHT_FLEET_SPEED_WRONG);
     }
 
   }
 
   protected function restrict2ToAllowedMissions() {
-    if(empty($this->allowed_missions[$this->_mission_type])) {
+    if (empty($this->allowed_missions[$this->_mission_type])) {
       throw new Exception('FLIGHT_MISSION_IMPOSSIBLE', FLIGHT_MISSION_IMPOSSIBLE);
     }
   }
 
   protected function restrict2ToAllowedPlanetTypes() {
-    if(empty($this->allowed_planet_types[$this->targetVector->type])) {
+    if (empty($this->allowed_planet_types[$this->targetVector->type])) {
       throw new Exception('FLIGHT_MISSION_IMPOSSIBLE', FLIGHT_MISSION_IMPOSSIBLE);
     }
   }
 
   protected function restrict2ToMaxFleets() {
-    if(FleetList::fleet_count_flying($this->getPlayerOwnerId()) >= GetMaxFleets($this->dbOwnerRow)) {
+    if (FleetList::fleet_count_flying($this->getPlayerOwnerId()) >= GetMaxFleets($this->dbOwnerRow)) {
       throw new Exception('FLIGHT_FLEET_NO_SLOTS', FLIGHT_FLEET_NO_SLOTS);
     }
   }
 
   protected function restrict2ToEnoughShips() {
-    if(!$this->unitList->shipsIsEnoughOnPlanet($this->dbSourcePlanetRow)) {
+    if (!$this->unitList->shipsIsEnoughOnPlanet($this->dbSourcePlanetRow)) {
       throw new Exception('FLIGHT_SHIPS_NOT_ENOUGH', FLIGHT_SHIPS_NOT_ENOUGH);
     }
   }
 
   protected function restrict2ToEnoughCapacity($fleetCapacity, $fleetConsumption) {
-    if(floor($fleetCapacity) < ceil(array_sum($this->resource_list) + $fleetConsumption)) {
+    if (floor($fleetCapacity) < ceil(array_sum($this->resource_list) + $fleetConsumption)) {
       throw new Exception('FLIGHT_FLEET_OVERLOAD', FLIGHT_FLEET_OVERLOAD);
     }
   }
@@ -1441,13 +1441,13 @@ 
   protected function restrict2ByResources($fleetConsumption) {
     $fleetResources = $this->resource_list;
     $fleetResources[RES_DEUTERIUM] = ceil($fleetResources[RES_DEUTERIUM] + $fleetConsumption);
-    foreach($fleetResources as $resourceId => $resourceAmount) {
-      if($fleetResources[$resourceId] < 0) {
+    foreach ($fleetResources as $resourceId => $resourceAmount) {
+      if ($fleetResources[$resourceId] < 0) {
         throw new Exception('FLIGHT_RESOURCES_NEGATIVE', FLIGHT_RESOURCES_NEGATIVE);
       }
 
-      if(mrc_get_level($this->dbOwnerRow, $this->dbSourcePlanetRow, $resourceId) < ceil($fleetResources[$resourceId])) {
-        if($resourceId == RES_DEUTERIUM) {
+      if (mrc_get_level($this->dbOwnerRow, $this->dbSourcePlanetRow, $resourceId) < ceil($fleetResources[$resourceId])) {
+        if ($resourceId == RES_DEUTERIUM) {
           throw new Exception('FLIGHT_RESOURCES_FUEL_NOT_ENOUGH', FLIGHT_RESOURCES_FUEL_NOT_ENOUGH);
         } else {
           throw new Exception('FLIGHT_RESOURCES_NOT_ENOUGH', FLIGHT_RESOURCES_NOT_ENOUGH);
@@ -1500,7 +1500,7 @@ 
 
 
   protected function printErrorIfNoShips() {
-    if($this->unitList->unitsCount() <= 0) {
+    if ($this->unitList->unitsCount() <= 0) {
       message(classLocale::$lang['fl_err_no_ships'], classLocale::$lang['fl_error'], 'fleet' . DOT_PHP_EX, 5);
     }
   }
@@ -1538,10 +1538,10 @@ 
   protected function renderAllowedMissions(&$template_result) {
     ksort($this->allowed_missions);
     // If mission is not set - setting first mission from allowed
-    if(empty($this->_mission_type) && is_array($this->allowed_missions)) {
+    if (empty($this->_mission_type) && is_array($this->allowed_missions)) {
       $this->_mission_type = reset($this->allowed_missions);
     }
-    foreach($this->allowed_missions as $key => $value) {
+    foreach ($this->allowed_missions as $key => $value) {
       $template_result['.']['missions'][] = array(
         'ID'   => $key,
         'NAME' => classLocale::$lang['type_mission'][$key],
@@ -1553,9 +1553,9 @@ 
    * @param $template_result
    */
   protected function renderDuration(&$template_result, $max_duration) {
-    if($max_duration) {
+    if ($max_duration) {
       $config_game_speed_expedition = ($this->_mission_type == MT_EXPLORE && classSupernova::$config->game_speed_expedition ? classSupernova::$config->game_speed_expedition : 1);
-      for($i = 1; $i <= $max_duration; $i++) {
+      for ($i = 1; $i <= $max_duration; $i++) {
         $template_result['.']['duration'][] = array(
           'ID'   => $i,
           'TIME' => pretty_time(ceil($i * 3600 / $config_game_speed_expedition)),
@@ -1571,7 +1571,7 @@ 
   protected function renderPlanetResources(&$planetResources, &$template_result) {
     // TODO - REDO to resource_id
     $i = 0;
-    foreach($planetResources as $resource_id => $resource_amount) {
+    foreach ($planetResources as $resource_id => $resource_amount) {
       $template_result['.']['resources'][] = array(
         'ID'        => $i++, // $resource_id,
         'ON_PLANET' => $resource_amount,
@@ -1585,7 +1585,7 @@ 
    * @param $template_result
    */
   protected function renderAllowedPlanetTypes(&$template_result) {
-    foreach($this->allowed_planet_types as $possible_planet_type_id) {
+    foreach ($this->allowed_planet_types as $possible_planet_type_id) {
       $template_result['.']['possible_planet_type_id'][] = array(
         'ID'         => $possible_planet_type_id,
         'NAME'       => classLocale::$lang['sys_planet_type'][$possible_planet_type_id],
@@ -1608,14 +1608,14 @@ 
       'TYPE_PRINT' => classLocale::$lang['fl_shrtcup'][$shortcut['planet_type']],
     );
 
-    if(isset($shortcut['priority'])) {
+    if (isset($shortcut['priority'])) {
       $result += array(
         'PRIORITY'       => $shortcut['priority'],
         'PRIORITY_CLASS' => $note_priority_classes[$shortcut['priority']],
       );
     }
 
-    if(isset($shortcut['id'])) {
+    if (isset($shortcut['id'])) {
       $result += array(
         'ID' => $shortcut['id'],
       );
@@ -1630,7 +1630,7 @@ 
   protected function renderFleetShortcuts(&$template_result) {
     // Building list of shortcuts
     $query = db_note_list_select_by_owner_and_planet($this->dbOwnerRow);
-    while($row = db_fetch($query)) {
+    while ($row = db_fetch($query)) {
       $template_result['.']['shortcut'][] = $this->renderFleet1TargetSelect($row);
     }
   }
@@ -1642,12 +1642,12 @@ 
    */
   protected function renderOwnPlanets(&$template_result) {
     $colonies = db_planet_list_sorted($this->dbOwnerRow);
-    if(count($colonies) <= 1) {
+    if (count($colonies) <= 1) {
       return;
     }
 
-    foreach($colonies as $row) {
-      if($row['id'] == $this->dbSourcePlanetRow['id']) {
+    foreach ($colonies as $row) {
+      if ($row['id'] == $this->dbSourcePlanetRow['id']) {
         continue;
       }
 
@@ -1660,10 +1660,10 @@ 
    */
   protected function renderACSList(&$template_result) {
     $query = db_acs_get_list();
-    while($row = db_fetch($query)) {
+    while ($row = db_fetch($query)) {
       $members = explode(',', $row['eingeladen']);
-      foreach($members as $a => $b) {
-        if($b == $this->dbOwnerRow['id']) {
+      foreach ($members as $a => $b) {
+        if ($b == $this->dbOwnerRow['id']) {
           $template_result['.']['acss'][] = $this->renderFleet1TargetSelect($row);
         }
       }
@@ -1674,7 +1674,7 @@ 
    * @param $template_result
    */
   protected function renderShipSortOptions(&$template_result) {
-    foreach(classLocale::$lang['player_option_fleet_ship_sort'] as $sort_id => $sort_text) {
+    foreach (classLocale::$lang['player_option_fleet_ship_sort'] as $sort_id => $sort_text) {
       $template_result['.']['ship_sort_list'][] = array(
         'VALUE' => $sort_id,
         'TEXT'  => $sort_text,
@@ -1693,7 +1693,7 @@ 
 
     lng_include('overview');
 
-    if(empty($this->dbSourcePlanetRow)) {
+    if (empty($this->dbSourcePlanetRow)) {
       message(classLocale::$lang['fl_noplanetrow'], classLocale::$lang['fl_error']);
     }
 
@@ -1769,9 +1769,9 @@ 
 
     try {
       $this->restrictMission();
-    } catch(Exception $e) {
+    } catch (Exception $e) {
       // TODO - MESSAGE BOX
-      if($e->getCode() != FLIGHT_ALLOWED) {
+      if ($e->getCode() != FLIGHT_ALLOWED) {
         pdie(classLocale::$lang['fl_attack_error'][$e->getCode()]);
       } else {
         pdump('FLIGHT_ALLOWED', FLIGHT_ALLOWED);
@@ -1781,20 +1781,19 @@ 
     $this->renderAllowedMissions($template_result);
     $this->renderFleet($template_result);
 
-    $max_duration = $this->_mission_type == MT_EXPLORE ? get_player_max_expedition_duration($this->dbOwnerRow) :
-      (isset($this->allowed_missions[MT_HOLD]) ? 12 : 0);
+    $max_duration = $this->_mission_type == MT_EXPLORE ? get_player_max_expedition_duration($this->dbOwnerRow) : (isset($this->allowed_missions[MT_HOLD]) ? 12 : 0);
     $this->renderDuration($template_result, $max_duration);
 
     $travel_data = $this->flt_travel_data($this->oldSpeedInTens);
 
     $sn_group_resources = sn_get_groups('resources_loot');
     $planetResources = array();
-    foreach($sn_group_resources as $resource_id) {
+    foreach ($sn_group_resources as $resource_id) {
       $planetResources[$resource_id] = floor(mrc_get_level($this->dbOwnerRow, $this->dbSourcePlanetRow, $resource_id) - ($resource_id == RES_DEUTERIUM ? $travel_data['consumption'] : 0));
     }
     $this->renderPlanetResources($planetResources, $template_result);
 
-    if(sn_module::$sn_module['unit_captain']->manifest['active'] && ($captain = sn_module::$sn_module['unit_captain']->unit_captain_get($this->dbSourcePlanetRow['id'])) && $captain['unit_location_type'] == LOC_PLANET) {
+    if (sn_module::$sn_module['unit_captain']->manifest['active'] && ($captain = sn_module::$sn_module['unit_captain']->unit_captain_get($this->dbSourcePlanetRow['id'])) && $captain['unit_location_type'] == LOC_PLANET) {
       $template_result += array(
         'CAPTAIN_ID'     => $captain['unit_id'],
         'CAPTAIN_LEVEL'  => $captain['captain_level'],
@@ -1830,24 +1829,24 @@ 
 
 
   public function restrict2MissionTransportWithResources($fleetResources) {
-    if($this->_mission_type != MT_TRANSPORT) {
+    if ($this->_mission_type != MT_TRANSPORT) {
       return;
     }
 
-    if(array_sum($fleetResources) <= 0) {
+    if (array_sum($fleetResources) <= 0) {
       throw new Exception('FLIGHT_RESOURCES_EMPTY', FLIGHT_RESOURCES_EMPTY);
     }
   }
 
   protected function restrict2MissionExploreAvailable() {
-    if($this->_mission_type != MT_EXPLORE) {
+    if ($this->_mission_type != MT_EXPLORE) {
       return;
     }
 
-    if(($expeditionsMax = get_player_max_expeditons($this->dbOwnerRow)) <= 0) {
+    if (($expeditionsMax = get_player_max_expeditons($this->dbOwnerRow)) <= 0) {
       throw new Exception('FLIGHT_MISSION_EXPLORE_NO_ASTROTECH', FLIGHT_MISSION_EXPLORE_NO_ASTROTECH);
     }
-    if(FleetList::fleet_count_flying($this->getPlayerOwnerId(), MT_EXPLORE) >= $expeditionsMax) {
+    if (FleetList::fleet_count_flying($this->getPlayerOwnerId(), MT_EXPLORE) >= $expeditionsMax) {
       throw new Exception('FLIGHT_MISSION_EXPLORE_NO_SLOTS', FLIGHT_MISSION_EXPLORE_NO_SLOTS);
     }
 
@@ -1872,10 +1871,10 @@ 
 
     $this->dbOwnerRow = db_user_by_id($this->dbOwnerRow['id'], true);
     $this->dbSourcePlanetRow = db_planet_by_id($this->dbSourcePlanetRow['id'], true);
-    if(!empty($this->dbTargetRow['id'])) {
+    if (!empty($this->dbTargetRow['id'])) {
       $this->dbTargetRow = db_planet_by_id($this->dbTargetRow['id'], true);
     }
-    if(!empty($this->dbTargetRow['id_owner'])) {
+    if (!empty($this->dbTargetRow['id_owner'])) {
       $this->dbTargetOwnerRow = db_planet_by_id($this->dbTargetRow['id_owner'], true);
     }
 
@@ -1927,9 +1926,9 @@ 
 
         // TODO  - ALL OF THE ABOVE!
         $this->restrictMission();
-      } catch(Exception $e) {
+      } catch (Exception $e) {
         // If mission is restricted - rethrow exception
-        if($e->getCode() != FLIGHT_ALLOWED) {
+        if ($e->getCode() != FLIGHT_ALLOWED) {
           throw new Exception($e->getMessage(), $e->getCode());
         }
       }
@@ -1967,7 +1966,7 @@ 
       $this->restrictTargetExistsOrMissionColonize();
       $this->restrictNotDebrisOrMissionRecycle();
       // TODO - START $this->restrictFriendOrFoe();
-      if($this->dbTargetRow['id'] == $this->getPlayerOwnerId()) {
+      if ($this->dbTargetRow['id'] == $this->getPlayerOwnerId()) {
         // Spying can't be done on owner's planet/moon
         unset($this->allowed_missions[MT_SPY]);
         // Attack can't be done on owner's planet/moon
@@ -2044,9 +2043,9 @@ 
 
 
 //      $this->restrict2MissionTransportWithResources($fleetResources);
-    } catch(Exception $e) {
+    } catch (Exception $e) {
       // TODO - MESSAGE BOX
-      if($e->getCode() != FLIGHT_ALLOWED) {
+      if ($e->getCode() != FLIGHT_ALLOWED) {
         sn_db_transaction_rollback();
         pdie(classLocale::$lang['fl_attack_error'][$e->getCode()]);
       } else {
@@ -2066,46 +2065,46 @@ 
     $TransDeuterium = max(0, floor(sys_get_param_float('resource2')));
     $StorageNeeded = $TransMetal + $TransCrystal + $TransDeuterium;
 
-    if(!$StorageNeeded && $target_mission == MT_TRANSPORT) {
+    if (!$StorageNeeded && $target_mission == MT_TRANSPORT) {
       $errorlist .= classLocale::$lang['fl_noenoughtgoods'];
     }
 
 
-    if($target_mission == MT_EXPLORE) {
-      if($MaxExpeditions == 0) {
+    if ($target_mission == MT_EXPLORE) {
+      if ($MaxExpeditions == 0) {
         $errorlist .= classLocale::$lang['fl_expe_notech'];
-      } elseif($FlyingExpeditions >= $MaxExpeditions) {
+      } elseif ($FlyingExpeditions >= $MaxExpeditions) {
         $errorlist .= classLocale::$lang['fl_expe_max'];
       }
     } else {
-      if($TargetPlanet['id_owner']) {
-        if($target_mission == MT_COLONIZE) {
+      if ($TargetPlanet['id_owner']) {
+        if ($target_mission == MT_COLONIZE) {
           $errorlist .= classLocale::$lang['fl_colonized'];
         }
 
-        if($TargetPlanet['id_owner'] == $planetrow['id_owner']) {
-          if($target_mission == MT_ATTACK) {
+        if ($TargetPlanet['id_owner'] == $planetrow['id_owner']) {
+          if ($target_mission == MT_ATTACK) {
             $errorlist .= classLocale::$lang['fl_no_self_attack'];
           }
 
-          if($target_mission == MT_SPY) {
+          if ($target_mission == MT_SPY) {
             $errorlist .= classLocale::$lang['fl_no_self_spy'];
           }
         } else {
-          if($target_mission == MT_RELOCATE) {
+          if ($target_mission == MT_RELOCATE) {
             $errorlist .= classLocale::$lang['fl_only_stay_at_home'];
           }
         }
       } else {
-        if($target_mission < MT_COLONIZE) {
+        if ($target_mission < MT_COLONIZE) {
           $errorlist .= classLocale::$lang['fl_unknow_target'];
         } else {
 //          if($target_mission == MT_DESTROY) {
 //            $errorlist .= classLocale::$lang['fl_nomoon'];
 //          }
 
-          if($target_mission == MT_RECYCLE) {
-            if($TargetPlanet['debris_metal'] + $TargetPlanet['debris_crystal'] == 0) {
+          if ($target_mission == MT_RECYCLE) {
+            if ($TargetPlanet['debris_metal'] + $TargetPlanet['debris_crystal'] == 0) {
               $errorlist .= classLocale::$lang['fl_nodebris'];
             }
           }
@@ -2114,12 +2113,12 @@ 
     }
 
 
-    if(sn_module::$sn_module['unit_captain']->manifest['active'] && $captain_id = sys_get_param_id('captain_id')) {
+    if (sn_module::$sn_module['unit_captain']->manifest['active'] && $captain_id = sys_get_param_id('captain_id')) {
       $captain = sn_module::$sn_module['unit_captain']->unit_captain_get($planetrow['id']);
-      if(!$captain) {
+      if (!$captain) {
         $errorlist .= classLocale::$lang['module_unit_captain_error_no_captain'];
-      } elseif($captain['unit_location_type'] == LOC_PLANET) {
-        if($target_mission == MT_RELOCATE && ($arriving_captain = mrc_get_level($user, $TargetPlanet, UNIT_CAPTAIN, true))) {
+      } elseif ($captain['unit_location_type'] == LOC_PLANET) {
+        if ($target_mission == MT_RELOCATE && ($arriving_captain = mrc_get_level($user, $TargetPlanet, UNIT_CAPTAIN, true))) {
           $errorlist .= classLocale::$lang['module_unit_captain_error_captain_already_bound'];
         }
       } else {
@@ -2127,7 +2126,7 @@ 
       }
     }
 
-    if($errorlist) {
+    if ($errorlist) {
       sn_db_transaction_rollback();
       message("<span class='error'><ul>{$errorlist}</ul></span>", classLocale::$lang['fl_error'], 'fleet' . DOT_PHP_EX, false);
     }
@@ -2138,10 +2137,10 @@ 
     //But is it acs??
     //Well all acs fleets must have a fleet code.
     //The co-ords must be the same as where the acs fleet is going.
-    if($fleet_group && sys_get_param_str('acs_target_mr') == "g{$galaxy}s{$system}p{$planet}t{$planet_type}") {
+    if ($fleet_group && sys_get_param_str('acs_target_mr') == "g{$galaxy}s{$system}p{$planet}t{$planet_type}") {
       //ACS attack must exist (if acs fleet has arrived this will also return false (2 checks in 1!!!)
       $aks = db_acs_get_by_group_id($fleet_group);
-      if(!$aks) {
+      if (!$aks) {
         $fleet_group = 0;
       } else {
         //Also it must be mission type 2
@@ -2152,26 +2151,26 @@ 
         $planet = $aks['planet'];
         $planet_type = $aks['planet_type'];
       }
-    } elseif($target_mission == MT_ACS) {
+    } elseif ($target_mission == MT_ACS) {
       //Check that a failed acs attack isn't being sent, if it is, make it an attack fleet.
       $target_mission = MT_ATTACK;
     }
 
-    if($target_mission == MT_COLONIZE || $target_mission == MT_EXPLORE) {
+    if ($target_mission == MT_COLONIZE || $target_mission == MT_EXPLORE) {
       $TargetPlanet = array('galaxy' => $galaxy, 'system' => $system, 'planet' => $planet, 'id_owner' => 0);
     }
     $options = array('fleet_speed_percent' => $speed_percent, 'fleet_group' => $fleet_group, 'resources' => $StorageNeeded);
     $cant_attack = flt_can_attack($planetrow, $TargetPlanet, $fleetarray, $target_mission, $options);
 
-    if($cant_attack !== FLIGHT_ALLOWED) {
+    if ($cant_attack !== FLIGHT_ALLOWED) {
       message("<span class='error'><b>{$classLocale['fl_attack_error'][$cant_attack]}</b></span>", classLocale::$lang['fl_error'], 'fleet' . DOT_PHP_EX, 99);
     }
 
     $mission_time_in_seconds = 0;
     $arrival_time = SN_TIME_NOW + $time_to_travel;
-    if($target_mission == MT_ACS && $aks) {
+    if ($target_mission == MT_ACS && $aks) {
 //    if($fleet_start_time > $aks['ankunft']) {
-      if($arrival_time > $aks['ankunft']) {
+      if ($arrival_time > $aks['ankunft']) {
         message(classLocale::$lang['fl_aks_too_slow'] . 'Fleet arrival: ' . date(FMT_DATE_TIME, $arrival_time) . " AKS arrival: " . date(FMT_DATE_TIME, $aks['ankunft']), classLocale::$lang['fl_error']);
       }
       $group_sync_delta_time = $aks['ankunft'] - $arrival_time;
@@ -2180,11 +2179,11 @@ 
       // Set return time to ACS return time + fleet's time to travel
       $return_time = $aks['ankunft'] + $time_to_travel;
     } else {
-      if($target_mission == MT_EXPLORE || $target_mission == MT_HOLD) {
+      if ($target_mission == MT_EXPLORE || $target_mission == MT_HOLD) {
         $max_duration = $target_mission == MT_EXPLORE ? get_player_max_expedition_duration($user) : ($target_mission == MT_HOLD ? 12 : 0);
-        if($max_duration) {
+        if ($max_duration) {
           $mission_time_in_hours = sys_get_param_id('missiontime');
-          if($mission_time_in_hours > $max_duration || $mission_time_in_hours < 1) {
+          if ($mission_time_in_hours > $max_duration || $mission_time_in_hours < 1) {
             $debug->warning('Supplying wrong mission time', 'Hack attempt', 302, array('base_dump' => true));
             die();
           }
@@ -2198,7 +2197,7 @@ 
 //    $FleetStorage = 0;
 
     $db_changeset = array();
-    foreach($fleetarray as $Ship => $Count) {
+    foreach ($fleetarray as $Ship => $Count) {
 //      $FleetStorage += get_unit_param($Ship, P_CAPACITY) * $Count;
       $db_changeset['unit'][] = sn_db_unit_changeset_prepare($Ship, -$Count, $user, $planetrow['id']);
     }
@@ -2251,7 +2250,7 @@ 
 
     $template = gettemplate('fleet3', true);
 
-    if(is_array($captain)) {
+    if (is_array($captain)) {
       db_unit_set_by_id($captain['unit_id'], "`unit_location_type` = " . LOC_FLEET . ", `unit_location_id` = {$objFleet->dbId}");
     }
 
@@ -2263,7 +2262,7 @@ 
       'START_TIME_TEXT'    => date(FMT_DATE_TIME, $return_time + SN_CLIENT_TIME_DIFF),
       'START_LEFT'         => floor($return_time + 1 - SN_TIME_NOW),
     );
-    if(!empty($TargetPlanet)) {
+    if (!empty($TargetPlanet)) {
       $template_route += array(
         'END_TYPE_TEXT_SH' => classLocale::$lang['sys_planet_type_sh'][$TargetPlanet['planet_type']],
         'END_COORDS'       => uni_render_coordinates($TargetPlanet),
@@ -2276,8 +2275,8 @@ 
     $template->assign_block_vars('fleets', $template_route);
 
     $sn_groups_fleet = sn_get_groups('fleet');
-    foreach($fleetarray as $ship_id => $ship_count) {
-      if(in_array($ship_id, $sn_groups_fleet) && $ship_count) {
+    foreach ($fleetarray as $ship_id => $ship_count) {
+      if (in_array($ship_id, $sn_groups_fleet) && $ship_count) {
 //      $ship_base_data = get_ship_data($ship_id, $user);
         $template->assign_block_vars('fleets.ships', array(
           'ID'          => $ship_id,
@@ -2317,16 +2316,16 @@ 
    * @throws Exception
    */
   public function checkMissionRestrictions($checklist) {
-    foreach($checklist as $condition => $action) {
+    foreach ($checklist as $condition => $action) {
       $checkResult = call_user_func(array($this, $condition));
 
-      if(is_array($action) && !empty($action[$checkResult])) {
+      if (is_array($action) && !empty($action[$checkResult])) {
         $action = $action[$checkResult];
       }
 
-      if(is_array($action)) {
+      if (is_array($action)) {
         $this->checkMissionRestrictions($action);
-      } elseif(!$checkResult) {
+      } elseif (!$checkResult) {
         throw new Exception($action, $action);
       }
     }
@@ -2376,8 +2375,8 @@ 
   }
 
   protected function checkResourcesPositive() {
-    foreach($this->resource_list as $resourceId => $resourceAmount) {
-      if($resourceAmount < 0) {
+    foreach ($this->resource_list as $resourceId => $resourceAmount) {
+      if ($resourceAmount < 0) {
         return false;
       }
     }
@@ -2395,8 +2394,8 @@ 
   protected function checkSourceEnoughResources() {
     $fleetResources = $this->resource_list;
     $fleetResources[RES_DEUTERIUM] = ceil($fleetResources[RES_DEUTERIUM] + $this->travelData['consumption']);
-    foreach($fleetResources as $resourceId => $resourceAmount) {
-      if(mrc_get_level($this->dbOwnerRow, $this->dbSourcePlanetRow, $resourceId) < ceil($fleetResources[$resourceId])) {
+    foreach ($fleetResources as $resourceId => $resourceAmount) {
+      if (mrc_get_level($this->dbOwnerRow, $this->dbSourcePlanetRow, $resourceId) < ceil($fleetResources[$resourceId])) {
         return false;
       }
     }
@@ -2454,7 +2453,7 @@ 
 
   protected function checkHaveRecyclers() {
     $recyclers = 0;
-    foreach(sn_get_groups('flt_recyclers') as $recycler_id) {
+    foreach (sn_get_groups('flt_recyclers') as $recycler_id) {
       $recyclers += $this->unitList->unitsCountById($recycler_id);
     }
 
@@ -2474,7 +2473,7 @@ 
   protected function checkTargetOwn() {
     $result = $this->dbTargetRow['id_owner'] == $this->dbSourcePlanetRow['id_owner'];
 
-    if($result) {
+    if ($result) {
       // Spying can't be done on owner's planet/moon
       unset($this->allowed_missions[MT_SPY]);
       // Attack can't be done on owner's planet/moon
@@ -2526,7 +2525,7 @@ 
 
   protected function checkMissionSpy() {
     $result = !$this->_mission_type || $this->_mission_type == MT_SPY;
-    if($result) {
+    if ($result) {
       $this->allowed_missions = array(
         MT_SPY => MT_SPY,
       );
@@ -2540,7 +2539,7 @@ 
 
   protected function checkMissionRelocate() {
     $result = !$this->_mission_type || $this->_mission_type == MT_RELOCATE;
-    if($result) {
+    if ($result) {
       $this->allowed_missions = array(
         MT_RELOCATE => MT_RELOCATE,
       );

includes/classes/UnitList.php

Spacing +40 added lines, -40 removed lines

@@ -88,7 +88,7 @@ 
    * @param Unit  $value
    */
   public function offsetSet($offset, $value) {
-    if(isset($this->mapUnitIdToDb[$value->unitId])) {
+    if (isset($this->mapUnitIdToDb[$value->unitId])) {
       classSupernova::$debug->error('UnitList::offsetSet: Unit with UnitId ' . $value->unitId . ' already exists');
     }
     $this->mapUnitIdToDb[$value->unitId] = $value;
@@ -96,7 +96,7 @@ 
   }
 
   public function offsetUnset($offset) {
-    if(!empty($this[$offset]->unitId)) {
+    if (!empty($this[$offset]->unitId)) {
 //      $unit_id = $this[$offset]->unitId;
 //      $this->mapUnitIdToDb[$unit_id] = null;
 //      unset($this->mapUnitIdToDb[$unit_id]);
@@ -117,20 +117,20 @@ 
   public function dbLoad($dbId, $lockSkip = false) {
 //    $this->_reset();
 
-    if($dbId <= 0) {
+    if ($dbId <= 0) {
       return;
     }
 
-    if(!is_object($this->locatedAt)) {
+    if (!is_object($this->locatedAt)) {
       classSupernova::$debug->error('UnitList::dbLoad have no locatedAt field set');
     }
 
     $unit_array = classSupernova::db_get_unit_list_by_location(0, $this->getLocationType(), $this->getLocationDbId());
-    if(!is_array($unit_array)) {
+    if (!is_array($unit_array)) {
       return;
     }
 
-    foreach($unit_array as $unit_db_row) {
+    foreach ($unit_array as $unit_db_row) {
       $unit = $this->_createElement();
       $unit->dbRowParse($unit_db_row);
 
@@ -145,25 +145,25 @@ 
   }
 
   public function dbSave() {
-    if(!is_object($this->locatedAt)) {
+    if (!is_object($this->locatedAt)) {
       classSupernova::$debug->error('UnitList::dbSave have no locatedAt field set');
     }
 
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       $unit_db_id = $unit->dbId;
       $unit->dbSave();
 
-      if($unit->isEmpty()) {
+      if ($unit->isEmpty()) {
         // Removing unit object
         // TODO - change when there will be common bus for all objects
         // ...or should I? If COUNT is empty - it means that object does not exists in DB. So it should be deleted from PHP memory and cache too
         unset($this[$unit_db_id]);
       } else {
-        if($unit->dbId <= 0) {
+        if ($unit->dbId <= 0) {
           classSupernova::$debug->error('Error writing unit to DB');
         }
         // If unit is new then putting unit object to container
-        if(empty($this->_container[$unit->dbId])) {
+        if (empty($this->_container[$unit->dbId])) {
           $this->_container[$unit->dbId] = $unit;
         }
       }
@@ -201,7 +201,7 @@ 
   }
 
   public function unitGetCount($unit_id) {
-    if(empty($this->mapUnitIdToDb[$unit_id])) {
+    if (empty($this->mapUnitIdToDb[$unit_id])) {
       throw new Exception('Unit [' . $unit_id . '] is not exists in UnitList');
     }
     return $this->mapUnitIdToDb[$unit_id]->count;
@@ -216,14 +216,14 @@ 
    * @param bool $replace_value
    */
   public function unitAdjustCount($unit_id, $unit_count = 0, $replace_value = false) {
-    if(empty($this->mapUnitIdToDb[$unit_id])) {
+    if (empty($this->mapUnitIdToDb[$unit_id])) {
       // If unit not exists - creating one and setting all attributes
       $this->mapUnitIdToDb[$unit_id] = $this->_createElement();
       $this->mapUnitIdToDb[$unit_id]->setUnitId($unit_id);
       $this->mapUnitIdToDb[$unit_id]->setLocatedAt($this);
     }
 
-    if($replace_value) {
+    if ($replace_value) {
       $this->mapUnitIdToDb[$unit_id]->count = $unit_count;
     } else {
       $this->mapUnitIdToDb[$unit_id]->adjustCount($unit_count);
@@ -237,7 +237,7 @@ 
    */
   public function unitsGetArray() {
     $result = array();
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       $result[$unit->unitId] = $unit->count;
     }
 
@@ -245,7 +245,7 @@ 
   }
 
   public function unitsCountApplyLossMultiplier($ships_lost_multiplier) {
-    foreach($this->mapUnitIdToDb as $unit_id => $unit) {
+    foreach ($this->mapUnitIdToDb as $unit_id => $unit) {
       $unit->count = floor($unit->count * $ships_lost_multiplier);
     }
   }
@@ -267,8 +267,8 @@ 
 
   public function unitsPropertySumById($unit_id = 0, $propertyName = 'count') {
     $result = 0;
-    foreach($this->mapUnitIdToDb as $unit) {
-      if(!$unit_id || $unit->unitId == $unit_id) {
+    foreach ($this->mapUnitIdToDb as $unit) {
+      if (!$unit_id || $unit->unitId == $unit_id) {
         $result += $unit->$propertyName;
       }
     }
@@ -284,8 +284,8 @@ 
   // TODO - WRONG FOR STRUCTURES
   public function shipsPoolPropertySumById($unit_id = 0, $propertyName = 'count') {
     $result = 0;
-    foreach($this->mapUnitIdToDb as $unit) {
-      if(!$unit_id || $unit->unitId == $unit_id) {
+    foreach ($this->mapUnitIdToDb as $unit) {
+      if (!$unit_id || $unit->unitId == $unit_id) {
         $result += $unit->$propertyName * $unit->count;
       }
     }
@@ -295,8 +295,8 @@ 
 
   public function shipsIsEnoughOnPlanet($dbPlanetRow) {
     $player = null;
-    foreach($this->mapUnitIdToDb as $unitId => $unit) {
-      if($unit->count < mrc_get_level($player, $dbPlanetRow, $unit->unitId)) {
+    foreach ($this->mapUnitIdToDb as $unitId => $unit) {
+      if ($unit->count < mrc_get_level($player, $dbPlanetRow, $unit->unitId)) {
         return false;
       }
     }
@@ -313,15 +313,15 @@ 
      * @var Fleet $objFleet
      */
     $objFleet = $this->getLocatedAt();
-    if(empty($objFleet)) {
+    if (empty($objFleet)) {
       throw new Exception('No fleet owner on UnitList::unitsRender() in ' . __FILE__ . '@' . __LINE__);
     }
 
     $tplShips = array();
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       $ship_id = $unit->unitId;
       $ship_count = $unit->count;
-      if(!UnitShip::is_in_group($ship_id) || $ship_count <= 0) {
+      if (!UnitShip::is_in_group($ship_id) || $ship_count <= 0) {
         continue;
       }
 
@@ -349,9 +349,9 @@ 
   // TODO - REDO!!!!
   public function shipsSpeedMin($user) {
     $speeds = array();
-    if(!empty($this->mapUnitIdToDb)) {
-      foreach($this->mapUnitIdToDb as $ship_id => $unit) {
-        if($unit->getCount() > 0 && in_array($unit->unitId, sn_get_groups(array('fleet', 'missile')))) {
+    if (!empty($this->mapUnitIdToDb)) {
+      foreach ($this->mapUnitIdToDb as $ship_id => $unit) {
+        if ($unit->getCount() > 0 && in_array($unit->unitId, sn_get_groups(array('fleet', 'missile')))) {
           $single_ship_data = get_ship_data($unit->unitId, $user);
           $speeds[] = $single_ship_data['speed'];
         }
@@ -374,11 +374,11 @@ 
     $fleet_speed = $this->shipsSpeedMin($dbOwnerRow);
     $real_speed = $speed_percent * sqrt($fleet_speed);
 
-    if($fleet_speed && $game_fleet_speed) {
+    if ($fleet_speed && $game_fleet_speed) {
       $duration = max(1, round((35000 / $speed_percent * sqrt($distance * 10 / $fleet_speed) + 10) / $game_fleet_speed));
 
-      foreach($this->mapUnitIdToDb as $ship_id => $unit) {
-        if(!$unit->unitId || $unit->getCount() <= 0) {
+      foreach ($this->mapUnitIdToDb as $ship_id => $unit) {
+        if (!$unit->unitId || $unit->getCount() <= 0) {
           continue;
         }
 
@@ -409,8 +409,8 @@ 
    * @return bool
    */
   public function unitsInGroup($group) {
-    foreach($this->mapUnitIdToDb as $unitId => $unit) {
-      if(!in_array($unitId, $group)) {
+    foreach ($this->mapUnitIdToDb as $unitId => $unit) {
+      if (!in_array($unitId, $group)) {
         return false;
       }
     }
@@ -419,9 +419,9 @@ 
   }
 
   public function unitsIsAllMovable($dbOwnerRow) {
-    foreach($this->mapUnitIdToDb as $unitId => $unit) {
+    foreach ($this->mapUnitIdToDb as $unitId => $unit) {
       $single_ship_data = get_ship_data($unit->unitId, $dbOwnerRow);
-      if($single_ship_data['speed'] <= 0) {
+      if ($single_ship_data['speed'] <= 0) {
         return false;
       }
     }
@@ -430,8 +430,8 @@ 
   }
 
   public function unitsPositive() {
-    foreach($this->mapUnitIdToDb as $unitId => $unit) {
-      if($unit->count < 1) {
+    foreach ($this->mapUnitIdToDb as $unitId => $unit) {
+      if ($unit->count < 1) {
         return false;
       }
     }
@@ -491,7 +491,7 @@ 
 
     print('</tr>');
 
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       print('<tr>');
 
       print('<td>');
@@ -540,12 +540,12 @@ 
     print('</table>');
   }
   public function unitZeroDbId() {
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       $unit->zeroDbId();
     }
   }
   public function unitZeroCount() {
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       $unit->count = 0;
     }
   }

includes/vars.php

Spacing +3 added lines, -3 removed lines

@@ -183,12 +183,12 @@
 $user_option_list = array();
 
 $user_option_list[OPT_MESSAGE] = array();
-foreach($sn_message_class_list as $message_class_id => $message_class_data) {
-  if($message_class_data['switchable']) {
+foreach ($sn_message_class_list as $message_class_id => $message_class_data) {
+  if ($message_class_data['switchable']) {
     $user_option_list[OPT_MESSAGE]["opt_{$message_class_data['name']}"] = 1;
   }
 
-  if($message_class_data['email']) {
+  if ($message_class_data['email']) {
     $user_option_list[OPT_MESSAGE]["opt_email_{$message_class_data['name']}"] = 0;
   }
 }