superdesk / web-publisher

src/SWP/Bundle/CoreBundle/Controller/ExternalOauthController.php

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 namespace SWP\Bundle\CoreBundle\Controller;
 
-use KnpU\OAuth2ClientBundle\Client\ClientRegistry;
 use Symfony\Component\HttpFoundation\Request;
-use League\OAuth2\Client\Provider\Exception\IdentityProviderException;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\Routing\Annotation\Route;
 

src/SWP/Bundle/CoreBundle/Security/Authenticator/ExternalOauthAuthenticator.php

Unused Use Statements -4 removed lines

@@ -4,10 +4,6 @@
 
 namespace SWP\Bundle\CoreBundle\Security\Authenticator;
 
-use Doctrine\ORM\EntityManagerInterface;
-use SWP\Bundle\CoreBundle\Model\UserInterface as CoreUserInterface;
-use SWP\Bundle\CoreBundle\Security\Provider\UserProvider;
-use Symfony\Component\Security\Core\User\UserInterface;
 use KnpU\OAuth2ClientBundle\Security\Authenticator\SocialAuthenticator;
 use KnpU\OAuth2ClientBundle\Client\ClientRegistry;
 use Symfony\Component\HttpFoundation\Request;

Spacing +5 added lines, -5 removed lines

@@ -50,7 +50,7 @@ 
      */
     public function supports(Request $request) 
     {
-        if(!$this->security->getUser() || ($request->query->get('code') && $request->get('state'))) {
+        if (!$this->security->getUser() || ($request->query->get('code') && $request->get('state'))) {
             return true;
         }
 
@@ -79,14 +79,14 @@ 
         $oauthEmail = $oauthUser->getEmail();
         $oauthId = $oauthUser->getId();
 
-        if(!$oauthUser) {
+        if (!$oauthUser) {
             return null;
         }
 
         // Is there an existing user with the same oauth id?
         $user = $userProvider->findOneByExternalId($oauthId);
-        if($user) {
-            if($user->getEmail() !== $oauthEmail) {
+        if ($user) {
+            if ($user->getEmail() !== $oauthEmail) {
                 // If the email has changed for the user, update it here as well
                 $user->setEmail($oauthEmail);
                 $user->setUsername($oauthEmail);
@@ -98,7 +98,7 @@ 
 
         // Is there an existing user with the same email address?
         $user = $userProvider->findOneByEmail($oauthEmail);
-        if($user) {
+        if ($user) {
             return $user;
         }
 

src/SWP/Bundle/UserBundle/Model/UserInterface.php

Doc Comments +4 added lines

@@ -29,6 +29,7 @@ 
 
     /**
      * @param string $about
+     * @return void
      */
     public function setAbout(string $about);
 
@@ -39,6 +40,7 @@ 
 
     /**
      * @param string $firstName
+     * @return void
      */
     public function setFirstName(string $firstName);
 
@@ -49,6 +51,7 @@ 
 
     /**
      * @param string $lastName
+     * @return void
      */
     public function setLastName(string $lastName);
 
@@ -59,6 +62,7 @@ 
 
     /**
      * @param string $externalId
+     * @return void
      */
     public function setExternalId(string $externalId);
 }

src/SWP/Bundle/CoreBundle/Security/Provider/ExternalOauthProvider.php

Spacing +7 added lines, -7 removed lines

@@ -22,7 +22,7 @@ 
     }
 
     public function getAccessToken($grant, $options = []) {
-        if(!isset($this->access_token)) {
+        if (!isset($this->access_token)) {
             $this->access_token = parent::getAccessToken($grant, $options);
         }
         return $this->access_token;
@@ -30,17 +30,17 @@ 
 
     public function getBaseAuthorizationUrl()
     {
-        return $this->base_url . '/authorize';
+        return $this->base_url.'/authorize';
     }
 
     public function getBaseAccessTokenUrl(array $params)
     {
-        return $this->base_url . '/oauth/token';
+        return $this->base_url.'/oauth/token';
     }
 
     public function getResourceOwnerDetailsUrl(AccessToken $token)
     {
-        return $this->base_url . '/userinfo';
+        return $this->base_url.'/userinfo';
     }
 
     protected function getDefaultScopes()
@@ -50,7 +50,7 @@ 
 
     protected function checkResponse(ResponseInterface $response, $data)
     {
-        if($response->getStatusCode() >= 400) {
+        if ($response->getStatusCode() >= 400) {
             return new IdentityProviderException(
                 $response->getReasonPhrase(),
                 $response->getStatusCode(),
@@ -70,9 +70,9 @@ 
 
     protected function getAuthorizationHeaders($token = null)
     {
-        if($token) {
+        if ($token) {
             return [
-                'Authorization' => 'Bearer ' . $token
+                'Authorization' => 'Bearer '.$token
             ];
         } else {
             return [];