sunrise-php / http-router

functions/path_match.php

Indentation +11 added lines, -11 removed lines

@@ -27,17 +27,17 @@
  */
 function path_match(string $path, string $subject, &$attributes = []) : bool
 {
-    $regex = path_regex($path);
-    if (!preg_match($regex, $subject, $matches)) {
-        return false;
-    }
+	$regex = path_regex($path);
+	if (!preg_match($regex, $subject, $matches)) {
+		return false;
+	}
 
-    $attributes = [];
-    foreach ($matches as $key => $value) {
-        if (! (is_int($key) || '' === $value)) {
-            $attributes[$key] = $value;
-        }
-    }
+	$attributes = [];
+	foreach ($matches as $key => $value) {
+		if (! (is_int($key) || '' === $value)) {
+			$attributes[$key] = $value;
+		}
+	}
 
-    return true;
+	return true;
 }

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
     $attributes = [];
     foreach ($matches as $key => $value) {
-        if (! (is_int($key) || '' === $value)) {
+        if (!(is_int($key) || '' === $value)) {
             $attributes[$key] = $value;
         }
     }

functions/path_build.php

Indentation +21 added lines, -21 removed lines

@@ -36,25 +36,25 @@
  */
 function path_build(string $path, array $attributes = [], bool $strict = false) : string
 {
-    $regex = '/{([0-9A-Za-z_]+)(?:<([^<#>]+)>)?}/';
-
-    return preg_replace_callback($regex, function ($match) use ($path, $attributes, $strict) {
-        if (!isset($attributes[$match[1]])) {
-            throw new InvalidArgumentException(
-                sprintf('[%s] missing attribute "%s".', $path, $match[1])
-            );
-        }
-
-        $attributes[$match[1]] = (string) $attributes[$match[1]];
-
-        if ($strict && isset($match[2])) {
-            if (!preg_match('#'.$match[2].'#u', $attributes[$match[1]])) {
-                throw new InvalidArgumentException(
-                    sprintf('[%s] "%s" must match "%s".', $path, $match[1], $match[2])
-                );
-            }
-        }
-
-        return $attributes[$match[1]];
-    }, $path);
+	$regex = '/{([0-9A-Za-z_]+)(?:<([^<#>]+)>)?}/';
+
+	return preg_replace_callback($regex, function ($match) use ($path, $attributes, $strict) {
+		if (!isset($attributes[$match[1]])) {
+			throw new InvalidArgumentException(
+				sprintf('[%s] missing attribute "%s".', $path, $match[1])
+			);
+		}
+
+		$attributes[$match[1]] = (string) $attributes[$match[1]];
+
+		if ($strict && isset($match[2])) {
+			if (!preg_match('#'.$match[2].'#u', $attributes[$match[1]])) {
+				throw new InvalidArgumentException(
+					sprintf('[%s] "%s" must match "%s".', $path, $match[1], $match[2])
+				);
+			}
+		}
+
+		return $attributes[$match[1]];
+	}, $path);
 }

Spacing +2 added lines, -2 removed lines

@@ -38,7 +38,7 @@ 
 {
     $regex = '/{([0-9A-Za-z_]+)(?:<([^<#>]+)>)?}/';
 
-    return preg_replace_callback($regex, function ($match) use ($path, $attributes, $strict) {
+    return preg_replace_callback($regex, function($match) use ($path, $attributes, $strict) {
         if (!isset($attributes[$match[1]])) {
             throw new InvalidArgumentException(
                 sprintf('[%s] missing attribute "%s".', $path, $match[1])
@@ -48,7 +48,7 @@ 
         $attributes[$match[1]] = (string) $attributes[$match[1]];
 
         if ($strict && isset($match[2])) {
-            if (!preg_match('#'.$match[2].'#u', $attributes[$match[1]])) {
+            if (!preg_match('#' . $match[2] . '#u', $attributes[$match[1]])) {
                 throw new InvalidArgumentException(
                     sprintf('[%s] "%s" must match "%s".', $path, $match[1], $match[2])
                 );

functions/path_regex.php

Indentation +10 added lines, -10 removed lines

@@ -34,18 +34,18 @@
  */
 function path_regex(string $path) : string
 {
-    preg_match_all('/{([0-9A-Za-z_]+)(?:<([^<#>]+)>)?}/', $path, $matches, PREG_SET_ORDER);
+	preg_match_all('/{([0-9A-Za-z_]+)(?:<([^<#>]+)>)?}/', $path, $matches, PREG_SET_ORDER);
 
-    foreach ($matches as $match) {
-        $path = str_replace($match[0], '{'.$match[1].'}', $path);
-    }
+	foreach ($matches as $match) {
+		$path = str_replace($match[0], '{'.$match[1].'}', $path);
+	}
 
-    $path = addcslashes($path, '#$*+-.?[\]^|');
-    $path = str_replace(['(', ')'], ['(?:', ')?'], $path);
+	$path = addcslashes($path, '#$*+-.?[\]^|');
+	$path = str_replace(['(', ')'], ['(?:', ')?'], $path);
 
-    foreach ($matches as $match) {
-        $path = str_replace('{'.$match[1].'}', '(?<'.$match[1].'>'.($match[2] ?? '[^/]+').')', $path);
-    }
+	foreach ($matches as $match) {
+		$path = str_replace('{'.$match[1].'}', '(?<'.$match[1].'>'.($match[2] ?? '[^/]+').')', $path);
+	}
 
-    return '#^'.$path.'$#uD';
+	return '#^'.$path.'$#uD';
 }

Spacing +3 added lines, -3 removed lines

@@ -37,15 +37,15 @@
     preg_match_all('/{([0-9A-Za-z_]+)(?:<([^<#>]+)>)?}/', $path, $matches, PREG_SET_ORDER);
 
     foreach ($matches as $match) {
-        $path = str_replace($match[0], '{'.$match[1].'}', $path);
+        $path = str_replace($match[0], '{' . $match[1] . '}', $path);
     }
 
     $path = addcslashes($path, '#$*+-.?[\]^|');
     $path = str_replace(['(', ')'], ['(?:', ')?'], $path);
 
     foreach ($matches as $match) {
-        $path = str_replace('{'.$match[1].'}', '(?<'.$match[1].'>'.($match[2] ?? '[^/]+').')', $path);
+        $path = str_replace('{' . $match[1] . '}', '(?<' . $match[1] . '>' . ($match[2] ?? '[^/]+') . ')', $path);
     }
 
-    return '#^'.$path.'$#uD';
+    return '#^' . $path . '$#uD';
 }

tests/Fixture/BlankRequestHandler.php

Indentation +51 added lines, -51 removed lines

@@ -16,62 +16,62 @@
 class BlankRequestHandler implements RequestHandlerInterface
 {
 
-    /**
-     * @var bool
-     */
-    private $isRunned = false;
+	/**
+	 * @var bool
+	 */
+	private $isRunned = false;
 
-    /**
-     * @var array
-     */
-    private $attributes = [];
+	/**
+	 * @var array
+	 */
+	private $attributes = [];
 
-    /**
-     * @return bool
-     */
-    public function isRunned() : bool
-    {
-        return $this->isRunned;
-    }
+	/**
+	 * @return bool
+	 */
+	public function isRunned() : bool
+	{
+		return $this->isRunned;
+	}
 
-    /**
-     * @return array
-     */
-    public function getAttributes() : array
-    {
-        return $this->attributes;
-    }
+	/**
+	 * @return array
+	 */
+	public function getAttributes() : array
+	{
+		return $this->attributes;
+	}
 
-    /**
-     * @param mixed $key
-     *
-     * @return mixed
-     */
-    public function getAttribute($key)
-    {
-        return $this->attributes[$key] ?? null;
-    }
+	/**
+	 * @param mixed $key
+	 *
+	 * @return mixed
+	 */
+	public function getAttribute($key)
+	{
+		return $this->attributes[$key] ?? null;
+	}
 
-    /**
-     * {@inheritDoc}
-     */
-    public function handle(ServerRequestInterface $request) : ResponseInterface
-    {
-        $this->isRunned = true;
-        $this->attributes = $request->getAttributes();
+	/**
+	 * {@inheritDoc}
+	 */
+	public function handle(ServerRequestInterface $request) : ResponseInterface
+	{
+		$this->isRunned = true;
+		$this->attributes = $request->getAttributes();
 
-        return (new ResponseFactory)->createResponse();
-    }
+		return (new ResponseFactory)->createResponse();
+	}
 
-    /**
-     * @param ServerRequestInterface $request
-     *
-     * @return ResponseInterface
-     *
-     * @link https://www.php.net/manual/ru/language.oop5.magic.php#object.invoke
-     */
-    public function __invoke(ServerRequestInterface $request) : ResponseInterface
-    {
-        return $this->handle($request);
-    }
+	/**
+	 * @param ServerRequestInterface $request
+	 *
+	 * @return ResponseInterface
+	 *
+	 * @link https://www.php.net/manual/ru/language.oop5.magic.php#object.invoke
+	 */
+	public function __invoke(ServerRequestInterface $request) : ResponseInterface
+	{
+		return $this->handle($request);
+	}
 }

tests/Fixture/TestRoute.php

Indentation +77 added lines, -77 removed lines

@@ -21,91 +21,91 @@
 class TestRoute extends BaseRoute
 {
 
-    /**
-     * @var int
-     */
-    public const WITH_BROKEN_MIDDLEWARE = 1;
+	/**
+	 * @var int
+	 */
+	public const WITH_BROKEN_MIDDLEWARE = 1;
 
-    /**
-     * Constructor of the class
-     *
-     * @param int $flags
-     */
-    public function __construct(int $flags = 0)
-    {
-        parent::__construct(
-            self::getTestRouteName($flags),
-            self::getTestRoutePath($flags),
-            self::getTestRouteMethods($flags),
-            self::getTestRouteRequestHandler($flags),
-            self::getTestRouteMiddlewares($flags),
-            self::getTestRouteAttributes($flags)
-        );
-    }
+	/**
+	 * Constructor of the class
+	 *
+	 * @param int $flags
+	 */
+	public function __construct(int $flags = 0)
+	{
+		parent::__construct(
+			self::getTestRouteName($flags),
+			self::getTestRoutePath($flags),
+			self::getTestRouteMethods($flags),
+			self::getTestRouteRequestHandler($flags),
+			self::getTestRouteMiddlewares($flags),
+			self::getTestRouteAttributes($flags)
+		);
+	}
 
-    /**
-     * @return string
-     */
-    public static function getTestRouteName(int $flags = 0) : string
-    {
-        return uniqid() . '.' . uniqid() . '.' . uniqid();
-    }
+	/**
+	 * @return string
+	 */
+	public static function getTestRouteName(int $flags = 0) : string
+	{
+		return uniqid() . '.' . uniqid() . '.' . uniqid();
+	}
 
-    /**
-     * @return string
-     */
-    public static function getTestRoutePath(int $flags = 0) : string
-    {
-        return '/' . uniqid() . '/' . uniqid() . '/' . uniqid();
-    }
+	/**
+	 * @return string
+	 */
+	public static function getTestRoutePath(int $flags = 0) : string
+	{
+		return '/' . uniqid() . '/' . uniqid() . '/' . uniqid();
+	}
 
-    /**
-     * @return string[]
-     */
-    public static function getTestRouteMethods(int $flags = 0) : array
-    {
-        return [
-            strtoupper(uniqid()),
-            strtoupper(uniqid()),
-            strtoupper(uniqid()),
-        ];
-    }
+	/**
+	 * @return string[]
+	 */
+	public static function getTestRouteMethods(int $flags = 0) : array
+	{
+		return [
+			strtoupper(uniqid()),
+			strtoupper(uniqid()),
+			strtoupper(uniqid()),
+		];
+	}
 
-    /**
-     * @return RequestHandlerInterface
-     */
-    public static function getTestRouteRequestHandler(int $flags = 0) : RequestHandlerInterface
-    {
-        return new BlankRequestHandler();
-    }
+	/**
+	 * @return RequestHandlerInterface
+	 */
+	public static function getTestRouteRequestHandler(int $flags = 0) : RequestHandlerInterface
+	{
+		return new BlankRequestHandler();
+	}
 
-    /**
-     * @return MiddlewareInterface[]
-     */
-    public static function getTestRouteMiddlewares(int $flags = 0) : array
-    {
-        $middlewares = [new BlankMiddleware()];
+	/**
+	 * @return MiddlewareInterface[]
+	 */
+	public static function getTestRouteMiddlewares(int $flags = 0) : array
+	{
+		$middlewares = [new BlankMiddleware()];
 
-        if ($flags & self::WITH_BROKEN_MIDDLEWARE) {
-            $middlewares[] = new BlankMiddleware(true);
-        } else {
-            $middlewares[] = new BlankMiddleware();
-        }
+		if ($flags & self::WITH_BROKEN_MIDDLEWARE) {
+			$middlewares[] = new BlankMiddleware(true);
+		} else {
+			$middlewares[] = new BlankMiddleware();
+		}
 
-        $middlewares[] = new BlankMiddleware();
+		$middlewares[] = new BlankMiddleware();
 
-        return $middlewares;
-    }
+		return $middlewares;
+	}
 
-    /**
-     * @return array
-     */
-    public static function getTestRouteAttributes(int $flags = 0) : array
-    {
-        return [
-            uniqid() => uniqid(),
-            uniqid() => uniqid(),
-            uniqid() => uniqid(),
-        ];
-    }
+	/**
+	 * @return array
+	 */
+	public static function getTestRouteAttributes(int $flags = 0) : array
+	{
+		return [
+			uniqid() => uniqid(),
+			uniqid() => uniqid(),
+			uniqid() => uniqid(),
+		];
+	}
 }

tests/Fixture/BlankMiddleware.php

Indentation +40 added lines, -40 removed lines

@@ -17,51 +17,51 @@
 class BlankMiddleware implements MiddlewareInterface
 {
 
-    /**
-     * @var bool
-     */
-    private $isBroken;
+	/**
+	 * @var bool
+	 */
+	private $isBroken;
 
-    /**
-     * @var bool
-     */
-    private $isRunned = false;
+	/**
+	 * @var bool
+	 */
+	private $isRunned = false;
 
-    /**
-     * @param bool $isBroken
-     */
-    public function __construct(bool $isBroken = false)
-    {
-        $this->isBroken = $isBroken;
-    }
+	/**
+	 * @param bool $isBroken
+	 */
+	public function __construct(bool $isBroken = false)
+	{
+		$this->isBroken = $isBroken;
+	}
 
-    /**
-     * @return bool
-     */
-    public function isBroken() : bool
-    {
-        return $this->isBroken;
-    }
+	/**
+	 * @return bool
+	 */
+	public function isBroken() : bool
+	{
+		return $this->isBroken;
+	}
 
-    /**
-     * @return bool
-     */
-    public function isRunned() : bool
-    {
-        return $this->isRunned;
-    }
+	/**
+	 * @return bool
+	 */
+	public function isRunned() : bool
+	{
+		return $this->isRunned;
+	}
 
-    /**
-     * {@inheritDoc}
-     */
-    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler) : ResponseInterface
-    {
-        $this->isRunned = true;
+	/**
+	 * {@inheritDoc}
+	 */
+	public function process(ServerRequestInterface $request, RequestHandlerInterface $handler) : ResponseInterface
+	{
+		$this->isRunned = true;
 
-        if ($this->isBroken) {
-            return (new ResponseFactory)->createResponse();
-        }
+		if ($this->isBroken) {
+			return (new ResponseFactory)->createResponse();
+		}
 
-        return $handler->handle($request);
-    }
+		return $handler->handle($request);
+	}
 }

tests/Annotation/AnnotationRouteLoaderTest.php

Indentation +293 added lines, -293 removed lines

@@ -23,297 +23,297 @@
 class AnnotationRouteLoaderTest extends TestCase
 {
 
-    /**
-     * @return void
-     */
-    public static function setUpBeforeClass() : void
-    {
-        if (! class_exists('Route')) {
-            class_alias(AnnotationRoute::class, 'Route');
-        }
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteNameMissing() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.name must be not an empty string.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteNameMissing');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteNameEmpty() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.name must be not an empty string.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteNameEmpty');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteNameNotString() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.name must be not an empty string.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteNameNotString');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRoutePathMissing() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.path must be not an empty string.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRoutePathMissing');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRoutePathEmpty() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.path must be not an empty string.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRoutePathEmpty');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRoutePathNotString() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.path must be not an empty string.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRoutePathNotString');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteMethodsMissing() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.methods must be not an empty array.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMethodsMissing');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteMethodsEmpty() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.methods must be not an empty array.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMethodsEmpty');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteMethodsNotArray() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.methods must be not an empty array.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMethodsNotArray');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteMethodsNotStringable() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.methods must contain only strings.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMethodsNotStringable');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteMiddlewaresNotArray() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.middlewares must be an array.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMiddlewaresNotArray');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteMiddlewaresNotStringable() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.middlewares must contain only middlewares.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMiddlewaresNotStringable');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteMiddlewaresContainNonexistenceClass() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.middlewares must contain only middlewares.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMiddlewaresContainNonexistenceClass');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteMiddlewaresContainNotMiddleware() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.middlewares must contain only middlewares.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMiddlewaresContainNotMiddleware');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRouteAttributesNotArray() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.attributes must be an array.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRouteAttributesNotArray');
-    }
-
-    /**
-     * @return void
-     */
-    public function testAnnotationRoutePriorityNotInteger() : void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('@Route.priority must be an integer.');
-
-        $root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
-        (new AnnotationRouteLoader)->discover($root . '/AnnotationRoutePriorityNotInteger');
-    }
-
-    /**
-     * @return void
-     *
-     * @todo This test needs to be improved...
-     */
-    public function testBuildRoutes() : void
-    {
-        $loader = new AnnotationRouteLoader();
-        $loader->discover(__DIR__ . '/../Fixture/Annotation/AnnotationRouteValid');
-
-        $routesMap = [];
-        $builtRoutes = $loader->buildRoutes();
-
-        foreach ($builtRoutes as $i => $route) {
-            $routesMap[$i]['name'] = $route->getName();
-            $routesMap[$i]['path'] = $route->getPath();
-            $routesMap[$i]['methods'] = $route->getMethods();
-            $routesMap[$i]['requestHandler'] = get_class($route->getRequestHandler());
-            $routesMap[$i]['middlewares'] = [];
-            $routesMap[$i]['attributes'] = $route->getAttributes();
-
-            foreach ($route->getMiddlewares() as $middleware) {
-                $routesMap[$i]['middlewares'][] = get_class($middleware);
-            }
-        }
-
-        $expectedMap = [
-            [
-                'name' => 'quuuux',
-                'path' => '/quuuux',
-                'methods' => ['PATCH', 'DELETE'],
-                'requestHandler' => 'Sunrise\Http\Router\Tests\Fixture\Annotation' .
-                                    '\AnnotationRouteValid\Subdirectory\QuuuuxRequestHandler',
-                'middlewares' => [
-                    'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
-                    'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
-                ],
-                'attributes' => [
-                    'foo' => 'bar',
-                    'source' => 'quuuux',
-                ],
-            ],
-            [
-                'name' => 'quuux',
-                'path' => '/quuux',
-                'methods' => ['PUT', 'PATCH'],
-                'requestHandler' => 'Sunrise\Http\Router\Tests\Fixture\Annotation' .
-                                    '\AnnotationRouteValid\Subdirectory\QuuuxRequestHandler',
-                'middlewares' => [
-                    'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
-                    'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
-                ],
-                'attributes' => [
-                    'foo' => 'bar',
-                    'source' => 'quuux',
-                ],
-            ],
-            [
-                'name' => 'quux',
-                'path' => '/quux',
-                'methods' => ['POST', 'PUT'],
-                'requestHandler' => 'Sunrise\Http\Router\Tests\Fixture\Annotation' .
-                                    '\AnnotationRouteValid\QuuxRequestHandler',
-                'middlewares' => [
-                    'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
-                    'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
-                ],
-                'attributes' => [
-                    'foo' => 'bar',
-                    'source' => 'quux',
-                ],
-            ],
-            [
-                'name' => 'qux',
-                'path' => '/qux',
-                'methods' => ['GET', 'POST'],
-                'requestHandler' => 'Sunrise\Http\Router\Tests\Fixture\Annotation' .
-                                    '\AnnotationRouteValid\QuxRequestHandler',
-                'middlewares' => [
-                    'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
-                    'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
-                ],
-                'attributes' => [
-                    'foo' => 'bar',
-                    'source' => 'qux',
-                ],
-            ],
-        ];
-
-        $this->assertSame($expectedMap, $routesMap);
-    }
+	/**
+	 * @return void
+	 */
+	public static function setUpBeforeClass() : void
+	{
+		if (! class_exists('Route')) {
+			class_alias(AnnotationRoute::class, 'Route');
+		}
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteNameMissing() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.name must be not an empty string.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteNameMissing');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteNameEmpty() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.name must be not an empty string.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteNameEmpty');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteNameNotString() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.name must be not an empty string.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteNameNotString');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRoutePathMissing() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.path must be not an empty string.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRoutePathMissing');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRoutePathEmpty() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.path must be not an empty string.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRoutePathEmpty');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRoutePathNotString() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.path must be not an empty string.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRoutePathNotString');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteMethodsMissing() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.methods must be not an empty array.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMethodsMissing');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteMethodsEmpty() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.methods must be not an empty array.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMethodsEmpty');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteMethodsNotArray() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.methods must be not an empty array.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMethodsNotArray');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteMethodsNotStringable() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.methods must contain only strings.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMethodsNotStringable');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteMiddlewaresNotArray() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.middlewares must be an array.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMiddlewaresNotArray');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteMiddlewaresNotStringable() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.middlewares must contain only middlewares.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMiddlewaresNotStringable');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteMiddlewaresContainNonexistenceClass() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.middlewares must contain only middlewares.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMiddlewaresContainNonexistenceClass');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteMiddlewaresContainNotMiddleware() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.middlewares must contain only middlewares.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteMiddlewaresContainNotMiddleware');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRouteAttributesNotArray() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.attributes must be an array.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRouteAttributesNotArray');
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testAnnotationRoutePriorityNotInteger() : void
+	{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('@Route.priority must be an integer.');
+
+		$root = __DIR__ . '/../Fixture/Annotation/AnnotationRouteInvalid';
+		(new AnnotationRouteLoader)->discover($root . '/AnnotationRoutePriorityNotInteger');
+	}
+
+	/**
+	 * @return void
+	 *
+	 * @todo This test needs to be improved...
+	 */
+	public function testBuildRoutes() : void
+	{
+		$loader = new AnnotationRouteLoader();
+		$loader->discover(__DIR__ . '/../Fixture/Annotation/AnnotationRouteValid');
+
+		$routesMap = [];
+		$builtRoutes = $loader->buildRoutes();
+
+		foreach ($builtRoutes as $i => $route) {
+			$routesMap[$i]['name'] = $route->getName();
+			$routesMap[$i]['path'] = $route->getPath();
+			$routesMap[$i]['methods'] = $route->getMethods();
+			$routesMap[$i]['requestHandler'] = get_class($route->getRequestHandler());
+			$routesMap[$i]['middlewares'] = [];
+			$routesMap[$i]['attributes'] = $route->getAttributes();
+
+			foreach ($route->getMiddlewares() as $middleware) {
+				$routesMap[$i]['middlewares'][] = get_class($middleware);
+			}
+		}
+
+		$expectedMap = [
+			[
+				'name' => 'quuuux',
+				'path' => '/quuuux',
+				'methods' => ['PATCH', 'DELETE'],
+				'requestHandler' => 'Sunrise\Http\Router\Tests\Fixture\Annotation' .
+									'\AnnotationRouteValid\Subdirectory\QuuuuxRequestHandler',
+				'middlewares' => [
+					'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
+					'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
+				],
+				'attributes' => [
+					'foo' => 'bar',
+					'source' => 'quuuux',
+				],
+			],
+			[
+				'name' => 'quuux',
+				'path' => '/quuux',
+				'methods' => ['PUT', 'PATCH'],
+				'requestHandler' => 'Sunrise\Http\Router\Tests\Fixture\Annotation' .
+									'\AnnotationRouteValid\Subdirectory\QuuuxRequestHandler',
+				'middlewares' => [
+					'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
+					'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
+				],
+				'attributes' => [
+					'foo' => 'bar',
+					'source' => 'quuux',
+				],
+			],
+			[
+				'name' => 'quux',
+				'path' => '/quux',
+				'methods' => ['POST', 'PUT'],
+				'requestHandler' => 'Sunrise\Http\Router\Tests\Fixture\Annotation' .
+									'\AnnotationRouteValid\QuuxRequestHandler',
+				'middlewares' => [
+					'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
+					'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
+				],
+				'attributes' => [
+					'foo' => 'bar',
+					'source' => 'quux',
+				],
+			],
+			[
+				'name' => 'qux',
+				'path' => '/qux',
+				'methods' => ['GET', 'POST'],
+				'requestHandler' => 'Sunrise\Http\Router\Tests\Fixture\Annotation' .
+									'\AnnotationRouteValid\QuxRequestHandler',
+				'middlewares' => [
+					'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
+					'Sunrise\Http\Router\Tests\Fixture\BlankMiddleware',
+				],
+				'attributes' => [
+					'foo' => 'bar',
+					'source' => 'qux',
+				],
+			],
+		];
+
+		$this->assertSame($expectedMap, $routesMap);
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
      */
     public static function setUpBeforeClass() : void
     {
-        if (! class_exists('Route')) {
+        if (!class_exists('Route')) {
             class_alias(AnnotationRoute::class, 'Route');
         }
     }

tests/RequestHandler/CallableRequestHandlerTest.php

Indentation +24 added lines, -24 removed lines

@@ -17,28 +17,28 @@
 class CallableRequestHandlerTest extends TestCase
 {
 
-    /**
-     * @return void
-     */
-    public function testConstructor() : void
-    {
-        $callback = new Fixture\BlankRequestHandler();
-        $requestHandler = new CallableRequestHandler($callback);
-
-        $this->assertInstanceOf(RequestHandlerInterface::class, $requestHandler);
-    }
-
-    /**
-     * @return void
-     */
-    public function testHandle() : void
-    {
-        $callback = new Fixture\BlankRequestHandler();
-        $requestHandler = new CallableRequestHandler($callback);
-
-        $request = (new ServerRequestFactory)->createServerRequest('GET', '/');
-        $requestHandler->handle($request);
-
-        $this->assertTrue($callback->isRunned());
-    }
+	/**
+	 * @return void
+	 */
+	public function testConstructor() : void
+	{
+		$callback = new Fixture\BlankRequestHandler();
+		$requestHandler = new CallableRequestHandler($callback);
+
+		$this->assertInstanceOf(RequestHandlerInterface::class, $requestHandler);
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testHandle() : void
+	{
+		$callback = new Fixture\BlankRequestHandler();
+		$requestHandler = new CallableRequestHandler($callback);
+
+		$request = (new ServerRequestFactory)->createServerRequest('GET', '/');
+		$requestHandler->handle($request);
+
+		$this->assertTrue($callback->isRunned());
+	}
 }

tests/RequestHandler/QueueableRequestHandlerTest.php

Indentation +72 added lines, -72 removed lines

@@ -17,76 +17,76 @@
 class QueueableRequestHandlerTest extends TestCase
 {
 
-    /**
-     * @return void
-     */
-    public function testConstructor() : void
-    {
-        $endpoint = new Fixture\BlankRequestHandler();
-        $requestHandler = new QueueableRequestHandler($endpoint);
-
-        $this->assertInstanceOf(RequestHandlerInterface::class, $requestHandler);
-    }
-
-    /**
-     * @return void
-     */
-    public function testHandle() : void
-    {
-        $endpoint = new Fixture\BlankRequestHandler();
-        $requestHandler = new QueueableRequestHandler($endpoint);
-
-        $request = (new ServerRequestFactory)->createServerRequest('GET', '/');
-        $requestHandler->handle($request);
-
-        $this->assertTrue($endpoint->isRunned());
-    }
-
-    /**
-     * @return void
-     */
-    public function testHandleWithMiddlewares() : void
-    {
-        $middlewares = [
-            new Fixture\BlankMiddleware(),
-            new Fixture\BlankMiddleware(),
-            new Fixture\BlankMiddleware(),
-        ];
-
-        $endpoint = new Fixture\BlankRequestHandler();
-        $requestHandler = new QueueableRequestHandler($endpoint);
-        $requestHandler->add(...$middlewares);
-
-        $request = (new ServerRequestFactory)->createServerRequest('GET', '/');
-        $requestHandler->handle($request);
-
-        $this->assertTrue($middlewares[0]->isRunned());
-        $this->assertTrue($middlewares[1]->isRunned());
-        $this->assertTrue($middlewares[2]->isRunned());
-        $this->assertTrue($endpoint->isRunned());
-    }
-
-    /**
-     * @return void
-     */
-    public function testHandleWithBrokenMiddleware() : void
-    {
-        $middlewares = [
-            new Fixture\BlankMiddleware(),
-            new Fixture\BlankMiddleware(true),
-            new Fixture\BlankMiddleware(),
-        ];
-
-        $endpoint = new Fixture\BlankRequestHandler();
-        $requestHandler = new QueueableRequestHandler($endpoint);
-        $requestHandler->add(...$middlewares);
-
-        $request = (new ServerRequestFactory)->createServerRequest('GET', '/');
-        $requestHandler->handle($request);
-
-        $this->assertTrue($middlewares[0]->isRunned());
-        $this->assertTrue($middlewares[1]->isRunned());
-        $this->assertFalse($middlewares[2]->isRunned());
-        $this->assertFalse($endpoint->isRunned());
-    }
+	/**
+	 * @return void
+	 */
+	public function testConstructor() : void
+	{
+		$endpoint = new Fixture\BlankRequestHandler();
+		$requestHandler = new QueueableRequestHandler($endpoint);
+
+		$this->assertInstanceOf(RequestHandlerInterface::class, $requestHandler);
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testHandle() : void
+	{
+		$endpoint = new Fixture\BlankRequestHandler();
+		$requestHandler = new QueueableRequestHandler($endpoint);
+
+		$request = (new ServerRequestFactory)->createServerRequest('GET', '/');
+		$requestHandler->handle($request);
+
+		$this->assertTrue($endpoint->isRunned());
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testHandleWithMiddlewares() : void
+	{
+		$middlewares = [
+			new Fixture\BlankMiddleware(),
+			new Fixture\BlankMiddleware(),
+			new Fixture\BlankMiddleware(),
+		];
+
+		$endpoint = new Fixture\BlankRequestHandler();
+		$requestHandler = new QueueableRequestHandler($endpoint);
+		$requestHandler->add(...$middlewares);
+
+		$request = (new ServerRequestFactory)->createServerRequest('GET', '/');
+		$requestHandler->handle($request);
+
+		$this->assertTrue($middlewares[0]->isRunned());
+		$this->assertTrue($middlewares[1]->isRunned());
+		$this->assertTrue($middlewares[2]->isRunned());
+		$this->assertTrue($endpoint->isRunned());
+	}
+
+	/**
+	 * @return void
+	 */
+	public function testHandleWithBrokenMiddleware() : void
+	{
+		$middlewares = [
+			new Fixture\BlankMiddleware(),
+			new Fixture\BlankMiddleware(true),
+			new Fixture\BlankMiddleware(),
+		];
+
+		$endpoint = new Fixture\BlankRequestHandler();
+		$requestHandler = new QueueableRequestHandler($endpoint);
+		$requestHandler->add(...$middlewares);
+
+		$request = (new ServerRequestFactory)->createServerRequest('GET', '/');
+		$requestHandler->handle($request);
+
+		$this->assertTrue($middlewares[0]->isRunned());
+		$this->assertTrue($middlewares[1]->isRunned());
+		$this->assertFalse($middlewares[2]->isRunned());
+		$this->assertFalse($endpoint->isRunned());
+	}
 }