WebpackPageControllerExtension::WebpackFileHash() - Code Metrics - Inspection of "MAJOR: better location for style file" - sunnysideup/silverstripe-webpack_requirements_backend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 485dd3...5ac67c )

by Nicolaas

created 2017-10-02 00:45 UTC

WebpackPageControllerExtension::WebpackFileHash() A

↳ Parent: WebpackPageControllerExtension

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	10
nc	3
nop	1

<?php


class WebpackPageControllerExtension extends extension
namespace YourVendor;

class YourClass { }
{

    /**
     *
     * @var {Array}
     */
    private static $webpack_enabled_themes = [];


    /**
     *
     * @var int
     */
    private static $webpack_port = 3000;



    /**
     *
     * @var string
     */
    private static $webpack_distribution_folder_extension = 'dist';


    /**
     *
     * @return bool
     */
    public function IsNotWebpackDevServer()
    {
        return $this->IsWebpackDevServer() ? false : true;
    }


    /**
     *
     * @return bool

     */
    public function IsWebpackDevServer()
    {
        if (Director::isDev()) {
            $socket = @fsockopen('localhost', $this->owner->Config()->get('webpack_port'), $errno, $errstr, 1);
            return !$socket ? false : true;
        }
    }


    /**
     *
     * @return string

     */
    public function WebpackBaseURL()
    {
        $str = Director::AbsoluteBaseURL('/');

        if ($this->IsWebpackDevServer()) {
            $str = rtrim($str, '/') .':'.$this->owner->Config()->get('webpack_port').'/';
        }

        return $str;
    }

    public function WebpackDistributionFolderExtension()

    {
        return $this->owner->Config()->get('webpack_distribution_folder_extension');
    }

    public function WebpackFileHash($type = 'JS')
    {
        $base = Director::baseFolder();
        if ($type === 'JS') {
            $file = 'bundle.js';
        } elseif ($type === 'CSS') {
            $file = 'style.css';
        } else {
            user_error('Please specify JS or CSS, '.$type.' specified.');
        }
        $fullFile = $base.'/'.$this->owner->ThemeDir().'_'.$this->WebpackDistributionFolderExtension().'/'.$file;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        return filemtime($fullFile);
    }
}


1			<?php
2
3
4			class WebpackPageControllerExtension extends extension
			0 ignored issues – show Coding Style Compatibility introduced 2017-06-27 04:56 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6
7			/**
8			*
9			* @var {Array}
10			*/
11			private static $webpack_enabled_themes = [];
			0 ignored issues – show Unused Code introduced 2017-08-29 05:51 UTC by Report Bug Copy Issue Report The property `$webpack_enabled_themes` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12
13			/**
14			*
15			* @var int
16			*/
17			private static $webpack_port = 3000;
			0 ignored issues – show Unused Code introduced 2017-08-30 04:58 UTC by Report Bug Copy Issue Report The property `$webpack_port` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
18
19
20			/**
21			*
22			* @var string
23			*/
24			private static $webpack_distribution_folder_extension = 'dist';
			0 ignored issues – show Unused Code introduced 2017-08-30 04:58 UTC by Report Bug Copy Issue Report The property `$webpack_distribution_folder_extension` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
25
26			/**
27			*
28			* @return bool
29			*/
30			public function IsNotWebpackDevServer()
31			{
32			return $this->IsWebpackDevServer() ? false : true;
33			}
34
35
36			/**
37			*
38			* @return bool
			0 ignored issues – show Documentation introduced 2017-08-02 02:02 UTC by Report Bug Copy Issue Report Should the return type not be `boolean\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
39			*/
40			public function IsWebpackDevServer()
41			{
42			if (Director::isDev()) {
43			$socket = @fsockopen('localhost', $this->owner->Config()->get('webpack_port'), $errno, $errstr, 1);
44			return !$socket ? false : true;
45			}
46			}
47
48
49			/**
50			*
51			* @return string
			0 ignored issues – show Documentation introduced 2017-08-02 02:02 UTC by Report Bug Copy Issue Report Should the return type not be `false\|string`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
52			*/
53			public function WebpackBaseURL()
54			{
55			$str = Director::AbsoluteBaseURL('/');
			0 ignored issues – show Unused Code introduced 2017-08-02 02:02 UTC by Report Bug Copy Issue Report The call to `Director::absoluteBaseURL()` has too many arguments starting with `'/'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
56			if ($this->IsWebpackDevServer()) {
57			$str = rtrim($str, '/') .':'.$this->owner->Config()->get('webpack_port').'/';
58			}
59
60			return $str;
61			}
62
63			public function WebpackDistributionFolderExtension()
			0 ignored issues – show Documentation introduced 2017-08-30 04:58 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
64			{
65			return $this->owner->Config()->get('webpack_distribution_folder_extension');
66			}
67
68			public function WebpackFileHash($type = 'JS')
69			{
70			$base = Director::baseFolder();
71			if ($type === 'JS') {
72			$file = 'bundle.js';
73			} elseif ($type === 'CSS') {
74			$file = 'style.css';
75			} else {
76			user_error('Please specify JS or CSS, '.$type.' specified.');
77			}
78			$fullFile = $base.'/'.$this->owner->ThemeDir().'_'.$this->WebpackDistributionFolderExtension().'/'.$file;
			0 ignored issues – show Bug introduced 2017-10-02 00:46 UTC by Report Bug Copy Issue Report The variable `$file` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
79
80			return filemtime($fullFile);
81			}
82			}
83

sunnysideup / silverstripe-webpack_requirements_backend

Push — master ( 485dd3...5ac67c )

WebpackPageControllerExtension::WebpackFileHash() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like