WebpackPageControllerExtension

Complexity

Total Complexity

11

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	IsNotWebpackDevServer()	0	4	2
A	IsWebpackDevServer()	0	7	3
A	WebpackBaseURL()	0	9	2
A	WebpackDistributionFolderExtension()	0	4	1
A	WebpackFileHash()	0	14	3

<?php


class WebpackPageControllerExtension extends extension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     *
     * @var {Array}
     */
    private static $webpack_enabled_themes = [];

The property $webpack_enabled_themes is not used and could be removed.

    /**
     *
     * @var int
     */
    private static $webpack_port = 3000;

The property $webpack_port is not used and could be removed.

    /**
     *
     * @var string
     */
    private static $webpack_distribution_folder_extension = 'dist';

The property $webpack_distribution_folder_extension is not used and could be removed.

    /**
     *
     * @return bool
     */
    public function IsNotWebpackDevServer()
    {
        return $this->IsWebpackDevServer() ? false : true;
    }


    /**
     *
     * @return bool

Should the return type not be boolean|null?

     */
    public function IsWebpackDevServer()
    {
        if (Director::isDev()) {
            $socket = @fsockopen('localhost', $this->owner->Config()->get('webpack_port'), $errno, $errstr, 1);
            return !$socket ? false : true;
        }
    }


    /**
     *
     * @return string

Should the return type not be false|string?

     */
    public function WebpackBaseURL()
    {
        $str = Director::AbsoluteBaseURL('/');

The call to Director::absoluteBaseURL() has too many arguments starting with '/'.

        if ($this->IsWebpackDevServer()) {
            $str = rtrim($str, '/') .':'.$this->owner->Config()->get('webpack_port').'/';
        }

        return $str;
    }

    public function WebpackDistributionFolderExtension()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->owner->Config()->get('webpack_distribution_folder_extension');
    }

    public function WebpackFileHash($type = 'JS')
    {
        $base = Director::baseFolder();
        if ($type === 'JS') {
            $file = 'bundle.js';
        } elseif ($type === 'CSS') {
            $file = 'style.css';
        } else {
            user_error('Please specify JS or CSS, '.$type.' specified.');
        }
        $fullFile = $base.'/'.$this->owner->ThemeDir().'_'.$this->WebpackDistributionFolderExtension().'/'.$file;

The variable $file does not seem to be defined for all execution paths leading up to this point.

        return filemtime($fullFile);
    }
}