WebpackPageControllerExtension::IsWebpackDevServer() - Code Metrics - Inspection of "MAJOR: api change" - sunnysideup/silverstripe-webpack_requirements_backend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2aa092...67112c )

by Nicolaas

created 2017-08-02 02:01 UTC

IsWebpackDevServer() A

↳ Parent: WebpackPageControllerExtension

Complexity

Conditions	3
Paths	3

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	4
nc	3
nop	0

<?php


class WebpackPageControllerExtension extends extension
namespace YourVendor;

class YourClass { }
{

    private static $port_for_webpack = 3000;


    /**
     *
     * @return bool
     */
    public function IsNotWebpackDevServer()
    {
        return $this->IsWebpackDevServer() ? false : true;
    }


    /**
     *
     * @return bool

     */
    public function IsWebpackDevServer()
    {
        if (Director::isDev()) {
            $socket = @fsockopen('localhost', $this->owner->Config()->get('port_for_webpack'), $errno, $errstr, 1);
            return !$socket ? false : true;
        }
    }


    /**
     *
     * @return string

     */
    public function WebpackBaseURL()
    {
        $str = Director::AbsoluteBaseURL('/');

        if($this->IsWebpackDevServer()) {
            $str = rtrim($str, '/') .':'.$this->owner->Config()->get('port_for_webpack').'/';
        }

        return $str;
    }
}


1			<?php
2
3
4			class WebpackPageControllerExtension extends extension
			0 ignored issues – show Coding Style Compatibility introduced 2017-06-27 04:56 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6
7			private static $port_for_webpack = 3000;
			0 ignored issues – show Unused Code introduced 2017-08-02 02:02 UTC by Report Bug Copy Issue Report The property `$port_for_webpack` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
8
9			/**
10			*
11			* @return bool
12			*/
13			public function IsNotWebpackDevServer()
14			{
15			return $this->IsWebpackDevServer() ? false : true;
16			}
17
18
19			/**
20			*
21			* @return bool
			0 ignored issues – show Documentation introduced 2017-08-02 02:02 UTC by Report Bug Copy Issue Report Should the return type not be `boolean\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
22			*/
23			public function IsWebpackDevServer()
24			{
25			if (Director::isDev()) {
26			$socket = @fsockopen('localhost', $this->owner->Config()->get('port_for_webpack'), $errno, $errstr, 1);
27			return !$socket ? false : true;
28			}
29			}
30
31
32			/**
33			*
34			* @return string
			0 ignored issues – show Documentation introduced 2017-08-02 02:02 UTC by Report Bug Copy Issue Report Should the return type not be `false\|string`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
35			*/
36			public function WebpackBaseURL()
37			{
38			$str = Director::AbsoluteBaseURL('/');
			0 ignored issues – show Unused Code introduced 2017-08-02 02:02 UTC by Report Bug Copy Issue Report The call to `Director::absoluteBaseURL()` has too many arguments starting with `'/'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
39			if($this->IsWebpackDevServer()) {
40			$str = rtrim($str, '/') .':'.$this->owner->Config()->get('port_for_webpack').'/';
41			}
42
43			return $str;
44			}
45			}
46

sunnysideup / silverstripe-webpack_requirements_backend

Push — master ( 2aa092...67112c )

IsWebpackDevServer() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like