WebpackPageControllerExtension

Complexity

Total Complexity

7

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	IsNotWebpackDevServer()	0	4	2
A	IsWebpackDevServer()	0	7	3
A	WebpackBaseURL()	0	9	2

<?php


class WebpackPageControllerExtension extends extension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $port_for_webpack = 3000;

The property $port_for_webpack is not used and could be removed.

    /**
     *
     * @return bool
     */
    public function IsNotWebpackDevServer()
    {
        return $this->IsWebpackDevServer() ? false : true;
    }


    /**
     *
     * @return bool

Should the return type not be boolean|null?

     */
    public function IsWebpackDevServer()
    {
        if (Director::isDev()) {
            $socket = @fsockopen('localhost', $this->owner->Config()->get('port_for_webpack'), $errno, $errstr, 1);
            return !$socket ? false : true;
        }
    }


    /**
     *
     * @return string

Should the return type not be false|string?

     */
    public function WebpackBaseURL()
    {
        $str = Director::AbsoluteBaseURL('/');

The call to Director::absoluteBaseURL() has too many arguments starting with '/'.

        if($this->IsWebpackDevServer()) {
            $str = rtrim($str, '/') .':'.$this->owner->Config()->get('port_for_webpack').'/';
        }

        return $str;
    }
}